)]}'
{"ceilometer/templates/bin/_ceilometer-api.sh.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"00c95d090a538804d1948b506b6eed02769dbe1b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"     rm -f /var/run/apache2/apache2.pid"},{"line_number":31,"context_line":"  fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  if [ -f /var/run/httpd/httpd.pid ]; then"},{"line_number":34,"context_line":"     # Remove the stale pid for centos/redhat images"},{"line_number":35,"context_line":"     rm -f /var/run/httpd/httpd.pid"},{"line_number":36,"context_line":"  fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  # Start Apache2"},{"line_number":39,"context_line":"  exec apache2 -DFOREGROUND"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3f79a3b5_953633df","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":4},"updated":"2018-12-05 19:40:39.000000000","message":"I\u0027d prefer to have gates in place here before opening the door for sprawl related to issues to images we\u0027re not gating or testing against. There\u0027s work happening in openstack-helm-images to support additional distros, and it would be awesome to see that work include centos/redhat images before we start baking disto-specific conditionals into the charts","commit_id":"8442474e68564fe9e3a527aaf5b99c5018bf6d22"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7affbacb50510e432745841e7ffe3a72f17440f4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"     rm -f /var/run/apache2/apache2.pid"},{"line_number":31,"context_line":"  fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  if [ -f /var/run/httpd/httpd.pid ]; then"},{"line_number":34,"context_line":"     # Remove the stale pid for centos/redhat images"},{"line_number":35,"context_line":"     rm -f /var/run/httpd/httpd.pid"},{"line_number":36,"context_line":"  fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  # Start Apache2"},{"line_number":39,"context_line":"  exec apache2 -DFOREGROUND"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3f79a3b5_9d1107fd","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":4},"updated":"2018-11-29 04:55:45.000000000","message":"I\u0027m really not comfortable with this, as it only really supports hacked images. I won\u0027t block it - but please can we get gates in place for these distros before starting to do things like this, as we could make it much neater.","commit_id":"8442474e68564fe9e3a527aaf5b99c5018bf6d22"}],"horizon/templates/bin/_horizon.sh.tpl":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bce301a24078ff99fd8e7d2a9c63f7c2b01f32e6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  fi"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  if [ -f /var/run/httpd/httpd.pid ]; then"},{"line_number":42,"context_line":"     # Remove the stale pid for custom images"},{"line_number":43,"context_line":"     rm -f /var/run/httpd/httpd.pid"},{"line_number":44,"context_line":"  fi"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3f79a3b5_100311bf","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":38},"updated":"2018-12-05 20:26:17.000000000","message":"maybe \"centos\", not \"custom\"?","commit_id":"2baa45e3ec2203d05d3162e0921a5bca88974482"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"56db3dfc13cc0577fac710c30fd127e0b7583d7c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  fi"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  if [ -f /var/run/httpd/httpd.pid ]; then"},{"line_number":42,"context_line":"     # Remove the stale pid for custom images"},{"line_number":43,"context_line":"     rm -f /var/run/httpd/httpd.pid"},{"line_number":44,"context_line":"  fi"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3f79a3b5_70dfe538","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":38},"in_reply_to":"3f79a3b5_100311bf","updated":"2018-12-05 20:30:28.000000000","message":"I have removed the verbage all together. This is a one-off/one-time patchset going forward we need better requirements on the type of images you are using.","commit_id":"2baa45e3ec2203d05d3162e0921a5bca88974482"}],"keystone/templates/bin/_keystone-api.sh.tpl":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"cc8b3f499fc0413b2005083d11eaf83ceba07835","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if [ -f /var/run/apache2/apache2.pid ]; then"},{"line_number":35,"context_line":"     # Remove the stale pid"},{"line_number":36,"context_line":"     rm -f /var/run/apach2/apache2.pid"},{"line_number":37,"context_line":"  fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  # Start Apache2"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_595998fd","line":36,"updated":"2018-11-23 22:13:26.000000000","message":"typo here","commit_id":"1e8250802a7e315fba35ca43915c502e466b41e8"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ebf43bf37c7bc3d1589a92963b415004104a65ca","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     source /etc/apache2/envvars"},{"line_number":32,"context_line":"  fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if [ -f /var/run/apache2/apache2.pid ]; then"},{"line_number":35,"context_line":"     # Remove the stale pid"},{"line_number":36,"context_line":"     rm -f /var/run/apache2/apache2.pid"},{"line_number":37,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_4061860f","line":34,"range":{"start_line":34,"start_character":27,"end_line":34,"end_character":38},"updated":"2018-11-26 17:07:30.000000000","message":"\"apache2\" is a symlink to \"httpd\", and the actual file seems to be /var/run/httpd/httpd.pid.","commit_id":"8ec84ed4e36193721018a26778b186ca525271ba"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"2c8d3da13fd972b541b7ec87484449493d923bac","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     source /etc/apache2/envvars"},{"line_number":32,"context_line":"  fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if [ -f /var/run/apache2/apache2.pid ]; then"},{"line_number":35,"context_line":"     # Remove the stale pid"},{"line_number":36,"context_line":"     rm -f /var/run/apache2/apache2.pid"},{"line_number":37,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_094b88b1","line":34,"range":{"start_line":34,"start_character":27,"end_line":34,"end_character":38},"in_reply_to":"3f79a3b5_4061860f","updated":"2018-11-28 16:54:05.000000000","message":"Actually it looks like the symlink is in a custom image used only in our environment...my bad.\n\nMore generically, in Ubuntu images it\u0027ll be \"/var/run/apache2/apache2.pid\" and in CentOS images it\u0027ll be \"/var/run/httpd/httpd.pid\".  So maybe the cleanest thing is to just try both and skip the existence check?\n\nrm -f /var/run/apache2/apache2.pid\nrm -f /var/run/httpd/httpd.pid\n\nAlternately, for our customized apache image (with an \"apache2\" symlink added) the following would also work:\n\nrm -f /var/run/apache2/*.pid","commit_id":"8ec84ed4e36193721018a26778b186ca525271ba"}]}