)]}'
{"tools/images/openstack/queens/loci.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"260dac2cfdfa396b19a65bfcd6fdbe1dcf020da7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # clone the loci repo if local URI is not provided"},{"line_number":34,"context_line":"    git clone https://git.openstack.org/openstack/loci.git $LOCAL_CLONE_PATH"},{"line_number":35,"context_line":"    pushd $LOCAL_CLONE_PATH"},{"line_number":36,"context_line":"    git fetch https://git.openstack.org/openstack/loci.git ${OPENSTACK_VERSION}"},{"line_number":37,"context_line":"    git checkout FETCH_HEAD"},{"line_number":38,"context_line":"    popd"},{"line_number":39,"context_line":"    # bind the local clone directory root to /opt/loci path in docker-in-docker container"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_728f5b21","line":36,"range":{"start_line":36,"start_character":59,"end_line":36,"end_character":79},"updated":"2018-11-30 09:29:13.000000000","message":"LOCI version and OPENSTACK_VERSION are likely to be different, as loci can build multiple openstack branches on its master branch. We should have therefore two variables for it.","commit_id":"e894ea5a20f9173c397c67e71ee61431e3a28294"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"ec3e73d639c392f7dec1b93576163539da5be194","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # clone the loci repo if local URI is not provided"},{"line_number":34,"context_line":"    git clone https://git.openstack.org/openstack/loci.git $LOCAL_CLONE_PATH"},{"line_number":35,"context_line":"    pushd $LOCAL_CLONE_PATH"},{"line_number":36,"context_line":"    git fetch https://git.openstack.org/openstack/loci.git ${OPENSTACK_VERSION}"},{"line_number":37,"context_line":"    git checkout FETCH_HEAD"},{"line_number":38,"context_line":"    popd"},{"line_number":39,"context_line":"    # bind the local clone directory root to /opt/loci path in docker-in-docker container"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_72f19464","line":36,"range":{"start_line":36,"start_character":59,"end_line":36,"end_character":79},"in_reply_to":"3f79a3b5_728f5b21","updated":"2018-11-30 16:10:38.000000000","message":"Oh yes, agreed. I will change this to master.","commit_id":"e894ea5a20f9173c397c67e71ee61431e3a28294"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"260dac2cfdfa396b19a65bfcd6fdbe1dcf020da7","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    sudo docker exec docker-in-docker apk add git"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"fi"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# create base OS image to be used for other components"},{"line_number":80,"context_line":"sudo docker exec docker-in-docker docker build --force-rm --pull --no-cache \\"},{"line_number":81,"context_line":"    https://git.openstack.org/openstack/loci.git#master:dockerfiles/${BASE_OS} \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_72dd1b11","line":78,"updated":"2018-11-30 09:29:13.000000000","message":"While this build is closer to loci\u0027s mechanism, it is fairly different than the approach taken by the other images (pike/ocata/newton), as the base images there are not based on loci, but based on upstream ubuntu slim images.\nThis might be important for reviewers.\n\nI still prefer this approach.","commit_id":"e894ea5a20f9173c397c67e71ee61431e3a28294"}]}