)]}'
{"cinder/templates/bin/_cinder-api-liveness.py.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"055b2d9a7b74f0fd947512c823a4a99d646430da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/lib/openstack/bin/python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_214f85bf","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":24},"updated":"2018-12-11 05:36:40.000000000","message":"this is a strange bin path to find python","commit_id":"92fffda0d8c97adaed29fb824129455f939621ba"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"055b2d9a7b74f0fd947512c823a4a99d646430da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/lib/openstack/bin/python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_e1442da2","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":14},"updated":"2018-12-11 05:36:40.000000000","message":"-2018","commit_id":"92fffda0d8c97adaed29fb824129455f939621ba"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"055b2d9a7b74f0fd947512c823a4a99d646430da","unresolved":false,"context_lines":[{"line_number":24,"context_line":"parser.add_argument(\u0027port\u0027)"},{"line_number":25,"context_line":"args \u003d parser.parse_args()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"url \u003d \u0027http://localhost:\u0027 + args.port + \u0027/v2\u0027"},{"line_number":28,"context_line":"try:"},{"line_number":29,"context_line":"  r\u003drequests.get(url, verify\u003dFalse)"},{"line_number":30,"context_line":"  if (r.status_code \u003e\u003d 200 and r.status_code \u003c 400) or r.status_code \u003d\u003d 401:"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_a15b9586","line":27,"range":{"start_line":27,"start_character":40,"end_line":27,"end_character":45},"updated":"2018-12-11 05:36:40.000000000","message":"what if this change to cinder v3?","commit_id":"92fffda0d8c97adaed29fb824129455f939621ba"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"055b2d9a7b74f0fd947512c823a4a99d646430da","unresolved":false,"context_lines":[{"line_number":27,"context_line":"url \u003d \u0027http://localhost:\u0027 + args.port + \u0027/v2\u0027"},{"line_number":28,"context_line":"try:"},{"line_number":29,"context_line":"  r\u003drequests.get(url, verify\u003dFalse)"},{"line_number":30,"context_line":"  if (r.status_code \u003e\u003d 200 and r.status_code \u003c 400) or r.status_code \u003d\u003d 401:"},{"line_number":31,"context_line":"    sys.exit(0)"},{"line_number":32,"context_line":"  sys.exit(1)"},{"line_number":33,"context_line":"except Exception as e:"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_01404989","line":30,"range":{"start_line":30,"start_character":30,"end_line":30,"end_character":76},"updated":"2018-12-11 05:36:40.000000000","message":"I am not clear why this is the liveness check, if it is not authorized, it is good, but if it is forbidden (403), the API is dead?  is there a reason for those specific codes?","commit_id":"92fffda0d8c97adaed29fb824129455f939621ba"}],"cinder/templates/deployment-api.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"055b2d9a7b74f0fd947512c823a4a99d646430da","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          readinessProbe:"},{"line_number":89,"context_line":"            tcpSocket:"},{"line_number":90,"context_line":"              port: {{ tuple \"volume\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":91,"context_line":"          livenessProbe:"},{"line_number":92,"context_line":"            exec:"},{"line_number":93,"context_line":"              command:"},{"line_number":94,"context_line":"              - python"},{"line_number":95,"context_line":"              - /tmp/cinder-api-liveness.py"},{"line_number":96,"context_line":"              - \u0027{{ tuple \"volume\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}\u0027"},{"line_number":97,"context_line":"            initialDelaySeconds: 30"},{"line_number":98,"context_line":"            failureThreshold: 3"},{"line_number":99,"context_line":"            periodSeconds: 10"},{"line_number":100,"context_line":"            successThreshold: 1"},{"line_number":101,"context_line":"            timeoutSeconds: 2"},{"line_number":102,"context_line":"          volumeMounts:"},{"line_number":103,"context_line":"            - name: cinder-bin"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_c15ed176","line":100,"range":{"start_line":91,"start_character":0,"end_line":100,"end_character":31},"updated":"2018-12-11 05:36:40.000000000","message":"I thought we wanted some concurrence on how to handle this via a spec that kind of languished. https://review.openstack.org/#/c/582620/","commit_id":"92fffda0d8c97adaed29fb824129455f939621ba"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"913e54313a5c2709c5a2e64189cd44f27d7bc680","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            failureThreshold: 3"},{"line_number":99,"context_line":"            periodSeconds: 10"},{"line_number":100,"context_line":"            successThreshold: 1"},{"line_number":101,"context_line":"            timeoutSeconds: 2"},{"line_number":102,"context_line":"          volumeMounts:"},{"line_number":103,"context_line":"            - name: cinder-bin"},{"line_number":104,"context_line":"              mountPath: /tmp/cinder-api.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_2121c5fd","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":29},"updated":"2018-12-11 05:24:37.000000000","message":"To me this seems a little too short, especially if the API is busy.","commit_id":"92fffda0d8c97adaed29fb824129455f939621ba"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"cd49474cf68ca128abcc082f5cea4f68ffae03be","unresolved":false,"context_lines":[{"line_number":93,"context_line":"              port: {{ tuple \"volume\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":94,"context_line":"            initialDelaySeconds: 30"},{"line_number":95,"context_line":"            failureThreshold: 3"},{"line_number":96,"context_line":"            periodSeconds: 10"},{"line_number":97,"context_line":"            successThreshold: 1"},{"line_number":98,"context_line":"            timeoutSeconds: 1"},{"line_number":99,"context_line":"          volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_43f93b4e","line":96,"range":{"start_line":96,"start_character":12,"end_line":96,"end_character":29},"updated":"2018-12-12 17:52:22.000000000","message":"do we want it that often?\n\nin general i worry we end up doing so many probes so often all over the place a lot of the system load is probes not work (to be fair this one should be very cheap)","commit_id":"fd4e49f7086fd81080f3039ede6552884d35276c"}]}