)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"0896948486b5a167084cfddbfc798cbd646f46d1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Blueprint name: openstack-helm-octavia"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note: This chart doesn\u0027t include amphora image and its build."},{"line_number":14,"context_line":"Note: For multi node, this chart requires modification later."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0bb7dfc7c15d77287c05a8542347e19fc269aba4"},{"line_number":17,"context_line":"Signed-off-by: hagun.kim \u003chagun.kim@samsung.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9fb8cfa7_d5c8c022","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":61},"updated":"2019-07-01 08:04:19.000000000","message":"This line got missing","commit_id":"fe28486e918e92d431c1c2c8517a0fb0adbfea6a"}],"neutron/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c5bd2dd4cf99682d71929ad9680c6fdc625e9c98","unresolved":false,"context_lines":[{"line_number":1493,"context_line":"      auth_type: password"},{"line_number":1494,"context_line":"      auth_version: v3"},{"line_number":1495,"context_line":"    octavia:"},{"line_number":1496,"context_line":"      base_url: http://octavia-api.openstack.svc.cluster.local:9876"},{"line_number":1497,"context_line":"      request_poll_timeout: 3000"},{"line_number":1498,"context_line":"  logging:"},{"line_number":1499,"context_line":"    loggers:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_6eefaa87","line":1496,"range":{"start_line":1496,"start_character":16,"end_line":1496,"end_character":67},"updated":"2019-01-19 21:49:57.000000000","message":"we should ideally do this via an endpoint lookup, see here for an example: https://github.com/openstack/openstack-helm/blob/master/neutron/templates/configmap-etc.yaml#L64-L66","commit_id":"e4d1a133efcbcd35c21f5c47fc45fe33e0d48df0"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"db87411498fc5084f42ee934081218ca13ea67c5","unresolved":false,"context_lines":[{"line_number":1493,"context_line":"      auth_type: password"},{"line_number":1494,"context_line":"      auth_version: v3"},{"line_number":1495,"context_line":"    octavia:"},{"line_number":1496,"context_line":"      base_url: http://octavia-api.openstack.svc.cluster.local:9876"},{"line_number":1497,"context_line":"      request_poll_timeout: 3000"},{"line_number":1498,"context_line":"  logging:"},{"line_number":1499,"context_line":"    loggers:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_ac327aa6","line":1496,"range":{"start_line":1496,"start_character":16,"end_line":1496,"end_character":67},"in_reply_to":"9fdfeff1_6eefaa87","updated":"2019-01-20 10:24:25.000000000","message":"Done","commit_id":"e4d1a133efcbcd35c21f5c47fc45fe33e0d48df0"}],"octavia/Chart.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"24cf904c558cce52dd140cc4b4073b99c6a8654b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfbec78f_fdb5dd32","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":44},"updated":"2019-05-14 15:45:03.000000000","message":"You must technically put your company name here, or nothing.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"6626e294bed105a9a0c2acd2e940c23fbf206d19","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfbec78f_1e20cbf6","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":44},"in_reply_to":"dfbec78f_8defbce7","updated":"2019-05-16 07:09:14.000000000","message":"Yes :)\n\nFYI: It\u0027s harder to change something existing in terms of licensing than creating something new correctly. Let\u0027s do it the right way :)","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"553aef312d31af9608c41758a46fd6053eba7b03","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfbec78f_8defbce7","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":44},"in_reply_to":"dfbec78f_fdb5dd32","updated":"2019-05-15 14:51:36.000000000","message":"I thought this is like convention. Because most of charts except for aodh were written this way. I\u0027ll reflect your opinion. Should I apply it to all files in this chart?","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_b3d8ed52","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":44},"updated":"2019-06-27 14:09:59.000000000","message":"Please don\u0027t change this.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"21b6e2d37da49f9719c32fb45481312d7ac0bbf1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_9e5cc419","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":44},"in_reply_to":"9fb8cfa7_b3d8ed52","updated":"2019-06-27 23:27:24.000000000","message":"Done","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/requirements.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"24cf904c558cce52dd140cc4b4073b99c6a8654b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfbec78f_7d7b2d7a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":44},"updated":"2019-05-14 15:45:03.000000000","message":"ditto.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_73def53e","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":44},"updated":"2019-06-27 14:09:59.000000000","message":"Please don\u0027t change this.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"21b6e2d37da49f9719c32fb45481312d7ac0bbf1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_1ea69410","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":44},"in_reply_to":"9fb8cfa7_73def53e","updated":"2019-06-27 23:27:24.000000000","message":"Done. I didn\u0027t realize that something changed to older one during rebase.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/bin/_bootstrap.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":12,"id":"9fb8cfa7_53b2d107","line":4,"range":{"start_line":4,"start_character":14,"end_line":4,"end_character":42},"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/bin/_db-sync.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":12,"id":"9fb8cfa7_73b7d5f6","line":4,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/bin/_octavia-api.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"24cf904c558cce52dd140cc4b4073b99c6a8654b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  exec octavia-api \\"},{"line_number":24,"context_line":"        --config-file /etc/octavia/octavia.conf"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function stop () {"},{"line_number":28,"context_line":"  kill -TERM 1"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"dfbec78f_fda95d7b","line":25,"range":{"start_line":23,"start_character":2,"end_line":25,"end_character":1},"updated":"2019-05-14 15:45:03.000000000","message":"question: Does this mean the octavia api doesn\u0027t run behind uwsgi?","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"6626e294bed105a9a0c2acd2e940c23fbf206d19","unresolved":false,"context_lines":[{"line_number":20,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  exec octavia-api \\"},{"line_number":24,"context_line":"        --config-file /etc/octavia/octavia.conf"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function stop () {"},{"line_number":28,"context_line":"  kill -TERM 1"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"dfbec78f_c9583b32","line":25,"range":{"start_line":23,"start_character":2,"end_line":25,"end_character":1},"in_reply_to":"dfbec78f_cd761471","updated":"2019-05-16 07:09:14.000000000","message":"This is not a blocker for me. But I understand that this will bring limitations for running wsgi middleware (like api healthchecks), or for end container ssl termination (not that it\u0027s required).\n\nI think we can start without uwsgi, and, should the need arise, add uwsgi on top.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"553aef312d31af9608c41758a46fd6053eba7b03","unresolved":false,"context_lines":[{"line_number":20,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  exec octavia-api \\"},{"line_number":24,"context_line":"        --config-file /etc/octavia/octavia.conf"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function stop () {"},{"line_number":28,"context_line":"  kill -TERM 1"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"dfbec78f_cd761471","line":25,"range":{"start_line":23,"start_character":2,"end_line":25,"end_character":1},"in_reply_to":"dfbec78f_fda95d7b","updated":"2019-05-15 14:51:36.000000000","message":"You\u0027re right. it\u0027s executed not using uwsgi.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":12,"id":"9fb8cfa7_13d0d91e","line":4,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/bin/_octavia-health-manager-get-port.sh.tpl":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cb2abde34a3c7962e881edf35fe19fe75e03fd74","unresolved":false,"context_lines":[{"line_number":21,"context_line":"HOSTNAME\u003d$(hostname -s)"},{"line_number":22,"context_line":"PORTNAME\u003doctavia-health-manager-port-$HOSTNAME"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"HM_PORT_ID\u003d$(openstack port show $PORTNAME -c id -f value)"},{"line_number":25,"context_line":"HM_PORT_MAC\u003d$(openstack port show $PORTNAME -c mac_address -f value)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"echo $HM_PORT_ID \u003e /tmp/pod-shared/HM_PORT_ID"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_77f476cf","line":24,"updated":"2019-08-21 08:45:04.000000000","message":"to avoid having extra call to neutron when octavia pod is spawning it is better to store host to port (mac) mapping in the configmap, and read data from configmap instead of calling neutron API.","commit_id":"777086546061135a7584095c3b1207eef72c765e"}],"octavia/templates/bin/_octavia-health-manager-nic-init.sh.tpl":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"32042fe1a178fde3d7ad91492de4d7026b612396","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":". /etc/os-release"},{"line_number":22,"context_line":"if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":23,"context_line":"  apt-get update"},{"line_number":24,"context_line":"  apt-get install iproute2 iptables -y"},{"line_number":25,"context_line":"fi"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"HM_PORT_ID\u003d$(cat /tmp/pod-shared/HM_PORT_ID)"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_f27bc3bb","line":24,"range":{"start_line":23,"start_character":2,"end_line":24,"end_character":38},"updated":"2019-08-19 10:41:06.000000000","message":"this also should be included in docker image","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5a5db0258d05c6f968ec51f71542e4c06619aead","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":". /etc/os-release"},{"line_number":22,"context_line":"if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":23,"context_line":"  apt-get update"},{"line_number":24,"context_line":"  apt-get install iproute2 iptables -y"},{"line_number":25,"context_line":"fi"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"HM_PORT_ID\u003d$(cat /tmp/pod-shared/HM_PORT_ID)"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_dce9d119","line":24,"range":{"start_line":23,"start_character":2,"end_line":24,"end_character":38},"in_reply_to":"7faddb67_f27bc3bb","updated":"2019-08-21 08:38:30.000000000","message":"+1 the content of image shouldn\u0027t be modified during deployment. environment might not have access to repos that present in the image.","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"f72be05815dd04baada9c6dfe2d9c688463b81d7","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":". /etc/os-release"},{"line_number":22,"context_line":"if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":23,"context_line":"  apt-get update"},{"line_number":24,"context_line":"  apt-get install iproute2 iptables -y"},{"line_number":25,"context_line":"fi"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"HM_PORT_ID\u003d$(cat /tmp/pod-shared/HM_PORT_ID)"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_b009f8dc","line":24,"range":{"start_line":23,"start_character":2,"end_line":24,"end_character":38},"in_reply_to":"7faddb67_f27bc3bb","updated":"2019-08-30 05:23:23.000000000","message":"Done. I changed images containing the packages.","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5a5db0258d05c6f968ec51f71542e4c06619aead","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"ovs-vsctl --no-wait show"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"ovs-vsctl --may-exist add-port br-int o-hm0 \\"},{"line_number":33,"context_line":"        -- set Interface o-hm0 type\u003dinternal \\"},{"line_number":34,"context_line":"        -- set Interface o-hm0 external-ids:iface-status\u003dactive \\"},{"line_number":35,"context_line":"        -- set Interface o-hm0 external-ids:attached-mac\u003d$HM_PORT_MAC \\"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_9c3d998f","line":32,"updated":"2019-08-21 08:38:30.000000000","message":"the bridge is crated by neutron-openvswitch agent as result health-manager should be running on the same nodes where neutron openvswitch agent is runnin\nIn case of lb the logic will be different.","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cb2abde34a3c7962e881edf35fe19fe75e03fd74","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"ovs-vsctl --no-wait show"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"ovs-vsctl --may-exist add-port br-int o-hm0 \\"},{"line_number":33,"context_line":"        -- set Interface o-hm0 type\u003dinternal \\"},{"line_number":34,"context_line":"        -- set Interface o-hm0 external-ids:iface-status\u003dactive \\"},{"line_number":35,"context_line":"        -- set Interface o-hm0 external-ids:attached-mac\u003d$HM_PORT_MAC \\"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_771d560d","line":32,"in_reply_to":"7faddb67_9c3d998f","updated":"2019-08-21 08:45:04.000000000","message":"Please also have look onto comments regarding networking setup https://review.opendev.org/#/c/630821/16/octavia/templates/daemonset-health-manager.yaml\nthis is only one of possible options, I suggest to add a flag in values.yaml that will allow to deploy lb network in other way.","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5a5db0258d05c6f968ec51f71542e4c06619aead","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"ip link set dev o-hm0 address $HM_PORT_MAC"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"iptables -I INPUT -i o-hm0 -p udp --dport {{ .Values.conf.octavia.health_manager.bind_port }} -j ACCEPT"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_7cd8dd7d","line":41,"updated":"2019-08-21 08:38:30.000000000","message":"this should be idempotent, you have to add checks if rule is present before adding it.","commit_id":"777086546061135a7584095c3b1207eef72c765e"}],"octavia/templates/bin/_octavia-health-manager.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":12,"id":"9fb8cfa7_f3c2e552","line":4,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a841aa2784893623ef24f257397d6830f9ae61ec","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  . /etc/os-release"},{"line_number":24,"context_line":"  if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":25,"context_line":"    apt-get update"},{"line_number":26,"context_line":"    apt-get install isc-dhcp-client -y"},{"line_number":27,"context_line":"  elif [ \"x$ID\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":28,"context_line":"    yum install dhclient -y"},{"line_number":29,"context_line":"  fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  cat \u003e /tmp/dhclient.conf \u003c\u003cEOF"},{"line_number":32,"context_line":"request subnet-mask,broadcast-address,interface-mtu;"}],"source_content_type":"text/x-smarty","patch_set":15,"id":"7faddb67_7533f214","line":29,"range":{"start_line":22,"start_character":0,"end_line":29,"end_character":4},"updated":"2019-08-07 11:36:44.000000000","message":"Not sure this is a good approach, we need image with preinstalled dhcp client.","commit_id":"ae2f759fa5b38e6357f2ff7ba67eb0f1fa5804b1"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"c0277744d22db3b23db5529815891f16b2ccd003","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  . /etc/os-release"},{"line_number":24,"context_line":"  if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":25,"context_line":"    apt-get update"},{"line_number":26,"context_line":"    apt-get install isc-dhcp-client -y"},{"line_number":27,"context_line":"  elif [ \"x$ID\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":28,"context_line":"    yum install dhclient -y"},{"line_number":29,"context_line":"  fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  cat \u003e /tmp/dhclient.conf \u003c\u003cEOF"},{"line_number":32,"context_line":"request subnet-mask,broadcast-address,interface-mtu;"}],"source_content_type":"text/x-smarty","patch_set":15,"id":"7faddb67_804f4a69","line":29,"range":{"start_line":22,"start_character":0,"end_line":29,"end_character":4},"in_reply_to":"7faddb67_7533f214","updated":"2019-08-07 12:19:57.000000000","message":"I agree with you. If there was an image containing dhclient I would have used it. But there was no choice for multinode :( \n\nI thought a good way to get each controller to have an o-hm device is to use a daemonset and create an o-hm on there. Of course we can create o-hm for each controller host outside of the pod (ex. 180-create-resource-for-octavia.sh), but from the user\u0027s point of view, daemonset is more convenient than it because you only need to run the pod. \n\nAnyway because I also think this is not the best way, if you don\u0027t want to do this, I\u0027ll revert to previous patch set and think about multinode later.","commit_id":"ae2f759fa5b38e6357f2ff7ba67eb0f1fa5804b1"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"c7ebe987c9d0383dfe33bb0b546a3b260788b3d4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  . /etc/os-release"},{"line_number":24,"context_line":"  if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":25,"context_line":"    apt-get update"},{"line_number":26,"context_line":"    apt-get install isc-dhcp-client -y"},{"line_number":27,"context_line":"  elif [ \"x$ID\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":28,"context_line":"    yum install dhclient -y"},{"line_number":29,"context_line":"  fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  cat \u003e /tmp/dhclient.conf \u003c\u003cEOF"},{"line_number":32,"context_line":"request subnet-mask,broadcast-address,interface-mtu;"}],"source_content_type":"text/x-smarty","patch_set":15,"id":"7faddb67_3b11eb05","line":29,"range":{"start_line":22,"start_character":0,"end_line":29,"end_character":4},"in_reply_to":"7faddb67_804f4a69","updated":"2019-08-07 12:48:10.000000000","message":"I don\u0027t know what are the best procedure here, I just describe my concerns.\nI would say that may be this change could be just adding octavia charts and new change on the top of it will include mutinode case. In that case initial change won\u0027t be blocked by any discussions.","commit_id":"ae2f759fa5b38e6357f2ff7ba67eb0f1fa5804b1"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ed3d16ffcbbb2a3e291560b97748b6eeae5c32a1","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  . /etc/os-release"},{"line_number":24,"context_line":"  if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":25,"context_line":"    apt-get update"},{"line_number":26,"context_line":"    apt-get install isc-dhcp-client -y"},{"line_number":27,"context_line":"  elif [ \"x$ID\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":28,"context_line":"    yum install dhclient -y"},{"line_number":29,"context_line":"  fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  cat \u003e /tmp/dhclient.conf \u003c\u003cEOF"},{"line_number":32,"context_line":"request subnet-mask,broadcast-address,interface-mtu;"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_91e8897c","line":29,"range":{"start_line":24,"start_character":0,"end_line":29,"end_character":4},"updated":"2019-08-14 14:26:16.000000000","message":"lets get this added to the loci image","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"96ad5a0f8802479bc407df8ea39c372c1da13337","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  . /etc/os-release"},{"line_number":24,"context_line":"  if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":25,"context_line":"    apt-get update"},{"line_number":26,"context_line":"    apt-get install isc-dhcp-client -y"},{"line_number":27,"context_line":"  elif [ \"x$ID\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":28,"context_line":"    yum install dhclient -y"},{"line_number":29,"context_line":"  fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  cat \u003e /tmp/dhclient.conf \u003c\u003cEOF"},{"line_number":32,"context_line":"request subnet-mask,broadcast-address,interface-mtu;"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_7294b336","line":29,"range":{"start_line":24,"start_character":0,"end_line":29,"end_character":4},"in_reply_to":"7faddb67_1ddd55dc","updated":"2019-08-19 09:53:25.000000000","message":"IMHO, it\u0027s impossible to use dhclient in init container, because init container will be stopped after initializing. \ndhclient process should be run on background.\nI uploaded patchset to add dhclient to octavia loci. \nAfter merging it, I am going to delete this logic.","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"32042fe1a178fde3d7ad91492de4d7026b612396","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  . /etc/os-release"},{"line_number":24,"context_line":"  if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":25,"context_line":"    apt-get update"},{"line_number":26,"context_line":"    apt-get install isc-dhcp-client -y"},{"line_number":27,"context_line":"  elif [ \"x$ID\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":28,"context_line":"    yum install dhclient -y"},{"line_number":29,"context_line":"  fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  cat \u003e /tmp/dhclient.conf \u003c\u003cEOF"},{"line_number":32,"context_line":"request subnet-mask,broadcast-address,interface-mtu;"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_a54c2376","line":29,"range":{"start_line":24,"start_character":0,"end_line":29,"end_character":4},"in_reply_to":"7faddb67_7294b336","updated":"2019-08-19 10:41:06.000000000","message":"I used such approach and it is possible, we do not need dhcp client running all the time - we need dhclient to set proper  ip address on o-hm0 ovs port, so this should not be a problem as this ip addresses expected to be constant for deployment.","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"97af080d5fd144b61c977c72953ed7d004ab1b78","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  . /etc/os-release"},{"line_number":24,"context_line":"  if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":25,"context_line":"    apt-get update"},{"line_number":26,"context_line":"    apt-get install isc-dhcp-client -y"},{"line_number":27,"context_line":"  elif [ \"x$ID\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":28,"context_line":"    yum install dhclient -y"},{"line_number":29,"context_line":"  fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  cat \u003e /tmp/dhclient.conf \u003c\u003cEOF"},{"line_number":32,"context_line":"request subnet-mask,broadcast-address,interface-mtu;"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_1ddd55dc","line":29,"range":{"start_line":24,"start_character":0,"end_line":29,"end_character":4},"in_reply_to":"7faddb67_91e8897c","updated":"2019-08-19 07:41:43.000000000","message":"I would rather have a separate docker image with dhcp client, which will be used as init container, as octavia does require dhcpclient for work.","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"2c1bf9796e23120a54e6c9153d7d9763ad9cc630","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  . /etc/os-release"},{"line_number":24,"context_line":"  if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":25,"context_line":"    apt-get update"},{"line_number":26,"context_line":"    apt-get install isc-dhcp-client -y"},{"line_number":27,"context_line":"  elif [ \"x$ID\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":28,"context_line":"    yum install dhclient -y"},{"line_number":29,"context_line":"  fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  cat \u003e /tmp/dhclient.conf \u003c\u003cEOF"},{"line_number":32,"context_line":"request subnet-mask,broadcast-address,interface-mtu;"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_a59423e9","line":29,"range":{"start_line":24,"start_character":0,"end_line":29,"end_character":4},"in_reply_to":"7faddb67_a54c2376","updated":"2019-08-19 11:44:44.000000000","message":"Yes I tested it too. But in my test to use init container, the ip was given by dhclient was released after certain period of time so o-hm nic missed the ip. Didn\u0027t you have that situation?","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a9e77bbd54a251fd2f818ccfa829a84e44c48560","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function start () {"},{"line_number":23,"context_line":"  . /etc/os-release"},{"line_number":24,"context_line":"  if [ \"x$ID\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":25,"context_line":"    apt-get update"},{"line_number":26,"context_line":"    apt-get install isc-dhcp-client -y"},{"line_number":27,"context_line":"  elif [ \"x$ID\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":28,"context_line":"    yum install dhclient -y"},{"line_number":29,"context_line":"  fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  cat \u003e /tmp/dhclient.conf \u003c\u003cEOF"},{"line_number":32,"context_line":"request subnet-mask,broadcast-address,interface-mtu;"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"7faddb67_237d8b1b","line":29,"range":{"start_line":24,"start_character":0,"end_line":29,"end_character":4},"in_reply_to":"7faddb67_a59423e9","updated":"2019-08-19 13:37:22.000000000","message":"No, I didn\u0027t see that, but I will recheck this, thanks! How long it was taken for ip to get missed?","commit_id":"777086546061135a7584095c3b1207eef72c765e"}],"octavia/templates/bin/_octavia-housekeeping.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":12,"id":"9fb8cfa7_93a129ac","line":4,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/bin/_octavia-worker.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":12,"id":"9fb8cfa7_73acb59e","line":4,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/configmap-bin.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"24cf904c558cce52dd140cc4b4073b99c6a8654b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"{{ tuple \"bin/_octavia-worker.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":56,"context_line":"  rabbit-init.sh: |"},{"line_number":57,"context_line":"{{- include \"helm-toolkit.scripts.rabbit_init\" . | indent 4 }}"},{"line_number":58,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfbec78f_fdd71ded","line":58,"updated":"2019-05-14 15:45:03.000000000","message":"everything seems there, lgtm.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_13953940","line":2,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/configmap-etc.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"24cf904c558cce52dd140cc4b4073b99c6a8654b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"type: Opaque"},{"line_number":112,"context_line":"data:"},{"line_number":113,"context_line":"  octavia.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.octavia | b64enc }}"},{"line_number":114,"context_line":"  logging.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.logging | b64enc }}"},{"line_number":115,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfbec78f_fd1e3db9","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":93},"updated":"2019-05-14 15:45:03.000000000","message":"should we have something for policy overrides?\nIt can be done in a later patchset if necessary.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"6626e294bed105a9a0c2acd2e940c23fbf206d19","unresolved":false,"context_lines":[{"line_number":111,"context_line":"type: Opaque"},{"line_number":112,"context_line":"data:"},{"line_number":113,"context_line":"  octavia.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.octavia | b64enc }}"},{"line_number":114,"context_line":"  logging.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.logging | b64enc }}"},{"line_number":115,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfbec78f_893ec3b5","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":93},"in_reply_to":"dfbec78f_ed92f856","updated":"2019-05-16 07:09:14.000000000","message":"In some other charts we have a way to apply a policy, should the policy in code need to be customized. This isn\u0027t here. It can be done in a later commit.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"553aef312d31af9608c41758a46fd6053eba7b03","unresolved":false,"context_lines":[{"line_number":111,"context_line":"type: Opaque"},{"line_number":112,"context_line":"data:"},{"line_number":113,"context_line":"  octavia.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.octavia | b64enc }}"},{"line_number":114,"context_line":"  logging.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.logging | b64enc }}"},{"line_number":115,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfbec78f_ed92f856","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":93},"in_reply_to":"dfbec78f_fd1e3db9","updated":"2019-05-15 14:51:36.000000000","message":"I didn\u0027t understand your question correctly.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_d39a416d","line":2,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/daemonset-health-manager.yaml":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"0c76f01afc451d87daee5b5c151330f5f4e146d4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":63,"context_line":"{{- end }}"},{"line_number":64,"context_line":"          command:"},{"line_number":65,"context_line":"            - /tmp/octavia-health-manager-get-port.sh"},{"line_number":66,"context_line":"          volumeMounts:"},{"line_number":67,"context_line":"            - name: pod-shared"},{"line_number":68,"context_line":"              mountPath: /tmp/pod-shared"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_5581164d","line":65,"range":{"start_line":65,"start_character":14,"end_line":65,"end_character":53},"updated":"2019-08-07 10:44:42.000000000","message":"Actually o-hm0 port required for successful work of octavia worker as well, so why do add init this only for octavia-health-manager?","commit_id":"ae2f759fa5b38e6357f2ff7ba67eb0f1fa5804b1"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a841aa2784893623ef24f257397d6830f9ae61ec","unresolved":false,"context_lines":[{"line_number":62,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":63,"context_line":"{{- end }}"},{"line_number":64,"context_line":"          command:"},{"line_number":65,"context_line":"            - /tmp/octavia-health-manager-get-port.sh"},{"line_number":66,"context_line":"          volumeMounts:"},{"line_number":67,"context_line":"            - name: pod-shared"},{"line_number":68,"context_line":"              mountPath: /tmp/pod-shared"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_35481a86","line":65,"range":{"start_line":65,"start_character":14,"end_line":65,"end_character":53},"in_reply_to":"7faddb67_1532be5f","updated":"2019-08-07 11:36:44.000000000","message":"yes, but is there a dependency between worker and healthmanager? \nI mean worker won\u0027t work properly until health-manager started.","commit_id":"ae2f759fa5b38e6357f2ff7ba67eb0f1fa5804b1"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"c0277744d22db3b23db5529815891f16b2ccd003","unresolved":false,"context_lines":[{"line_number":62,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":63,"context_line":"{{- end }}"},{"line_number":64,"context_line":"          command:"},{"line_number":65,"context_line":"            - /tmp/octavia-health-manager-get-port.sh"},{"line_number":66,"context_line":"          volumeMounts:"},{"line_number":67,"context_line":"            - name: pod-shared"},{"line_number":68,"context_line":"              mountPath: /tmp/pod-shared"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_20ce962d","line":65,"range":{"start_line":65,"start_character":14,"end_line":65,"end_character":53},"in_reply_to":"7faddb67_35481a86","updated":"2019-08-07 12:19:57.000000000","message":"But as I looked at the worker log in my testbed, the worker didn\u0027t seem to use o-hm until I actually created openstack loadbalancer. \nSo I didn\u0027t care. \nFrom this point of view, how about create o-hm on each controller before deployment (ex. 180-create-resource-for-octavia.sh)?","commit_id":"ae2f759fa5b38e6357f2ff7ba67eb0f1fa5804b1"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"5a876ac0fc3053dd057b5c19d06572bb42d0a1df","unresolved":false,"context_lines":[{"line_number":62,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":63,"context_line":"{{- end }}"},{"line_number":64,"context_line":"          command:"},{"line_number":65,"context_line":"            - /tmp/octavia-health-manager-get-port.sh"},{"line_number":66,"context_line":"          volumeMounts:"},{"line_number":67,"context_line":"            - name: pod-shared"},{"line_number":68,"context_line":"              mountPath: /tmp/pod-shared"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_1532be5f","line":65,"range":{"start_line":65,"start_character":14,"end_line":65,"end_character":53},"in_reply_to":"7faddb67_5581164d","updated":"2019-08-07 11:16:16.000000000","message":"both hm and worker use host network. At once hm initialize o-hm0 nic, worker can see it. So it works well.","commit_id":"ae2f759fa5b38e6357f2ff7ba67eb0f1fa5804b1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5a5db0258d05c6f968ec51f71542e4c06619aead","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"---"},{"line_number":28,"context_line":"apiVersion: apps/v1"},{"line_number":29,"context_line":"kind: DaemonSet"},{"line_number":30,"context_line":"metadata:"},{"line_number":31,"context_line":"  name: octavia-health-manager"},{"line_number":32,"context_line":"  annotations:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_9756d2cd","line":29,"updated":"2019-08-21 08:38:30.000000000","message":"Several octavia components like worker, healt-manager and housekeeping require access to LB management network (more infor might be found here https://docs.openstack.org/octavia/stein/contributor/guides/dev-quick-start.html#install-octavia-controller-software).\nAt the same time non of mentioned processes have strict requirement to be launched as single instance on the physical host (for example neutron openvwitch agent or nova-compute have this requirement as they modify network settings (ovs) or manage qemu domains). Octavia only needed access to LB network, and it is completely safe to run several instances of workers on the same host.\nAccess to LB network might be done in different ways:\n1. By using external physnets in neutron (drawback is that it will require additional vlan, or physical interface on hardware host)\n2. By using one of tenant networks (using openvswitch agent to bind (plug) octavia port in-to the neutron lb network).\n3. Setup lb network in the same way as floating network is configured.\n\nIMO we shouldn\u0027t use daemon set here to allow having multiple workers running on the same host.","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"31f0a0a52b32434983519af358e3be76b31ffa6b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"---"},{"line_number":28,"context_line":"apiVersion: apps/v1"},{"line_number":29,"context_line":"kind: DaemonSet"},{"line_number":30,"context_line":"metadata:"},{"line_number":31,"context_line":"  name: octavia-health-manager"},{"line_number":32,"context_line":"  annotations:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_f0821052","line":29,"in_reply_to":"7faddb67_9756d2cd","updated":"2019-08-30 05:11:20.000000000","message":"I appreciate to your reviews :) But this is the first patchset for Octavia so I\u0027d not like to modify more structurally on this patchset.\nAs you can see from the prevoius reviews, some teams are ready to iterate this and I think your opinion also can be applied later.\nI\u0027d like to improve this together, after merging to the current state.","commit_id":"777086546061135a7584095c3b1207eef72c765e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4f3edadd77288adbfdd6d0a89ac5a9aeafc364a9","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"---"},{"line_number":28,"context_line":"apiVersion: apps/v1"},{"line_number":29,"context_line":"kind: DaemonSet"},{"line_number":30,"context_line":"metadata:"},{"line_number":31,"context_line":"  name: octavia-health-manager"},{"line_number":32,"context_line":"  annotations:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_83fd7809","line":29,"in_reply_to":"7faddb67_f0821052","updated":"2019-09-02 11:02:15.000000000","message":"The issue here changing types from deamosets to deployments (for example) will cause difficulties with upgrades, so it is better to have solid starting point to iterate on.","commit_id":"777086546061135a7584095c3b1207eef72c765e"}],"octavia/templates/deployment-api.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_f3974544","line":2,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/deployment-health-manager.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_938a8918","line":2,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/deployment-housekeeping.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_b38f8d28","line":2,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/deployment-worker.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_538091f7","line":2,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/ingress-api.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_137e9918","line":2,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/job-bootstrap.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_337b9d28","line":2,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/job-db-drop.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_d373214d","line":2,"updated":"2019-06-27 14:09:59.000000000","message":"You cannot change this to this value (not legal existence), nor you haven\u0027t significantly changed file.\nPlease revert.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/network_policy.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f7204f343acdbab11ca8b3a57566d2202e652e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019-2020 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_33a07d90","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"updated":"2019-06-27 14:09:59.000000000","message":"I am looking forward to the future, but let\u0027s not change that.","commit_id":"911e4a24e7620cf5ee77e811157224527dc2d669"}],"octavia/templates/secret-ingress-tls.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c5bd2dd4cf99682d71929ad9680c6fdc625e9c98","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019-2020 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_2ee9a27f","line":2,"range":{"start_line":2,"start_character":14,"end_line":2,"end_character":19},"updated":"2019-01-19 21:49:57.000000000","message":"the future?","commit_id":"e4d1a133efcbcd35c21f5c47fc45fe33e0d48df0"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"db87411498fc5084f42ee934081218ca13ea67c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019-2020 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_8c2d3648","line":2,"range":{"start_line":2,"start_character":14,"end_line":2,"end_character":19},"in_reply_to":"9fdfeff1_2ee9a27f","updated":"2019-01-20 10:24:25.000000000","message":"Actually, I use this code from glance chart.\nI just changed +1 since it is 2018-2019.","commit_id":"e4d1a133efcbcd35c21f5c47fc45fe33e0d48df0"}],"octavia/templates/service-ingress-api.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"24cf904c558cce52dd140cc4b4073b99c6a8654b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dfbec78f_bd9685ef","updated":"2019-05-14 15:45:03.000000000","message":"note: I suppose in the future we can add a rally test. It doesn\u0027t sound very mandatory to have from the start.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"}],"octavia/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f85844286ca2d80368a7e72541106b85790d5676","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    database:"},{"line_number":212,"context_line":"      max_retries: -1"},{"line_number":213,"context_line":"    health_manager:"},{"line_number":214,"context_line":"      bind_port: 5555"},{"line_number":215,"context_line":"      bind_ip: 0.0.0.0"},{"line_number":216,"context_line":"      controller_ip_port_list: 0.0.0.0:5555"},{"line_number":217,"context_line":"      heartbeat_key: insecure"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_7fcd36b5","line":214,"range":{"start_line":214,"start_character":6,"end_line":214,"end_character":21},"updated":"2019-02-01 14:49:39.000000000","message":"we should be driving this via the endpoints section","commit_id":"b6991bfa21c92a467d84ed3555b48ecf66b310fe"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"397ee85faf98d6221632dfd88e8f4ba2ddb4579b","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    database:"},{"line_number":212,"context_line":"      max_retries: -1"},{"line_number":213,"context_line":"    health_manager:"},{"line_number":214,"context_line":"      bind_port: 5555"},{"line_number":215,"context_line":"      bind_ip: 0.0.0.0"},{"line_number":216,"context_line":"      controller_ip_port_list: 0.0.0.0:5555"},{"line_number":217,"context_line":"      heartbeat_key: insecure"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_d41176ae","line":214,"range":{"start_line":214,"start_character":6,"end_line":214,"end_character":21},"in_reply_to":"9fdfeff1_7fcd36b5","updated":"2019-03-20 09:07:25.000000000","message":"It\u0027s not api endpoint port. It is just used to health check in octavia via udp(between controller and health manager). Should it be handled by endpoints section??","commit_id":"b6991bfa21c92a467d84ed3555b48ecf66b310fe"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f85844286ca2d80368a7e72541106b85790d5676","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    health_manager:"},{"line_number":214,"context_line":"      bind_port: 5555"},{"line_number":215,"context_line":"      bind_ip: 0.0.0.0"},{"line_number":216,"context_line":"      controller_ip_port_list: 0.0.0.0:5555"},{"line_number":217,"context_line":"      heartbeat_key: insecure"},{"line_number":218,"context_line":"    keystone_authtoken:"},{"line_number":219,"context_line":"      auth_type: password"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_ffb84611","line":216,"range":{"start_line":216,"start_character":6,"end_line":216,"end_character":43},"updated":"2019-02-01 14:49:39.000000000","message":"ditto","commit_id":"b6991bfa21c92a467d84ed3555b48ecf66b310fe"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"397ee85faf98d6221632dfd88e8f4ba2ddb4579b","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    health_manager:"},{"line_number":214,"context_line":"      bind_port: 5555"},{"line_number":215,"context_line":"      bind_ip: 0.0.0.0"},{"line_number":216,"context_line":"      controller_ip_port_list: 0.0.0.0:5555"},{"line_number":217,"context_line":"      heartbeat_key: insecure"},{"line_number":218,"context_line":"    keystone_authtoken:"},{"line_number":219,"context_line":"      auth_type: password"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_9423ee05","line":216,"range":{"start_line":216,"start_character":6,"end_line":216,"end_character":43},"in_reply_to":"9fdfeff1_ffb84611","updated":"2019-03-20 09:07:25.000000000","message":"ditto.","commit_id":"b6991bfa21c92a467d84ed3555b48ecf66b310fe"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f85844286ca2d80368a7e72541106b85790d5676","unresolved":false,"context_lines":[{"line_number":233,"context_line":"      rest_request_conn_timeout: 10"},{"line_number":234,"context_line":"      rest_request_read_timeout: 120"},{"line_number":235,"context_line":"    controller_worker:"},{"line_number":236,"context_line":"      amp_image_owner_id: a4d81f2e4b164b1a93765f42c6eabd67"},{"line_number":237,"context_line":"      amp_secgroup_list: a7168852-ce2e-4187-a63b-f7bd4945666b"},{"line_number":238,"context_line":"      amp_flavor_id: a1011743-be4f-4ef3-8c3f-fb167b71042b"},{"line_number":239,"context_line":"      amp_boot_network_list: d74c4e77-3a55-43f8-b0f2-bd218ffb7ffc"},{"line_number":240,"context_line":"      amp_ssh_key_name: octavia_ssh_key"},{"line_number":241,"context_line":"      amp_image_tag: amphora"},{"line_number":242,"context_line":"      network_driver: allowed_address_pairs_driver"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_9f625aad","line":239,"range":{"start_line":236,"start_character":0,"end_line":239,"end_character":65},"updated":"2019-02-01 14:49:39.000000000","message":"should we have defaults here? or use the \u0027required\u0027 gotpl function to ensure they are set by the operator - as presumably these will be different for each deployment?","commit_id":"b6991bfa21c92a467d84ed3555b48ecf66b310fe"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"397ee85faf98d6221632dfd88e8f4ba2ddb4579b","unresolved":false,"context_lines":[{"line_number":233,"context_line":"      rest_request_conn_timeout: 10"},{"line_number":234,"context_line":"      rest_request_read_timeout: 120"},{"line_number":235,"context_line":"    controller_worker:"},{"line_number":236,"context_line":"      amp_image_owner_id: a4d81f2e4b164b1a93765f42c6eabd67"},{"line_number":237,"context_line":"      amp_secgroup_list: a7168852-ce2e-4187-a63b-f7bd4945666b"},{"line_number":238,"context_line":"      amp_flavor_id: a1011743-be4f-4ef3-8c3f-fb167b71042b"},{"line_number":239,"context_line":"      amp_boot_network_list: d74c4e77-3a55-43f8-b0f2-bd218ffb7ffc"},{"line_number":240,"context_line":"      amp_ssh_key_name: octavia_ssh_key"},{"line_number":241,"context_line":"      amp_image_tag: amphora"},{"line_number":242,"context_line":"      network_driver: allowed_address_pairs_driver"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_1467fe27","line":239,"range":{"start_line":236,"start_character":0,"end_line":239,"end_character":65},"in_reply_to":"9fdfeff1_9f625aad","updated":"2019-03-20 09:07:25.000000000","message":"As your comment, they will be different for each deployment.I\u0027ll change them to empty string. For them, Octavia configuration has no default values.","commit_id":"b6991bfa21c92a467d84ed3555b48ecf66b310fe"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"24cf904c558cce52dd140cc4b4073b99c6a8654b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"images:"},{"line_number":40,"context_line":"  tags:"},{"line_number":41,"context_line":"    test: docker.io/xrally/xrally-openstack:1.3.0"},{"line_number":42,"context_line":"    bootstrap: docker.io/openstackhelm/heat:ocata"},{"line_number":43,"context_line":"    db_init: docker.io/openstackhelm/heat:ocata"},{"line_number":44,"context_line":"    octavia_db_sync: docker.io/loci/octavia:master-ubuntu"},{"line_number":45,"context_line":"    db_drop: docker.io/openstackhelm/heat:ocata"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfbec78f_5d8749b6","line":42,"range":{"start_line":42,"start_character":44,"end_line":42,"end_character":49},"updated":"2019-05-14 15:45:03.000000000","message":"nit: I would encourage you to use the ocata-ubuntu_xenial image instead.\n\nBut because this is a new patch, and the change to move to ocata-ubuntu_xenial everywhere isn\u0027t ready, this is limited to a \"nit:\" item.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"553aef312d31af9608c41758a46fd6053eba7b03","unresolved":false,"context_lines":[{"line_number":39,"context_line":"images:"},{"line_number":40,"context_line":"  tags:"},{"line_number":41,"context_line":"    test: docker.io/xrally/xrally-openstack:1.3.0"},{"line_number":42,"context_line":"    bootstrap: docker.io/openstackhelm/heat:ocata"},{"line_number":43,"context_line":"    db_init: docker.io/openstackhelm/heat:ocata"},{"line_number":44,"context_line":"    octavia_db_sync: docker.io/loci/octavia:master-ubuntu"},{"line_number":45,"context_line":"    db_drop: docker.io/openstackhelm/heat:ocata"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfbec78f_add400ea","line":42,"range":{"start_line":42,"start_character":44,"end_line":42,"end_character":49},"in_reply_to":"dfbec78f_5d8749b6","updated":"2019-05-15 14:51:36.000000000","message":"I tried to keep consistency with other charts.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"6626e294bed105a9a0c2acd2e940c23fbf206d19","unresolved":false,"context_lines":[{"line_number":39,"context_line":"images:"},{"line_number":40,"context_line":"  tags:"},{"line_number":41,"context_line":"    test: docker.io/xrally/xrally-openstack:1.3.0"},{"line_number":42,"context_line":"    bootstrap: docker.io/openstackhelm/heat:ocata"},{"line_number":43,"context_line":"    db_init: docker.io/openstackhelm/heat:ocata"},{"line_number":44,"context_line":"    octavia_db_sync: docker.io/loci/octavia:master-ubuntu"},{"line_number":45,"context_line":"    db_drop: docker.io/openstackhelm/heat:ocata"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfbec78f_2949d75e","line":42,"range":{"start_line":42,"start_character":44,"end_line":42,"end_character":49},"in_reply_to":"dfbec78f_add400ea","updated":"2019-05-16 07:09:14.000000000","message":"Yes, don\u0027t worry. When this merges, we can update it to the latest tags.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"}],"tools/deployment/developer/common/180-create-resource-for-octavia.sh":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"48ac8abd7fe1e709a725a86061652442673acc5d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"rm -rf /tmp/octavia"},{"line_number":58,"context_line":"git clone https://github.com/openstack/octavia.git /tmp/octavia"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"sudo dhclient -v $OSH_LB_HM_IF_NAME -cf /tmp/octavia/etc/dhcp/dhclient.conf"}],"source_content_type":"text/x-sh","patch_set":9,"id":"dfbec78f_57b08a8a","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":75},"updated":"2019-05-14 14:35:44.000000000","message":"I tried this change, and for some reason this command is failing with \u0027No DHCPOFFERS received.\u0027 Do you have any idea why this can happen?","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"3a1ace828ae62599b4155fd10c74659eced82649","unresolved":false,"context_lines":[{"line_number":57,"context_line":"rm -rf /tmp/octavia"},{"line_number":58,"context_line":"git clone https://github.com/openstack/octavia.git /tmp/octavia"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"sudo dhclient -v $OSH_LB_HM_IF_NAME -cf /tmp/octavia/etc/dhcp/dhclient.conf"}],"source_content_type":"text/x-sh","patch_set":9,"id":"dfbec78f_d0ac72ee","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":75},"in_reply_to":"dfbec78f_57b08a8a","updated":"2019-05-15 10:30:30.000000000","message":"Ignore my comment here - port binding was failed, after it was fixed - current command has succeeded.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"98a373d299dd66f1053273a12b4659af50c8ce85","unresolved":false,"context_lines":[{"line_number":57,"context_line":"rm -rf /tmp/octavia"},{"line_number":58,"context_line":"git clone https://github.com/openstack/octavia.git /tmp/octavia"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"sudo dhclient -v $OSH_LB_HM_IF_NAME -cf /tmp/octavia/etc/dhcp/dhclient.conf"}],"source_content_type":"text/x-sh","patch_set":9,"id":"dfbec78f_6dd8487a","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":75},"in_reply_to":"dfbec78f_d0ac72ee","updated":"2019-05-15 14:32:00.000000000","message":"Good! :) I still couldn\u0027t reproduce it.","commit_id":"7e4fdc03cd0b546a62e0e30efa9d16eefdaa0578"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cd607e621dd36b376e55155d006d08f1c399e7cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7faddb67_93d49c21","updated":"2019-08-06 14:26:57.000000000","message":"to help both review, and subsequent use of this chart, i think adding comments here would be greatly beneficial.","commit_id":"a4b77d0fa3720fb974497b31231e363ed375db0a"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"6897f69d998d3c1f8e6a8dec6cc2cc3425b88034","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7faddb67_5adaa51d","in_reply_to":"7faddb67_93d49c21","updated":"2019-08-07 10:11:01.000000000","message":"Done","commit_id":"a4b77d0fa3720fb974497b31231e363ed375db0a"}],"tools/deployment/developer/common/190-create-octavia-certs.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f85844286ca2d80368a7e72541106b85790d5676","unresolved":false,"context_lines":[{"line_number":32,"context_line":"kind: Secret"},{"line_number":33,"context_line":"metadata:"},{"line_number":34,"context_line":"  name: $secret_name"},{"line_number":35,"context_line":"type: Opaque"},{"line_number":36,"context_line":"data:"},{"line_number":37,"context_line":"  $data_name: $(trim_data $data_path)"},{"line_number":38,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_7f5bf6f4","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":12},"updated":"2019-02-01 14:49:39.000000000","message":"can we use a k8s tls type secret here, rather than three separate opaque ones?","commit_id":"b6991bfa21c92a467d84ed3555b48ecf66b310fe"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"397ee85faf98d6221632dfd88e8f4ba2ddb4579b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"kind: Secret"},{"line_number":33,"context_line":"metadata:"},{"line_number":34,"context_line":"  name: $secret_name"},{"line_number":35,"context_line":"type: Opaque"},{"line_number":36,"context_line":"data:"},{"line_number":37,"context_line":"  $data_name: $(trim_data $data_path)"},{"line_number":38,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5fc1f717_b70dcce9","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":12},"in_reply_to":"9fdfeff1_7f5bf6f4","updated":"2019-03-20 09:07:25.000000000","message":"I think they are not simple 1 pair because they are 3 files and generated via octavia\u0027s script. So it\u0027s impossible tls secret simply. But I\u0027ll change this one opaque secret(has 3 data).","commit_id":"b6991bfa21c92a467d84ed3555b48ecf66b310fe"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cd607e621dd36b376e55155d006d08f1c399e7cb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"rm -rf /tmp/octavia"},{"line_number":42,"context_line":"git clone https://github.com/openstack/octavia.git /tmp/octavia"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cd /tmp/octavia/bin"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"7faddb67_53daa44a","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":63},"updated":"2019-08-06 14:26:57.000000000","message":"should this be versioned/pinned?","commit_id":"a4b77d0fa3720fb974497b31231e363ed375db0a"},{"author":{"_account_id":29796,"name":"Kim Ha-gun","email":"hagun.kim@samsung.com","username":"hagun-kim"},"change_message_id":"6897f69d998d3c1f8e6a8dec6cc2cc3425b88034","unresolved":false,"context_lines":[{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"rm -rf /tmp/octavia"},{"line_number":42,"context_line":"git clone https://github.com/openstack/octavia.git /tmp/octavia"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cd /tmp/octavia/bin"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"7faddb67_1a32ed5f","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":63},"in_reply_to":"7faddb67_53daa44a","updated":"2019-08-07 10:11:01.000000000","message":"Actually I only use stuffs about generating certificates. They are in Octavia git, but don\u0027t seem to be included Octavia source. (not in octavia/octavia directory) So I think pinning version is not needed.","commit_id":"a4b77d0fa3720fb974497b31231e363ed375db0a"}]}