)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3c299be77f961bd4479a20f11cd514b635f525ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     PRATEEK REDDY DODDA \u003cpd2839@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-16 01:52:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Setting the secure flag on all cookies that are used for transmitting sensitive data when accessing content over HTTPS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8ed76969e8418013256307c006958662c3909eb0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfdaf3ff_cacc2b63","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":90},"updated":"2019-01-16 08:47:37.000000000","message":"First line of commitmsg should be ~70 chars.","commit_id":"5c8c835811767bddbf094538217566b8b53a585a"},{"author":{"_account_id":29144,"name":"PRATEEK REDDY DODDA","email":"prateek.reddy.dodda@att.com","username":"pd2839"},"change_message_id":"8681702609c04cfc90211c3011857801acf16061","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     PRATEEK REDDY DODDA \u003cpd2839@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-16 01:52:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Setting the secure flag on all cookies that are used for transmitting sensitive data when accessing content over HTTPS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8ed76969e8418013256307c006958662c3909eb0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfdaf3ff_c409772c","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":90},"in_reply_to":"bfdaf3ff_cacc2b63","updated":"2019-01-17 14:04:27.000000000","message":"Done","commit_id":"5c8c835811767bddbf094538217566b8b53a585a"}],"horizon/templates/deployment.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"3e873e240027171aa92840ba912f885348dc5bf5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"              containerPort: {{ tuple \"dashboard\" \"internal\" \"web\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":75,"context_line":"          readinessProbe:"},{"line_number":76,"context_line":"            httpGet:"},{"line_number":77,"context_line":"              schema: HTTPS"},{"line_number":78,"context_line":"              path: /"},{"line_number":79,"context_line":"              port: {{ tuple \"dashboard\" \"internal\" \"web\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":80,"context_line":"            initialDelaySeconds: 15"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_d9352cf9","line":77,"range":{"start_line":77,"start_character":13,"end_line":77,"end_character":27},"updated":"2019-01-21 18:08:53.000000000","message":"why this change?\ndoes schema work?  and the service is http\n\nalso same for below","commit_id":"ec3a756c4e790d172e2f7f6c1544d1c23b2bf7eb"}],"horizon/values.yaml":[{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"8ae3c9cf1f480c0cffbd5b3e886b3b45e055e4dc","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # If Horizon is being served through SSL, then uncomment the following two"},{"line_number":174,"context_line":"        # settings to better secure the cookies from security exploits"},{"line_number":175,"context_line":"        CSRF_COOKIE_SECURE \u003d True"},{"line_number":176,"context_line":"        SESSION_COOKIE_SECURE \u003d True"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        # Overrides for OpenStack API versions. Use this setting to force the"},{"line_number":179,"context_line":"        # OpenStack dashboard to use a specific API version for a given service API."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfdaf3ff_b45ef60f","line":176,"range":{"start_line":175,"start_character":0,"end_line":176,"end_character":36},"updated":"2019-01-15 18:26:30.000000000","message":"It is \"http\" by default [1], are you sure that this won\u0027t be broken without configuring \"https\"?\n\nAs an option, it can be enabled with templates logic, based on flag or dynamically determining if ssl is enabled.\n\n[1] https://github.com/openstack/openstack-helm/blob/master/horizon/values.yaml#L2028-L2048","commit_id":"74b18d91590a45f7235b656cdd393c5657106a35"},{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"bf53cfdd259bc64607cf1d49a8e1e4e923dbe8d4","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"    path:"},{"line_number":2013,"context_line":"      default: /v3"},{"line_number":2014,"context_line":"    scheme:"},{"line_number":2015,"context_line":"      default: https"},{"line_number":2016,"context_line":"    port:"},{"line_number":2017,"context_line":"      api:"},{"line_number":2018,"context_line":"        default: 80"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfdaf3ff_ef3b4bc5","line":2015,"range":{"start_line":2015,"start_character":19,"end_line":2015,"end_character":20},"updated":"2019-01-15 18:57:41.000000000","message":"Can you please clarify what is the purpose of your patch?\n\nHere you change access to keystone using https instead of http, Keystone is configured with http by default [1].\n\n[1] https://github.com/openstack/openstack-helm/blob/master/keystone/values.yaml#L1047-L1048","commit_id":"ca4366f7426700936fbdc2a06a18a785ae85ba78"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3c299be77f961bd4479a20f11cd514b635f525ca","unresolved":false,"context_lines":[{"line_number":2041,"context_line":"      #     key: null"},{"line_number":2042,"context_line":"    path:"},{"line_number":2043,"context_line":"      default: null"},{"line_number":2044,"context_line":"    scheme:"},{"line_number":2045,"context_line":"      default: https"},{"line_number":2046,"context_line":"    port:"},{"line_number":2047,"context_line":"      web:"},{"line_number":2048,"context_line":"        default: 80"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfdaf3ff_ea000f6a","line":2045,"range":{"start_line":2044,"start_character":0,"end_line":2045,"end_character":20},"updated":"2019-01-16 08:47:37.000000000","message":"Changing this to https would require you to have certificates in place - else how are you securing the connection?","commit_id":"5c8c835811767bddbf094538217566b8b53a585a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3c299be77f961bd4479a20f11cd514b635f525ca","unresolved":false,"context_lines":[{"line_number":2045,"context_line":"      default: https"},{"line_number":2046,"context_line":"    port:"},{"line_number":2047,"context_line":"      web:"},{"line_number":2048,"context_line":"        default: 80"},{"line_number":2049,"context_line":"  oslo_db:"},{"line_number":2050,"context_line":"    auth:"},{"line_number":2051,"context_line":"      admin:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfdaf3ff_8aef03af","line":2048,"range":{"start_line":2048,"start_character":17,"end_line":2048,"end_character":19},"updated":"2019-01-16 08:47:37.000000000","message":"443 if you are going to to use https","commit_id":"5c8c835811767bddbf094538217566b8b53a585a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"928bc02c86e3bb00b7daf5a71f498c204d9d409a","unresolved":false,"context_lines":[{"line_number":2042,"context_line":"    path:"},{"line_number":2043,"context_line":"      default: null"},{"line_number":2044,"context_line":"    scheme:"},{"line_number":2045,"context_line":"      default: http"},{"line_number":2046,"context_line":"    port:"},{"line_number":2047,"context_line":"      web:"},{"line_number":2048,"context_line":"        default: 80"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfdaf3ff_e062593e","line":2045,"range":{"start_line":2045,"start_character":10,"end_line":2045,"end_character":19},"updated":"2019-01-17 07:32:59.000000000","message":"this patch is using httpS for readiness and liveness probe against the service running on http:80.","commit_id":"ec3a756c4e790d172e2f7f6c1544d1c23b2bf7eb"},{"author":{"_account_id":29144,"name":"PRATEEK REDDY DODDA","email":"prateek.reddy.dodda@att.com","username":"pd2839"},"change_message_id":"8681702609c04cfc90211c3011857801acf16061","unresolved":false,"context_lines":[{"line_number":2042,"context_line":"    path:"},{"line_number":2043,"context_line":"      default: null"},{"line_number":2044,"context_line":"    scheme:"},{"line_number":2045,"context_line":"      default: http"},{"line_number":2046,"context_line":"    port:"},{"line_number":2047,"context_line":"      web:"},{"line_number":2048,"context_line":"        default: 80"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfdaf3ff_0053d640","line":2045,"range":{"start_line":2045,"start_character":10,"end_line":2045,"end_character":19},"in_reply_to":"bfdaf3ff_e062593e","updated":"2019-01-17 14:04:27.000000000","message":"Done","commit_id":"ec3a756c4e790d172e2f7f6c1544d1c23b2bf7eb"}]}