)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"bea6c2cdc9c13aab3315e2837d1e9132b8260f22","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updating keystone-api to work with opensuse based image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modifiying apache vhosts file location for keystone-api wsgi"},{"line_number":10,"context_line":"component to work with opensuse based images."},{"line_number":11,"context_line":"Also adding conf file for allowing access to cgi script in opensuse"},{"line_number":12,"context_line":"environment."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3e49fb7cdb5f84060d9a7b580589b461de201c23"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_5cf7258c","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":12},"updated":"2019-02-01 08:21:57.000000000","message":"This is not clear about WHY this is done.\nWe can see the changes by reading the patchset, but I cannot understand the reasons with only this (excepted that it\u0027s needed for SUSE support).","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"60ecf87a336d73f478aa89c603506ee785bf2003","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updating keystone-api to work with opensuse based image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modifiying apache vhosts file location for keystone-api wsgi"},{"line_number":10,"context_line":"component to work with opensuse based images."},{"line_number":11,"context_line":"Also adding conf file for allowing access to cgi script in opensuse"},{"line_number":12,"context_line":"environment."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3e49fb7cdb5f84060d9a7b580589b461de201c23"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_2c0e8a32","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":12},"in_reply_to":"9fdfeff1_5cf7258c","updated":"2019-02-04 21:06:57.000000000","message":"I have tried to more details in reply to review comments but not sure what level of details are needed here.\n\nI can add more details here if needed but it seems like this is a larger and common aspect/issue which we have to deal across multiple helm components i.e. \"how to make these various deployment artifacts definition work across multiple distros\". Is there a common template/ pattern to be defined and followed across various openstack services and other helm infra components.\n\nI will try to bring attention to this topic in weekly meeting. Added review first to highlight and provide a working sample of kind of changes needed.","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"}],"keystone/templates/bin/_keystone-api.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"bea6c2cdc9c13aab3315e2837d1e9132b8260f22","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  fi"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if [[ \"x$HOST_OS\" \u003d\u003d \"xsles\" ]] || [[ \"$HOST_OS\" \u003d\u003d *\"suse\"* ]]; then"},{"line_number":43,"context_line":"    a2enmod version"},{"line_number":44,"context_line":"    exec apachectl -DFOREGROUND -k start"},{"line_number":45,"context_line":"  else"},{"line_number":46,"context_line":"    # Start Apache2"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"9fdfeff1_bc2df1fe","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":19},"updated":"2019-02-01 08:21:57.000000000","message":"nit: I would add a comment here:\nConfigMap contains IfVersion therefore the version mod has to be enabled.","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"0ebb0b0e52b7a7f0c92f3e43228cab3d8065f5c3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  fi"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if [[ \"x$HOST_OS\" \u003d\u003d \"xsles\" ]] || [[ \"$HOST_OS\" \u003d\u003d *\"suse\"* ]]; then"},{"line_number":43,"context_line":"    a2enmod version"},{"line_number":44,"context_line":"    exec apachectl -DFOREGROUND -k start"},{"line_number":45,"context_line":"  else"},{"line_number":46,"context_line":"    # Start Apache2"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"9fdfeff1_040e0432","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":19},"in_reply_to":"9fdfeff1_bc2df1fe","updated":"2019-02-04 18:17:00.000000000","message":"Are you referring to this line..\n\nhttps://github.com/openstack/openstack-helm/blob/master/keystone/values.yaml#L891\n\nThis is needed only for SUSE though its same config map used in other distros. I can add the comment if it helps. Just to be clear I am not sure if error observed is going to go away if related directive is not used there.","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"}],"keystone/templates/configmap-etc.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"bea6c2cdc9c13aab3315e2837d1e9132b8260f22","unresolved":false,"context_lines":[{"line_number":59,"context_line":"{{- end }}"},{"line_number":60,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.mpm_event \"key\" \"mpm_event.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":61,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.wsgi_keystone \"key\" \"wsgi-keystone.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":62,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.wsgi_keystone_script \"key\" \"wsgi-keystone-script.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":63,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.sso_callback_template \"key\" \"sso_callback_template.html\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":64,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_3c4101aa","line":62,"range":{"start_line":62,"start_character":58,"end_line":62,"end_character":162},"updated":"2019-02-01 08:21:57.000000000","message":"could you explain what this does (except loading the new script content you\u0027ve added) vs wsgi-keystone.conf?\nIt seems for suse they are two different files, but except that, what was the reason to have this? Couldn\u0027t we just generate a different configuration file per distro in the configmap, without the need to extend the template?\n\n\nIf these are two different things that ideally must be kept separate, it should be written somewhere, so no one tries to change it later :)","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"0ebb0b0e52b7a7f0c92f3e43228cab3d8065f5c3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"{{- end }}"},{"line_number":60,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.mpm_event \"key\" \"mpm_event.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":61,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.wsgi_keystone \"key\" \"wsgi-keystone.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":62,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.wsgi_keystone_script \"key\" \"wsgi-keystone-script.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":63,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.sso_callback_template \"key\" \"sso_callback_template.html\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":64,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_a40058ad","line":62,"range":{"start_line":62,"start_character":58,"end_line":62,"end_character":162},"in_reply_to":"9fdfeff1_3c4101aa","updated":"2019-02-04 18:17:00.000000000","message":"here we are mapping that script file which","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"60ecf87a336d73f478aa89c603506ee785bf2003","unresolved":false,"context_lines":[{"line_number":59,"context_line":"{{- end }}"},{"line_number":60,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.mpm_event \"key\" \"mpm_event.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":61,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.wsgi_keystone \"key\" \"wsgi-keystone.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":62,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.wsgi_keystone_script \"key\" \"wsgi-keystone-script.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":63,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.sso_callback_template \"key\" \"sso_callback_template.html\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":64,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_f13cdb31","line":62,"range":{"start_line":62,"start_character":58,"end_line":62,"end_character":162},"in_reply_to":"9fdfeff1_a40058ad","updated":"2019-02-04 21:06:57.000000000","message":"I meant to say above..\n\nThis conf section is used for add access to wsgi script which is placed in different directory path than ubuntu version.\n\nAnd key here refers to mapping of volume mount used to map that file path which allows access to /www/ directory paths.\n\nFor details,\n\nhttps://doc.opensuse.org/documentation/leap/reference/html/book.opensuse.reference/cha.apache2.html#ex.apache.directives.virtualhost.basic_configuration","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"}],"keystone/templates/deployment-api.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"bea6c2cdc9c13aab3315e2837d1e9132b8260f22","unresolved":false,"context_lines":[{"line_number":59,"context_line":"{{ tuple $envAll \"keystone_api\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.api | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"          securityContext:"},{"line_number":62,"context_line":"{{- if and (.Values.image_distro) (eq .Values.image_distro \"suse_15\") }}"},{"line_number":63,"context_line":"            runAsUser: 0"},{"line_number":64,"context_line":"{{- else }}"},{"line_number":65,"context_line":"            allowPrivilegeEscalation: false"},{"line_number":66,"context_line":"{{- end }}"},{"line_number":67,"context_line":"          command:"},{"line_number":68,"context_line":"            - /tmp/keystone-api.sh"},{"line_number":69,"context_line":"            - start"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_bc089191","line":66,"range":{"start_line":62,"start_character":0,"end_line":66,"end_character":10},"updated":"2019-02-01 08:21:57.000000000","message":"I am not really sure of the impact here, so I\u0027d love to see a review from someone more experimented than I am.","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"0ebb0b0e52b7a7f0c92f3e43228cab3d8065f5c3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"{{ tuple $envAll \"keystone_api\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.api | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"          securityContext:"},{"line_number":62,"context_line":"{{- if and (.Values.image_distro) (eq .Values.image_distro \"suse_15\") }}"},{"line_number":63,"context_line":"            runAsUser: 0"},{"line_number":64,"context_line":"{{- else }}"},{"line_number":65,"context_line":"            allowPrivilegeEscalation: false"},{"line_number":66,"context_line":"{{- end }}"},{"line_number":67,"context_line":"          command:"},{"line_number":68,"context_line":"            - /tmp/keystone-api.sh"},{"line_number":69,"context_line":"            - start"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_64d11030","line":66,"range":{"start_line":62,"start_character":0,"end_line":66,"end_character":10},"in_reply_to":"9fdfeff1_bc089191","updated":"2019-02-04 18:17:00.000000000","message":"This is needed to run keystone-api.sh as root user otherwise that command fails. I believe in SUSE most of non-general user command requires explicit sudo privilege. \n\nI recall seeing that in ubuntu, specific users are setup by \n\"source /etc/apache2/envvars\" . I don\u0027t see something similar on suse side.","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"bea6c2cdc9c13aab3315e2837d1e9132b8260f22","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            mountPath: /etc/keystone/sso_callback_template.html"},{"line_number":126,"context_line":"            subPath: sso_callback_template.html"},{"line_number":127,"context_line":"            readOnly: true"},{"line_number":128,"context_line":"{{- if and (.Values.image_distro) (eq .Values.image_distro \"suse_15\") }}"},{"line_number":129,"context_line":"          - name: keystone-etc"},{"line_number":130,"context_line":"            mountPath: /etc/apache2/vhosts.d/wsgi-keystone.conf"},{"line_number":131,"context_line":"            subPath: wsgi-keystone.conf"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_bc7bb1f2","line":128,"range":{"start_line":128,"start_character":3,"end_line":128,"end_character":72},"updated":"2019-02-01 08:21:57.000000000","message":"Same gist as previous file\u0027s comment: Can we be more flexible here?\n\nIf we want OSH to be distro independent, we shouldn\u0027t add a value \"image_distro\". Instead we should probably split the templates into what semantically means something (that\u0027s what I meant in the previous file by \u0027if things should be ideally separated\u0027), and have different values that can be injected by the deployers.\n\nFor example, I can definitely imagine a variable that can be modified per distro for the mountPath, and whose content will also be overriden per distro. At the end we would have files like a \u0027ubuntu xenial override\u0027, or a \u0027opensuse leap 15 override\u0027, each of them providing path to the right locations, and whose default content would be safe defaults for the distribution.\n\nHow do you feel about that?","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"0ebb0b0e52b7a7f0c92f3e43228cab3d8065f5c3","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            mountPath: /etc/keystone/sso_callback_template.html"},{"line_number":126,"context_line":"            subPath: sso_callback_template.html"},{"line_number":127,"context_line":"            readOnly: true"},{"line_number":128,"context_line":"{{- if and (.Values.image_distro) (eq .Values.image_distro \"suse_15\") }}"},{"line_number":129,"context_line":"          - name: keystone-etc"},{"line_number":130,"context_line":"            mountPath: /etc/apache2/vhosts.d/wsgi-keystone.conf"},{"line_number":131,"context_line":"            subPath: wsgi-keystone.conf"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_3807a81b","line":128,"range":{"start_line":128,"start_character":3,"end_line":128,"end_character":72},"in_reply_to":"9fdfeff1_bc7bb1f2","updated":"2019-02-04 18:17:00.000000000","message":"As you correctly identified, this is distro specific mount path logic. Every distro will have some configuration files which are placed in different path and refer different content. And then there will be files which are additional or not applicable in specific distro. \n\nSo requirement is to have ability to execute distro specific logic when defining k8s artifacts, probably based on a certain flag or condition which identifies the distro.\n\nSo now choice is around how to define them ?\nIf I am understanding correctly, are you suggesting to define them at some central place? It may also mean that we are moving artifact structure/format in that common area as there will be additional or \u0027not applicable\u0027 configuration files specific to a distro and hence addition and/or removal of config paths.\n\nImho, defining here seems more maintainable and explicit as we know what distro specific paths are applicable for that k8s artifact in that helm release component.\n\nCan you clarify and provide more details about alternative approach?","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"bea6c2cdc9c13aab3315e2837d1e9132b8260f22","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            subPath: sso_callback_template.html"},{"line_number":127,"context_line":"            readOnly: true"},{"line_number":128,"context_line":"{{- if and (.Values.image_distro) (eq .Values.image_distro \"suse_15\") }}"},{"line_number":129,"context_line":"          - name: keystone-etc"},{"line_number":130,"context_line":"            mountPath: /etc/apache2/vhosts.d/wsgi-keystone.conf"},{"line_number":131,"context_line":"            subPath: wsgi-keystone.conf"},{"line_number":132,"context_line":"            readOnly: true"},{"line_number":133,"context_line":"          - name: keystone-etc"},{"line_number":134,"context_line":"            mountPath: /etc/apache2/conf.d/default.conf"},{"line_number":135,"context_line":"            subPath: wsgi-keystone-script.conf"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_3cfca16e","line":132,"range":{"start_line":129,"start_character":0,"end_line":132,"end_character":26},"updated":"2019-02-01 08:21:57.000000000","message":"could you clarify in the commit message why this needs to happen (vs ubuntu behaviour,where everything is in a single file)","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"0ebb0b0e52b7a7f0c92f3e43228cab3d8065f5c3","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            subPath: sso_callback_template.html"},{"line_number":127,"context_line":"            readOnly: true"},{"line_number":128,"context_line":"{{- if and (.Values.image_distro) (eq .Values.image_distro \"suse_15\") }}"},{"line_number":129,"context_line":"          - name: keystone-etc"},{"line_number":130,"context_line":"            mountPath: /etc/apache2/vhosts.d/wsgi-keystone.conf"},{"line_number":131,"context_line":"            subPath: wsgi-keystone.conf"},{"line_number":132,"context_line":"            readOnly: true"},{"line_number":133,"context_line":"          - name: keystone-etc"},{"line_number":134,"context_line":"            mountPath: /etc/apache2/conf.d/default.conf"},{"line_number":135,"context_line":"            subPath: wsgi-keystone-script.conf"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_7874509d","line":132,"range":{"start_line":129,"start_character":0,"end_line":132,"end_character":26},"in_reply_to":"9fdfeff1_3cfca16e","updated":"2019-02-04 18:17:00.000000000","message":"This is different as vhosts config file default location is different and then need to provide access to wsgi script directory location.\n\nIf interested in details, check following.\n\nhttps://doc.opensuse.org/documentation/leap/reference/html/book.opensuse.reference/cha.apache2.html#sec.apache2.configuration.manually.vhost\n\nhttps://doc.opensuse.org/documentation/leap/reference/html/book.opensuse.reference/cha.apache2.html#sec.apache2.configuration.manually.vhost.basic_configuration","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"}],"keystone/values.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"bea6c2cdc9c13aab3315e2837d1e9132b8260f22","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"release_group: null"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"image_distro: ubuntu_xenial"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"images:"},{"line_number":33,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_5cce455a","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":27},"updated":"2019-02-01 08:21:57.000000000","message":"I don\u0027t think this need to exist, as we can pass a toggle of the function in values anyway.\n\nThis can get quickly out of hand.","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"0ebb0b0e52b7a7f0c92f3e43228cab3d8065f5c3","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"release_group: null"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"image_distro: ubuntu_xenial"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"images:"},{"line_number":33,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_b8bdd803","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":27},"in_reply_to":"9fdfeff1_5cce455a","updated":"2019-02-04 18:17:00.000000000","message":"Can you please expand on that? \n\nOn what condition or value, a deployer can make the switch to execute distro specific logic per helm component artifact. I think it can be more specific to deployment artifact but did not found out how to do that without introducing a intrusive change in deployment definitions.","commit_id":"e132eefb9786710873d79ea5e62ca940c3087992"}]}