)]}'
{"id":"openstack%2Fopenstack-helm~634471","triplet_id":"openstack%2Fopenstack-helm~master~I8132a58182f7e3d82bb596793badb13bb5f0340b","project":"openstack/openstack-helm","branch":"master","topic":"horizon_checklist","hashtags":[],"change_id":"I8132a58182f7e3d82bb596793badb13bb5f0340b","subject":"Horizon: Update local_settings","status":"ABANDONED","created":"2019-02-01 19:03:36.000000000","updated":"2019-02-01 19:41:15.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a7b643f06bfe71ade60ea81abc93f713fbc6c150","_number":634471,"virtual_id_number":634471,"owner":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":-1,"date":"2019-02-01 19:17:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":-1,"date":"2019-02-01 19:35:05.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"date":"2019-02-01 19:12:06.000000000","_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"date":"2019-02-01 19:12:19.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-02-01 19:08:15.000000000","updated_by":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"reviewer":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"state":"REVIEWER"},{"updated":"2019-02-01 19:08:15.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2019-02-01 19:08:15.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2019-02-01 19:08:15.000000000","updated_by":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"reviewer":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"state":"REVIEWER"},{"updated":"2019-02-01 19:12:06.000000000","updated_by":{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},"reviewer":{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},"state":"REVIEWER"},{"updated":"2019-02-01 19:12:19.000000000","updated_by":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"reviewer":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"state":"REVIEWER"},{"updated":"2019-02-01 19:17:13.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2019-02-01 19:35:05.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"}],"messages":[{"id":"dab17d516e5ef8227b6a68d8c4019b7f0547c483","author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"date":"2019-02-01 19:03:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"216a20149a1199d4cb034cbdcb8506fde561dc50","author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"date":"2019-02-01 19:10:43.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"00b07e52cf8b9c389dacdbc9421c33aa246b32da","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2019-02-01 19:17:13.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f69eda42f62805bfb03484d91df9f7865cd8195a","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-02-01 19:35:05.000000000","message":"Patch Set 2: Code-Review-1\n\nThis is the chart before the horse.","accounts_in_message":[],"_revision_number":2},{"id":"d27af1a2a1de0e91e7620335c8685368d85a127e","author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"date":"2019-02-01 19:41:15.000000000","message":"Abandoned\n\nThanks for the review, I will make the changes in the downstream manifest","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d9507ec197883b22fb0da34616a7bcd5cffc50fe","revisions":{"730c81feee0c3ab87ea43098e550d6632bb9367f":{"kind":"REWORK","_number":1,"created":"2019-02-01 19:03:36.000000000","uploader":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"ref":"refs/changes/71/634471/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/71/634471/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/71/634471/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/71/634471/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/71/634471/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/71/634471/1"}}},"commit":{"parents":[{"commit":"326200bf939763144d3bdb3ee22252e1ee00cdea","subject":"Merge \"Scan templated python files with bandit\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/326200bf939763144d3bdb3ee22252e1ee00cdea"}]}],"author":{"name":"Rick Bartra","email":"rb560u@att.com","date":"2019-02-01 18:50:15.000000000","tz":-300},"committer":{"name":"Rick Bartra","email":"rb560u@att.com","date":"2019-02-01 18:50:15.000000000","tz":-300},"subject":"Horizon: Update local_settings","message":"Horizon: Update local_settings\n\nIn accordance with the OpenStack Security Guide this PS updates\nthe local_settings configuration to comply with the Horizon\nsecurity checklist [0]\n\n- Check-Dashboard-03: Is DISALLOW_IFRAME_EMBED parameter set to True\n- Check-Dashboard-04: Is CSRF_COOKIE_SECURE parameter set to True\n- Check-Dashboard-05: Is SESSION_COOKIE_SECURE parameter set to True\n- Check-Dashboard-06: Is SESSION_COOKIE_HTTPONLY parameter set to True\n- Check-Dashboard-07: Is PASSWORD_AUTOCOMPLETE set to False\n- Check-Dashboard-08: Is DISABLE_PASSWORD_REVEAL set to True\n- Check-Dashboard-11: Is SECURE_PROXY_SSL_HEADER configured\n\n[0] https://docs.openstack.org/security-guide/dashboard/checklist.html\n\nChange-Id: I8132a58182f7e3d82bb596793badb13bb5f0340b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/730c81feee0c3ab87ea43098e550d6632bb9367f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/730c81feee0c3ab87ea43098e550d6632bb9367f"}]},"branch":"refs/heads/master"},"d9507ec197883b22fb0da34616a7bcd5cffc50fe":{"kind":"REWORK","_number":2,"created":"2019-02-01 19:10:43.000000000","uploader":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"ref":"refs/changes/71/634471/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/71/634471/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/71/634471/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/71/634471/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/71/634471/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/71/634471/2"}}},"commit":{"parents":[{"commit":"326200bf939763144d3bdb3ee22252e1ee00cdea","subject":"Merge \"Scan templated python files with bandit\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/326200bf939763144d3bdb3ee22252e1ee00cdea"}]}],"author":{"name":"Rick Bartra","email":"rb560u@att.com","date":"2019-02-01 18:50:15.000000000","tz":-300},"committer":{"name":"Rick Bartra","email":"rb560u@att.com","date":"2019-02-01 19:10:37.000000000","tz":0},"subject":"Horizon: Update local_settings","message":"Horizon: Update local_settings\n\nIn accordance with the OpenStack Security Guide this PS updates\nthe local_settings configuration to comply with the Horizon\nsecurity checklist [0]\n\n- Check-Dashboard-03: Is DISALLOW_IFRAME_EMBED parameter set to True\n- Check-Dashboard-04: Is CSRF_COOKIE_SECURE parameter set to True\n- Check-Dashboard-05: Is SESSION_COOKIE_SECURE parameter set to True\n- Check-Dashboard-06: Is SESSION_COOKIE_HTTPONLY parameter set to True\n- Check-Dashboard-07: Is PASSWORD_AUTOCOMPLETE set to False\n- Check-Dashboard-08: Is DISABLE_PASSWORD_REVEAL set to True\n- Check-Dashboard-11: Is SECURE_PROXY_SSL_HEADER configured\n\n[0] https://docs.openstack.org/security-guide/dashboard/checklist.html\n\nChange-Id: I8132a58182f7e3d82bb596793badb13bb5f0340b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d9507ec197883b22fb0da34616a7bcd5cffc50fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d9507ec197883b22fb0da34616a7bcd5cffc50fe"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}