)]}'
{"horizon/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"019ff01bd5231c55f7e03a96e6dcdbae5df7c403","unresolved":false,"context_lines":[{"line_number":876,"context_line":"        # where iframes are not used in deployment. Default setting is True."},{"line_number":877,"context_line":"        # For more information see:"},{"line_number":878,"context_line":"        # http://tinyurl.com/anticlickjack"},{"line_number":879,"context_line":"        DISALLOW_IFRAME_EMBED \u003d \u0027{{ .Values.conf.horizon.local_settings.config.disallow_iframe_embed }}\u0027"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        STATIC_ROOT \u003d \u0027/var/www/html/horizon\u0027"},{"line_number":882,"context_line":"    policy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_4179542d","line":879,"range":{"start_line":879,"start_character":31,"end_line":879,"end_character":104},"updated":"2019-02-05 02:47:32.000000000","message":"Would this not render the python line;\n\n   DISALLOW_IFRAME_EMBED \u003d \u0027False\u0027\n\ninstead of:\n\n  DISALLOW_IFRAME_EMBED \u003d False\n\nwhich is what we want.  This seems to apply to other security toggles as well.  See [0].\n\n[0] http://paste.openstack.org/show/744534/","commit_id":"6788e45eb811c438697d2e14f1b5f58088137f20"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"6c6f9ab5bf6ee91469732532aea315d1f245d4b4","unresolved":false,"context_lines":[{"line_number":876,"context_line":"        # where iframes are not used in deployment. Default setting is True."},{"line_number":877,"context_line":"        # For more information see:"},{"line_number":878,"context_line":"        # http://tinyurl.com/anticlickjack"},{"line_number":879,"context_line":"        DISALLOW_IFRAME_EMBED \u003d \u0027{{ .Values.conf.horizon.local_settings.config.disallow_iframe_embed }}\u0027"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        STATIC_ROOT \u003d \u0027/var/www/html/horizon\u0027"},{"line_number":882,"context_line":"    policy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_60723c14","line":879,"range":{"start_line":879,"start_character":31,"end_line":879,"end_character":104},"in_reply_to":"9fdfeff1_00b7b0da","updated":"2019-02-06 04:46:50.000000000","message":"Hey Tin, yes, I am also not referring to the key\u0027s quotes. I am referring to like lines 184-190:\n\n          enable_router: \"True\"\n          enable_quotas: \"True\"\n          enable_ipv6: \"True\"\n          enable_distributed_router: \"False\"\n          enable_ha_router: \"False\"\n          enable_lb: \"True\"\n          enable_firewall: \"True\"\n\nThat although these values are set to either \"True\" or \"False\", what is ultimately rendered to local_settings is True or False without the quotes. Examples:\n\nlocal_settings:    \u0027enable_router\u0027: True\nlocal_settings:    \u0027enable_lb\u0027: True\nlocal_settings:    \u0027enable_firewall\u0027: True","commit_id":"6788e45eb811c438697d2e14f1b5f58088137f20"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"a2bc7233d1223be6e627907ffc839cc88902dca5","unresolved":false,"context_lines":[{"line_number":876,"context_line":"        # where iframes are not used in deployment. Default setting is True."},{"line_number":877,"context_line":"        # For more information see:"},{"line_number":878,"context_line":"        # http://tinyurl.com/anticlickjack"},{"line_number":879,"context_line":"        DISALLOW_IFRAME_EMBED \u003d \u0027{{ .Values.conf.horizon.local_settings.config.disallow_iframe_embed }}\u0027"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        STATIC_ROOT \u003d \u0027/var/www/html/horizon\u0027"},{"line_number":882,"context_line":"    policy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_bcad9a32","line":879,"range":{"start_line":879,"start_character":31,"end_line":879,"end_character":104},"in_reply_to":"9fdfeff1_3c7d2ae7","updated":"2019-02-06 22:59:42.000000000","message":"Thanks for the explanation. I understand now, sorry for the misunderstanding before. My latest PS reflects what you highlighted and follows what was done in L461.","commit_id":"6788e45eb811c438697d2e14f1b5f58088137f20"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"546184a44d65e82795801c9f905066c681b68659","unresolved":false,"context_lines":[{"line_number":876,"context_line":"        # where iframes are not used in deployment. Default setting is True."},{"line_number":877,"context_line":"        # For more information see:"},{"line_number":878,"context_line":"        # http://tinyurl.com/anticlickjack"},{"line_number":879,"context_line":"        DISALLOW_IFRAME_EMBED \u003d \u0027{{ .Values.conf.horizon.local_settings.config.disallow_iframe_embed }}\u0027"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        STATIC_ROOT \u003d \u0027/var/www/html/horizon\u0027"},{"line_number":882,"context_line":"    policy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_e08dd931","line":879,"range":{"start_line":879,"start_character":31,"end_line":879,"end_character":104},"in_reply_to":"9fdfeff1_40c4e592","updated":"2019-02-05 15:09:29.000000000","message":"Well actually, I am not sure. I looked at the local_settings file deployed to a lab and I see what the values properly propagated even when using quotes. Examples:\n\nlocal_settings:    \u0027enable_backup\u0027: True\nlocal_settings:    \u0027enable_router\u0027: True\nlocal_settings:    \u0027enable_lb\u0027: True","commit_id":"6788e45eb811c438697d2e14f1b5f58088137f20"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"40a5847c64c38e86b627910d11e2503f134ee1ca","unresolved":false,"context_lines":[{"line_number":876,"context_line":"        # where iframes are not used in deployment. Default setting is True."},{"line_number":877,"context_line":"        # For more information see:"},{"line_number":878,"context_line":"        # http://tinyurl.com/anticlickjack"},{"line_number":879,"context_line":"        DISALLOW_IFRAME_EMBED \u003d \u0027{{ .Values.conf.horizon.local_settings.config.disallow_iframe_embed }}\u0027"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        STATIC_ROOT \u003d \u0027/var/www/html/horizon\u0027"},{"line_number":882,"context_line":"    policy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_40c4e592","line":879,"range":{"start_line":879,"start_character":31,"end_line":879,"end_character":104},"in_reply_to":"9fdfeff1_4179542d","updated":"2019-02-05 14:59:30.000000000","message":"Hey Tin, thanks for the review. I see what you are saying and yes I agree. I will update the change.","commit_id":"6788e45eb811c438697d2e14f1b5f58088137f20"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"bc2feca71510143005fe44f0660260b40ca54622","unresolved":false,"context_lines":[{"line_number":876,"context_line":"        # where iframes are not used in deployment. Default setting is True."},{"line_number":877,"context_line":"        # For more information see:"},{"line_number":878,"context_line":"        # http://tinyurl.com/anticlickjack"},{"line_number":879,"context_line":"        DISALLOW_IFRAME_EMBED \u003d \u0027{{ .Values.conf.horizon.local_settings.config.disallow_iframe_embed }}\u0027"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        STATIC_ROOT \u003d \u0027/var/www/html/horizon\u0027"},{"line_number":882,"context_line":"    policy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_3c7d2ae7","line":879,"range":{"start_line":879,"start_character":31,"end_line":879,"end_character":104},"in_reply_to":"9fdfeff1_60723c14","updated":"2019-02-06 22:56:35.000000000","message":"I think the point was missed.  It is true when gotpl renders it strips the quotation marks for the value.  However, there is another pair of \u0027\u0027 that is surrounding the {{ .Values... }} so, it will become: DISALLOW_IFRAME_EMBED\u003d\u0027True\u0027 and not DISALLOW_IFRAME_EMBED\u003dTrue.  Since that is a python file, one version of that variable is a string the other is a boolean.  Horizon might handle both - so it may not be an issue, but that variable should technically be a boolean True and not a string \u0027True\u0027.\n\nIf you look at L461 where enable_ipv6 is rendered, there is no \u0027\u0027 around {{}}.","commit_id":"6788e45eb811c438697d2e14f1b5f58088137f20"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1a6de64ad085fe092115afb774fb2ef0f2d8f828","unresolved":false,"context_lines":[{"line_number":876,"context_line":"        # where iframes are not used in deployment. Default setting is True."},{"line_number":877,"context_line":"        # For more information see:"},{"line_number":878,"context_line":"        # http://tinyurl.com/anticlickjack"},{"line_number":879,"context_line":"        DISALLOW_IFRAME_EMBED \u003d \u0027{{ .Values.conf.horizon.local_settings.config.disallow_iframe_embed }}\u0027"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        STATIC_ROOT \u003d \u0027/var/www/html/horizon\u0027"},{"line_number":882,"context_line":"    policy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_00b7b0da","line":879,"range":{"start_line":879,"start_character":31,"end_line":879,"end_character":104},"in_reply_to":"9fdfeff1_e08dd931","updated":"2019-02-06 04:13:52.000000000","message":"It is not the key\u0027s quotes (e.g. \u0027enable_lb\u0027) that I was referencing, it is the quotes around the boolean True. Specifically, does Horizon handle both True and \u0027True\u0027 correctly for these variables? I.e. Do DISALLOW_IFRAME_EMBED \u003d True the same as DISALLOW_IFRAME_EMBED \u003d \u0027True\u0027 in the local_settings.py when everything renders out in the horizon deployment - I\u0027ll need to dig into the horizon code to convert.","commit_id":"6788e45eb811c438697d2e14f1b5f58088137f20"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"5918876ad196489f42e96bb12d2c260db56be8b7","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        session_cookie_httponly: \"False\""},{"line_number":178,"context_line":"        secure_proxy_ssl_header: false"},{"line_number":179,"context_line":"        password_autocomplete: \"off\""},{"line_number":180,"context_line":"        disallow_iframe_embed: \"False\""},{"line_number":181,"context_line":"        openstack_cinder_features:"},{"line_number":182,"context_line":"          enable_backup: \"True\""},{"line_number":183,"context_line":"        openstack_neutron_network:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_a9c47e93","line":180,"range":{"start_line":180,"start_character":32,"end_line":180,"end_character":37},"updated":"2019-02-06 21:58:00.000000000","message":"I am a little confused. Why would we be defaulting this to False?  The Check-Dashboard-03 suggestion is to default this to True for security hardening.\n\nOr are we leaving it to downstream code to do this?","commit_id":"c17502d73d6c6c5bfac5379c9a9f3b94fcb2aa9d"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"938b0c9a5427f5002ef166eef644f20ff32c0bf4","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        session_cookie_httponly: \"False\""},{"line_number":178,"context_line":"        secure_proxy_ssl_header: false"},{"line_number":179,"context_line":"        password_autocomplete: \"off\""},{"line_number":180,"context_line":"        disallow_iframe_embed: \"False\""},{"line_number":181,"context_line":"        openstack_cinder_features:"},{"line_number":182,"context_line":"          enable_backup: \"True\""},{"line_number":183,"context_line":"        openstack_neutron_network:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_e93fe684","line":180,"range":{"start_line":180,"start_character":32,"end_line":180,"end_character":37},"in_reply_to":"9fdfeff1_a9c47e93","updated":"2019-02-06 21:59:02.000000000","message":"We will override this to True in downstream","commit_id":"c17502d73d6c6c5bfac5379c9a9f3b94fcb2aa9d"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"ef7de348c8d67595f0533858e30584b63b4dcdab","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        session_cookie_httponly: \"False\""},{"line_number":178,"context_line":"        secure_proxy_ssl_header: false"},{"line_number":179,"context_line":"        password_autocomplete: \"off\""},{"line_number":180,"context_line":"        disallow_iframe_embed: \"False\""},{"line_number":181,"context_line":"        openstack_cinder_features:"},{"line_number":182,"context_line":"          enable_backup: \"True\""},{"line_number":183,"context_line":"        openstack_neutron_network:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_c96f8290","line":180,"range":{"start_line":180,"start_character":32,"end_line":180,"end_character":37},"in_reply_to":"9fdfeff1_e93fe684","updated":"2019-02-06 22:00:07.000000000","message":"Ok, gotcha. Thanks.","commit_id":"c17502d73d6c6c5bfac5379c9a9f3b94fcb2aa9d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"01258ddd1ffdcf062cca22362faca541c56e1d67","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # Turn off browser autocompletion for forms including the login form and"},{"line_number":314,"context_line":"        # the database creation workflow if so desired."},{"line_number":315,"context_line":"        HORIZON_CONFIG[\"password_autocomplete\"] \u003d {{ .Values.conf.horizon.local_settings.config.password_autocomplete }}"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # Setting this to True will disable the reveal button for password fields,"},{"line_number":318,"context_line":"        # including on the login form."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_7ffe44af","line":315,"range":{"start_line":315,"start_character":49,"end_line":315,"end_character":120},"updated":"2019-02-06 23:26:46.000000000","message":"You probably need quotes around these, else it becomes - \n\n   HORIZON_CONFIG[\"password_autocomplete\"] \u003d off\n\nwhich may bomb on your in python as you don\u0027t have the variable named \"off\".  Hope I didn\u0027t muddle the water too much by picking on the quotation marks.","commit_id":"c17502d73d6c6c5bfac5379c9a9f3b94fcb2aa9d"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"3ce2d8b49b89afb6ed83346d9790646bf274bfd4","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # Turn off browser autocompletion for forms including the login form and"},{"line_number":314,"context_line":"        # the database creation workflow if so desired."},{"line_number":315,"context_line":"        HORIZON_CONFIG[\"password_autocomplete\"] \u003d {{ .Values.conf.horizon.local_settings.config.password_autocomplete }}"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # Setting this to True will disable the reveal button for password fields,"},{"line_number":318,"context_line":"        # including on the login form."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_165fda41","line":315,"range":{"start_line":315,"start_character":49,"end_line":315,"end_character":120},"in_reply_to":"9fdfeff1_7ffe44af","updated":"2019-02-07 14:18:27.000000000","message":"Good catch, updated in next PS","commit_id":"c17502d73d6c6c5bfac5379c9a9f3b94fcb2aa9d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"01258ddd1ffdcf062cca22362faca541c56e1d67","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # Setting this to True will disable the reveal button for password fields,"},{"line_number":318,"context_line":"        # including on the login form."},{"line_number":319,"context_line":"        HORIZON_CONFIG[\"disable_password_reveal\"] \u003d {{ .Values.conf.horizon.local_settings.config.disable_password_reveal }}"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        LOCAL_PATH \u003d \u0027/tmp\u0027"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_3fd75c26","line":319,"range":{"start_line":319,"start_character":52,"end_line":319,"end_character":70},"updated":"2019-02-06 23:26:46.000000000","message":"may want to double check if this is a boolean or a string","commit_id":"c17502d73d6c6c5bfac5379c9a9f3b94fcb2aa9d"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"3ce2d8b49b89afb6ed83346d9790646bf274bfd4","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # Setting this to True will disable the reveal button for password fields,"},{"line_number":318,"context_line":"        # including on the login form."},{"line_number":319,"context_line":"        HORIZON_CONFIG[\"disable_password_reveal\"] \u003d {{ .Values.conf.horizon.local_settings.config.disable_password_reveal }}"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        LOCAL_PATH \u003d \u0027/tmp\u0027"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_3608de2b","line":319,"range":{"start_line":319,"start_character":52,"end_line":319,"end_character":70},"in_reply_to":"9fdfeff1_3fd75c26","updated":"2019-02-07 14:18:27.000000000","message":"it appears to be a boolean:\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L146","commit_id":"c17502d73d6c6c5bfac5379c9a9f3b94fcb2aa9d"}]}
