)]}'
{"tools/deployment/common/wait-for-pods.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"52db31635800e430f772ddb5b7cb9cefb78782e8","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# From Kolla-Kubernetes, orginal authors Kevin Fox \u0026 Serguei Bezverkhi"},{"line_number":19,"context_line":"# Default wait timeout is 900 seconds"},{"line_number":20,"context_line":"end\u003d$(date +%s)"},{"line_number":21,"context_line":"timeout\u003d900"},{"line_number":22,"context_line":"if ! [ -z $2 ]; then"},{"line_number":23,"context_line":" timeout\u003d$2"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":"end\u003d$((end + timeout))"},{"line_number":26,"context_line":"while true; do"},{"line_number":27,"context_line":"    kubectl get pods --namespace\u003d$1 -o json | jq -r \\"},{"line_number":28,"context_line":"        \u0027.items[].status.phase\u0027 | grep Pending \u003e /dev/null \u0026\u0026 \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_6da7790d","line":25,"range":{"start_line":20,"start_character":0,"end_line":25,"end_character":22},"updated":"2019-02-07 10:22:53.000000000","message":"nit: If we are to simplify this we could write:\n\ntimeout\u003d${2:-900}\nend\u003d$(($(date +%s) + $timeout ))","commit_id":"1e9180d2851b63ab972f4d9e4987c21fafbb4fc4"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e93bad3fe1a05845babaafac6d36ae21f75ccccc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027.items[] | .spec.completions \u003d\u003d .status.succeeded\u0027 | \\"},{"line_number":33,"context_line":"        grep false \u003e /dev/null \u0026\u0026 JOBR\u003d\"False\" || JOBR\u003d\"True\""},{"line_number":34,"context_line":"    [ $PENDING \u003d\u003d \"False\" -a $READY \u003d\u003d \"True\" -a $JOBR \u003d\u003d \"True\" ] \u0026\u0026 \\"},{"line_number":35,"context_line":"        break || true"},{"line_number":36,"context_line":"    sleep 5"},{"line_number":37,"context_line":"    now\u003d$(date +%s)"},{"line_number":38,"context_line":"    if [ $now -gt $end ] ; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_6e7bddf3","line":35,"updated":"2019-02-08 10:37:54.000000000","message":"Alternatively, we can show things here, so we see an improvement over the deployment, instead of just having the results. But it will be \"spammy\" :p","commit_id":"ef501a9190fa4ed0603ee2ee3a1e42dc4304ac18"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"6c02b3717048112c6007f2e10f320763b066fb12","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027.items[] | .spec.completions \u003d\u003d .status.succeeded\u0027 | \\"},{"line_number":33,"context_line":"        grep false \u003e /dev/null \u0026\u0026 JOBR\u003d\"False\" || JOBR\u003d\"True\""},{"line_number":34,"context_line":"    [ $PENDING \u003d\u003d \"False\" -a $READY \u003d\u003d \"True\" -a $JOBR \u003d\u003d \"True\" ] \u0026\u0026 \\"},{"line_number":35,"context_line":"        break || true"},{"line_number":36,"context_line":"    sleep 5"},{"line_number":37,"context_line":"    now\u003d$(date +%s)"},{"line_number":38,"context_line":"    if [ $now -gt $end ] ; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_a2a319b1","line":35,"in_reply_to":"9fdfeff1_42a4ad08","updated":"2019-02-08 11:14:09.000000000","message":"Ah, true, I did not realize where does the comment belong.\n\nI\u0027m afraid it would be too much output","commit_id":"ef501a9190fa4ed0603ee2ee3a1e42dc4304ac18"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"3cce2f7e21294dd14bfc6c7c63ee75ba698b2ecc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027.items[] | .spec.completions \u003d\u003d .status.succeeded\u0027 | \\"},{"line_number":33,"context_line":"        grep false \u003e /dev/null \u0026\u0026 JOBR\u003d\"False\" || JOBR\u003d\"True\""},{"line_number":34,"context_line":"    [ $PENDING \u003d\u003d \"False\" -a $READY \u003d\u003d \"True\" -a $JOBR \u003d\u003d \"True\" ] \u0026\u0026 \\"},{"line_number":35,"context_line":"        break || true"},{"line_number":36,"context_line":"    sleep 5"},{"line_number":37,"context_line":"    now\u003d$(date +%s)"},{"line_number":38,"context_line":"    if [ $now -gt $end ] ; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_82fe1503","line":35,"in_reply_to":"9fdfeff1_6e7bddf3","updated":"2019-02-08 10:51:23.000000000","message":"Well, this break means \"All is good\" so I\u0027m not sure what to report","commit_id":"ef501a9190fa4ed0603ee2ee3a1e42dc4304ac18"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3a85739ad79803d6c43fb71a363ae4a4a864e630","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027.items[] | .spec.completions \u003d\u003d .status.succeeded\u0027 | \\"},{"line_number":33,"context_line":"        grep false \u003e /dev/null \u0026\u0026 JOBR\u003d\"False\" || JOBR\u003d\"True\""},{"line_number":34,"context_line":"    [ $PENDING \u003d\u003d \"False\" -a $READY \u003d\u003d \"True\" -a $JOBR \u003d\u003d \"True\" ] \u0026\u0026 \\"},{"line_number":35,"context_line":"        break || true"},{"line_number":36,"context_line":"    sleep 5"},{"line_number":37,"context_line":"    now\u003d$(date +%s)"},{"line_number":38,"context_line":"    if [ $now -gt $end ] ; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_42a4ad08","line":35,"in_reply_to":"9fdfeff1_82fe1503","updated":"2019-02-08 10:58:25.000000000","message":"No I meant just before the sleep... \nIf it\u0027s after the break, it means there is still something not good :)\n\nBut it\u0027s a nit, as you can see. I didn\u0027t change my vote there :)","commit_id":"ef501a9190fa4ed0603ee2ee3a1e42dc4304ac18"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"7881ae64b1a1be70330141584e8748e1c7d6ffc8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027.items[] | .spec.completions \u003d\u003d .status.succeeded\u0027 | \\"},{"line_number":33,"context_line":"        grep false \u003e /dev/null \u0026\u0026 JOBR\u003d\"False\" || JOBR\u003d\"True\""},{"line_number":34,"context_line":"    [ $PENDING \u003d\u003d \"False\" -a $READY \u003d\u003d \"True\" -a $JOBR \u003d\u003d \"True\" ] \u0026\u0026 \\"},{"line_number":35,"context_line":"        break || true"},{"line_number":36,"context_line":"    sleep 5"},{"line_number":37,"context_line":"    now\u003d$(date +%s)"},{"line_number":38,"context_line":"    if [ $now -gt $end ] ; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_b7c21084","line":35,"in_reply_to":"9fdfeff1_a2a319b1","updated":"2019-02-14 10:45:13.000000000","message":"totally agreed :)","commit_id":"ef501a9190fa4ed0603ee2ee3a1e42dc4304ac18"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f38666c79eb2bbce2464b6f1802ba80671a460b4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    now\u003d$(date +%s)"},{"line_number":38,"context_line":"    if [ $now -gt $end ] ; then"},{"line_number":39,"context_line":"        echo \"Containers failed to start after $timeout seconds\""},{"line_number":40,"context_line":"        [ $PENDING \u003d\u003d \"True\" ] \u0026\u0026 echo \"Some pods are in pending state\""},{"line_number":41,"context_line":"        [ $READY \u003d\u003d \"False\" ] \u0026\u0026 echo \"Some pods are not ready\""},{"line_number":42,"context_line":"        [ $JOBR \u003d\u003d \"False\" ] \u0026\u0026 echo \"Some jobs have not succeeded\""},{"line_number":43,"context_line":"        kubectl get pods --namespace $1 -o wide"},{"line_number":44,"context_line":"        exit -1"},{"line_number":45,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_9b2a13e5","line":42,"range":{"start_line":40,"start_character":8,"end_line":42,"end_character":67},"updated":"2019-02-07 13:03:59.000000000","message":"It\u0027s even more readable as last line btw.","commit_id":"ef501a9190fa4ed0603ee2ee3a1e42dc4304ac18"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"746c2eb2348cfe988dd4d795d01f0c972e05b4da","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    now\u003d$(date +%s)"},{"line_number":38,"context_line":"    if [ $now -gt $end ] ; then"},{"line_number":39,"context_line":"        echo \"Containers failed to start after $timeout seconds\""},{"line_number":40,"context_line":"        [ $PENDING \u003d\u003d \"True\" ] \u0026\u0026 echo \"Some pods are in pending state\""},{"line_number":41,"context_line":"        [ $READY \u003d\u003d \"False\" ] \u0026\u0026 echo \"Some pods are not ready\""},{"line_number":42,"context_line":"        [ $JOBR \u003d\u003d \"False\" ] \u0026\u0026 echo \"Some jobs have not succeeded\""},{"line_number":43,"context_line":"        kubectl get pods --namespace $1 -o wide"},{"line_number":44,"context_line":"        exit -1"},{"line_number":45,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_be5fee4b","line":42,"range":{"start_line":40,"start_character":8,"end_line":42,"end_character":67},"in_reply_to":"9fdfeff1_9b2a13e5","updated":"2019-03-04 14:52:31.000000000","message":"Good point, I will move it","commit_id":"ef501a9190fa4ed0603ee2ee3a1e42dc4304ac18"}]}
