)]}'
{"tools/deployment/multinode/080-keystone.sh":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"af13d13c925d1c2ba216b51ae5abd865e141bc69","unresolved":false,"context_lines":[{"line_number":32,"context_line":"sleep 30 #NOTE(portdirect): Wait for ingress controller to update rules and restart Nginx"},{"line_number":33,"context_line":"openstack endpoint list"},{"line_number":34,"context_line":"# Delete the test pod if it still exists"},{"line_number":35,"context_line":"if kubectl get pods -l application\u003dkeystone,component\u003dtest --namespace\u003dopenstack; then"},{"line_number":36,"context_line":"    kubectl delete pods -l application\u003dkeystone,component\u003dtest --namespace\u003dopenstack"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":"helm test keystone --timeout 900"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_be111caf","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":86},"updated":"2019-02-06 14:41:00.000000000","message":"question: is there a reason for doing this check vs. using `--ignore-not-found` switch on `kubectl delete` command?","commit_id":"c0dd2de945fb44055e35c424a1938dcf42fcf8e0"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"a490353b387f351da0c89e591d450de3b6faf37f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"sleep 30 #NOTE(portdirect): Wait for ingress controller to update rules and restart Nginx"},{"line_number":33,"context_line":"openstack endpoint list"},{"line_number":34,"context_line":"# Delete the test pod if it still exists"},{"line_number":35,"context_line":"if kubectl get pods -l application\u003dkeystone,component\u003dtest --namespace\u003dopenstack; then"},{"line_number":36,"context_line":"    kubectl delete pods -l application\u003dkeystone,component\u003dtest --namespace\u003dopenstack"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":"helm test keystone --timeout 900"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_fd07a917","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":86},"in_reply_to":"9fdfeff1_be111caf","updated":"2019-02-06 15:34:44.000000000","message":"Not really, I just thought it\u0027s better to check before deleting.\nIf you think it\u0027s better with --ignore-not-found, I can change it. It will be shorter for sure...","commit_id":"c0dd2de945fb44055e35c424a1938dcf42fcf8e0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"eb2b970ea40a216557e87bb41d6d341a1a1319e2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"sleep 30 #NOTE(portdirect): Wait for ingress controller to update rules and restart Nginx"},{"line_number":33,"context_line":"openstack endpoint list"},{"line_number":34,"context_line":"# Delete the test pod if it still exists"},{"line_number":35,"context_line":"if kubectl get pods -l application\u003dkeystone,component\u003dtest --namespace\u003dopenstack; then"},{"line_number":36,"context_line":"    kubectl delete pods -l application\u003dkeystone,component\u003dtest --namespace\u003dopenstack"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":"helm test keystone --timeout 900"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_e35b8c51","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":86},"in_reply_to":"9fdfeff1_fd07a917","updated":"2019-02-06 17:29:41.000000000","message":"I think using the --ignore-not-found switch might be cleaner. I was going to suggest just doing a check on the exit code for running the command as it is to reduce the verbosity, but the switch makes more sense","commit_id":"c0dd2de945fb44055e35c424a1938dcf42fcf8e0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"50f2b226743b95ceb7dbe03f13a6ac253c69b684","unresolved":false,"context_lines":[{"line_number":32,"context_line":"sleep 30 #NOTE(portdirect): Wait for ingress controller to update rules and restart Nginx"},{"line_number":33,"context_line":"openstack endpoint list"},{"line_number":34,"context_line":"# Delete the test pod if it still exists"},{"line_number":35,"context_line":"kubectl delete pods -l application\u003dkeystone,component\u003dtest --namespace\u003dopenstack --ignore-not-found"},{"line_number":36,"context_line":"helm test keystone --timeout 900"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_d4da2d76","line":35,"range":{"start_line":35,"start_character":23,"end_line":35,"end_character":58},"updated":"2019-03-15 06:07:27.000000000","message":"can we also included the \u0027release_group\u0027 here","commit_id":"30bfff74bf9a68f97b7db11aaf587bbb302abfe5"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"b88589a2db07c780fd431f92fbe3b7679588a6f3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"sleep 30 #NOTE(portdirect): Wait for ingress controller to update rules and restart Nginx"},{"line_number":33,"context_line":"openstack endpoint list"},{"line_number":34,"context_line":"# Delete the test pod if it still exists"},{"line_number":35,"context_line":"kubectl delete pods -l application\u003dkeystone,component\u003dtest --namespace\u003dopenstack --ignore-not-found"},{"line_number":36,"context_line":"helm test keystone --timeout 900"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_cd9a9cb7","line":35,"range":{"start_line":35,"start_character":23,"end_line":35,"end_character":58},"in_reply_to":"5fc1f717_d4da2d76","updated":"2019-03-15 09:33:23.000000000","message":"Will do","commit_id":"30bfff74bf9a68f97b7db11aaf587bbb302abfe5"}]}
