)]}'
{"id":"openstack%2Fopenstack-helm~640915","triplet_id":"openstack%2Fopenstack-helm~master~I31263e9ce06d31773e961ae5d1252e062a38a4e5","project":"openstack/openstack-helm","branch":"master","topic":"cinder_stein_changes","hashtags":[],"change_id":"I31263e9ce06d31773e961ae5d1252e062a38a4e5","subject":"Add resource_filters.json to Cinder\u0027s configmap","status":"MERGED","created":"2019-03-05 01:38:57.000000000","updated":"2019-03-07 04:35:50.000000000","submitted":"2019-03-07 04:35:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"640915-1551933350987-98014b58","meta_rev_id":"800fd8d9a519b7206fee2c394aa8d99e841666e7","_number":640915,"virtual_id_number":640915,"owner":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},{"value":2,"date":"2019-03-07 04:35:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":2,"date":"2019-03-07 03:52:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":2,"date":"2019-03-06 14:33:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":1,"date":"2019-03-07 03:52:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-06 14:33:07.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-03-07 03:52:08.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2019-03-07 04:35:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"457a197f8cd196349bace598d84128d576374ee5","author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"date":"2019-03-05 01:38:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3a0c2e12af1ca802fba5c654319459f54aca8397","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-05 02:21:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/15/640915/1/check/openstack-tox-docs/f297b93/html/ : SUCCESS in 4m 46s\n- openstack-helm-lint http://logs.openstack.org/15/640915/1/check/openstack-helm-lint/69eaede/ : SUCCESS in 1m 39s\n- openstack-helm-bandit http://logs.openstack.org/15/640915/1/check/openstack-helm-bandit/b46e1d3/ : SUCCESS in 14m 13s\n- openstack-helm-keystone http://logs.openstack.org/15/640915/1/check/openstack-helm-keystone/296932d/ : SUCCESS in 21m 25s\n- openstack-helm-keystone-ldap http://logs.openstack.org/15/640915/1/check/openstack-helm-keystone-ldap/f27c716/ : SUCCESS in 20m 47s\n- openstack-helm-glance http://logs.openstack.org/15/640915/1/check/openstack-helm-glance/d816816/ : SUCCESS in 25m 37s\n- openstack-helm-heat http://logs.openstack.org/15/640915/1/check/openstack-helm-heat/c791d1e/ : SUCCESS in 23m 24s\n- openstack-helm-cinder http://logs.openstack.org/15/640915/1/check/openstack-helm-cinder/304c3b4/ : SUCCESS in 37m 02s\n- openstack-helm-compute-kit http://logs.openstack.org/15/640915/1/check/openstack-helm-compute-kit/9c3605e/ : SUCCESS in 31m 42s","accounts_in_message":[],"_revision_number":1},{"id":"cc43ffe2a36575edeb6f513a3d99fe042ebc60c4","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-03-05 03:30:44.000000000","message":"Patch Set 1: Code-Review-1\n\nit would probably be a good idea to explicity set `resource_query_filters_file \u003d /etc/cinder/resource_filters.json` in the primary cinder config - otherwise this lgtm - thanks bob.","accounts_in_message":[],"_revision_number":1},{"id":"197e28b8083b26c68033c2bf8d25d86ad21457ab","author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"date":"2019-03-05 07:42:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"55b86561a8edc4308f602eefeec3d158efdd9b0e","author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"date":"2019-03-05 07:47:12.000000000","message":"Patch Set 2:\n\nPete, thanks for the quick review. I tested patch set 2 by overriding the default location and verifying that the volume list API worked as expected. This was also tested with a cinder image based on master, so the non functioning API is obvious since this file is now required.","accounts_in_message":[],"_revision_number":2},{"id":"3b8faccf3f14e9a1eb02caf2a979e35efd02b2b0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-05 08:22:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/15/640915/2/check/openstack-tox-docs/85a5d85/html/ : SUCCESS in 6m 35s\n- openstack-helm-lint http://logs.openstack.org/15/640915/2/check/openstack-helm-lint/f9e15aa/ : SUCCESS in 1m 30s\n- openstack-helm-bandit http://logs.openstack.org/15/640915/2/check/openstack-helm-bandit/632e02c/ : SUCCESS in 13m 33s\n- openstack-helm-keystone http://logs.openstack.org/15/640915/2/check/openstack-helm-keystone/e2fb656/ : SUCCESS in 23m 10s\n- openstack-helm-keystone-ldap http://logs.openstack.org/15/640915/2/check/openstack-helm-keystone-ldap/ce079c4/ : SUCCESS in 22m 09s\n- openstack-helm-glance http://logs.openstack.org/15/640915/2/check/openstack-helm-glance/3bfa2c1/ : SUCCESS in 27m 56s\n- openstack-helm-heat http://logs.openstack.org/15/640915/2/check/openstack-helm-heat/3c18bba/ : SUCCESS in 24m 21s\n- openstack-helm-cinder http://logs.openstack.org/15/640915/2/check/openstack-helm-cinder/ca5b008/ : SUCCESS in 35m 28s\n- openstack-helm-compute-kit http://logs.openstack.org/15/640915/2/check/openstack-helm-compute-kit/03168fa/ : SUCCESS in 32m 03s","accounts_in_message":[],"_revision_number":2},{"id":"d541782b4f7da92a94a6bc1314c8a9c5ea34f436","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-03-06 04:34:53.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"8dbd9f9f233e7d1f5bacf226e5be63cad356b807","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-03-06 04:34:58.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"1a56d65b9b388c460d64eea5091044858d0b473e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-06 05:41:22.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/15/640915/3/check/openstack-tox-docs/7dd49a2/html/ : SUCCESS in 4m 34s\n- openstack-helm-lint http://logs.openstack.org/15/640915/3/check/openstack-helm-lint/fe13a57/ : SUCCESS in 1m 53s\n- openstack-helm-keystone http://logs.openstack.org/15/640915/3/check/openstack-helm-keystone/7ea22c6/ : SUCCESS in 20m 36s\n- openstack-helm-keystone-ldap http://logs.openstack.org/15/640915/3/check/openstack-helm-keystone-ldap/69fcc3a/ : SUCCESS in 22m 10s\n- openstack-helm-glance http://logs.openstack.org/15/640915/3/check/openstack-helm-glance/28c0f41/ : SUCCESS in 24m 27s\n- openstack-helm-heat http://logs.openstack.org/15/640915/3/check/openstack-helm-heat/aea1e31/ : SUCCESS in 22m 52s\n- openstack-helm-cinder http://logs.openstack.org/15/640915/3/check/openstack-helm-cinder/0aeb861/ : SUCCESS in 56m 41s\n- openstack-helm-compute-kit http://logs.openstack.org/15/640915/3/check/openstack-helm-compute-kit/d0e91af/ : SUCCESS in 31m 53s","accounts_in_message":[],"_revision_number":3},{"id":"36c3ee1f9169fc391d9959edf718788841574066","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-03-06 14:33:07.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c7139012acafcbbe8a66ad3b29a983f1199dc8f6","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-03-07 03:52:08.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"518bac62f0ecf917f2032d236234f89c4c7dcce4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-07 03:52:19.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"fe95c14e9d78aa3dd652723bc2d4c72db673f29e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-07 04:35:50.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/15/640915/3/gate/openstack-tox-docs/4be4222/html/ : SUCCESS in 5m 24s\n- openstack-helm-lint http://logs.openstack.org/15/640915/3/gate/openstack-helm-lint/22a5e4f/ : SUCCESS in 1m 38s\n- openstack-helm-keystone http://logs.openstack.org/15/640915/3/gate/openstack-helm-keystone/41de9f2/ : SUCCESS in 25m 01s\n- openstack-helm-keystone-ldap http://logs.openstack.org/15/640915/3/gate/openstack-helm-keystone-ldap/1889e84/ : SUCCESS in 27m 48s\n- openstack-helm-glance http://logs.openstack.org/15/640915/3/gate/openstack-helm-glance/ae9f6f1/ : SUCCESS in 28m 08s\n- openstack-helm-heat http://logs.openstack.org/15/640915/3/gate/openstack-helm-heat/d151520/ : SUCCESS in 23m 37s\n- openstack-helm-cinder http://logs.openstack.org/15/640915/3/gate/openstack-helm-cinder/4fad9d0/ : SUCCESS in 41m 43s\n- openstack-helm-compute-kit http://logs.openstack.org/15/640915/3/gate/openstack-helm-compute-kit/f124939/ : SUCCESS in 36m 24s","accounts_in_message":[],"_revision_number":3},{"id":"b7c5343fd35c41c272fd9b88e135136a6112264f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-07 04:35:50.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d1fbf4ac145ae6a658123516b9f3ae1be598059e","revisions":{"2864d0e6e46fed8fa825ce1ce090b1c37117eebb":{"kind":"REWORK","_number":1,"created":"2019-03-05 01:38:57.000000000","uploader":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"ref":"refs/changes/15/640915/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/15/640915/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/1"}}},"commit":{"parents":[{"commit":"66ba0be81c66c20b5ffae709358970d5937a0202","subject":"Merge \"Explicitly set datefmt for logging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/66ba0be81c66c20b5ffae709358970d5937a0202"}]}],"author":{"name":"Robert Church","email":"robert.church@windriver.com","date":"2019-03-01 01:04:49.000000000","tz":-300},"committer":{"name":"Robert Church","email":"robert.church@windriver.com","date":"2019-03-01 01:54:29.000000000","tz":-300},"subject":"Add resource_filters.json to Cinder\u0027s configmap","message":"Add resource_filters.json to Cinder\u0027s configmap\n\nDuring the Stein development cycle, Cinder removed the deprecated\nquery_volume_filters configuration option with\nIcd311db7f88c3c274d9a362eb96519e46c7e4d17.\n\nThis chart update will add resource_filters.json to the configmap and\nprovides the default values for the filter keys to enable filtering in\nthe list APIs.\n\nChange-Id: I31263e9ce06d31773e961ae5d1252e062a38a4e5\nSigned-off-by: Robert Church \u003crobert.church@windriver.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/2864d0e6e46fed8fa825ce1ce090b1c37117eebb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/2864d0e6e46fed8fa825ce1ce090b1c37117eebb"}]},"branch":"refs/heads/master"},"511d5f361679a43b69a2d57d4557b4f32f09a1a9":{"kind":"REWORK","_number":2,"created":"2019-03-05 07:42:08.000000000","uploader":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"ref":"refs/changes/15/640915/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/15/640915/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/2"}}},"commit":{"parents":[{"commit":"66ba0be81c66c20b5ffae709358970d5937a0202","subject":"Merge \"Explicitly set datefmt for logging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/66ba0be81c66c20b5ffae709358970d5937a0202"}]}],"author":{"name":"Robert Church","email":"robert.church@windriver.com","date":"2019-03-01 01:04:49.000000000","tz":-300},"committer":{"name":"Robert Church","email":"robert.church@windriver.com","date":"2019-03-05 06:18:48.000000000","tz":-300},"subject":"Add resource_filters.json to Cinder\u0027s configmap","message":"Add resource_filters.json to Cinder\u0027s configmap\n\nDuring the Stein development cycle, Cinder removed the deprecated\nquery_volume_filters configuration option with\nIcd311db7f88c3c274d9a362eb96519e46c7e4d17.\n\nThis chart update will add resource_filters.json to the configmap and\nprovides the default values for the filter keys to enable filtering in\nthe list APIs.\n\nChange-Id: I31263e9ce06d31773e961ae5d1252e062a38a4e5\nSigned-off-by: Robert Church \u003crobert.church@windriver.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/511d5f361679a43b69a2d57d4557b4f32f09a1a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/511d5f361679a43b69a2d57d4557b4f32f09a1a9"}]},"branch":"refs/heads/master"},"d1fbf4ac145ae6a658123516b9f3ae1be598059e":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2019-03-06 04:34:53.000000000","uploader":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"ref":"refs/changes/15/640915/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/15/640915/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/15/640915/3"}}},"commit":{"parents":[{"commit":"89d53f2d78faea71a9a4d034071825e1563863e8","subject":"Merge \"Update irc meeting channel\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/89d53f2d78faea71a9a4d034071825e1563863e8"}]}],"author":{"name":"Robert Church","email":"robert.church@windriver.com","date":"2019-03-01 01:04:49.000000000","tz":-300},"committer":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2019-03-06 04:34:53.000000000","tz":0},"subject":"Add resource_filters.json to Cinder\u0027s configmap","message":"Add resource_filters.json to Cinder\u0027s configmap\n\nDuring the Stein development cycle, Cinder removed the deprecated\nquery_volume_filters configuration option with\nIcd311db7f88c3c274d9a362eb96519e46c7e4d17.\n\nThis chart update will add resource_filters.json to the configmap and\nprovides the default values for the filter keys to enable filtering in\nthe list APIs.\n\nChange-Id: I31263e9ce06d31773e961ae5d1252e062a38a4e5\nSigned-off-by: Robert Church \u003crobert.church@windriver.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d1fbf4ac145ae6a658123516b9f3ae1be598059e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d1fbf4ac145ae6a658123516b9f3ae1be598059e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}