)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"8e0a1dfb8342fc102d62fad2246ae20c259554d1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    conf_dir:"},{"line_number":18,"context_line":"    binary:"},{"line_number":19,"context_line":"    extra_flags:"},{"line_number":20,"context_line":"    a2enmod:"},{"line_number":21,"context_line":"    a2dismod:"},{"line_number":22,"context_line":"  nova_placement_apache_config:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"On which:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_fee5c8dc","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":13},"updated":"2019-03-15 02:50:52.000000000","message":"Rather than specify what to enable and disable, wouldn\u0027t it be better to provide a list of all modules you want enabled and disable anything not listed? That would allow this to be more idempotent and also account for differences in default modules depending on the package/distro etc.","commit_id":"7869b21fe8fb71e6d140e9e1b77ef4be553fc682"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"1d902bf979616b69a5c55e851a51b176b5c77a5a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    conf_dir:"},{"line_number":18,"context_line":"    binary:"},{"line_number":19,"context_line":"    extra_flags:"},{"line_number":20,"context_line":"    a2enmod:"},{"line_number":21,"context_line":"    a2dismod:"},{"line_number":22,"context_line":"  nova_placement_apache_config:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"On which:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_c91d5e74","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":13},"in_reply_to":"5fc1f717_325e2176","updated":"2019-03-20 06:19:19.000000000","message":"Yes, it would require a list. This is likely the tricky part.\n\nHowever, a list of modules would actually be more explicit as it would be stating \"this is exactly what I want\", and the logic would work out what to enable or disable. Each chart would then have to spell out the differences they need. And of course deployers could still override themselves.\n\nBut since this is keeping with what is currently being done, it is likely easier as it won\u0027t require figuring out the exact list or differences between distros.","commit_id":"7869b21fe8fb71e6d140e9e1b77ef4be553fc682"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"5b47a9661ef4c1ee4e82159a21ef565c68c41f89","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    conf_dir:"},{"line_number":18,"context_line":"    binary:"},{"line_number":19,"context_line":"    extra_flags:"},{"line_number":20,"context_line":"    a2enmod:"},{"line_number":21,"context_line":"    a2dismod:"},{"line_number":22,"context_line":"  nova_placement_apache_config:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"On which:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_325e2176","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":13},"in_reply_to":"5fc1f717_fee5c8dc","updated":"2019-03-15 09:14:14.000000000","message":"Mhhh that would require a list of all the modules right?\n\nI did it this way because there is some specific modules that are disabled on some charts so I would rather have those spelled out explicitely. Plus this keeps compatibility with the existing chart as it wont do anything differently that what was done before.\n\nNot only that, but leaving this to the values allows deployers to override this themselves which proves pretty flexible.","commit_id":"7869b21fe8fb71e6d140e9e1b77ef4be553fc682"}],"nova/templates/bin/_nova-placement-api.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"844fb3749dde50d4ee4aa2cc772d106a1aaa1c71","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  a2dismod {{ . }}"},{"line_number":40,"context_line":"    {{- end }}"},{"line_number":41,"context_line":"  {{- end }}"},{"line_number":42,"context_line":"  exec {{ .Values.conf.apache2.binary }} {{ .Values.conf.apache2.extra_flags }}"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"function stop () {"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"5fc1f717_168c19d5","line":42,"range":{"start_line":42,"start_character":65,"end_line":42,"end_character":70},"updated":"2019-03-18 10:55:55.000000000","message":"start_flags or start_parameters ? It seems more explicit than extra_flags, which could be understood as both start and stop arguments.","commit_id":"7869b21fe8fb71e6d140e9e1b77ef4be553fc682"}],"nova/templates/configmap-etc.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e7e8eea33faf7c8ca882c4eb60e365d9b92d35c9","unresolved":false,"context_lines":[{"line_number":232,"context_line":"  logging.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.logging | b64enc }}"},{"line_number":233,"context_line":"  nova-ironic.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.nova_ironic | b64enc }}"},{"line_number":234,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.wsgi_placement \"key\" \"wsgi-nova-placement.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":235,"context_line":"{{- if .Values.conf.nova_placement_apache_config }}{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.nova_placement_apache_config \"key\" \"nova-placement-apache-config.conf\" \"format\" \"Secret\" ) | indent 2 }}{{- end }}"},{"line_number":236,"context_line":"# FIXME(portdirect): why is this file suffixed .sh?"},{"line_number":237,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.ssh \"key\" \"ssh-config.sh\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":238,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_a153a138","line":235,"updated":"2019-03-15 05:43:28.000000000","message":"for readability, could we split this over two lines","commit_id":"7869b21fe8fb71e6d140e9e1b77ef4be553fc682"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"31244d05980db3985ec92900a2c5c70b76d9255b","unresolved":false,"context_lines":[{"line_number":232,"context_line":"  logging.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.logging | b64enc }}"},{"line_number":233,"context_line":"  nova-ironic.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.nova_ironic | b64enc }}"},{"line_number":234,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.wsgi_placement \"key\" \"wsgi-nova-placement.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":235,"context_line":"{{- if .Values.conf.nova_placement_apache_config }}{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.nova_placement_apache_config \"key\" \"nova-placement-apache-config.conf\" \"format\" \"Secret\" ) | indent 2 }}{{- end }}"},{"line_number":236,"context_line":"# FIXME(portdirect): why is this file suffixed .sh?"},{"line_number":237,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.ssh \"key\" \"ssh-config.sh\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":238,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_b270d109","line":235,"in_reply_to":"5fc1f717_a153a138","updated":"2019-03-15 09:11:57.000000000","message":"Please, do!","commit_id":"7869b21fe8fb71e6d140e9e1b77ef4be553fc682"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"5b47a9661ef4c1ee4e82159a21ef565c68c41f89","unresolved":false,"context_lines":[{"line_number":232,"context_line":"  logging.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.logging | b64enc }}"},{"line_number":233,"context_line":"  nova-ironic.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.nova_ironic | b64enc }}"},{"line_number":234,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.wsgi_placement \"key\" \"wsgi-nova-placement.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":235,"context_line":"{{- if .Values.conf.nova_placement_apache_config }}{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.nova_placement_apache_config \"key\" \"nova-placement-apache-config.conf\" \"format\" \"Secret\" ) | indent 2 }}{{- end }}"},{"line_number":236,"context_line":"# FIXME(portdirect): why is this file suffixed .sh?"},{"line_number":237,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.ssh \"key\" \"ssh-config.sh\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":238,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_b21bf1c7","line":235,"in_reply_to":"5fc1f717_a153a138","updated":"2019-03-15 09:14:14.000000000","message":"ok for me, let me resend!","commit_id":"7869b21fe8fb71e6d140e9e1b77ef4be553fc682"}]}