)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"84ed2b7d5c7f57ecb0e88b025b29a7932c6a0313","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix indent filter not properly adding a newline after toYaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we use toYaml + indent to properly indent any volumeMount"},{"line_number":10,"context_line":"in all of our charts. Unfortunately this doesnt work properly as the"},{"line_number":11,"context_line":"indent does not insert a newline so adding any mount results in a wrongly"},{"line_number":12,"context_line":"template, as its rendered inline after the last item"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_cb540356","line":9,"updated":"2019-03-12 19:55:35.000000000","message":"You\u0027re fixing it for \"volumes\" as well, not only \"volumeMount\" values","commit_id":"1f9400581395e26357730fe38c127235f1cb86dc"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"f0ee75fa4dc287f77cecd812bb766130c284e369","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix indent filter not properly adding a newline after toYaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we use toYaml + indent to properly indent any volumeMount"},{"line_number":10,"context_line":"in all of our charts. Unfortunately this doesnt work properly as the"},{"line_number":11,"context_line":"indent does not insert a newline so adding any mount results in a wrongly"},{"line_number":12,"context_line":"template, as its rendered inline after the last item"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_8beefbb1","line":10,"updated":"2019-03-12 19:51:44.000000000","message":"doesn\u0027t","commit_id":"1f9400581395e26357730fe38c127235f1cb86dc"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"f0ee75fa4dc287f77cecd812bb766130c284e369","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we use toYaml + indent to properly indent any volumeMount"},{"line_number":10,"context_line":"in all of our charts. Unfortunately this doesnt work properly as the"},{"line_number":11,"context_line":"indent does not insert a newline so adding any mount results in a wrongly"},{"line_number":12,"context_line":"template, as its rendered inline after the last item"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Probably no one has added any extra mounts by overriding the values.yaml and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_cbf8837c","line":11,"updated":"2019-03-12 19:51:44.000000000","message":"\"wrongly formatted\" or \"a wrong template\" maybe?","commit_id":"1f9400581395e26357730fe38c127235f1cb86dc"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"f0ee75fa4dc287f77cecd812bb766130c284e369","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently we use toYaml + indent to properly indent any volumeMount"},{"line_number":10,"context_line":"in all of our charts. Unfortunately this doesnt work properly as the"},{"line_number":11,"context_line":"indent does not insert a newline so adding any mount results in a wrongly"},{"line_number":12,"context_line":"template, as its rendered inline after the last item"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Probably no one has added any extra mounts by overriding the values.yaml and"},{"line_number":15,"context_line":"we dont use it ourselves on openstack-helm so this feature is totally broken"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_6b462fc3","line":12,"updated":"2019-03-12 19:51:44.000000000","message":"it\u0027s","commit_id":"1f9400581395e26357730fe38c127235f1cb86dc"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"f0ee75fa4dc287f77cecd812bb766130c284e369","unresolved":false,"context_lines":[{"line_number":12,"context_line":"template, as its rendered inline after the last item"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Probably no one has added any extra mounts by overriding the values.yaml and"},{"line_number":15,"context_line":"we dont use it ourselves on openstack-helm so this feature is totally broken"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Instead of using indent, use nindent which creates a newline before indenting"},{"line_number":18,"context_line":"which works perfectly with our current templates"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_8b435baf","line":15,"updated":"2019-03-12 19:51:44.000000000","message":"don\u0027t","commit_id":"1f9400581395e26357730fe38c127235f1cb86dc"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"f0ee75fa4dc287f77cecd812bb766130c284e369","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  volumeMounts:"},{"line_number":50,"context_line":"    - name: test1"},{"line_number":51,"context_line":"      mountPath: test1"},{"line_number":52,"context_line":"    - mountPath: tes"},{"line_number":53,"context_line":"      name: test"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Change-Id: I6d8398b55d81de3aeca8d737e0dbdc98185a688d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_ebfd3f6e","line":52,"updated":"2019-03-12 19:51:44.000000000","message":"test","commit_id":"1f9400581395e26357730fe38c127235f1cb86dc"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"efd91f35991539ed85e2283dc159260b0f6ec52f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  volumeMounts:"},{"line_number":32,"context_line":"    - name: test1"},{"line_number":33,"context_line":"      mountPath: test1"},{"line_number":34,"context_line":"{{- if .Values.volumeMounts }}{{ toYaml .Values.volumeMounts | indent 4  }}{{- end }}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"output of helm template:"},{"line_number":37,"context_line":"---------------------------"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_14119504","line":34,"range":{"start_line":34,"start_character":2,"end_line":34,"end_character":3},"updated":"2019-03-15 06:13:38.000000000","message":"i need to double check, but its this that\u0027s causing the issue in some manifests i believe - once removed the function as is should work correctly.","commit_id":"08317d013f94c3f7e517a7e857844795a14b6fdc"}],"barbican/templates/deployment-api.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"2d425be1104b7ad5b22bfcd1d080b5861d750c17","unresolved":false,"context_lines":[{"line_number":105,"context_line":"              mountPath: /tmp/barbican.sh"},{"line_number":106,"context_line":"              subPath: barbican.sh"},{"line_number":107,"context_line":"              readOnly: true"},{"line_number":108,"context_line":"{{ if $mounts_barbican_api.volumeMounts }}{{ toYaml $mounts_barbican_api.volumeMounts | nindent 12 }}{{ end }}"},{"line_number":109,"context_line":"      volumes:"},{"line_number":110,"context_line":"        - name: etcbarbican"},{"line_number":111,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5fc1f717_afe08498","line":108,"updated":"2019-03-26 09:25:05.000000000","message":"just add a - here.","commit_id":"857a114af28fc33a97aaf778d00b602bab4eabad"}]}