)]}'
{"id":"openstack%2Fopenstack-helm~642844","triplet_id":"openstack%2Fopenstack-helm~master~I6d8398b55d81de3aeca8d737e0dbdc98185a688d","project":"openstack/openstack-helm","branch":"master","topic":"osh_suse_nova","hashtags":[],"change_id":"I6d8398b55d81de3aeca8d737e0dbdc98185a688d","subject":"Fix indent filter not properly adding a newline after toYaml","status":"ABANDONED","created":"2019-03-12 18:09:20.000000000","updated":"2019-04-10 09:58:07.000000000","total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"49a816c205823b2015d335104627d79adbf04774","_number":642844,"virtual_id_number":642844,"owner":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},{"value":1,"date":"2019-04-10 03:26:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":-1,"date":"2019-04-10 08:11:11.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-12 18:10:33.000000000","updated_by":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"reviewer":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"state":"REVIEWER"},{"updated":"2019-03-18 12:00:06.000000000","updated_by":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"reviewer":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"state":"REVIEWER"},{"updated":"2019-03-20 06:25:12.000000000","updated_by":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"reviewer":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"state":"REVIEWER"},{"updated":"2019-03-25 16:20:32.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-03-26 09:25:05.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2019-04-10 03:26:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4bb00cb330410f6f8c14a826ae98198a95f21c84","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-03-12 18:09:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1c30f840c81dda5ecdc445cb02f1e947713e9394","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-03-12 18:12:26.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"d8a9f09ce7ad132e70435f994334b2a0f0632ba6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-12 18:23:01.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/44/642844/2/check/openstack-tox-docs/7b8fa40/html/ : SUCCESS in 5m 48s\n- openstack-helm-lint http://logs.openstack.org/44/642844/2/check/openstack-helm-lint/5459273/ : SUCCESS in 2m 42s\n- openstack-helm-keystone http://logs.openstack.org/44/642844/2/check/openstack-helm-keystone/82eb83f/ : FAILURE in 4m 27s\n- openstack-helm-keystone-ldap http://logs.openstack.org/44/642844/2/check/openstack-helm-keystone-ldap/04f6629/ : FAILURE in 4m 26s\n- openstack-helm-glance http://logs.openstack.org/44/642844/2/check/openstack-helm-glance/0d70c4c/ : FAILURE in 3m 33s\n- openstack-helm-heat http://logs.openstack.org/44/642844/2/check/openstack-helm-heat/c88590b/ : FAILURE in 4m 54s\n- openstack-helm-cinder http://logs.openstack.org/44/642844/2/check/openstack-helm-cinder/05962d7/ : FAILURE in 3m 45s\n- openstack-helm-compute-kit http://logs.openstack.org/44/642844/2/check/openstack-helm-compute-kit/c3a66d5/ : FAILURE in 4m 20s","accounts_in_message":[],"_revision_number":2},{"id":"f0ee75fa4dc287f77cecd812bb766130c284e369","author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"date":"2019-03-12 19:51:44.000000000","message":"Patch Set 2:\n\n(5 comments)\n\nSorry, I know it\u0027s nitpicking...","accounts_in_message":[],"_revision_number":2},{"id":"84ed2b7d5c7f57ecb0e88b025b29a7932c6a0313","author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"date":"2019-03-12 19:55:35.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3f2907515c30a0e5392ef2063a3a1f7ec1189465","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-03-12 20:01:18.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"5912ddd57d4422a7a32025b3ce93f4856c5b7091","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-12 20:12:19.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/44/642844/3/check/openstack-tox-docs/7a71686/html/ : SUCCESS in 5m 34s\n- openstack-helm-lint http://logs.openstack.org/44/642844/3/check/openstack-helm-lint/f4c6fa7/ : SUCCESS in 2m 06s\n- openstack-helm-keystone http://logs.openstack.org/44/642844/3/check/openstack-helm-keystone/102145b/ : FAILURE in 4m 00s\n- openstack-helm-keystone-ldap http://logs.openstack.org/44/642844/3/check/openstack-helm-keystone-ldap/72b7406/ : FAILURE in 3m 47s\n- openstack-helm-glance http://logs.openstack.org/44/642844/3/check/openstack-helm-glance/32d63f2/ : FAILURE in 4m 59s\n- openstack-helm-heat http://logs.openstack.org/44/642844/3/check/openstack-helm-heat/6bc3164/ : FAILURE in 3m 19s\n- openstack-helm-cinder http://logs.openstack.org/44/642844/3/check/openstack-helm-cinder/3e91894/ : FAILURE in 4m 47s\n- openstack-helm-compute-kit http://logs.openstack.org/44/642844/3/check/openstack-helm-compute-kit/2e458f3/ : FAILURE in 3m 39s","accounts_in_message":[],"_revision_number":3},{"id":"e5977fc37fa0e1acf45a4b8a100775fb7d9e31c0","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-03-13 08:33:06.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"d36df803cba464098a3e28530716f2024335f7d7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-13 09:15:33.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/44/642844/3/check/openstack-tox-docs/1daf0ba/html/ : SUCCESS in 6m 40s\n- openstack-helm-lint http://logs.openstack.org/44/642844/3/check/openstack-helm-lint/d39389f/ : SUCCESS in 2m 42s\n- openstack-helm-keystone http://logs.openstack.org/44/642844/3/check/openstack-helm-keystone/09f38c4/ : SUCCESS in 23m 28s\n- openstack-helm-keystone-ldap http://logs.openstack.org/44/642844/3/check/openstack-helm-keystone-ldap/ca9ede7/ : SUCCESS in 23m 50s\n- openstack-helm-glance http://logs.openstack.org/44/642844/3/check/openstack-helm-glance/2009bab/ : SUCCESS in 26m 30s\n- openstack-helm-heat http://logs.openstack.org/44/642844/3/check/openstack-helm-heat/7f063ab/ : SUCCESS in 24m 59s\n- openstack-helm-cinder http://logs.openstack.org/44/642844/3/check/openstack-helm-cinder/1ba3dee/ : SUCCESS in 40m 57s\n- openstack-helm-compute-kit http://logs.openstack.org/44/642844/3/check/openstack-helm-compute-kit/81e4f93/ : FAILURE in 13m 22s","accounts_in_message":[],"_revision_number":3},{"id":"31c886384b194f46c14fc640e28ccf075e99399d","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-03-13 09:18:36.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"ff81ea199feeafbc61ee4c7ee1b0994b9bce585a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-13 10:09:58.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/44/642844/3/check/openstack-tox-docs/b81c2c3/html/ : SUCCESS in 6m 10s\n- openstack-helm-lint http://logs.openstack.org/44/642844/3/check/openstack-helm-lint/008e101/ : SUCCESS in 2m 38s\n- openstack-helm-keystone http://logs.openstack.org/44/642844/3/check/openstack-helm-keystone/d003cdd/ : FAILURE in 24m 34s\n- openstack-helm-keystone-ldap http://logs.openstack.org/44/642844/3/check/openstack-helm-keystone-ldap/4dd862c/ : FAILURE in 23m 39s\n- openstack-helm-glance http://logs.openstack.org/44/642844/3/check/openstack-helm-glance/10c2997/ : SUCCESS in 27m 21s\n- openstack-helm-heat http://logs.openstack.org/44/642844/3/check/openstack-helm-heat/565f9ec/ : SUCCESS in 26m 34s\n- openstack-helm-cinder http://logs.openstack.org/44/642844/3/check/openstack-helm-cinder/3acb230/ : SUCCESS in 39m 37s\n- openstack-helm-compute-kit http://logs.openstack.org/44/642844/3/check/openstack-helm-compute-kit/0b5929d/ : SUCCESS in 36m 10s","accounts_in_message":[],"_revision_number":3},{"id":"377b38cf1aa90ac4bea847af7f37b11f7ec90055","author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"date":"2019-03-13 12:50:06.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"cd53953b12dd9edf1ea2c76b20c61395366c1762","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-13 13:38:46.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/44/642844/3/check/openstack-tox-docs/5ce9257/html/ : SUCCESS in 7m 22s\n- openstack-helm-lint http://logs.openstack.org/44/642844/3/check/openstack-helm-lint/0badd90/ : SUCCESS in 1m 58s\n- openstack-helm-keystone http://logs.openstack.org/44/642844/3/check/openstack-helm-keystone/a8bd01c/ : SUCCESS in 27m 02s\n- openstack-helm-keystone-ldap http://logs.openstack.org/44/642844/3/check/openstack-helm-keystone-ldap/8ef22d3/ : SUCCESS in 24m 00s\n- openstack-helm-glance http://logs.openstack.org/44/642844/3/check/openstack-helm-glance/1011778/ : SUCCESS in 25m 19s\n- openstack-helm-heat http://logs.openstack.org/44/642844/3/check/openstack-helm-heat/f60343e/ : SUCCESS in 26m 53s\n- openstack-helm-cinder http://logs.openstack.org/44/642844/3/check/openstack-helm-cinder/0f579a1/ : SUCCESS in 36m 56s\n- openstack-helm-compute-kit http://logs.openstack.org/44/642844/3/check/openstack-helm-compute-kit/caaf4fa/ : SUCCESS in 34m 23s","accounts_in_message":[],"_revision_number":3},{"id":"e2135c8ea950f765cb24eb701ed95ab49f485d2a","author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"date":"2019-03-13 20:28:02.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"ad8384d06eb8a4db065464e1506656e1d9fa8b29","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-03-13 22:23:17.000000000","message":"Patch Set 3:\n\nI will review this ASAIC.","accounts_in_message":[],"_revision_number":3},{"id":"1ec9771eef205c887582a576bb6ccf5effbe528b","author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"date":"2019-03-15 02:46:10.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"efd91f35991539ed85e2283dc159260b0f6ec52f","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-03-15 06:13:38.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"878c91d9f4b9e617a444e3ecaf74991a7d66af9d","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-03-15 09:17:06.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"56cd6826bea0be919b7bce46b9e70b2718c38e10","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-15 09:26:00.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/44/642844/4/check/openstack-tox-docs/9e6a077/html/ : SUCCESS in 4m 23s\n- openstack-helm-lint http://logs.openstack.org/44/642844/4/check/openstack-helm-lint/08ce5b8/ : SUCCESS in 1m 50s\n- openstack-helm-keystone http://logs.openstack.org/44/642844/4/check/openstack-helm-keystone/da97e4d/ : FAILURE in 2m 38s\n- openstack-helm-keystone-ldap http://logs.openstack.org/44/642844/4/check/openstack-helm-keystone-ldap/ed21762/ : FAILURE in 2m 22s\n- openstack-helm-glance http://logs.openstack.org/44/642844/4/check/openstack-helm-glance/e5668c5/ : FAILURE in 2m 36s\n- openstack-helm-heat http://logs.openstack.org/44/642844/4/check/openstack-helm-heat/3914464/ : FAILURE in 2m 37s\n- openstack-helm-cinder http://logs.openstack.org/44/642844/4/check/openstack-helm-cinder/07e77f0/ : FAILURE in 2m 44s\n- openstack-helm-compute-kit http://logs.openstack.org/44/642844/4/check/openstack-helm-compute-kit/b3da7c7/ : FAILURE in 2m 28s","accounts_in_message":[],"_revision_number":4},{"id":"1f89601c16ef178c0018e6580a05edc75d49b2d2","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-03-18 11:10:11.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"ff5a67e8761e0d069ac38f80dc9717d2732fd616","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-18 11:56:12.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/44/642844/5/check/openstack-tox-docs/577c4da/html/ : SUCCESS in 6m 49s\n- openstack-helm-lint http://logs.openstack.org/44/642844/5/check/openstack-helm-lint/df0abd2/ : SUCCESS in 2m 25s\n- openstack-helm-keystone http://logs.openstack.org/44/642844/5/check/openstack-helm-keystone/18724d9/ : SUCCESS in 23m 00s\n- openstack-helm-keystone-ldap http://logs.openstack.org/44/642844/5/check/openstack-helm-keystone-ldap/3b3809f/ : SUCCESS in 23m 51s\n- openstack-helm-glance http://logs.openstack.org/44/642844/5/check/openstack-helm-glance/80cdefe/ : SUCCESS in 26m 04s\n- openstack-helm-heat http://logs.openstack.org/44/642844/5/check/openstack-helm-heat/c1bcbd4/ : SUCCESS in 30m 45s\n- openstack-helm-cinder http://logs.openstack.org/44/642844/5/check/openstack-helm-cinder/bed65d0/ : SUCCESS in 43m 25s\n- openstack-helm-compute-kit http://logs.openstack.org/44/642844/5/check/openstack-helm-compute-kit/e50cb27/ : SUCCESS in 36m 36s","accounts_in_message":[],"_revision_number":5},{"id":"708af2b7a3a7ed0983dd9976dc75828e4cf8d9f0","author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"date":"2019-03-18 12:00:06.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"12ce765e8ed636b62419d4d455baa6844e00964d","author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"date":"2019-03-20 06:25:12.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"83964d136c340cc5aeaab52ce604f0ac15b63595","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-03-25 12:58:53.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"be840ed2ca9c2ea60ae40d55c0fbc2b6d81a34f7","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-03-25 13:06:03.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"9f3a75f4e50cafbcf28ed75c13dfb0ba19caed03","author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"date":"2019-03-25 13:26:53.000000000","message":"Patch Set 7:\n\nPete, any chance for a new review?","accounts_in_message":[],"_revision_number":7},{"id":"517d109ab360b0ceead754bee2e174f2600346e3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-25 13:58:13.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/44/642844/7/check/openstack-tox-docs/a705cd1/html/ : SUCCESS in 5m 54s\n- openstack-helm-lint http://logs.openstack.org/44/642844/7/check/openstack-helm-lint/d6581a9/ : SUCCESS in 2m 40s\n- openstack-helm-keystone http://logs.openstack.org/44/642844/7/check/openstack-helm-keystone/17dfd1e/ : SUCCESS in 21m 17s\n- openstack-helm-keystone-ldap http://logs.openstack.org/44/642844/7/check/openstack-helm-keystone-ldap/212ccfb/ : SUCCESS in 27m 02s\n- openstack-helm-glance http://logs.openstack.org/44/642844/7/check/openstack-helm-glance/83de4bc/ : SUCCESS in 26m 54s\n- openstack-helm-heat http://logs.openstack.org/44/642844/7/check/openstack-helm-heat/6e52370/ : SUCCESS in 25m 15s\n- openstack-helm-cinder http://logs.openstack.org/44/642844/7/check/openstack-helm-cinder/4ba5c23/ : SUCCESS in 40m 09s\n- openstack-helm-compute-kit http://logs.openstack.org/44/642844/7/check/openstack-helm-compute-kit/021de13/ : SUCCESS in 38m 32s","accounts_in_message":[],"_revision_number":7},{"id":"47901fa8d84b59716cdeda90bee3f6defb7a0a33","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-03-25 16:20:06.000000000","message":"Patch Set 3:\n\n\u003e Pete, any chance for a new review?\n\nplease see my comment in ps3.","accounts_in_message":[],"_revision_number":3},{"id":"1bcdc628e7a1d385fc88b2af4dfe49b2f162fdf6","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-03-25 16:20:32.000000000","message":"Patch Set 7: Code-Review-1\n\nplease can we check the comment in ps3","accounts_in_message":[],"_revision_number":7},{"id":"70bf885e349c6712ad51446c4c7bcb1e4f96df4b","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-03-26 09:22:41.000000000","message":"Patch Set 8: Commit message was updated.","accounts_in_message":[],"_revision_number":8},{"id":"2d425be1104b7ad5b22bfcd1d080b5861d750c17","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-03-26 09:25:05.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"c1e3b7b331befec40891787d4fe8efb4b2fd081c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-26 10:16:52.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/44/642844/8/check/openstack-tox-docs/268c6ff/html/ : SUCCESS in 5m 18s\n- openstack-helm-lint http://logs.openstack.org/44/642844/8/check/openstack-helm-lint/a3c2c60/ : SUCCESS in 1m 46s\n- openstack-helm-keystone http://logs.openstack.org/44/642844/8/check/openstack-helm-keystone/ad4a7f9/ : SUCCESS in 24m 45s\n- openstack-helm-keystone-ldap http://logs.openstack.org/44/642844/8/check/openstack-helm-keystone-ldap/d70bb1b/ : SUCCESS in 21m 18s\n- openstack-helm-glance http://logs.openstack.org/44/642844/8/check/openstack-helm-glance/0cbd425/ : SUCCESS in 23m 55s\n- openstack-helm-heat http://logs.openstack.org/44/642844/8/check/openstack-helm-heat/8447929/ : SUCCESS in 23m 23s\n- openstack-helm-cinder http://logs.openstack.org/44/642844/8/check/openstack-helm-cinder/e6a1184/ : SUCCESS in 48m 14s\n- openstack-helm-compute-kit http://logs.openstack.org/44/642844/8/check/openstack-helm-compute-kit/bfaef44/ : SUCCESS in 34m 22s","accounts_in_message":[],"_revision_number":8},{"id":"0e13ecbe825a64058fb5bfccbc76642db9c26d71","author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"date":"2019-04-10 02:44:02.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"8564db6c9f99bd18ecebe0ac310fef05f7049e7e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-10 03:26:31.000000000","message":"Patch Set 9: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/44/642844/9/check/openstack-tox-docs/a7bdb8f/html/ : SUCCESS in 6m 54s\n- openstack-helm-lint http://logs.openstack.org/44/642844/9/check/openstack-helm-lint/9727f73/ : SUCCESS in 2m 24s\n- openstack-helm-keystone http://logs.openstack.org/44/642844/9/check/openstack-helm-keystone/bb1626e/ : SUCCESS in 23m 40s\n- openstack-helm-keystone-ldap http://logs.openstack.org/44/642844/9/check/openstack-helm-keystone-ldap/1f7eac2/ : SUCCESS in 24m 18s\n- openstack-helm-glance http://logs.openstack.org/44/642844/9/check/openstack-helm-glance/72b7e9f/ : SUCCESS in 25m 42s\n- openstack-helm-heat http://logs.openstack.org/44/642844/9/check/openstack-helm-heat/d4d4bec/ : SUCCESS in 24m 51s\n- openstack-helm-cinder http://logs.openstack.org/44/642844/9/check/openstack-helm-cinder/621a32a/ : SUCCESS in 37m 04s\n- openstack-helm-compute-kit http://logs.openstack.org/44/642844/9/check/openstack-helm-compute-kit/2979ca3/ : SUCCESS in 36m 23s","accounts_in_message":[],"_revision_number":9},{"id":"3d057cf4df1edd5f5d5ec9f72e846ddf3efbbae2","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-04-10 08:11:11.000000000","message":"Patch Set 9: Workflow-1\n\nPete provided an explanation:\n    a few files have lines that start with `{{-` which is the cause of the problem (eg: https://review.openstack.org/#/c/642844/3/ironic/templates/deployment-api.yaml ) if we change that to `{{` then the templates should work without needing to touch every file.","accounts_in_message":[],"_revision_number":9},{"id":"d88386014730b047ae8df9aabaf1178203e2aeeb","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-04-10 09:58:07.000000000","message":"Abandoned\n\nabandon in favour of https://review.openstack.org/#/c/651485/","accounts_in_message":[],"_revision_number":9}],"current_revision_number":9,"current_revision":"285288429c36f4902c73708183a6c06c02884166","revisions":{"dca3e25d5b56e9340fe5ce74a3a35bad18668c5d":{"kind":"REWORK","_number":1,"created":"2019-03-12 18:09:20.000000000","uploader":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"ref":"refs/changes/44/642844/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/44/642844/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/1"}}},"commit":{"parents":[{"commit":"00fff1d274d4aa5ba9bcfae4aca4da65ece1ec4d","subject":"Merge \"Health probe for Nova components\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/00fff1d274d4aa5ba9bcfae4aca4da65ece1ec4d"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 17:56:40.000000000","tz":60},"committer":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 17:56:40.000000000","tz":60},"subject":"Fix indent filter not properly adding a newline after toYaml","message":"Fix indent filter not properly adding a newline after toYaml\n\nCurrently we use toYaml + indent to properly indent any volumeMount\nin all of our charts. Unfortunately this doesnt work properly as the\nindent does not insert a newline so adding any mount results in a wrongly\ntemplate, as its rendered inline after the last item\n\nProbably no one has added any extra mounts by overriding the values.yaml and\nwe dont use it ourselves on openstack-helm so this feature is totally broken\n\nInstead of using indent, use nindent which creates a newline before indenting\nwhich works perfectly with our current templates\n\nExample of indent VS nindent on a example template.\n\nvalues.yaml:\n------------------\nvolumeMounts:\n  - name: test\n    mountPath: test\n\ndeployment.yml:\n---------------------\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n{{- if .Values.volumeMounts }}{{ toYaml .Values.volumeMounts | indent 4  }}{{- end }}\n\noutput of helm template:\n---------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1    - mountPath: test\n      name: test\n\nchanging indent by nindent produces the following correct template:\n------------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n    - mountPath: tes\n      name: test\n\nChange-Id: I6d8398b55d81de3aeca8d737e0dbdc98185a688d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/dca3e25d5b56e9340fe5ce74a3a35bad18668c5d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/dca3e25d5b56e9340fe5ce74a3a35bad18668c5d"}]},"branch":"refs/heads/master"},"1f9400581395e26357730fe38c127235f1cb86dc":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-03-12 18:12:26.000000000","uploader":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"ref":"refs/changes/44/642844/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/44/642844/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/2"}}},"commit":{"parents":[{"commit":"7869b21fe8fb71e6d140e9e1b77ef4be553fc682","subject":"Allow more generic overrides for nova placement-api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7869b21fe8fb71e6d140e9e1b77ef4be553fc682"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 17:56:40.000000000","tz":60},"committer":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 18:11:53.000000000","tz":60},"subject":"Fix indent filter not properly adding a newline after toYaml","message":"Fix indent filter not properly adding a newline after toYaml\n\nCurrently we use toYaml + indent to properly indent any volumeMount\nin all of our charts. Unfortunately this doesnt work properly as the\nindent does not insert a newline so adding any mount results in a wrongly\ntemplate, as its rendered inline after the last item\n\nProbably no one has added any extra mounts by overriding the values.yaml and\nwe dont use it ourselves on openstack-helm so this feature is totally broken\n\nInstead of using indent, use nindent which creates a newline before indenting\nwhich works perfectly with our current templates\n\nExample of indent VS nindent on a example template.\n\nvalues.yaml:\n------------------\nvolumeMounts:\n  - name: test\n    mountPath: test\n\ndeployment.yml:\n---------------------\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n{{- if .Values.volumeMounts }}{{ toYaml .Values.volumeMounts | indent 4  }}{{- end }}\n\noutput of helm template:\n---------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1    - mountPath: test\n      name: test\n\nchanging indent by nindent produces the following correct template:\n------------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n    - mountPath: tes\n      name: test\n\nChange-Id: I6d8398b55d81de3aeca8d737e0dbdc98185a688d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1f9400581395e26357730fe38c127235f1cb86dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1f9400581395e26357730fe38c127235f1cb86dc"}]},"branch":"refs/heads/master"},"08317d013f94c3f7e517a7e857844795a14b6fdc":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2019-03-12 20:01:18.000000000","uploader":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"ref":"refs/changes/44/642844/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/44/642844/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/3"}}},"commit":{"parents":[{"commit":"7869b21fe8fb71e6d140e9e1b77ef4be553fc682","subject":"Allow more generic overrides for nova placement-api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7869b21fe8fb71e6d140e9e1b77ef4be553fc682"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 17:56:40.000000000","tz":60},"committer":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 19:59:15.000000000","tz":60},"subject":"Fix indent filter not properly adding a newline after toYaml","message":"Fix indent filter not properly adding a newline after toYaml\n\nCurrently we use toYaml + indent to properly indent any volumeMount or\nvolumes in all of our charts. Unfortunately this doesn\u0027t work properly as the\nindent does not insert a newline so adding any mount results in a wrong\ntemplate, as it\u0027s rendered inline after the last item\n\nProbably no one has added any extra mounts by overriding the values.yaml and\nwe don\u0027t use it ourselves on openstack-helm so this feature is totally broken\n\nInstead of using indent, use nindent which creates a newline before indenting\nwhich works perfectly with our current templates\n\nExample of indent VS nindent on a example template.\n\nvalues.yaml:\n------------------\nvolumeMounts:\n  - name: test\n    mountPath: test\n\ndeployment.yml:\n---------------------\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n{{- if .Values.volumeMounts }}{{ toYaml .Values.volumeMounts | indent 4  }}{{- end }}\n\noutput of helm template:\n---------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1    - mountPath: test\n      name: test\n\nchanging indent by nindent produces the following correct template:\n------------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n    - mountPath: test\n      name: test\n\nChange-Id: I6d8398b55d81de3aeca8d737e0dbdc98185a688d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/08317d013f94c3f7e517a7e857844795a14b6fdc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/08317d013f94c3f7e517a7e857844795a14b6fdc"}]},"branch":"refs/heads/master"},"094ac7a74f8aab485e4806ed6df41e79947ef4d7":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2019-03-15 09:17:06.000000000","uploader":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"ref":"refs/changes/44/642844/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/44/642844/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/4"}}},"commit":{"parents":[{"commit":"f176b3d73f2f163786aee5e3478c14dea0c6ab7c","subject":"Allow more generic overrides for nova placement-api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f176b3d73f2f163786aee5e3478c14dea0c6ab7c"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 17:56:40.000000000","tz":60},"committer":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-15 09:16:53.000000000","tz":60},"subject":"Fix indent filter not properly adding a newline after toYaml","message":"Fix indent filter not properly adding a newline after toYaml\n\nCurrently we use toYaml + indent to properly indent any volumeMount\nin all of our charts. Unfortunately this doesnt work properly as the\nindent does not insert a newline so adding any mount results in a wrongly\ntemplate, as its rendered inline after the last item\n\nProbably no one has added any extra mounts by overriding the values.yaml and\nwe dont use it ourselves on openstack-helm so this feature is totally broken\n\nInstead of using indent, use nindent which creates a newline before indenting\nwhich works perfectly with our current templates\n\nExample of indent VS nindent on a example template.\n\nvalues.yaml:\n------------------\nvolumeMounts:\n  - name: test\n    mountPath: test\n\ndeployment.yml:\n---------------------\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n{{- if .Values.volumeMounts }}{{ toYaml .Values.volumeMounts | indent 4  }}{{- end }}\n\noutput of helm template:\n---------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1    - mountPath: test\n      name: test\n\nchanging indent by nindent produces the following correct template:\n------------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n    - mountPath: tes\n      name: test\n\nChange-Id: I6d8398b55d81de3aeca8d737e0dbdc98185a688d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/094ac7a74f8aab485e4806ed6df41e79947ef4d7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/094ac7a74f8aab485e4806ed6df41e79947ef4d7"}]},"branch":"refs/heads/master"},"104f3eaaf9faf92f6df57e5ab9665ba4ccdce31a":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2019-03-18 11:10:11.000000000","uploader":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"ref":"refs/changes/44/642844/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/44/642844/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/5"}}},"commit":{"parents":[{"commit":"364e2d82901a098f9d4fef4532ae96b467a22cd5","subject":"Allow more generic overrides for nova placement-api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/364e2d82901a098f9d4fef4532ae96b467a22cd5"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 17:56:40.000000000","tz":60},"committer":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-18 11:07:53.000000000","tz":60},"subject":"Fix indent filter not properly adding a newline after toYaml","message":"Fix indent filter not properly adding a newline after toYaml\n\nCurrently we use toYaml + indent to properly indent any volumeMount\nin all of our charts. Unfortunately this doesnt work properly as the\nindent does not insert a newline so adding any mount results in a wrongly\ntemplate, as its rendered inline after the last item\n\nProbably no one has added any extra mounts by overriding the values.yaml and\nwe dont use it ourselves on openstack-helm so this feature is totally broken\n\nInstead of using indent, use nindent which creates a newline before indenting\nwhich works perfectly with our current templates\n\nExample of indent VS nindent on a example template.\n\nvalues.yaml:\n------------------\nvolumeMounts:\n  - name: test\n    mountPath: test\n\ndeployment.yml:\n---------------------\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n{{- if .Values.volumeMounts }}{{ toYaml .Values.volumeMounts | indent 4  }}{{- end }}\n\noutput of helm template:\n---------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1    - mountPath: test\n      name: test\n\nchanging indent by nindent produces the following correct template:\n------------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n    - mountPath: tes\n      name: test\n\nChange-Id: I6d8398b55d81de3aeca8d737e0dbdc98185a688d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/104f3eaaf9faf92f6df57e5ab9665ba4ccdce31a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/104f3eaaf9faf92f6df57e5ab9665ba4ccdce31a"}]},"branch":"refs/heads/master"},"3bfe5bc8b2e2a04323aaad1e5ec2e7b37a21a4b8":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2019-03-25 12:58:53.000000000","uploader":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"ref":"refs/changes/44/642844/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/44/642844/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/6"}}},"commit":{"parents":[{"commit":"3ff1227cf2b90e5d92f44ef81d2bd4b28dce9d43","subject":"Allow more generic overrides for nova placement-api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3ff1227cf2b90e5d92f44ef81d2bd4b28dce9d43"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 17:56:40.000000000","tz":60},"committer":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-25 12:58:29.000000000","tz":60},"subject":"Fix indent filter not properly adding a newline after toYaml","message":"Fix indent filter not properly adding a newline after toYaml\n\nCurrently we use toYaml + indent to properly indent any volumeMount\nin all of our charts. Unfortunately this doesnt work properly as the\nindent does not insert a newline so adding any mount results in a wrongly\ntemplate, as its rendered inline after the last item\n\nProbably no one has added any extra mounts by overriding the values.yaml and\nwe dont use it ourselves on openstack-helm so this feature is totally broken\n\nInstead of using indent, use nindent which creates a newline before indenting\nwhich works perfectly with our current templates\n\nExample of indent VS nindent on a example template.\n\nvalues.yaml:\n------------------\nvolumeMounts:\n  - name: test\n    mountPath: test\n\ndeployment.yml:\n---------------------\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n{{- if .Values.volumeMounts }}{{ toYaml .Values.volumeMounts | indent 4  }}{{- end }}\n\noutput of helm template:\n---------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1    - mountPath: test\n      name: test\n\nchanging indent by nindent produces the following correct template:\n------------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n    - mountPath: tes\n      name: test\n\nChange-Id: I6d8398b55d81de3aeca8d737e0dbdc98185a688d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3bfe5bc8b2e2a04323aaad1e5ec2e7b37a21a4b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3bfe5bc8b2e2a04323aaad1e5ec2e7b37a21a4b8"}]},"branch":"refs/heads/master"},"b98680640c19ed7077ee04a11a1184cfc7509132":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2019-03-25 13:06:03.000000000","uploader":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"ref":"refs/changes/44/642844/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/44/642844/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/7"}}},"commit":{"parents":[{"commit":"4e7f11f91709199410080cc2d98a5054c0f8371a","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/4e7f11f91709199410080cc2d98a5054c0f8371a"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 17:56:40.000000000","tz":60},"committer":{"name":"Itxaka Serrano Garcia","email":"igarcia@suse.com","date":"2019-03-25 13:06:03.000000000","tz":0},"subject":"Fix indent filter not properly adding a newline after toYaml","message":"Fix indent filter not properly adding a newline after toYaml\n\nCurrently we use toYaml + indent to properly indent any volumeMount\nin all of our charts. Unfortunately this doesnt work properly as the\nindent does not insert a newline so adding any mount results in a wrongly\ntemplate, as its rendered inline after the last item\n\nProbably no one has added any extra mounts by overriding the values.yaml and\nwe dont use it ourselves on openstack-helm so this feature is totally broken\n\nInstead of using indent, use nindent which creates a newline before indenting\nwhich works perfectly with our current templates\n\nExample of indent VS nindent on a example template.\n\nvalues.yaml:\n------------------\nvolumeMounts:\n  - name: test\n    mountPath: test\n\ndeployment.yml:\n---------------------\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n{{- if .Values.volumeMounts }}{{ toYaml .Values.volumeMounts | indent 4  }}{{- end }}\n\noutput of helm template:\n---------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1    - mountPath: test\n      name: test\n\nchanging indent by nindent produces the following correct template:\n------------------------------\n\nspec:\n  volumeMounts:\n    - name: test1\n      mountPath: test1\n    - mountPath: tes\n      name: test\n\nChange-Id: I6d8398b55d81de3aeca8d737e0dbdc98185a688d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b98680640c19ed7077ee04a11a1184cfc7509132"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b98680640c19ed7077ee04a11a1184cfc7509132"}]},"branch":"refs/heads/master"},"857a114af28fc33a97aaf778d00b602bab4eabad":{"kind":"NO_CODE_CHANGE","_number":8,"created":"2019-03-26 09:22:41.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/44/642844/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/44/642844/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/8"}}},"commit":{"parents":[{"commit":"4e7f11f91709199410080cc2d98a5054c0f8371a","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/4e7f11f91709199410080cc2d98a5054c0f8371a"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 17:56:40.000000000","tz":60},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe@evrard.me","date":"2019-03-26 09:22:33.000000000","tz":0},"subject":"Fix indent filter not properly adding a newline after toYaml","message":"Fix indent filter not properly adding a newline after toYaml\n\nCurrently we use toYaml + indent to properly indent any volumeMount\nin all of our charts.\n\nThis is a problem when adding extra mounts by overriding the\n`values.yaml`, as indent does not insert a newline.\nNew mounts results in a wrong template.\n``mountPath: test1    - mountPath: test``\n\nThis fixes it by using nindent when appropriate, creating a newline\nbefore indenting.\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/857a114af28fc33a97aaf778d00b602bab4eabad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/857a114af28fc33a97aaf778d00b602bab4eabad"}]},"branch":"refs/heads/master"},"285288429c36f4902c73708183a6c06c02884166":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":9,"created":"2019-04-10 02:44:02.000000000","uploader":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"ref":"refs/changes/44/642844/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/44/642844/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/44/642844/9"}}},"commit":{"parents":[{"commit":"94ac3569f5bca5509636f9c78f4108589b7dc2e9","subject":"Merge \"Fix ssh config in nova to support cold migrations\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/94ac3569f5bca5509636f9c78f4108589b7dc2e9"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-03-12 17:56:40.000000000","tz":60},"committer":{"name":"Joshua Hesketh","email":"josh@nitrotech.org","date":"2019-04-10 02:43:26.000000000","tz":600},"subject":"Fix indent filter not properly adding a newline after toYaml","message":"Fix indent filter not properly adding a newline after toYaml\n\nCurrently we use toYaml + indent to properly indent any volumeMount\nin all of our charts.\n\nThis is a problem when adding extra mounts by overriding the\n`values.yaml`, as indent does not insert a newline.\nNew mounts results in a wrong template.\n``mountPath: test1    - mountPath: test``\n\nThis fixes it by using nindent when appropriate, creating a newline\nbefore indenting.\n\nChange-Id: I6d8398b55d81de3aeca8d737e0dbdc98185a688d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/285288429c36f4902c73708183a6c06c02884166"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/285288429c36f4902c73708183a6c06c02884166"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}