)]}'
{"id":"openstack%2Fopenstack-helm~643909","triplet_id":"openstack%2Fopenstack-helm~master~I8bffae640dfe0086de0b5274bb8c3cdce9754160","project":"openstack/openstack-helm","branch":"master","hashtags":[],"change_id":"I8bffae640dfe0086de0b5274bb8c3cdce9754160","subject":"change the way to get tunnel device","status":"MERGED","created":"2019-03-18 10:23:52.000000000","updated":"2019-04-08 14:36:13.000000000","submitted":"2019-04-08 14:36:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"643909-1554734173183-8d3b0050","meta_rev_id":"55cfded9510e1f1dd374a3978b744e7cb5cfd7c7","_number":643909,"virtual_id_number":643909,"owner":{"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"},{"value":2,"date":"2019-04-08 14:36:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2019-04-07 19:12:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":1,"date":"2019-04-05 06:48:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":2,"date":"2019-04-08 13:47:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"date":"2019-04-05 02:52:49.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},{"value":0,"date":"2019-04-05 02:53:10.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":1,"date":"2019-04-08 13:47:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},{"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-05 02:52:49.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2019-04-05 02:53:10.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2019-04-05 06:48:18.000000000","updated_by":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"reviewer":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"state":"REVIEWER"},{"updated":"2019-04-07 19:12:15.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2019-04-08 13:47:22.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-04-08 14:36:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d091121f216e3d8a25f5ee2ca88b551ccbf54b99","author":{"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"},"date":"2019-03-18 10:23:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c08efd03354f39178be9334d5300eaa382fcb5d9","author":{"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"},"date":"2019-03-18 10:24:40.000000000","message":"Topic TB_190308_getting_tunel_interface_by_c removed","accounts_in_message":[],"_revision_number":1},{"id":"6317bc79fc8efdec8ca7d0131498238387cb3c36","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-18 11:32:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/09/643909/1/check/openstack-tox-docs/b2c9f3f/html/ : SUCCESS in 5m 44s\n- openstack-helm-lint http://logs.openstack.org/09/643909/1/check/openstack-helm-lint/2dabdd8/ : SUCCESS in 2m 23s\n- openstack-helm-keystone http://logs.openstack.org/09/643909/1/check/openstack-helm-keystone/c5a9006/ : SUCCESS in 24m 51s\n- openstack-helm-keystone-ldap http://logs.openstack.org/09/643909/1/check/openstack-helm-keystone-ldap/158fc10/ : SUCCESS in 22m 34s\n- openstack-helm-glance http://logs.openstack.org/09/643909/1/check/openstack-helm-glance/39a9711/ : SUCCESS in 29m 28s\n- openstack-helm-heat http://logs.openstack.org/09/643909/1/check/openstack-helm-heat/a1a5f19/ : SUCCESS in 24m 28s\n- openstack-helm-cinder http://logs.openstack.org/09/643909/1/check/openstack-helm-cinder/e73bb5d/ : SUCCESS in 43m 21s\n- openstack-helm-compute-kit http://logs.openstack.org/09/643909/1/check/openstack-helm-compute-kit/07474c7/ : SUCCESS in 1h 03m 58s","accounts_in_message":[],"_revision_number":1},{"id":"ef24c4aed590b689af50974266603213de21dfa9","author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"date":"2019-03-31 08:11:38.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI like this idea, it\u0027s awesome.","accounts_in_message":[],"_revision_number":1},{"id":"37152456a6f3da20d0c6f990ac279fea7180973a","author":{"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"},"date":"2019-04-01 08:59:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"eda1ecf16509a3fda53cff30a45617f5099b6abd","author":{"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"},"date":"2019-04-01 09:00:06.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"87397374f7717deee6ad6b4f8e6d2de96d80a7b6","author":{"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"},"date":"2019-04-01 09:01:41.000000000","message":"Topic TB_190308_getting_tunel_interface_by_c removed","accounts_in_message":[],"_revision_number":2},{"id":"b4cee3d84d644906ee808219ed2af428eafc1193","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-01 09:39:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/09/643909/2/check/openstack-tox-docs/2d70553/html/ : SUCCESS in 6m 35s\n- openstack-helm-lint http://logs.openstack.org/09/643909/2/check/openstack-helm-lint/0e3b558/ : SUCCESS in 1m 32s\n- openstack-helm-keystone http://logs.openstack.org/09/643909/2/check/openstack-helm-keystone/ee6b408/ : SUCCESS in 23m 45s\n- openstack-helm-keystone-ldap http://logs.openstack.org/09/643909/2/check/openstack-helm-keystone-ldap/9115af4/ : SUCCESS in 21m 50s\n- openstack-helm-glance http://logs.openstack.org/09/643909/2/check/openstack-helm-glance/b735597/ : SUCCESS in 35m 32s\n- openstack-helm-heat http://logs.openstack.org/09/643909/2/check/openstack-helm-heat/ba4947e/ : SUCCESS in 24m 06s\n- openstack-helm-cinder http://logs.openstack.org/09/643909/2/check/openstack-helm-cinder/268fe35/ : SUCCESS in 35m 15s\n- openstack-helm-compute-kit http://logs.openstack.org/09/643909/2/check/openstack-helm-compute-kit/5751b71/ : SUCCESS in 34m 27s","accounts_in_message":[],"_revision_number":2},{"id":"67aadefae279653649af1fb5ae31920bbd0065c7","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-04-05 05:30:35.000000000","message":"Patch Set 2:\n\n(1 comment)\n\ni take it the goal here is that you know the cidr present on an interface but not the interface name?\n\n\n\nthe logic we have now is already a bit fragile / quirky, in part because of shell scripting\n\ni have to convince myself this doesn\u0027t make that worse\n\nalso, it requires an exact cidr match ... not cidr containing, or something we would get from ip route","accounts_in_message":[],"_revision_number":2},{"id":"4cb255de3a4771f98cbc4edb513c5a08c3e361a8","author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"date":"2019-04-05 06:48:18.000000000","message":"Patch Set 2: Code-Review+1\n\nChris, explicitly specify the interface for vxlan is great. But for multi nodes deployment, if their interfaces are different, this patch would be really useful.\n\nIn fact, I was thinking of implementing per-host overrides of vxlan interface. So that we don\u0027t have to use same interface name for all nodes. But when I saw this patch, I think this is a better solution.\n\nBecause with this patch, I don\u0027t have to collect the node interface information(mainly the node interface map, i.e. {node1: eth0, node2: eth1} ). \nThe only concern I have with this patch is this doesn\u0027t support vxlan cross multi subnets, like below case.\nnode1(192.168.1.0/24) ----router----- node2(192.168.100.0/24)","accounts_in_message":[],"_revision_number":2},{"id":"c01caf9dee9ee5952ed0fdc21d5a2eb941703ef8","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-04-07 19:12:15.000000000","message":"Patch Set 2: Code-Review+2\n\ni\u0027m gonna +2 this because it passes the gates, looks to solve a real problem for you without breaking things\n\nthe caveat is that i really dislike all this code already without adding to it :/","accounts_in_message":[],"_revision_number":2},{"id":"6141de23e68ac67fee3ce4dd79ef745837dc03b4","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-04-08 13:47:22.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nlike chris i have some concerns about how we drive this config atm, though this change does solve a real-world problem and is limited in scope to that, so +2.\n\nI think we should probably move this config to live under `conf` so we can use host/label targeted over-rides to drive agents explicitly, but that\u0027s out of scope here.","accounts_in_message":[],"_revision_number":2},{"id":"f4977ba3c35e7e9214c7a2c65e3dd500e332a5d3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-08 13:47:34.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"8a597bb3e94218305675ab5c4343905b6abb8187","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-08 14:36:12.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/09/643909/2/gate/openstack-tox-docs/f46efeb/html/ : SUCCESS in 5m 28s\n- openstack-helm-lint http://logs.openstack.org/09/643909/2/gate/openstack-helm-lint/5886b57/ : SUCCESS in 2m 34s\n- openstack-helm-keystone http://logs.openstack.org/09/643909/2/gate/openstack-helm-keystone/6411a10/ : SUCCESS in 23m 00s\n- openstack-helm-keystone-ldap http://logs.openstack.org/09/643909/2/gate/openstack-helm-keystone-ldap/0c8da4a/ : SUCCESS in 23m 52s\n- openstack-helm-glance http://logs.openstack.org/09/643909/2/gate/openstack-helm-glance/ff621c7/ : SUCCESS in 26m 35s\n- openstack-helm-heat http://logs.openstack.org/09/643909/2/gate/openstack-helm-heat/f5a10a9/ : SUCCESS in 25m 36s\n- openstack-helm-cinder http://logs.openstack.org/09/643909/2/gate/openstack-helm-cinder/5e975a8/ : SUCCESS in 42m 14s\n- openstack-helm-compute-kit http://logs.openstack.org/09/643909/2/gate/openstack-helm-compute-kit/122be3c/ : SUCCESS in 36m 59s","accounts_in_message":[],"_revision_number":2},{"id":"55cfded9510e1f1dd374a3978b744e7cb5cfd7c7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-08 14:36:13.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3e67ceadb2f756ecb797504500bf03b9fb9cc36d","revisions":{"6baff81b4ba0ef09b91d18fb1b4f992a8d66889a":{"kind":"REWORK","_number":1,"created":"2019-03-18 10:23:52.000000000","uploader":{"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"},"ref":"refs/changes/09/643909/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/09/643909/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/09/643909/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/09/643909/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/09/643909/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/09/643909/1"}}},"commit":{"parents":[{"commit":"b9bc466535913d3885f4dd738ac2809d2f65c4d9","subject":"Merge \"Armada: Fix openstack-helm update password job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b9bc466535913d3885f4dd738ac2809d2f65c4d9"}]}],"author":{"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","date":"2019-03-18 10:14:05.000000000","tz":540},"committer":{"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","date":"2019-03-18 10:14:05.000000000","tz":540},"subject":"change the way to get tunnel device","message":"change the way to get tunnel device\n\nto set local_ip in osh, you have to use nic name.\nbut some devices can have different nic name.\nso I add new option for getting tunnel device by cidr.\n\nAdded value:\nnetwork:\n  interface:\n    tunnel: null\n    tunnel_network_cidr: \"0/0\"\n\nChange-Id: I8bffae640dfe0086de0b5274bb8c3cdce9754160\nSigned-off-by: Hyunkook Cho \u003chk0713.cho@samsung.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/6baff81b4ba0ef09b91d18fb1b4f992a8d66889a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/6baff81b4ba0ef09b91d18fb1b4f992a8d66889a"}]},"branch":"refs/heads/master"},"3e67ceadb2f756ecb797504500bf03b9fb9cc36d":{"kind":"REWORK","_number":2,"created":"2019-04-01 08:59:34.000000000","uploader":{"_account_id":29674,"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","username":"hk0713.cho"},"ref":"refs/changes/09/643909/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/09/643909/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/09/643909/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/09/643909/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/09/643909/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/09/643909/2"}}},"commit":{"parents":[{"commit":"19a9026d67c1489d83c13eb40b04553ddea50e55","subject":"Merge \"Add preliminary support for standalone ironic\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/19a9026d67c1489d83c13eb40b04553ddea50e55"}]}],"author":{"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","date":"2019-03-18 10:14:05.000000000","tz":540},"committer":{"name":"Hyunkook Cho","email":"hk0713.cho@samsung.com","date":"2019-04-01 08:59:33.000000000","tz":540},"subject":"change the way to get tunnel device","message":"change the way to get tunnel device\n\nto set local_ip in osh, you have to use nic name.\nbut some devices can have different nic name.\nso I add new option for getting tunnel device by cidr.\n\nAdded value:\nnetwork:\n  interface:\n    tunnel: null\n    tunnel_network_cidr: \"0/0\"\n\nChange-Id: I8bffae640dfe0086de0b5274bb8c3cdce9754160\nSigned-off-by: Hyunkook Cho \u003chk0713.cho@samsung.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3e67ceadb2f756ecb797504500bf03b9fb9cc36d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3e67ceadb2f756ecb797504500bf03b9fb9cc36d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}