)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"9052f80f311c5aa59f5926571da1538d610a3b11","unresolved":false,"context_lines":[{"line_number":10,"context_line":"rabbitmq and its the children the ones that do instead, for example"},{"line_number":11,"context_line":"in nova-scheduler from rocky version onwards."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The current health check only checks for the main parent pid to see"},{"line_number":14,"context_line":"if it has an active connection to the rabbitmq port."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch adds a flag to allow the health probe to check all processes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_2497c4ee","line":13,"range":{"start_line":13,"start_character":25,"end_line":13,"end_character":60},"updated":"2019-03-27 02:32:07.000000000","message":"I\u0027m confused, and likely not understanding the codebase enough, but isn\u0027t the parent pid the only one that is skipped?\n\n`if p.ppid() \u003d\u003d parentId: continue`\n\nSo this change really checks the parent pid, as well as all the children (which it was already doing).","commit_id":"931e4eba54368c67111bddd878e91e5cd8a6b514"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"28a6a1120f8b23f60f1a8c40f2377a158f4ff840","unresolved":false,"context_lines":[{"line_number":10,"context_line":"rabbitmq and its the children the ones that do instead, for example"},{"line_number":11,"context_line":"in nova-scheduler from rocky version onwards."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The current health check only checks for the main parent pid to see"},{"line_number":14,"context_line":"if it has an active connection to the rabbitmq port."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch adds a flag to allow the health probe to check all processes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_54a63dc3","line":13,"range":{"start_line":13,"start_character":25,"end_line":13,"end_character":60},"in_reply_to":"5fc1f717_2497c4ee","updated":"2019-03-27 08:27:39.000000000","message":"no, not really. `p.ppid()` refers to the process parent id, and it checks to see if it matches the parentID set before, which will be assigned to the first PID found `parentId \u003d p.pid`\n\nAs in rocky there is forking now, all the nova-scheduler process will have the first process ID as their parent.id, so this will match and they will be skipped.\n\nIm not even sure why that check and skip is there in the first place to be honest, all processes that match the process name that we are searching for should be checked, but it might have something to do with the old containers? Not sure but I want to maintain the same behavior.\n\nBTW, this is easy to check by launching the probe manually in even a normal nova install (rocky based!) and seeing how it fails to find any connections to rabbit, or adding logs around to see what pids are checking (I did it myself because I also thought it was checking everything)\n\n\nMaybe I should rewrite it to say \"only checks the first process found\" instead?","commit_id":"931e4eba54368c67111bddd878e91e5cd8a6b514"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"84f85814570696b3e7d3b22232d6f8230a1db908","unresolved":false,"context_lines":[{"line_number":10,"context_line":"rabbitmq and its the children the ones that do instead, for example"},{"line_number":11,"context_line":"in nova-scheduler from rocky version onwards."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The current health check only checks for the main parent pid to see"},{"line_number":14,"context_line":"if it has an active connection to the rabbitmq port."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch adds a flag to allow the health probe to check all processes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_68cd7f5b","line":13,"range":{"start_line":13,"start_character":25,"end_line":13,"end_character":60},"in_reply_to":"5fc1f717_54a63dc3","updated":"2019-03-28 10:31:13.000000000","message":"ah, okay, I see it now. Thanks.","commit_id":"931e4eba54368c67111bddd878e91e5cd8a6b514"}]}