)]}'
{"doc/source/specs/multi-os.rst":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1ac52e42e60af9803bcc047f80ca99f7cac7d8b8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The current helm charts have the opinion to run on ubuntu xenial,"},{"line_number":21,"context_line":"yet our :ref:`images documentation` documentation claims otherwise."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"We need to adapt all the helm charts to be image agnostic,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_c4bccedd","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":64},"updated":"2019-03-26 15:21:53.000000000","message":"I think it\u0027s important to clarify - we have charts for services that don\u0027t use ubuntu xenial as a base for their images.  For example, we have charts that use debian images, alpine images, and even a scratch base or two (if i recall correctly).  Can we update this to target exactly what we see the problem description to be, instead of focusing on one specific area (ie: the openstack images are ubuntu base images at the moment)?","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"4def037ca52140ccf5b2923e93fc929d2becca51","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The current helm charts have the opinion to run on ubuntu xenial,"},{"line_number":21,"context_line":"yet our :ref:`images documentation` documentation claims otherwise."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"We need to adapt all the helm charts to be image agnostic,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_e8283398","line":20,"updated":"2019-03-21 12:53:42.000000000","message":"opinion?","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6df258b71c2cdd22f3f9212cf2047fb21229e344","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The current helm charts have the opinion to run on ubuntu xenial,"},{"line_number":21,"context_line":"yet our :ref:`images documentation` documentation claims otherwise."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"We need to adapt all the helm charts to be image agnostic,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_d6667aef","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":64},"in_reply_to":"5fc1f717_c4bccedd","updated":"2019-03-29 14:19:21.000000000","message":"\u003e I think it\u0027s important to clarify - we have charts for services\n \u003e that don\u0027t use ubuntu xenial as a base for their images.  For\n \u003e example, we have charts that use debian images, alpine images, and\n \u003e even a scratch base or two (if i recall correctly).  Can we update\n \u003e this to target exactly what we see the problem description to be,\n \u003e instead of focusing on one specific area (ie: the openstack images\n \u003e are ubuntu base images at the moment)?","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"246b753487c0d6997d4bb4efc99c45dd0205f2fe","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The current helm charts have the opinion to run on ubuntu xenial,"},{"line_number":21,"context_line":"yet our :ref:`images documentation` documentation claims otherwise."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"We need to adapt all the helm charts to be image agnostic,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_eeb44438","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":64},"in_reply_to":"5fc1f717_c4bccedd","updated":"2019-03-26 16:43:26.000000000","message":"i agree, the wording here should have opinion removed, and reflect the current situation.","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1ac52e42e60af9803bcc047f80ca99f7cac7d8b8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Use cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Allow the usage of openSUSE (or any other) images in OSH."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed Change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_2467d2b9","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":57},"updated":"2019-03-26 15:21:53.000000000","message":"Can we stick to the topic of the spec, which is allowing for multi base image support?  I don\u0027t think we need to call out a specific base here as the main focus of this spec.","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"4def037ca52140ccf5b2923e93fc929d2becca51","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Use cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Allow the usage of openSUSE (or any other) images in OSH."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed Change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_28087b2b","line":29,"updated":"2019-03-21 12:53:42.000000000","message":"I would just say non-ubuntu, instead of specifically pointing out openSUSE","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"246b753487c0d6997d4bb4efc99c45dd0205f2fe","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Use cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Allow the usage of openSUSE (or any other) images in OSH."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed Change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_6e537417","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":57},"in_reply_to":"5fc1f717_2467d2b9","updated":"2019-03-26 16:43:26.000000000","message":"agreed","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1ac52e42e60af9803bcc047f80ca99f7cac7d8b8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"#. Helm charts for which we are building images in osh-images."},{"line_number":43,"context_line":"   (Called further ``Category B`` helm charts)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The ``Category A`` helm charts might have a lower priority in the work items."},{"line_number":46,"context_line":"However all helm charts need to covered for a truly image independent"},{"line_number":47,"context_line":"deployment."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For the ``Category B`` helm charts, an informal testing has been done in the"},{"line_number":50,"context_line":"past to ensure image independence."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_24a6f2ac","line":47,"range":{"start_line":45,"start_character":0,"end_line":47,"end_character":11},"updated":"2019-03-26 15:21:53.000000000","message":"If the goal of the spec is to address the problem description (ie: We need to adapt all the helm charts to be image agnostic, and allow users to bring their own images.), I dont think we should necessarily assign priority to charts in differing categories.  As the proposed solution is leveraging new/updated overrides, this should be applied to every chart equally.","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"2ada8cbc6c8fd35ccc5d75aaf52d776e7da2ca74","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   images:"},{"line_number":73,"context_line":"     tags:"},{"line_number":74,"context_line":"       imagename1: imagelocation:tag"},{"line_number":75,"context_line":"       imagename2: imagelocation:tag"},{"line_number":76,"context_line":"     pull_policy:"},{"line_number":77,"context_line":"     local_registry:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_852dda47","line":74,"range":{"start_line":74,"start_character":33,"end_line":74,"end_character":36},"updated":"2019-03-21 11:43:29.000000000","message":"should I clarify here that tag was already decided before this spec, in the form, \u003cversion\u003e-\u003cdistro\u003e ?","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"4def037ca52140ccf5b2923e93fc929d2becca51","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   images:"},{"line_number":73,"context_line":"     tags:"},{"line_number":74,"context_line":"       imagename1: imagelocation:tag"},{"line_number":75,"context_line":"       imagename2: imagelocation:tag"},{"line_number":76,"context_line":"     pull_policy:"},{"line_number":77,"context_line":"     local_registry:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_4b21419f","line":74,"range":{"start_line":74,"start_character":33,"end_line":74,"end_character":36},"in_reply_to":"5fc1f717_852dda47","updated":"2019-03-21 12:53:42.000000000","message":"I think it would be helpful","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"50d3144fff9e380a16a0223786a1fdc356c16731","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"For this spec, we assume ``imagename1`` and ``imagename2`` are similarly built."},{"line_number":80,"context_line":"This means we do not require any override per image. Instead we require a"},{"line_number":81,"context_line":"generic kind of override, per application, usable in all images."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"I propose to extend the existing schema with generic software information:"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_88788ff8","line":81,"range":{"start_line":81,"start_character":57,"end_line":81,"end_character":63},"updated":"2019-03-21 12:35:00.000000000","message":"should I add \"in a single chart\"?","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b6f37d5a6fabf9ad06df6a92243e0e261b41c11f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"       imagename2: imagelocation:tag"},{"line_number":91,"context_line":"     pull_policy:"},{"line_number":92,"context_line":"     local_registry:"},{"line_number":93,"context_line":"     software:"},{"line_number":94,"context_line":"       apache2:"},{"line_number":95,"context_line":"         #the apache2 binary location"},{"line_number":96,"context_line":"         binary: apache2"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_8504fac7","line":93,"range":{"start_line":93,"start_character":5,"end_line":93,"end_character":13},"updated":"2019-03-21 11:42:31.000000000","message":"This key can be moved to a different level, be renamed, go to conf, or anything. I am very open. I just think we should be flexible, and not bikeshed. Let\u0027s just make this happen :)","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"246b753487c0d6997d4bb4efc99c45dd0205f2fe","unresolved":false,"context_lines":[{"line_number":90,"context_line":"       imagename2: imagelocation:tag"},{"line_number":91,"context_line":"     pull_policy:"},{"line_number":92,"context_line":"     local_registry:"},{"line_number":93,"context_line":"     software:"},{"line_number":94,"context_line":"       apache2:"},{"line_number":95,"context_line":"         #the apache2 binary location"},{"line_number":96,"context_line":"         binary: apache2"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_2e3c8cc6","line":93,"range":{"start_line":93,"start_character":5,"end_line":93,"end_character":13},"in_reply_to":"5fc1f717_8504fac7","updated":"2019-03-26 16:43:26.000000000","message":"i think housing this under `conf:` would be appropriate","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"741522a7905acb574e35fd7e1e143571f93efaf0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"         #the apache2 start arguments"},{"line_number":98,"context_line":"         start_args: -DFOREGROUND"},{"line_number":99,"context_line":"         #the apache2 stop arguments"},{"line_number":100,"context_line":"         stop_args: apachectl -k graceful-stop"},{"line_number":101,"context_line":"         #directory where to drop the config files for apache vhosts"},{"line_number":102,"context_line":"         base_conf_dir: /etc/apache2/conf-enabled"},{"line_number":103,"context_line":"         #Extra details can be added here"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_aeeb1310","line":100,"range":{"start_line":100,"start_character":20,"end_line":100,"end_character":29},"updated":"2019-03-21 13:42:02.000000000","message":"nit: only the args shoul be here","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"741522a7905acb574e35fd7e1e143571f93efaf0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"         #the apache2 stop arguments"},{"line_number":100,"context_line":"         stop_args: apachectl -k graceful-stop"},{"line_number":101,"context_line":"         #directory where to drop the config files for apache vhosts"},{"line_number":102,"context_line":"         base_conf_dir: /etc/apache2/conf-enabled"},{"line_number":103,"context_line":"         #Extra details can be added here"},{"line_number":104,"context_line":"         #like extra configuration."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_eee03b29","line":102,"updated":"2019-03-21 13:42:02.000000000","message":"suggestion: as an example you could add also the sites_dir as that is something that may be different across distros (sites-enabled, vhosts.d, etc...)","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1ac52e42e60af9803bcc047f80ca99f7cac7d8b8","unresolved":false,"context_lines":[{"line_number":90,"context_line":"       imagename2: imagelocation:tag"},{"line_number":91,"context_line":"     pull_policy:"},{"line_number":92,"context_line":"     local_registry:"},{"line_number":93,"context_line":"     software:"},{"line_number":94,"context_line":"       apache2:"},{"line_number":95,"context_line":"         #the apache2 binary location"},{"line_number":96,"context_line":"         binary: apache2"},{"line_number":97,"context_line":"         #the apache2 start arguments"},{"line_number":98,"context_line":"         start_args: -DFOREGROUND"},{"line_number":99,"context_line":"         #the apache2 stop arguments"},{"line_number":100,"context_line":"         stop_args: apachectl -k graceful-stop"},{"line_number":101,"context_line":"         #directory where to drop the config files for apache vhosts"},{"line_number":102,"context_line":"         base_conf_dir: /etc/apache2/conf-enabled"},{"line_number":103,"context_line":"         #Extra details can be added here"},{"line_number":104,"context_line":"         #like extra configuration."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"When possible, ``values_overrides/`` will refer to existing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_a4366250","line":104,"range":{"start_line":93,"start_character":0,"end_line":104,"end_character":35},"updated":"2019-03-26 15:21:53.000000000","message":"I don\u0027t think the key used here (whether software or something else) should live under the images: key. It seems a bit strange to me.  Currently, we have charts that contain apache configs under the conf: key in the charts. Can we not leverage that existing key in some manner for these types of configuration values?","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"246b753487c0d6997d4bb4efc99c45dd0205f2fe","unresolved":false,"context_lines":[{"line_number":90,"context_line":"       imagename2: imagelocation:tag"},{"line_number":91,"context_line":"     pull_policy:"},{"line_number":92,"context_line":"     local_registry:"},{"line_number":93,"context_line":"     software:"},{"line_number":94,"context_line":"       apache2:"},{"line_number":95,"context_line":"         #the apache2 binary location"},{"line_number":96,"context_line":"         binary: apache2"},{"line_number":97,"context_line":"         #the apache2 start arguments"},{"line_number":98,"context_line":"         start_args: -DFOREGROUND"},{"line_number":99,"context_line":"         #the apache2 stop arguments"},{"line_number":100,"context_line":"         stop_args: apachectl -k graceful-stop"},{"line_number":101,"context_line":"         #directory where to drop the config files for apache vhosts"},{"line_number":102,"context_line":"         base_conf_dir: /etc/apache2/conf-enabled"},{"line_number":103,"context_line":"         #Extra details can be added here"},{"line_number":104,"context_line":"         #like extra configuration."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"When possible, ``values_overrides/`` will refer to existing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_ee31a4ee","line":104,"range":{"start_line":93,"start_character":0,"end_line":104,"end_character":35},"in_reply_to":"5fc1f717_a4366250","updated":"2019-03-26 16:43:26.000000000","message":"agreed","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"741522a7905acb574e35fd7e1e143571f93efaf0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"* Keeps the usual expectations for images, and is backwards compatible."},{"line_number":113,"context_line":"* Allow a single use of \"apache\" like configuration for different purposes."},{"line_number":114,"context_line":"* Allow different profiles of apache, should some charts require different"},{"line_number":115,"context_line":"  args for examplei for the same kind of images, by using yaml dict merges"},{"line_number":116,"context_line":"  features."},{"line_number":117,"context_line":"* Will apply differently per helm chart. In the future, we can learn from"},{"line_number":118,"context_line":"  this approach, propose new initiatives to simplify the approach"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_4ecb8fa4","line":115,"range":{"start_line":115,"start_character":11,"end_line":115,"end_character":19},"updated":"2019-03-21 13:42:02.000000000","message":"typo: examplei/example","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1ac52e42e60af9803bcc047f80ca99f7cac7d8b8","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* Allow different profiles of apache, should some charts require different"},{"line_number":115,"context_line":"  args for examplei for the same kind of images, by using yaml dict merges"},{"line_number":116,"context_line":"  features."},{"line_number":117,"context_line":"* Will apply differently per helm chart. In the future, we can learn from"},{"line_number":118,"context_line":"  this approach, propose new initiatives to simplify the approach"},{"line_number":119,"context_line":"  (for example, exposing more features in the ``helm-toolkit``),"},{"line_number":120,"context_line":"  and adapt this spec."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Security Impact"},{"line_number":123,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_c414cea2","line":120,"range":{"start_line":117,"start_character":2,"end_line":120,"end_character":22},"updated":"2019-03-26 15:21:53.000000000","message":"Why?  I think the key to this being successful is using a common approach for solving this problem, as this has been the preferred criteria for solving common problems in osh previously","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"4def037ca52140ccf5b2923e93fc929d2becca51","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"* Not providing a support of multiple images. This leads to ease of"},{"line_number":148,"context_line":"  maintainance and reduced gate impact, with the risk of having"},{"line_number":149,"context_line":"  less contributors."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* Create conditionals in the helm charts. This is problematic, as the amount"},{"line_number":152,"context_line":"  of conditionals will increase and will be harder to maintain."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_4b6f01c5","line":149,"updated":"2019-03-21 12:53:42.000000000","message":"It also means users would have to provide (much) more overrides themselves, while with this proposal distro specific overrides would be visible to everyone","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"741522a7905acb574e35fd7e1e143571f93efaf0","unresolved":false,"context_lines":[{"line_number":194,"context_line":"#.  Alter webserver configuration per distro. Different distros have different"},{"line_number":195,"context_line":"    expectations in terms of path (including a different series of files"},{"line_number":196,"context_line":"    required), and it would make the operators\u0027 life easier by using their"},{"line_number":197,"context_line":"    expected distro paths."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Testing"},{"line_number":200,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_2e6e4396","line":197,"updated":"2019-03-21 13:42:02.000000000","message":"Addendum: I would add that security overrides for things like apache are really useful to be provided in here as that allows not only deployers but developers to play with those settings easily to test more tighten security and safely update it upstream.\n\nPlus allowing fine grained extra config for services allows deployers to restrict things a lot.","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fef4b5a3edba632585c34f2912aaa5b1ae91f231","unresolved":false,"context_lines":[{"line_number":199,"context_line":"Testing"},{"line_number":200,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"No change in testing required."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"However, additional OS/image vendors can leverage the new ``values.yaml``"},{"line_number":205,"context_line":"and propose new overrides files to be consumed for CI."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Documentation Impact"},{"line_number":208,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_7cb37c4e","line":205,"range":{"start_line":202,"start_character":0,"end_line":205,"end_character":54},"updated":"2019-03-23 03:10:23.000000000","message":"are we adding gate jobs to ensure these images work?","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cbab556870ddca17d5b7e6e8053c17d94e762fae","unresolved":false,"context_lines":[{"line_number":199,"context_line":"Testing"},{"line_number":200,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"No change in testing required."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"However, additional OS/image vendors can leverage the new ``values.yaml``"},{"line_number":205,"context_line":"and propose new overrides files to be consumed for CI."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Documentation Impact"},{"line_number":208,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_6abe20b5","line":205,"range":{"start_line":202,"start_character":0,"end_line":205,"end_character":54},"in_reply_to":"5fc1f717_7cb37c4e","updated":"2019-03-25 14:43:50.000000000","message":"There is no functional testing of the ubuntu images right now, so I think adding it for any extra OS is outside the scope. We can work this out outside the spec.\n\nOf course, I would prefer exercising the images built in CI with a job.","commit_id":"bcec0db97010e76202a22852a7a0220de50e7470"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"4e5e5328bcfd85c7ead01b6eb9d6b2518f4bd063","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The current helm charts run on ubuntu xenial,"},{"line_number":21,"context_line":"yet our :ref:`images documentation` documentation claims to be independent"},{"line_number":22,"context_line":"of the image."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_974107a9","line":20,"updated":"2019-03-27 09:35:12.000000000","message":"Maybe word it like \"most of the images run on ubuntu xenial\" ?","commit_id":"72147bf70154088f35c2b2578e3f422a6d4b511b"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"4e5e5328bcfd85c7ead01b6eb9d6b2518f4bd063","unresolved":false,"context_lines":[{"line_number":168,"context_line":"A few areas have been identified on changes required."},{"line_number":169,"context_line":"Each of them will be a work item."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"#. Make webserver binary path/arguments templated using ``values.yaml``."},{"line_number":172,"context_line":"   As expressed above, this allows us to provide different overrides per"},{"line_number":173,"context_line":"   image/distribution to automatically wire things."},{"line_number":174,"context_line":"#.  Dynamically alter webserver environment conditionally in the helm chart."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_b729a3e6","line":171,"updated":"2019-03-27 09:35:12.000000000","message":"wrong indent here?","commit_id":"72147bf70154088f35c2b2578e3f422a6d4b511b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6df258b71c2cdd22f3f9212cf2047fb21229e344","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The current helm charts run on ubuntu xenial,"},{"line_number":21,"context_line":"yet our :ref:`images documentation` documentation claims to be independent"},{"line_number":22,"context_line":"of the image."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_f359485b","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":45},"updated":"2019-03-29 14:19:21.000000000","message":"from steve:\n\u003e I think it\u0027s important to clarify - we have charts for services\n \u003e that don\u0027t use ubuntu xenial as a base for their images.  For\n \u003e example, we have charts that use debian images, alpine images, and\n \u003e even a scratch base or two (if i recall correctly).  Can we update\n \u003e this to target exactly what we see the problem description to be,\n \u003e instead of focusing on one specific area (ie: the openstack images\n \u003e are ubuntu base images at the moment)?\n\nWe also use bionic for those charts that do use ubunut base images where appropriate - eg neutron sriov agent, and nova compute.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0f22085154ee9f9ec48b57a5404991e57d7f3f3b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The current helm charts run on ubuntu xenial,"},{"line_number":21,"context_line":"yet our :ref:`images documentation` documentation claims to be independent"},{"line_number":22,"context_line":"of the image."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_3b06ba1e","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":45},"in_reply_to":"5fc1f717_f359485b","updated":"2019-03-30 10:14:28.000000000","message":"got it.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6df258b71c2cdd22f3f9212cf2047fb21229e344","unresolved":false,"context_lines":[{"line_number":52,"context_line":"(in other words, overrides), to test different image providers use cases in CI."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The ``profiles`` yaml files (for example ``centos_7``, ``opensuse_15``)"},{"line_number":55,"context_line":"will be provided in each chart\u0027s ``values_overrides/`` directory."},{"line_number":56,"context_line":"This folder will be masked to helm through a helmignore file."},{"line_number":57,"context_line":"Its content is only for user consumption, not for inclusion in helm charts"},{"line_number":58,"context_line":"through the File directive."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_133894ec","line":55,"range":{"start_line":55,"start_character":35,"end_line":55,"end_character":41},"updated":"2019-03-29 14:19:21.000000000","message":"i think \u0027example\u0027 makes more sense here","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0f22085154ee9f9ec48b57a5404991e57d7f3f3b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"(in other words, overrides), to test different image providers use cases in CI."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The ``profiles`` yaml files (for example ``centos_7``, ``opensuse_15``)"},{"line_number":55,"context_line":"will be provided in each chart\u0027s ``values_overrides/`` directory."},{"line_number":56,"context_line":"This folder will be masked to helm through a helmignore file."},{"line_number":57,"context_line":"Its content is only for user consumption, not for inclusion in helm charts"},{"line_number":58,"context_line":"through the File directive."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_fb0fd22c","line":55,"range":{"start_line":55,"start_character":35,"end_line":55,"end_character":41},"in_reply_to":"5fc1f717_133894ec","updated":"2019-03-30 10:14:28.000000000","message":"I would like to keep \"values\" somewhere, because it then makes sense it\u0027s overrides for the \"values.yaml\". \n\nWould `example_values` be okay?","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b1b70700993a6a3d2073e04dbf256a898631acf3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"(in other words, overrides), to test different image providers use cases in CI."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The ``profiles`` yaml files (for example ``centos_7``, ``opensuse_15``)"},{"line_number":55,"context_line":"will be provided in each chart\u0027s ``values_overrides/`` directory."},{"line_number":56,"context_line":"This folder will be masked to helm through a helmignore file."},{"line_number":57,"context_line":"Its content is only for user consumption, not for inclusion in helm charts"},{"line_number":58,"context_line":"through the File directive."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_7bb522d0","line":55,"range":{"start_line":55,"start_character":35,"end_line":55,"end_character":41},"in_reply_to":"5fc1f717_fb0fd22c","updated":"2019-03-30 14:07:01.000000000","message":"`example_values` would be great.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6df258b71c2cdd22f3f9212cf2047fb21229e344","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"   images:"},{"line_number":70,"context_line":"     tags:"},{"line_number":71,"context_line":"       imagename1: imagelocation:version-os"},{"line_number":72,"context_line":"       imagename2: imagelocation:version-os"},{"line_number":73,"context_line":"     pull_policy:"},{"line_number":74,"context_line":"     local_registry:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_932b2494","line":71,"range":{"start_line":71,"start_character":33,"end_line":71,"end_character":43},"updated":"2019-03-29 14:19:21.000000000","message":"version-distro","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0f22085154ee9f9ec48b57a5404991e57d7f3f3b","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"   images:"},{"line_number":70,"context_line":"     tags:"},{"line_number":71,"context_line":"       imagename1: imagelocation:version-os"},{"line_number":72,"context_line":"       imagename2: imagelocation:version-os"},{"line_number":73,"context_line":"     pull_policy:"},{"line_number":74,"context_line":"     local_registry:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_1b0dfe34","line":71,"range":{"start_line":71,"start_character":33,"end_line":71,"end_character":43},"in_reply_to":"5fc1f717_932b2494","updated":"2019-03-30 10:14:28.000000000","message":"got it.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6df258b71c2cdd22f3f9212cf2047fb21229e344","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"For this spec, we assume ``imagename1`` and ``imagename2`` are similarly built."},{"line_number":77,"context_line":"This means we do not require any override per image. Instead we require a"},{"line_number":78,"context_line":"generic kind of override, per application, usable in all images."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"I propose to extend the conf schema with generic software information."},{"line_number":81,"context_line":"For example, for apache2:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_3316f057","line":78,"range":{"start_line":78,"start_character":50,"end_line":78,"end_character":63},"updated":"2019-03-29 14:19:21.000000000","message":"by all charts","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0f22085154ee9f9ec48b57a5404991e57d7f3f3b","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"For this spec, we assume ``imagename1`` and ``imagename2`` are similarly built."},{"line_number":77,"context_line":"This means we do not require any override per image. Instead we require a"},{"line_number":78,"context_line":"generic kind of override, per application, usable in all images."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"I propose to extend the conf schema with generic software information."},{"line_number":81,"context_line":"For example, for apache2:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_bb194a7b","line":78,"range":{"start_line":78,"start_character":50,"end_line":78,"end_character":63},"in_reply_to":"5fc1f717_3316f057","updated":"2019-03-30 10:14:28.000000000","message":"ok.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6df258b71c2cdd22f3f9212cf2047fb21229e344","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":".. code-block:: yaml"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"     conf:"},{"line_number":86,"context_line":"       apache2:"},{"line_number":87,"context_line":"         #the apache2 binary location"},{"line_number":88,"context_line":"         binary: apache2"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_9619d27b","line":85,"range":{"start_line":85,"start_character":5,"end_line":85,"end_character":10},"updated":"2019-03-29 14:19:21.000000000","message":"if we want this to be truly generic and applicable over-all charts, the following will probably scale better:\n```\nconf:\n   software:\n```","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"1ad9849f0c18e51f2f161ea6630d682d346b2e78","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":".. code-block:: yaml"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"     conf:"},{"line_number":86,"context_line":"       apache2:"},{"line_number":87,"context_line":"         #the apache2 binary location"},{"line_number":88,"context_line":"         binary: apache2"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_702a182d","line":85,"range":{"start_line":85,"start_character":5,"end_line":85,"end_character":10},"in_reply_to":"5fc1f717_3be47ae0","updated":"2019-04-01 08:56:01.000000000","message":"would that mean moving *everything* under the software part? I mean, keystone config should be moved into the conf -\u003e software key? In that case, I dont think we gain a lot by moving it just one extra key deep tbh, if we move everything in there.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e5dfe10c68c2f6ccc1390ebcc06ba343f8c43327","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":".. code-block:: yaml"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"     conf:"},{"line_number":86,"context_line":"       apache2:"},{"line_number":87,"context_line":"         #the apache2 binary location"},{"line_number":88,"context_line":"         binary: apache2"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_dd81924f","line":85,"range":{"start_line":85,"start_character":5,"end_line":85,"end_character":10},"in_reply_to":"5fc1f717_702a182d","updated":"2019-04-02 01:07:09.000000000","message":"i just mean the config that we need to add to support the spec here, not the existing configuration we have for the applications that we run under them.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b1b70700993a6a3d2073e04dbf256a898631acf3","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":".. code-block:: yaml"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"     conf:"},{"line_number":86,"context_line":"       apache2:"},{"line_number":87,"context_line":"         #the apache2 binary location"},{"line_number":88,"context_line":"         binary: apache2"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_3be47ae0","line":85,"range":{"start_line":85,"start_character":5,"end_line":85,"end_character":10},"in_reply_to":"5fc1f717_7bfc420c","updated":"2019-03-30 14:07:01.000000000","message":"the former, so the path is conf.software.\u003capplication\u003e, which allows us to compartmentalize this neatly into a hopefully generic solution.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0f22085154ee9f9ec48b57a5404991e57d7f3f3b","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":".. code-block:: yaml"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"     conf:"},{"line_number":86,"context_line":"       apache2:"},{"line_number":87,"context_line":"         #the apache2 binary location"},{"line_number":88,"context_line":"         binary: apache2"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_7bfc420c","line":85,"range":{"start_line":85,"start_character":5,"end_line":85,"end_character":10},"in_reply_to":"5fc1f717_9619d27b","updated":"2019-03-30 10:14:28.000000000","message":"do you mean we should add a key \"software\" on top of apache, or do you want this part of the spec to be generic?","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6df258b71c2cdd22f3f9212cf2047fb21229e344","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  features."},{"line_number":105,"context_line":"* Exposes security/configuration features of software, allowing deployers to"},{"line_number":106,"context_line":"  configure software to their needs."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Security Impact"},{"line_number":109,"context_line":"---------------"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_3659fe34","line":107,"updated":"2019-03-29 14:19:21.000000000","message":"we should call out the goal is to have a common stanza that describes the distro specific differences for applications.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0f22085154ee9f9ec48b57a5404991e57d7f3f3b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  features."},{"line_number":105,"context_line":"* Exposes security/configuration features of software, allowing deployers to"},{"line_number":106,"context_line":"  configure software to their needs."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Security Impact"},{"line_number":109,"context_line":"---------------"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_db16964a","line":107,"in_reply_to":"5fc1f717_3659fe34","updated":"2019-03-30 10:14:28.000000000","message":"Good idea.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6df258b71c2cdd22f3f9212cf2047fb21229e344","unresolved":false,"context_lines":[{"line_number":187,"context_line":"Testing"},{"line_number":188,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"No change in testing required."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"However, additional OS/image vendors can leverage the new ``values.yaml``"},{"line_number":193,"context_line":"and propose new overrides files to be consumed for CI."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_7678e68e","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":30},"updated":"2019-03-29 14:19:21.000000000","message":"we should be adding gate jobs to ensure new distros can be supported, and promoted by the community, in the same way we do for the current default images in the charts.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b1b70700993a6a3d2073e04dbf256a898631acf3","unresolved":false,"context_lines":[{"line_number":187,"context_line":"Testing"},{"line_number":188,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"No change in testing required."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"However, additional OS/image vendors can leverage the new ``values.yaml``"},{"line_number":193,"context_line":"and propose new overrides files to be consumed for CI."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_bb45cab6","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":30},"in_reply_to":"5fc1f717_1b365ee9","updated":"2019-03-30 14:07:01.000000000","message":"I think its important to call out that testing is the goal, as we discussed in the etherpad (https://etherpad.openstack.org/p/openstack-helm-container-distro-support), its essential we test new distro support (see \u0027lines in the sand\u0027). You raise a good point here, in that we currently don\u0027t test the images built in infra, but use pre-built images, and I think this situation is therefore acceptable for any new distro we add - what is important here is that we ensure that we have a way of validating the functionality this work adds - even if less than ideal initially.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0f22085154ee9f9ec48b57a5404991e57d7f3f3b","unresolved":false,"context_lines":[{"line_number":187,"context_line":"Testing"},{"line_number":188,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"No change in testing required."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"However, additional OS/image vendors can leverage the new ``values.yaml``"},{"line_number":193,"context_line":"and propose new overrides files to be consumed for CI."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_1b365ee9","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":30},"in_reply_to":"5fc1f717_7678e68e","updated":"2019-03-30 10:14:28.000000000","message":"We will, but I don\u0027t want to overextend that spec -- the CI is currently only testing pre-built images, not testing the building the images in an end to end fashion. I don\u0027t want to go that route, so as long as it\u0027s clear we want to be at feature parity in this spec, I am good.\n\nAnything extra should be done ad-hoc or with another spec.","commit_id":"4265011e829eea9fc55836f7ff4616a1e5b65148"}]}