)]}'
{"horizon/values.yaml":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"9d34c25874e3577ee4cba7f13a510c6b0ae2695f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"conf:"},{"line_number":60,"context_line":"  horizon:"},{"line_number":61,"context_line":"    apache: |"},{"line_number":62,"context_line":"      \u003cIfVersion \u003c 2.4\u003e"},{"line_number":63,"context_line":"      Listen 0.0.0.0:{{ tuple \"dashboard\" \"internal\" \"web\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":64,"context_line":"      \u003c/IfVersion\u003e"},{"line_number":65,"context_line":"      LogFormat \"%h %l %u %t \\\"%r\\\" %\u003es %b \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" combined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_3a3bddc8","line":62,"updated":"2019-03-21 15:39:14.000000000","message":"You need to load mod_version to have this working. Should that be done somewhere?","commit_id":"2ec91c4c3febf0ca96f5ea98f55f62f74be1c052"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"2eafabb07e98e1acad42196bd4f7f230c8c456a8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"conf:"},{"line_number":60,"context_line":"  horizon:"},{"line_number":61,"context_line":"    apache: |"},{"line_number":62,"context_line":"      \u003cIfVersion \u003c 2.4\u003e"},{"line_number":63,"context_line":"      Listen 0.0.0.0:{{ tuple \"dashboard\" \"internal\" \"web\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":64,"context_line":"      \u003c/IfVersion\u003e"},{"line_number":65,"context_line":"      LogFormat \"%h %l %u %t \\\"%r\\\" %\u003es %b \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" combined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_500cbceb","line":62,"in_reply_to":"5fc1f717_1950ae5e","updated":"2019-04-01 08:52:01.000000000","message":"nope, we dont.\n\nThe thing is the listen directive + ports is duplicated in this config file, one is generic (all hosts) and the other one is for the virtualhost (line 72) which is the one we are interested in.\n\nThis is accepted in apache versions lower than 2.4  but in 2.4 this has been changed into a fatal error( duplication of listen directives) so we should only enable this in lower versions.","commit_id":"2ec91c4c3febf0ca96f5ea98f55f62f74be1c052"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"8aa931755f50d61c0605b8b06a2a9f1fc913cc0a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"conf:"},{"line_number":60,"context_line":"  horizon:"},{"line_number":61,"context_line":"    apache: |"},{"line_number":62,"context_line":"      \u003cIfVersion \u003c 2.4\u003e"},{"line_number":63,"context_line":"      Listen 0.0.0.0:{{ tuple \"dashboard\" \"internal\" \"web\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":64,"context_line":"      \u003c/IfVersion\u003e"},{"line_number":65,"context_line":"      LogFormat \"%h %l %u %t \\\"%r\\\" %\u003es %b \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" combined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_ba97cdeb","line":62,"in_reply_to":"5fc1f717_3a3bddc8","updated":"2019-03-21 15:59:33.000000000","message":"Version is loaded by default under ubuntu it seems as its used below on line 91.\n\nOther distros would have to override the list of modules to enable version if its not on by default :)","commit_id":"2ec91c4c3febf0ca96f5ea98f55f62f74be1c052"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"5531564e8f26c5d626bf6e67394832298b75698c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"conf:"},{"line_number":60,"context_line":"  horizon:"},{"line_number":61,"context_line":"    apache: |"},{"line_number":62,"context_line":"      \u003cIfVersion \u003c 2.4\u003e"},{"line_number":63,"context_line":"      Listen 0.0.0.0:{{ tuple \"dashboard\" \"internal\" \"web\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":64,"context_line":"      \u003c/IfVersion\u003e"},{"line_number":65,"context_line":"      LogFormat \"%h %l %u %t \\\"%r\\\" %\u003es %b \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" combined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_1950ae5e","line":62,"in_reply_to":"5fc1f717_4b69f3f6","updated":"2019-03-29 20:35:20.000000000","message":"should we not block out the ports, in the same way we do for keystone (https://github.com/openstack/openstack-helm/blob/master/keystone/templates/deployment-api.yaml#L104-L107)\n\nwith this change, we lose the ability to change the port don\u0027t we?","commit_id":"2ec91c4c3febf0ca96f5ea98f55f62f74be1c052"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"8947bdc0e3d6bbfa6d6c0c4df1f85585a87e0b08","unresolved":false,"context_lines":[{"line_number":59,"context_line":"conf:"},{"line_number":60,"context_line":"  horizon:"},{"line_number":61,"context_line":"    apache: |"},{"line_number":62,"context_line":"      \u003cIfVersion \u003c 2.4\u003e"},{"line_number":63,"context_line":"      Listen 0.0.0.0:{{ tuple \"dashboard\" \"internal\" \"web\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":64,"context_line":"      \u003c/IfVersion\u003e"},{"line_number":65,"context_line":"      LogFormat \"%h %l %u %t \\\"%r\\\" %\u003es %b \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" combined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_c60f28de","line":62,"in_reply_to":"5fc1f717_500cbceb","updated":"2019-04-05 16:28:45.000000000","message":"this makes sense, thanks for the explanation","commit_id":"2ec91c4c3febf0ca96f5ea98f55f62f74be1c052"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"930b8990405ca1c89e5d737ceae26f91f69b58d5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"conf:"},{"line_number":60,"context_line":"  horizon:"},{"line_number":61,"context_line":"    apache: |"},{"line_number":62,"context_line":"      \u003cIfVersion \u003c 2.4\u003e"},{"line_number":63,"context_line":"      Listen 0.0.0.0:{{ tuple \"dashboard\" \"internal\" \"web\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":64,"context_line":"      \u003c/IfVersion\u003e"},{"line_number":65,"context_line":"      LogFormat \"%h %l %u %t \\\"%r\\\" %\u003es %b \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" combined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_4b69f3f6","line":62,"in_reply_to":"5fc1f717_8b394ea4","updated":"2019-03-25 10:04:30.000000000","message":"then we override this on opensuse no? BTW this worked on my tests with suse_15 so I think it is in there, its just not activated with a2enmod (which we should be able to override once the horizon multi os patch gets in)","commit_id":"2ec91c4c3febf0ca96f5ea98f55f62f74be1c052"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"6bdc93308758096103832101e08e45d7e33a25a4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"conf:"},{"line_number":60,"context_line":"  horizon:"},{"line_number":61,"context_line":"    apache: |"},{"line_number":62,"context_line":"      \u003cIfVersion \u003c 2.4\u003e"},{"line_number":63,"context_line":"      Listen 0.0.0.0:{{ tuple \"dashboard\" \"internal\" \"web\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":64,"context_line":"      \u003c/IfVersion\u003e"},{"line_number":65,"context_line":"      LogFormat \"%h %l %u %t \\\"%r\\\" %\u003es %b \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" combined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_8b394ea4","line":62,"in_reply_to":"5fc1f717_ba97cdeb","updated":"2019-03-22 13:05:26.000000000","message":"I think it\u0027s not on opensuse 15 by default. We need something to list and enable those modules in a distro independent way.","commit_id":"2ec91c4c3febf0ca96f5ea98f55f62f74be1c052"}]}