)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"0163305c91babca8abedff11058d16611ef57571","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Itxaka \u003cigarcia@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-22 12:45:25 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add heat dashboard if available to horizon"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there is no enabling of the heat dashboard if its"},{"line_number":10,"context_line":"installed on the horizon image."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_32d20a5e","line":7,"updated":"2019-03-22 16:36:32.000000000","message":"Add heat dashboard to horizon, if available\n\nAdd heat dashboard to horizon (if available)","commit_id":"4be09eb056e9113c04a65dfcce7e4e15c54e0d7e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"eaf7ee3c05bdf62c87c56c855fd869e5a721ded3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Itxaka \u003cigarcia@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-22 12:45:25 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add heat dashboard if available to horizon"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there is no enabling of the heat dashboard if its"},{"line_number":10,"context_line":"installed on the horizon image."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_6b987074","line":7,"in_reply_to":"5fc1f717_32d20a5e","updated":"2019-03-25 09:18:31.000000000","message":"-1 on this is very harsh :p","commit_id":"4be09eb056e9113c04a65dfcce7e4e15c54e0d7e"}],"horizon/templates/bin/_horizon.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"eaf7ee3c05bdf62c87c56c855fd869e5a721ded3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  rm -rf /var/run/apache2/*"},{"line_number":38,"context_line":"  APACHE_DIR\u003d\"apache2\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  # Add heat dashboard panel if available"},{"line_number":41,"context_line":"  HEAT_PANEL_DIR\u003d\"${SITE_PACKAGES_ROOT}/heat_dashboard/enabled\""},{"line_number":42,"context_line":"  if [ -d ${HEAT_PANEL_DIR} ];then"},{"line_number":43,"context_line":"    for f in `ls -1 ${HEAT_PANEL_DIR}/_[1-9]*.py`"},{"line_number":44,"context_line":"    do"},{"line_number":45,"context_line":"      ln -s ${f} ${SITE_PACKAGES_ROOT}/openstack_dashboard/local/enabled/$(basename ${f})"},{"line_number":46,"context_line":"    done"},{"line_number":47,"context_line":"  fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  # If the image has support for it, compile the translations"},{"line_number":50,"context_line":"  if type -p gettext \u003e/dev/null 2\u003e/dev/null; then"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"5fc1f717_8b7efc16","line":47,"range":{"start_line":40,"start_character":2,"end_line":47,"end_character":4},"updated":"2019-03-25 09:18:31.000000000","message":"We can probably make this more generic with different panels, but it looks okay to me for now.","commit_id":"4be09eb056e9113c04a65dfcce7e4e15c54e0d7e"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"a58cdce6aa10727a286f434e969bfc7db9e13802","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  rm -rf /var/run/apache2/*"},{"line_number":38,"context_line":"  APACHE_DIR\u003d\"apache2\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  # Add heat dashboard panel if available"},{"line_number":41,"context_line":"  HEAT_PANEL_DIR\u003d\"${SITE_PACKAGES_ROOT}/heat_dashboard/enabled\""},{"line_number":42,"context_line":"  if [ -d ${HEAT_PANEL_DIR} ];then"},{"line_number":43,"context_line":"    for f in `ls -1 ${HEAT_PANEL_DIR}/_[1-9]*.py`"},{"line_number":44,"context_line":"    do"},{"line_number":45,"context_line":"      ln -s ${f} ${SITE_PACKAGES_ROOT}/openstack_dashboard/local/enabled/$(basename ${f})"},{"line_number":46,"context_line":"    done"},{"line_number":47,"context_line":"  fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  # If the image has support for it, compile the translations"},{"line_number":50,"context_line":"  if type -p gettext \u003e/dev/null 2\u003e/dev/null; then"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"5fc1f717_1f900543","line":47,"range":{"start_line":40,"start_character":2,"end_line":47,"end_character":4},"in_reply_to":"5fc1f717_8b7efc16","updated":"2019-03-25 12:14:05.000000000","message":"as usual the solution would be...an override!\n\nWe could have an override for plugins installed so we can iterate over them and link to the enabled dir if they exists so this is expandable in the future with user input and not developer modification.\n\nLet me rework this to make it easier to maintain.","commit_id":"4be09eb056e9113c04a65dfcce7e4e15c54e0d7e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e17a259c8c148952df2f5e4f8bd2eb6e5f959466","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  if [ -f ${TAAS_PANEL} ]; then"},{"line_number":43,"context_line":"     ln -s ${TAAS_PANEL}   ${SITE_PACKAGES_ROOT}/openstack_dashboard/local/enabled/_90_project_tapservices_panel.py"},{"line_number":44,"context_line":"  fi"},{"line_number":45,"context_line":"  "},{"line_number":46,"context_line":"  # Add heat dashboard panel if available"},{"line_number":47,"context_line":"  HEAT_PANEL_DIR\u003d\"${SITE_PACKAGES_ROOT}/heat_dashboard/enabled\""},{"line_number":48,"context_line":"  if [ -d ${HEAT_PANEL_DIR} ];then"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"5fc1f717_90479a4d","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":2},"updated":"2019-03-29 12:55:23.000000000","message":"nit: whitespace","commit_id":"40bdac1406cb3fbf71ef0d0d48a44bbad36cf988"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a152cd35212ed319111597f796eab8e9a658392b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  rm -rf /var/run/apache2/*"},{"line_number":38,"context_line":"  APACHE_DIR\u003d\"apache2\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  # Add TaaS dashboard panel if available"},{"line_number":41,"context_line":"  TAAS_PANEL\u003d\"${SITE_PACKAGES_ROOT}/neutron_taas_dashboard/enabled/_90_project_tapservices_panel.py\""},{"line_number":42,"context_line":"  if [ -f ${TAAS_PANEL} ]; then"},{"line_number":43,"context_line":"     ln -s ${TAAS_PANEL}   ${SITE_PACKAGES_ROOT}/openstack_dashboard/local/enabled/_90_project_tapservices_panel.py"},{"line_number":44,"context_line":"  fi"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  # Add extra panels if available"},{"line_number":47,"context_line":"  {{- range .Values.conf.horizon.extra_panels }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5fc1f717_de070d1d","line":44,"range":{"start_line":40,"start_character":0,"end_line":44,"end_character":4},"updated":"2019-04-04 12:07:39.000000000","message":"could we drive the taas panel via the same mechanism please.","commit_id":"f281b9a73fd1ea9287dfba3a4010f3f43a5519d7"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"2da009768864edca4607c7b1979bcd7780304ead","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  rm -rf /var/run/apache2/*"},{"line_number":38,"context_line":"  APACHE_DIR\u003d\"apache2\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  # Add TaaS dashboard panel if available"},{"line_number":41,"context_line":"  TAAS_PANEL\u003d\"${SITE_PACKAGES_ROOT}/neutron_taas_dashboard/enabled/_90_project_tapservices_panel.py\""},{"line_number":42,"context_line":"  if [ -f ${TAAS_PANEL} ]; then"},{"line_number":43,"context_line":"     ln -s ${TAAS_PANEL}   ${SITE_PACKAGES_ROOT}/openstack_dashboard/local/enabled/_90_project_tapservices_panel.py"},{"line_number":44,"context_line":"  fi"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  # Add extra panels if available"},{"line_number":47,"context_line":"  {{- range .Values.conf.horizon.extra_panels }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5fc1f717_f2cd5db7","line":44,"range":{"start_line":40,"start_character":0,"end_line":44,"end_character":4},"in_reply_to":"5fc1f717_de070d1d","updated":"2019-04-04 12:20:57.000000000","message":"I missed it. Good catch!","commit_id":"f281b9a73fd1ea9287dfba3a4010f3f43a5519d7"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"867ab82c59d6d321bbeb99731c8effaff303ee49","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  rm -rf /var/run/apache2/*"},{"line_number":38,"context_line":"  APACHE_DIR\u003d\"apache2\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  # Add TaaS dashboard panel if available"},{"line_number":41,"context_line":"  TAAS_PANEL\u003d\"${SITE_PACKAGES_ROOT}/neutron_taas_dashboard/enabled/_90_project_tapservices_panel.py\""},{"line_number":42,"context_line":"  if [ -f ${TAAS_PANEL} ]; then"},{"line_number":43,"context_line":"     ln -s ${TAAS_PANEL}   ${SITE_PACKAGES_ROOT}/openstack_dashboard/local/enabled/_90_project_tapservices_panel.py"},{"line_number":44,"context_line":"  fi"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  # Add extra panels if available"},{"line_number":47,"context_line":"  {{- range .Values.conf.horizon.extra_panels }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5fc1f717_755dd713","line":44,"range":{"start_line":40,"start_character":0,"end_line":44,"end_character":4},"in_reply_to":"5fc1f717_de070d1d","updated":"2019-04-04 13:09:41.000000000","message":"different patch! This is already a logical change, adding an extra change on top of it in the same patch makes no sense!","commit_id":"f281b9a73fd1ea9287dfba3a4010f3f43a5519d7"}]}