)]}'
{"keystone/templates/bin/_keystone-api.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b7e3f2ab6e6fcfe80a92006089047f73323bb19e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  done"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  {{- if .Values.conf.software.apache2.a2enmod }}"},{"line_number":30,"context_line":"    {{- range .Values.conf.software.apache2.a2enmod | default \"\"}}"},{"line_number":31,"context_line":"  a2enmod {{ . }}"},{"line_number":32,"context_line":"    {{- end }}"},{"line_number":33,"context_line":"  {{- end }}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5fc1f717_2490bbed","line":30,"range":{"start_line":30,"start_character":52,"end_line":30,"end_character":64},"updated":"2019-04-02 09:33:03.000000000","message":"shouldn\u0027t this be in the default values instead of the current null ? It confuses me to have two different defaults :)","commit_id":"5d729afb51274496b6057cb66a591369b1fbe2ee"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"a39138e97320c53b52f0dcb1f0feff9a190ecaee","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  done"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  {{- if .Values.conf.software.apache2.a2enmod }}"},{"line_number":30,"context_line":"    {{- range .Values.conf.software.apache2.a2enmod | default \"\"}}"},{"line_number":31,"context_line":"  a2enmod {{ . }}"},{"line_number":32,"context_line":"    {{- end }}"},{"line_number":33,"context_line":"  {{- end }}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5fc1f717_7fe40d3d","line":30,"range":{"start_line":30,"start_character":52,"end_line":30,"end_character":64},"in_reply_to":"5fc1f717_2490bbed","updated":"2019-04-02 10:21:25.000000000","message":"Indeed, this was from one of my tests to remove the previous if, should be removed!","commit_id":"5d729afb51274496b6057cb66a591369b1fbe2ee"}],"keystone/values.yaml":[{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"a1026d2512344e565c78124d7864cb26d981e39c","unresolved":false,"context_lines":[{"line_number":440,"context_line":"    site_dir: /etc/apache2/sites-enable"},{"line_number":441,"context_line":"    conf_dir: /etc/apache2/conf-enabled"},{"line_number":442,"context_line":"    mods_dir: /etc/apache2/mods-available"},{"line_number":443,"context_line":"    a2enmod:"},{"line_number":444,"context_line":"    a2dismod:"},{"line_number":445,"context_line":"    security: |"},{"line_number":446,"context_line":"      #"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_34bf2862","line":443,"updated":"2019-03-25 11:41:22.000000000","message":"I think this is wrong and it should have a default value of null instead","commit_id":"76cb57c5e42fb66cb8a1eb3aca60bb32571a5736"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f84a765d66749eacef39ae7b3ec34017103e153a","unresolved":false,"context_lines":[{"line_number":443,"context_line":"      mods_dir: /etc/apache2/mods-available"},{"line_number":444,"context_line":"      a2enmod: null"},{"line_number":445,"context_line":"      a2dismod: null"},{"line_number":446,"context_line":"      security: |"},{"line_number":447,"context_line":"        #"},{"line_number":448,"context_line":"        # Disable access to the entire file system except for the directories that"},{"line_number":449,"context_line":"        # are explicitly allowed later."},{"line_number":450,"context_line":"        #"},{"line_number":451,"context_line":"        # This currently breaks the configurations that come with some web application"},{"line_number":452,"context_line":"        # Debian packages."},{"line_number":453,"context_line":"        #"},{"line_number":454,"context_line":"        #\u003cDirectory /\u003e"},{"line_number":455,"context_line":"        #   AllowOverride None"},{"line_number":456,"context_line":"        #   Require all denied"},{"line_number":457,"context_line":"        #\u003c/Directory\u003e"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        # Changing the following options will not really affect the security of the"},{"line_number":460,"context_line":"        # server, but might make attacks slightly more difficult in some cases."},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        #"},{"line_number":463,"context_line":"        # ServerTokens"},{"line_number":464,"context_line":"        # This directive configures what you return as the Server HTTP response"},{"line_number":465,"context_line":"        # Header. The default is \u0027Full\u0027 which sends information about the OS-Type"},{"line_number":466,"context_line":"        # and compiled in modules."},{"line_number":467,"context_line":"        # Set to one of:  Full | OS | Minimal | Minor | Major | Prod"},{"line_number":468,"context_line":"        # where Full conveys the most information, and Prod the least."},{"line_number":469,"context_line":"        ServerTokens Prod"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        #"},{"line_number":472,"context_line":"        # Optionally add a line containing the server version and virtual host"},{"line_number":473,"context_line":"        # name to server-generated pages (internal error documents, FTP directory"},{"line_number":474,"context_line":"        # listings, mod_status and mod_info output etc., but not CGI generated"},{"line_number":475,"context_line":"        # documents or custom error documents)."},{"line_number":476,"context_line":"        # Set to \"EMail\" to also include a mailto: link to the ServerAdmin."},{"line_number":477,"context_line":"        # Set to one of:  On | Off | EMail"},{"line_number":478,"context_line":"        ServerSignature Off"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        #"},{"line_number":481,"context_line":"        # Allow TRACE method"},{"line_number":482,"context_line":"        #"},{"line_number":483,"context_line":"        # Set to \"extended\" to also reflect the request body (only for testing and"},{"line_number":484,"context_line":"        # diagnostic purposes)."},{"line_number":485,"context_line":"        #"},{"line_number":486,"context_line":"        # Set to one of:  On | Off | extended"},{"line_number":487,"context_line":"        TraceEnable Off"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        #"},{"line_number":490,"context_line":"        # Forbid access to version control directories"},{"line_number":491,"context_line":"        #"},{"line_number":492,"context_line":"        # If you use version control systems in your document root, you should"},{"line_number":493,"context_line":"        # probably deny access to their directories. For example, for subversion:"},{"line_number":494,"context_line":"        #"},{"line_number":495,"context_line":"        #\u003cDirectoryMatch \"/\\.svn\"\u003e"},{"line_number":496,"context_line":"        #   Require all denied"},{"line_number":497,"context_line":"        #\u003c/DirectoryMatch\u003e"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        #"},{"line_number":500,"context_line":"        # Setting this header will prevent MSIE from interpreting files as something"},{"line_number":501,"context_line":"        # else than declared by the content type in the HTTP headers."},{"line_number":502,"context_line":"        # Requires mod_headers to be enabled."},{"line_number":503,"context_line":"        #"},{"line_number":504,"context_line":"        #Header set X-Content-Type-Options: \"nosniff\""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        #"},{"line_number":507,"context_line":"        # Setting this header will prevent other sites from embedding pages from this"},{"line_number":508,"context_line":"        # site as frames. This defends against clickjacking attacks."},{"line_number":509,"context_line":"        # Requires mod_headers to be enabled."},{"line_number":510,"context_line":"        #"},{"line_number":511,"context_line":"        #Header set X-Frame-Options: \"sameorigin\""},{"line_number":512,"context_line":"  keystone:"},{"line_number":513,"context_line":"    DEFAULT:"},{"line_number":514,"context_line":"      log_config_append: /etc/keystone/logging.conf"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_1e483585","line":511,"range":{"start_line":446,"start_character":0,"end_line":511,"end_character":49},"updated":"2019-04-04 12:04:46.000000000","message":"should this not sit alongside the other apache config files eg npm_event?","commit_id":"22fe1adb1c88b543aa11782809667af334231bd8"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"7285933e0c566d5abdfc9bd006e09d73dd72a73f","unresolved":false,"context_lines":[{"line_number":443,"context_line":"      mods_dir: /etc/apache2/mods-available"},{"line_number":444,"context_line":"      a2enmod: null"},{"line_number":445,"context_line":"      a2dismod: null"},{"line_number":446,"context_line":"      security: |"},{"line_number":447,"context_line":"        #"},{"line_number":448,"context_line":"        # Disable access to the entire file system except for the directories that"},{"line_number":449,"context_line":"        # are explicitly allowed later."},{"line_number":450,"context_line":"        #"},{"line_number":451,"context_line":"        # This currently breaks the configurations that come with some web application"},{"line_number":452,"context_line":"        # Debian packages."},{"line_number":453,"context_line":"        #"},{"line_number":454,"context_line":"        #\u003cDirectory /\u003e"},{"line_number":455,"context_line":"        #   AllowOverride None"},{"line_number":456,"context_line":"        #   Require all denied"},{"line_number":457,"context_line":"        #\u003c/Directory\u003e"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        # Changing the following options will not really affect the security of the"},{"line_number":460,"context_line":"        # server, but might make attacks slightly more difficult in some cases."},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        #"},{"line_number":463,"context_line":"        # ServerTokens"},{"line_number":464,"context_line":"        # This directive configures what you return as the Server HTTP response"},{"line_number":465,"context_line":"        # Header. The default is \u0027Full\u0027 which sends information about the OS-Type"},{"line_number":466,"context_line":"        # and compiled in modules."},{"line_number":467,"context_line":"        # Set to one of:  Full | OS | Minimal | Minor | Major | Prod"},{"line_number":468,"context_line":"        # where Full conveys the most information, and Prod the least."},{"line_number":469,"context_line":"        ServerTokens Prod"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        #"},{"line_number":472,"context_line":"        # Optionally add a line containing the server version and virtual host"},{"line_number":473,"context_line":"        # name to server-generated pages (internal error documents, FTP directory"},{"line_number":474,"context_line":"        # listings, mod_status and mod_info output etc., but not CGI generated"},{"line_number":475,"context_line":"        # documents or custom error documents)."},{"line_number":476,"context_line":"        # Set to \"EMail\" to also include a mailto: link to the ServerAdmin."},{"line_number":477,"context_line":"        # Set to one of:  On | Off | EMail"},{"line_number":478,"context_line":"        ServerSignature Off"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        #"},{"line_number":481,"context_line":"        # Allow TRACE method"},{"line_number":482,"context_line":"        #"},{"line_number":483,"context_line":"        # Set to \"extended\" to also reflect the request body (only for testing and"},{"line_number":484,"context_line":"        # diagnostic purposes)."},{"line_number":485,"context_line":"        #"},{"line_number":486,"context_line":"        # Set to one of:  On | Off | extended"},{"line_number":487,"context_line":"        TraceEnable Off"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        #"},{"line_number":490,"context_line":"        # Forbid access to version control directories"},{"line_number":491,"context_line":"        #"},{"line_number":492,"context_line":"        # If you use version control systems in your document root, you should"},{"line_number":493,"context_line":"        # probably deny access to their directories. For example, for subversion:"},{"line_number":494,"context_line":"        #"},{"line_number":495,"context_line":"        #\u003cDirectoryMatch \"/\\.svn\"\u003e"},{"line_number":496,"context_line":"        #   Require all denied"},{"line_number":497,"context_line":"        #\u003c/DirectoryMatch\u003e"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        #"},{"line_number":500,"context_line":"        # Setting this header will prevent MSIE from interpreting files as something"},{"line_number":501,"context_line":"        # else than declared by the content type in the HTTP headers."},{"line_number":502,"context_line":"        # Requires mod_headers to be enabled."},{"line_number":503,"context_line":"        #"},{"line_number":504,"context_line":"        #Header set X-Content-Type-Options: \"nosniff\""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        #"},{"line_number":507,"context_line":"        # Setting this header will prevent other sites from embedding pages from this"},{"line_number":508,"context_line":"        # site as frames. This defends against clickjacking attacks."},{"line_number":509,"context_line":"        # Requires mod_headers to be enabled."},{"line_number":510,"context_line":"        #"},{"line_number":511,"context_line":"        #Header set X-Frame-Options: \"sameorigin\""},{"line_number":512,"context_line":"  keystone:"},{"line_number":513,"context_line":"    DEFAULT:"},{"line_number":514,"context_line":"      log_config_append: /etc/keystone/logging.conf"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_52fc713d","line":511,"range":{"start_line":446,"start_character":0,"end_line":511,"end_character":49},"in_reply_to":"5fc1f717_1e483585","updated":"2019-04-04 12:53:40.000000000","message":"I dont understand the question sorry.\n\nDo you mean as in the place that thy should be in the values.yml or in the final container destination?\n\nIf its on the values...I would say that its part of apache so it should go under apache, not sure where the npm_event config is going\n\nIf its final container destination, conf files should go into the conf.d dir under suse and conf-enabled under ubuntu. (Actaully they should go into conf-available and then a soft link needs to be created into conf-enabled IIRC, but dont quote me on that)","commit_id":"22fe1adb1c88b543aa11782809667af334231bd8"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"51d93ab11a2e1de4fdf792ce0fa4360436e6d18d","unresolved":false,"context_lines":[{"line_number":443,"context_line":"      mods_dir: /etc/apache2/mods-available"},{"line_number":444,"context_line":"      a2enmod: null"},{"line_number":445,"context_line":"      a2dismod: null"},{"line_number":446,"context_line":"      security: |"},{"line_number":447,"context_line":"        #"},{"line_number":448,"context_line":"        # Disable access to the entire file system except for the directories that"},{"line_number":449,"context_line":"        # are explicitly allowed later."},{"line_number":450,"context_line":"        #"},{"line_number":451,"context_line":"        # This currently breaks the configurations that come with some web application"},{"line_number":452,"context_line":"        # Debian packages."},{"line_number":453,"context_line":"        #"},{"line_number":454,"context_line":"        #\u003cDirectory /\u003e"},{"line_number":455,"context_line":"        #   AllowOverride None"},{"line_number":456,"context_line":"        #   Require all denied"},{"line_number":457,"context_line":"        #\u003c/Directory\u003e"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        # Changing the following options will not really affect the security of the"},{"line_number":460,"context_line":"        # server, but might make attacks slightly more difficult in some cases."},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        #"},{"line_number":463,"context_line":"        # ServerTokens"},{"line_number":464,"context_line":"        # This directive configures what you return as the Server HTTP response"},{"line_number":465,"context_line":"        # Header. The default is \u0027Full\u0027 which sends information about the OS-Type"},{"line_number":466,"context_line":"        # and compiled in modules."},{"line_number":467,"context_line":"        # Set to one of:  Full | OS | Minimal | Minor | Major | Prod"},{"line_number":468,"context_line":"        # where Full conveys the most information, and Prod the least."},{"line_number":469,"context_line":"        ServerTokens Prod"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        #"},{"line_number":472,"context_line":"        # Optionally add a line containing the server version and virtual host"},{"line_number":473,"context_line":"        # name to server-generated pages (internal error documents, FTP directory"},{"line_number":474,"context_line":"        # listings, mod_status and mod_info output etc., but not CGI generated"},{"line_number":475,"context_line":"        # documents or custom error documents)."},{"line_number":476,"context_line":"        # Set to \"EMail\" to also include a mailto: link to the ServerAdmin."},{"line_number":477,"context_line":"        # Set to one of:  On | Off | EMail"},{"line_number":478,"context_line":"        ServerSignature Off"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        #"},{"line_number":481,"context_line":"        # Allow TRACE method"},{"line_number":482,"context_line":"        #"},{"line_number":483,"context_line":"        # Set to \"extended\" to also reflect the request body (only for testing and"},{"line_number":484,"context_line":"        # diagnostic purposes)."},{"line_number":485,"context_line":"        #"},{"line_number":486,"context_line":"        # Set to one of:  On | Off | extended"},{"line_number":487,"context_line":"        TraceEnable Off"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        #"},{"line_number":490,"context_line":"        # Forbid access to version control directories"},{"line_number":491,"context_line":"        #"},{"line_number":492,"context_line":"        # If you use version control systems in your document root, you should"},{"line_number":493,"context_line":"        # probably deny access to their directories. For example, for subversion:"},{"line_number":494,"context_line":"        #"},{"line_number":495,"context_line":"        #\u003cDirectoryMatch \"/\\.svn\"\u003e"},{"line_number":496,"context_line":"        #   Require all denied"},{"line_number":497,"context_line":"        #\u003c/DirectoryMatch\u003e"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        #"},{"line_number":500,"context_line":"        # Setting this header will prevent MSIE from interpreting files as something"},{"line_number":501,"context_line":"        # else than declared by the content type in the HTTP headers."},{"line_number":502,"context_line":"        # Requires mod_headers to be enabled."},{"line_number":503,"context_line":"        #"},{"line_number":504,"context_line":"        #Header set X-Content-Type-Options: \"nosniff\""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        #"},{"line_number":507,"context_line":"        # Setting this header will prevent other sites from embedding pages from this"},{"line_number":508,"context_line":"        # site as frames. This defends against clickjacking attacks."},{"line_number":509,"context_line":"        # Requires mod_headers to be enabled."},{"line_number":510,"context_line":"        #"},{"line_number":511,"context_line":"        #Header set X-Frame-Options: \"sameorigin\""},{"line_number":512,"context_line":"  keystone:"},{"line_number":513,"context_line":"    DEFAULT:"},{"line_number":514,"context_line":"      log_config_append: /etc/keystone/logging.conf"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_be2321be","line":511,"range":{"start_line":446,"start_character":0,"end_line":511,"end_character":49},"in_reply_to":"5fc1f717_1e483585","updated":"2019-04-04 12:05:52.000000000","message":"I think those security things would be fine inline, as I am used to do :D","commit_id":"22fe1adb1c88b543aa11782809667af334231bd8"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fc98e1a7e41f10f59af99c15680c3fbca33a92d","unresolved":false,"context_lines":[{"line_number":443,"context_line":"      mods_dir: /etc/apache2/mods-available"},{"line_number":444,"context_line":"      a2enmod: null"},{"line_number":445,"context_line":"      a2dismod: null"},{"line_number":446,"context_line":"      security: |"},{"line_number":447,"context_line":"        #"},{"line_number":448,"context_line":"        # Disable access to the entire file system except for the directories that"},{"line_number":449,"context_line":"        # are explicitly allowed later."},{"line_number":450,"context_line":"        #"},{"line_number":451,"context_line":"        # This currently breaks the configurations that come with some web application"},{"line_number":452,"context_line":"        # Debian packages."},{"line_number":453,"context_line":"        #"},{"line_number":454,"context_line":"        #\u003cDirectory /\u003e"},{"line_number":455,"context_line":"        #   AllowOverride None"},{"line_number":456,"context_line":"        #   Require all denied"},{"line_number":457,"context_line":"        #\u003c/Directory\u003e"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        # Changing the following options will not really affect the security of the"},{"line_number":460,"context_line":"        # server, but might make attacks slightly more difficult in some cases."},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        #"},{"line_number":463,"context_line":"        # ServerTokens"},{"line_number":464,"context_line":"        # This directive configures what you return as the Server HTTP response"},{"line_number":465,"context_line":"        # Header. The default is \u0027Full\u0027 which sends information about the OS-Type"},{"line_number":466,"context_line":"        # and compiled in modules."},{"line_number":467,"context_line":"        # Set to one of:  Full | OS | Minimal | Minor | Major | Prod"},{"line_number":468,"context_line":"        # where Full conveys the most information, and Prod the least."},{"line_number":469,"context_line":"        ServerTokens Prod"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        #"},{"line_number":472,"context_line":"        # Optionally add a line containing the server version and virtual host"},{"line_number":473,"context_line":"        # name to server-generated pages (internal error documents, FTP directory"},{"line_number":474,"context_line":"        # listings, mod_status and mod_info output etc., but not CGI generated"},{"line_number":475,"context_line":"        # documents or custom error documents)."},{"line_number":476,"context_line":"        # Set to \"EMail\" to also include a mailto: link to the ServerAdmin."},{"line_number":477,"context_line":"        # Set to one of:  On | Off | EMail"},{"line_number":478,"context_line":"        ServerSignature Off"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        #"},{"line_number":481,"context_line":"        # Allow TRACE method"},{"line_number":482,"context_line":"        #"},{"line_number":483,"context_line":"        # Set to \"extended\" to also reflect the request body (only for testing and"},{"line_number":484,"context_line":"        # diagnostic purposes)."},{"line_number":485,"context_line":"        #"},{"line_number":486,"context_line":"        # Set to one of:  On | Off | extended"},{"line_number":487,"context_line":"        TraceEnable Off"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        #"},{"line_number":490,"context_line":"        # Forbid access to version control directories"},{"line_number":491,"context_line":"        #"},{"line_number":492,"context_line":"        # If you use version control systems in your document root, you should"},{"line_number":493,"context_line":"        # probably deny access to their directories. For example, for subversion:"},{"line_number":494,"context_line":"        #"},{"line_number":495,"context_line":"        #\u003cDirectoryMatch \"/\\.svn\"\u003e"},{"line_number":496,"context_line":"        #   Require all denied"},{"line_number":497,"context_line":"        #\u003c/DirectoryMatch\u003e"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        #"},{"line_number":500,"context_line":"        # Setting this header will prevent MSIE from interpreting files as something"},{"line_number":501,"context_line":"        # else than declared by the content type in the HTTP headers."},{"line_number":502,"context_line":"        # Requires mod_headers to be enabled."},{"line_number":503,"context_line":"        #"},{"line_number":504,"context_line":"        #Header set X-Content-Type-Options: \"nosniff\""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        #"},{"line_number":507,"context_line":"        # Setting this header will prevent other sites from embedding pages from this"},{"line_number":508,"context_line":"        # site as frames. This defends against clickjacking attacks."},{"line_number":509,"context_line":"        # Requires mod_headers to be enabled."},{"line_number":510,"context_line":"        #"},{"line_number":511,"context_line":"        #Header set X-Frame-Options: \"sameorigin\""},{"line_number":512,"context_line":"  keystone:"},{"line_number":513,"context_line":"    DEFAULT:"},{"line_number":514,"context_line":"      log_config_append: /etc/keystone/logging.conf"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_c70a8b88","line":511,"range":{"start_line":446,"start_character":0,"end_line":511,"end_character":49},"in_reply_to":"5fc1f717_52fc713d","updated":"2019-04-09 14:38:09.000000000","message":"I\u0027m saying these config files should sit alongside the current definition of them - ie circa line 967.","commit_id":"22fe1adb1c88b543aa11782809667af334231bd8"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"f8e5d88d06d130646033498f79a99d98cedb6bec","unresolved":false,"context_lines":[{"line_number":443,"context_line":"      mods_dir: /etc/apache2/mods-available"},{"line_number":444,"context_line":"      a2enmod: null"},{"line_number":445,"context_line":"      a2dismod: null"},{"line_number":446,"context_line":"      security: |"},{"line_number":447,"context_line":"        #"},{"line_number":448,"context_line":"        # Disable access to the entire file system except for the directories that"},{"line_number":449,"context_line":"        # are explicitly allowed later."},{"line_number":450,"context_line":"        #"},{"line_number":451,"context_line":"        # This currently breaks the configurations that come with some web application"},{"line_number":452,"context_line":"        # Debian packages."},{"line_number":453,"context_line":"        #"},{"line_number":454,"context_line":"        #\u003cDirectory /\u003e"},{"line_number":455,"context_line":"        #   AllowOverride None"},{"line_number":456,"context_line":"        #   Require all denied"},{"line_number":457,"context_line":"        #\u003c/Directory\u003e"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        # Changing the following options will not really affect the security of the"},{"line_number":460,"context_line":"        # server, but might make attacks slightly more difficult in some cases."},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        #"},{"line_number":463,"context_line":"        # ServerTokens"},{"line_number":464,"context_line":"        # This directive configures what you return as the Server HTTP response"},{"line_number":465,"context_line":"        # Header. The default is \u0027Full\u0027 which sends information about the OS-Type"},{"line_number":466,"context_line":"        # and compiled in modules."},{"line_number":467,"context_line":"        # Set to one of:  Full | OS | Minimal | Minor | Major | Prod"},{"line_number":468,"context_line":"        # where Full conveys the most information, and Prod the least."},{"line_number":469,"context_line":"        ServerTokens Prod"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        #"},{"line_number":472,"context_line":"        # Optionally add a line containing the server version and virtual host"},{"line_number":473,"context_line":"        # name to server-generated pages (internal error documents, FTP directory"},{"line_number":474,"context_line":"        # listings, mod_status and mod_info output etc., but not CGI generated"},{"line_number":475,"context_line":"        # documents or custom error documents)."},{"line_number":476,"context_line":"        # Set to \"EMail\" to also include a mailto: link to the ServerAdmin."},{"line_number":477,"context_line":"        # Set to one of:  On | Off | EMail"},{"line_number":478,"context_line":"        ServerSignature Off"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        #"},{"line_number":481,"context_line":"        # Allow TRACE method"},{"line_number":482,"context_line":"        #"},{"line_number":483,"context_line":"        # Set to \"extended\" to also reflect the request body (only for testing and"},{"line_number":484,"context_line":"        # diagnostic purposes)."},{"line_number":485,"context_line":"        #"},{"line_number":486,"context_line":"        # Set to one of:  On | Off | extended"},{"line_number":487,"context_line":"        TraceEnable Off"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        #"},{"line_number":490,"context_line":"        # Forbid access to version control directories"},{"line_number":491,"context_line":"        #"},{"line_number":492,"context_line":"        # If you use version control systems in your document root, you should"},{"line_number":493,"context_line":"        # probably deny access to their directories. For example, for subversion:"},{"line_number":494,"context_line":"        #"},{"line_number":495,"context_line":"        #\u003cDirectoryMatch \"/\\.svn\"\u003e"},{"line_number":496,"context_line":"        #   Require all denied"},{"line_number":497,"context_line":"        #\u003c/DirectoryMatch\u003e"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        #"},{"line_number":500,"context_line":"        # Setting this header will prevent MSIE from interpreting files as something"},{"line_number":501,"context_line":"        # else than declared by the content type in the HTTP headers."},{"line_number":502,"context_line":"        # Requires mod_headers to be enabled."},{"line_number":503,"context_line":"        #"},{"line_number":504,"context_line":"        #Header set X-Content-Type-Options: \"nosniff\""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        #"},{"line_number":507,"context_line":"        # Setting this header will prevent other sites from embedding pages from this"},{"line_number":508,"context_line":"        # site as frames. This defends against clickjacking attacks."},{"line_number":509,"context_line":"        # Requires mod_headers to be enabled."},{"line_number":510,"context_line":"        #"},{"line_number":511,"context_line":"        #Header set X-Frame-Options: \"sameorigin\""},{"line_number":512,"context_line":"  keystone:"},{"line_number":513,"context_line":"    DEFAULT:"},{"line_number":514,"context_line":"      log_config_append: /etc/keystone/logging.conf"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_42d9a980","line":511,"range":{"start_line":446,"start_character":0,"end_line":511,"end_character":49},"in_reply_to":"5fc1f717_c70a8b88","updated":"2019-04-09 14:50:55.000000000","message":"ahh I see the npm_event now.\n\nMmmh, I would argue that those should be actually moved under this key as they are part of the apache config.\n\nBut this is kind of bikeshedding on where the keys would go which brings us nowhere. I do not really care as long as its consistent across charts so its easily identified.\n\nSo if you feel this should be moved from apache into them main config, I will change it, or vice versa.","commit_id":"22fe1adb1c88b543aa11782809667af334231bd8"}]}