)]}'
{"id":"openstack%2Fopenstack-helm~650122","triplet_id":"openstack%2Fopenstack-helm~master~I711d5fc4a2a376a29daf526fc420790ea9cacf25","project":"openstack/openstack-helm","branch":"master","topic":"fix_spice_deployment","hashtags":[],"change_id":"I711d5fc4a2a376a29daf526fc420790ea9cacf25","subject":"Add missing dependencies for spiceproxy in values","status":"MERGED","created":"2019-04-04 19:51:20.000000000","updated":"2019-04-07 07:26:48.000000000","submitted":"2019-04-07 07:26:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"650122-1554622008053-c9f4f036","meta_rev_id":"47267a3a6721d6c9d82665a7d696d134a6256747","_number":650122,"virtual_id_number":650122,"owner":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":2,"date":"2019-04-07 07:26:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":2,"date":"2019-04-07 06:41:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":2,"date":"2019-04-04 19:54:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":1,"date":"2019-04-07 06:41:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"date":"2019-04-05 08:09:49.000000000","_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-04 19:54:59.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-04-07 06:41:48.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2019-04-07 07:26:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a0ca997e024373b94ae5a2bca6f9099918b88923","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-04-04 19:51:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8479f30db9151070e55e877a995ffef018bf8467","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-04-04 19:54:59.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c55814902804a13ec7f2392943b48fefeb1ddbc8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-04 20:37:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/22/650122/1/check/openstack-tox-docs/85f242e/html/ : SUCCESS in 5m 13s\n- openstack-helm-lint http://logs.openstack.org/22/650122/1/check/openstack-helm-lint/66a582d/ : SUCCESS in 2m 13s\n- openstack-helm-keystone http://logs.openstack.org/22/650122/1/check/openstack-helm-keystone/1e04d98/ : SUCCESS in 24m 10s\n- openstack-helm-keystone-ldap http://logs.openstack.org/22/650122/1/check/openstack-helm-keystone-ldap/edc74f8/ : SUCCESS in 23m 32s\n- openstack-helm-glance http://logs.openstack.org/22/650122/1/check/openstack-helm-glance/6187156/ : SUCCESS in 26m 10s\n- openstack-helm-heat http://logs.openstack.org/22/650122/1/check/openstack-helm-heat/1c3bb85/ : SUCCESS in 28m 49s\n- openstack-helm-cinder http://logs.openstack.org/22/650122/1/check/openstack-helm-cinder/944440d/ : SUCCESS in 41m 14s\n- openstack-helm-compute-kit http://logs.openstack.org/22/650122/1/check/openstack-helm-compute-kit/4bd5ca9/ : SUCCESS in 37m 31s","accounts_in_message":[],"_revision_number":1},{"id":"b433bb8c2968579d5f6c3711d495f39a056c7998","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-04-04 20:41:32.000000000","message":"Patch Set 1: Workflow-1\n\nsomething is still not right with the permissions as I get:\n\n \u0027pods \"nova-spiceproxy-596db8d54c-\" is forbidden: unable to validate\n against any pod security policy: [spec.securityContext.hostNetwork: Invalid\n value: true: Host network is not allowed to be used spec.initContainers[0].securityContext.hostNetwork:\n Invalid value: true: Host network is not allowed to be used spec.initContainers[1].securityContext.hostNetwork:\n Invalid value: true: Host network is not allowed to be used spec.initContainers[2].securityContext.hostNetwork:\n Invalid value: true: Host network is not allowed to be used spec.containers[0].securityContext.hostNetwork:\n Invalid value: true: Host network is not allowed to be used]\u0027\n\n\nwhen using spice and this patch. Roles and Rolebindings seem to be correct thought....","accounts_in_message":[],"_revision_number":1},{"id":"f7712b3865c82b073e893125700e0d375a677d32","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-04-05 08:09:49.000000000","message":"Patch Set 1: -Workflow\n\nlets not block this and tackle the spiceproxy thing lately as it seems to be missing some ingress rules and Im not sure if that its ok or not.","accounts_in_message":[],"_revision_number":1},{"id":"aaf7c75dd96ac48a1c6585dae5a0c371ee7618c1","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-04-07 06:41:48.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"d87cb216fd4abba2e99d1f93e05b3e97287fad13","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-07 06:41:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ded654615efaaa7875d976de46532d9b3562aeae","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-07 07:26:47.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/22/650122/1/gate/openstack-tox-docs/377e22b/html/ : SUCCESS in 5m 06s\n- openstack-helm-lint http://logs.openstack.org/22/650122/1/gate/openstack-helm-lint/8739848/ : SUCCESS in 1m 24s\n- openstack-helm-keystone http://logs.openstack.org/22/650122/1/gate/openstack-helm-keystone/af78a61/ : SUCCESS in 26m 59s\n- openstack-helm-keystone-ldap http://logs.openstack.org/22/650122/1/gate/openstack-helm-keystone-ldap/958c341/ : SUCCESS in 25m 39s\n- openstack-helm-glance http://logs.openstack.org/22/650122/1/gate/openstack-helm-glance/396ebb6/ : SUCCESS in 31m 01s\n- openstack-helm-heat http://logs.openstack.org/22/650122/1/gate/openstack-helm-heat/b9f44e0/ : SUCCESS in 22m 40s\n- openstack-helm-cinder http://logs.openstack.org/22/650122/1/gate/openstack-helm-cinder/0bcc14b/ : SUCCESS in 42m 09s\n- openstack-helm-compute-kit http://logs.openstack.org/22/650122/1/gate/openstack-helm-compute-kit/c187aae/ : SUCCESS in 41m 18s","accounts_in_message":[],"_revision_number":1},{"id":"496f49cdedb70db1c219426b238aeeeb72ba5682","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-07 07:26:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"114ff4eeba37b3de41dc1ba3aece65458247f305","revisions":{"114ff4eeba37b3de41dc1ba3aece65458247f305":{"kind":"REWORK","_number":1,"created":"2019-04-04 19:51:20.000000000","uploader":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"ref":"refs/changes/22/650122/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/22/650122/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/22/650122/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/22/650122/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/22/650122/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/22/650122/1"}}},"commit":{"parents":[{"commit":"6c71637222f47d85681038994f02feac92f75bd2","subject":"change the nova cache to dogpile.cache.memcached","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/6c71637222f47d85681038994f02feac92f75bd2"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-04-04 19:49:53.000000000","tz":120},"committer":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-04-04 19:49:53.000000000","tz":120},"subject":"Add missing dependencies for spiceproxy in values","message":"Add missing dependencies for spiceproxy in values\n\nwithout the dependencies in the values.yaml, the role and rolebinding will\nnot be created by helm-toolkit as it uses those to create and generate the\nrole/rolebinding for the accounts\n\nChange-Id: I711d5fc4a2a376a29daf526fc420790ea9cacf25\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/114ff4eeba37b3de41dc1ba3aece65458247f305"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/114ff4eeba37b3de41dc1ba3aece65458247f305"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
