)]}'
{"id":"openstack%2Fopenstack-helm~653274","triplet_id":"openstack%2Fopenstack-helm~master~I0ad97f3ed608973d7e5a4a11d87595fe258a0db5","project":"openstack/openstack-helm","branch":"master","topic":"change_ironic_api_url","hashtags":[],"change_id":"I0ad97f3ed608973d7e5a4a11d87595fe258a0db5","subject":"Change default of ironic.conductor.api_url from internal to public","status":"MERGED","created":"2019-04-17 04:12:53.000000000","updated":"2019-04-18 21:41:52.000000000","submitted":"2019-04-18 21:41:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"653274-1555623712076-61dee02a","meta_rev_id":"58312250ddffc746697484c667f39ed150f96f41","_number":653274,"virtual_id_number":653274,"owner":{"_account_id":30278,"name":"Jongmoon Kim","email":"jlego229.kim@samsung.com","username":"jlego229.kim"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":2,"date":"2019-04-18 21:41:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2019-04-18 20:22:55.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":2,"date":"2019-04-18 13:40:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-04-18 16:21:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"all":[{"value":0,"date":"2019-04-18 05:53:10.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"date":"2019-04-18 05:54:23.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":1,"date":"2019-04-18 20:22:55.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-18 05:53:10.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2019-04-18 05:54:23.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2019-04-18 13:40:16.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-04-18 16:21:01.000000000","updated_by":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"reviewer":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"state":"REVIEWER"},{"updated":"2019-04-18 20:22:55.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2019-04-18 21:41:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"be4932611a821dd08c8e30a547fb22c4db1612b5","author":{"_account_id":30278,"name":"Jongmoon Kim","email":"jlego229.kim@samsung.com","username":"jlego229.kim"},"date":"2019-04-17 04:12:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"20d97ae060d65f954140c2a95f758068793d9a76","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2019-04-17 04:13:04.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\nYour patch will now be tested automatically by OpenStack testing frameworks\nand once the automatic tests pass, it will be reviewed by other friendly\ndevelopers. They will give you feedback and may require you to refine it.\n\nPeople seldom get their patch approved on the first try, so don\u0027t be\nconcerned if requested to make corrections. Feel free to modify your patch\nand resubmit a new change-set.\n\nPatches usually take 3 to 7 days to be reviewed so be patient and be\navailable on IRC to ask and answer questions about your work. Also it\ntakes generally at least a couple of weeks for cores to get around to\nreviewing code. The more you participate in the community the more\nrewarding it is for you. You may also notice that the more you get to know\npeople and get to be known, the faster your patches will be reviewed and\neventually approved. Get to know others and become known by doing code\nreviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\nThanks again for supporting OpenStack, we look forward to working with you.\n\nIRC: https://wiki.openstack.org/wiki/IRC\nWorkflow: https://docs.openstack.org/infra/manual/developers.html\nCommit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"f55eead901fa0ba1ceb6895a1843e1ddde356d19","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-17 05:02:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/74/653274/1/check/openstack-tox-docs/6f69a69/html/ : SUCCESS in 5m 51s\n- openstack-helm-lint http://logs.openstack.org/74/653274/1/check/openstack-helm-lint/854274e/ : SUCCESS in 1m 43s\n- openstack-helm-keystone http://logs.openstack.org/74/653274/1/check/openstack-helm-keystone/3c64fbe/ : SUCCESS in 25m 37s\n- openstack-helm-keystone-ldap http://logs.openstack.org/74/653274/1/check/openstack-helm-keystone-ldap/e006201/ : SUCCESS in 24m 38s\n- openstack-helm-glance http://logs.openstack.org/74/653274/1/check/openstack-helm-glance/de6cecb/ : SUCCESS in 29m 07s\n- openstack-helm-heat http://logs.openstack.org/74/653274/1/check/openstack-helm-heat/2221374/ : SUCCESS in 26m 11s\n- openstack-helm-cinder http://logs.openstack.org/74/653274/1/check/openstack-helm-cinder/92f9042/ : SUCCESS in 38m 24s\n- openstack-helm-compute-kit http://logs.openstack.org/74/653274/1/check/openstack-helm-compute-kit/8ad74ea/ : SUCCESS in 49m 30s\n- openstack-helm-apparmor http://logs.openstack.org/74/653274/1/check/openstack-helm-apparmor/af6dacc/ : SUCCESS in 40m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"290a3a89e38af71dd28732a68de1d41c687fe7ce","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-04-18 13:40:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"950de3b29ebc1495095acf1b366999a307dc53e2","author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"date":"2019-04-18 16:21:01.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"70c58375ed252a666157cc4b1e0e5b638e8bfcfb","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2019-04-18 20:22:55.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"cde1a2c5f103f94807bb59f009dbd3faf89b7c2d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-18 20:23:07.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f39acbd2ceef94e1bf8de5f393288fa880238413","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-18 21:41:51.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/74/653274/1/gate/openstack-tox-docs/2558c7a/html/ : SUCCESS in 4m 39s\n- openstack-helm-lint http://logs.openstack.org/74/653274/1/gate/openstack-helm-lint/44c6161/ : SUCCESS in 1m 31s\n- openstack-helm-keystone http://logs.openstack.org/74/653274/1/gate/openstack-helm-keystone/97fed60/ : SUCCESS in 24m 34s\n- openstack-helm-keystone-ldap http://logs.openstack.org/74/653274/1/gate/openstack-helm-keystone-ldap/a4c0c94/ : SUCCESS in 32m 03s\n- openstack-helm-glance http://logs.openstack.org/74/653274/1/gate/openstack-helm-glance/63137c4/ : SUCCESS in 27m 38s\n- openstack-helm-heat http://logs.openstack.org/74/653274/1/gate/openstack-helm-heat/542ef64/ : SUCCESS in 24m 22s\n- openstack-helm-cinder http://logs.openstack.org/74/653274/1/gate/openstack-helm-cinder/61b8883/ : SUCCESS in 37m 33s\n- openstack-helm-compute-kit http://logs.openstack.org/74/653274/1/gate/openstack-helm-compute-kit/f47f1a7/ : SUCCESS in 42m 25s","accounts_in_message":[],"_revision_number":1},{"id":"30a1b5c127f243c1d7b35006e94f5c0ccd73d8f4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-18 21:41:52.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"65bd9a7a04d7c8eb57432a8bbaabc541bed1a472","revisions":{"65bd9a7a04d7c8eb57432a8bbaabc541bed1a472":{"kind":"REWORK","_number":1,"created":"2019-04-17 04:12:53.000000000","uploader":{"_account_id":30278,"name":"Jongmoon Kim","email":"jlego229.kim@samsung.com","username":"jlego229.kim"},"ref":"refs/changes/74/653274/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/74/653274/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/74/653274/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/74/653274/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/74/653274/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/74/653274/1"}}},"commit":{"parents":[{"commit":"f65c21de1e2867b9fdb88073a94445a399759dd1","subject":"Merge \"point to openstackhelm tempest image\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f65c21de1e2867b9fdb88073a94445a399759dd1"}]}],"author":{"name":"jlego229-kim","email":"jlego229.kim@samsung.com","date":"2019-04-17 04:08:32.000000000","tz":540},"committer":{"name":"jlego229-kim","email":"jlego229.kim@samsung.com","date":"2019-04-17 04:08:32.000000000","tz":540},"subject":"Change default of ironic.conductor.api_url from internal to public","message":"Change default of ironic.conductor.api_url from internal to public\n\nCurrently a pxe-client has to contact with ironic-api through\nit\u0027s internal endpoint during lookup() period.\n\nHowever, the pxe-client cannot access kube-dns by ifself,\nso it needs additional dns server. (or Using NodePort)\n\nWith additional dns server, it will be safer for pxe-client\nto contact with ironic-api through it\u0027s public endpoint(passing by ingress)\nrather than internal endpoint directly becuase internal pod\u0027s IPs would be changed frequently.\n\nAlso, I refered to {Values.conf.ironic.glance.swift_endpoint_url}.\n(swift is also accessed by the pxe-client and swift_url\u0027s default is public endpoint)\n\nChange-Id: I0ad97f3ed608973d7e5a4a11d87595fe258a0db5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/65bd9a7a04d7c8eb57432a8bbaabc541bed1a472"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/65bd9a7a04d7c8eb57432a8bbaabc541bed1a472"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
