)]}'
{"id":"openstack%2Fopenstack-helm~660184","triplet_id":"openstack%2Fopenstack-helm~master~Ifab508f2c3e39de69e3b1423b6aab57e333fc37e","project":"openstack/openstack-helm","branch":"master","topic":"Client\u0027s IP","hashtags":[],"change_id":"Ifab508f2c3e39de69e3b1423b6aab57e333fc37e","subject":"Horizon: Set SECURE_PROXY_ADDR_HEADER","status":"MERGED","created":"2019-05-20 17:40:49.000000000","updated":"2019-06-26 13:40:51.000000000","submitted":"2019-06-26 13:40:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"660184-1561556451714-ca750131","meta_rev_id":"e10057b05645186da9b8f83ecdfd06df7fd146ed","_number":660184,"virtual_id_number":660184,"owner":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-06-26 13:40:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-26 12:54:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":2,"date":"2019-06-26 09:11:34.000000000","_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-26 12:54:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-26 09:11:34.000000000","updated_by":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"reviewer":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"state":"REVIEWER"},{"updated":"2019-06-26 12:54:44.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-06-26 13:40:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8dd22115c2695534009dcf69314c262a2b48ed84","author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"date":"2019-05-20 17:40:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b14856ca17c9c5c681413a1dc54c4ea2378205a1","author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"date":"2019-05-20 17:41:41.000000000","message":"Topic set to Client\u0027s IP","accounts_in_message":[],"_revision_number":1},{"id":"25e08e6a4f7422d1b825246d48e20cd273d18ea5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-20 18:09:22.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/84/660184/1/check/openstack-tox-docs/1e395d8/html/ : SUCCESS in 4m 43s\n- openstack-helm-lint http://logs.openstack.org/84/660184/1/check/openstack-helm-lint/ce62b56/ : FAILURE in 1m 22s\n- openstack-helm-keystone http://logs.openstack.org/84/660184/1/check/openstack-helm-keystone/d6b2586/ : FAILURE in 13m 06s\n- openstack-helm-keystone-rocky-opensuse_15 http://logs.openstack.org/84/660184/1/check/openstack-helm-keystone-rocky-opensuse_15/6c10e1e/ : FAILURE in 12m 13s (non-voting)\n- openstack-helm-keystone-ldap http://logs.openstack.org/84/660184/1/check/openstack-helm-keystone-ldap/086bdc4/ : FAILURE in 12m 12s\n- openstack-helm-glance http://logs.openstack.org/84/660184/1/check/openstack-helm-glance/36ef4a4/ : FAILURE in 12m 45s\n- openstack-helm-glance-rocky-opensuse_15 http://logs.openstack.org/84/660184/1/check/openstack-helm-glance-rocky-opensuse_15/3833bef/ : FAILURE in 12m 34s (non-voting)\n- openstack-helm-heat http://logs.openstack.org/84/660184/1/check/openstack-helm-heat/a2375d7/ : FAILURE in 12m 28s\n- openstack-helm-heat-rocky-opensuse_15 http://logs.openstack.org/84/660184/1/check/openstack-helm-heat-rocky-opensuse_15/e8baa95/ : FAILURE in 12m 04s (non-voting)\n- openstack-helm-cinder http://logs.openstack.org/84/660184/1/check/openstack-helm-cinder/7bda453/ : FAILURE in 12m 35s\n- openstack-helm-cinder-rocky-opensuse_15 http://logs.openstack.org/84/660184/1/check/openstack-helm-cinder-rocky-opensuse_15/67b5313/ : FAILURE in 12m 14s (non-voting)\n- openstack-helm-compute-kit http://logs.openstack.org/84/660184/1/check/openstack-helm-compute-kit/3c3b50f/ : FAILURE in 12m 37s\n- openstack-helm-compute-kit-rocky-opensuse_15 http://logs.openstack.org/84/660184/1/check/openstack-helm-compute-kit-rocky-opensuse_15/0d70e23/ : FAILURE in 10m 54s (non-voting)\n- openstack-helm-apparmor http://logs.openstack.org/84/660184/1/check/openstack-helm-apparmor/d47b229/ : FAILURE in 14m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b2ad922d77adcfda1f35be04b26cc0ee034b0aa7","author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"date":"2019-05-20 19:19:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8f0ffc2c250f6b22ca2522e5acb4cd6329c9279e","author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"date":"2019-05-20 19:21:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"45045f1180d2be367b9000a89e68d1876d27c4de","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-20 20:13:46.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/84/660184/3/check/openstack-tox-docs/5333fe8/html/ : SUCCESS in 4m 42s\n- openstack-helm-lint http://logs.openstack.org/84/660184/3/check/openstack-helm-lint/bee1ada/ : SUCCESS in 1m 23s\n- openstack-helm-keystone http://logs.openstack.org/84/660184/3/check/openstack-helm-keystone/3a90b9d/ : SUCCESS in 20m 38s\n- openstack-helm-keystone-rocky-opensuse_15 http://logs.openstack.org/84/660184/3/check/openstack-helm-keystone-rocky-opensuse_15/6aef6a5/ : SUCCESS in 24m 07s (non-voting)\n- openstack-helm-keystone-ldap http://logs.openstack.org/84/660184/3/check/openstack-helm-keystone-ldap/46e498f/ : SUCCESS in 22m 15s\n- openstack-helm-glance http://logs.openstack.org/84/660184/3/check/openstack-helm-glance/381d650/ : SUCCESS in 23m 11s\n- openstack-helm-glance-rocky-opensuse_15 http://logs.openstack.org/84/660184/3/check/openstack-helm-glance-rocky-opensuse_15/2943084/ : SUCCESS in 23m 28s (non-voting)\n- openstack-helm-heat http://logs.openstack.org/84/660184/3/check/openstack-helm-heat/1b3545d/ : SUCCESS in 23m 32s\n- openstack-helm-heat-rocky-opensuse_15 http://logs.openstack.org/84/660184/3/check/openstack-helm-heat-rocky-opensuse_15/bf8ffbe/ : SUCCESS in 19m 27s (non-voting)\n- openstack-helm-cinder http://logs.openstack.org/84/660184/3/check/openstack-helm-cinder/ebea682/ : SUCCESS in 37m 36s\n- openstack-helm-cinder-rocky-opensuse_15 http://logs.openstack.org/84/660184/3/check/openstack-helm-cinder-rocky-opensuse_15/93d6568/ : SUCCESS in 33m 32s (non-voting)\n- openstack-helm-compute-kit http://logs.openstack.org/84/660184/3/check/openstack-helm-compute-kit/f3498d9/ : SUCCESS in 36m 50s\n- openstack-helm-compute-kit-rocky-opensuse_15 http://logs.openstack.org/84/660184/3/check/openstack-helm-compute-kit-rocky-opensuse_15/d6d3abd/ : SUCCESS in 44m 49s (non-voting)\n- openstack-helm-apparmor http://logs.openstack.org/84/660184/3/check/openstack-helm-apparmor/ef5a8ba/ : SUCCESS in 33m 35s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"7e1fa79ddada88493370816eb31c0ef1b68f1cd6","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-06-26 09:11:34.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"3411ba33a9bfa33e5618f9cce1afd907aa2a7616","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-06-26 12:54:44.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"3f15b222929b5ff692f19dcffcccf17dbe4afc37","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-26 12:54:57.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"c9ba9c6fc6f9f61df3cc3af1ef7422e355048bcc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-26 13:40:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"e10057b05645186da9b8f83ecdfd06df7fd146ed","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-26 13:40:51.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/84/660184/3/gate/openstack-tox-docs/b15649e/html/ : SUCCESS in 3m 48s\n- openstack-helm-lint http://logs.openstack.org/84/660184/3/gate/openstack-helm-lint/50f4b3e/ : SUCCESS in 1m 28s\n- openstack-helm-cinder http://logs.openstack.org/84/660184/3/gate/openstack-helm-cinder/01b1a5d/ : SUCCESS in 33m 03s\n- openstack-helm-compute-kit http://logs.openstack.org/84/660184/3/gate/openstack-helm-compute-kit/49c81ad/ : SUCCESS in 38m 39s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0d1e01ee3d26f9b1c51643b688f8a619c96a20fb","revisions":{"befb88d04df3a9d443ed31cb69b85754d4231e55":{"kind":"REWORK","_number":1,"created":"2019-05-20 17:40:49.000000000","uploader":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"ref":"refs/changes/84/660184/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/84/660184/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/1"}}},"commit":{"parents":[{"commit":"f8adab245b3ee9c9e3767f6ff6127879a2bdfd3f","subject":"Merge \"Point to OSH-images images\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f8adab245b3ee9c9e3767f6ff6127879a2bdfd3f"}]}],"author":{"name":"sg774j","email":"sg774j@att.com","date":"2019-05-20 17:37:41.000000000","tz":-300},"committer":{"name":"sg774j","email":"sg774j@att.com","date":"2019-05-20 17:40:37.000000000","tz":-300},"subject":"Horizon: Set SECURE_PROXY_ADDR_HEADER","message":"Horizon: Set SECURE_PROXY_ADDR_HEADER\n\nSetting this to HTTP_X_FORWARDED_FOR will display the IP in\nX-Forwarded-For header instead of REMOTE_ADDR. This is to display\nclient\u0027s IP.\n\nChange-Id: Ifab508f2c3e39de69e3b1423b6aab57e333fc37e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/befb88d04df3a9d443ed31cb69b85754d4231e55"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/befb88d04df3a9d443ed31cb69b85754d4231e55"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f8adab245b3ee9c9e3767f6ff6127879a2bdfd3f","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"d583620561eb6005347fff4222ec8e847c615ca9":{"kind":"REWORK","_number":2,"created":"2019-05-20 19:19:31.000000000","uploader":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"ref":"refs/changes/84/660184/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/84/660184/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/2"}}},"commit":{"parents":[{"commit":"f8adab245b3ee9c9e3767f6ff6127879a2bdfd3f","subject":"Merge \"Point to OSH-images images\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f8adab245b3ee9c9e3767f6ff6127879a2bdfd3f"}]}],"author":{"name":"sg774j","email":"sg774j@att.com","date":"2019-05-20 17:37:41.000000000","tz":-300},"committer":{"name":"sg774j","email":"sg774j@att.com","date":"2019-05-20 19:19:05.000000000","tz":-300},"subject":"Horizon: Set SECURE_PROXY_ADDR_HEADER","message":"Horizon: Set SECURE_PROXY_ADDR_HEADER\n\nSetting this to HTTP_X_FORWARDED_FOR will display the IP in\nX-Forwarded-For header instead of REMOTE_ADDR. This is to display\nclient\u0027s IP.\n\nChange-Id: Ifab508f2c3e39de69e3b1423b6aab57e333fc37e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d583620561eb6005347fff4222ec8e847c615ca9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d583620561eb6005347fff4222ec8e847c615ca9"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f8adab245b3ee9c9e3767f6ff6127879a2bdfd3f","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"0d1e01ee3d26f9b1c51643b688f8a619c96a20fb":{"kind":"REWORK","_number":3,"created":"2019-05-20 19:21:02.000000000","uploader":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"ref":"refs/changes/84/660184/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/84/660184/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/84/660184/3"}}},"commit":{"parents":[{"commit":"f8adab245b3ee9c9e3767f6ff6127879a2bdfd3f","subject":"Merge \"Point to OSH-images images\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f8adab245b3ee9c9e3767f6ff6127879a2bdfd3f"}]}],"author":{"name":"sg774j","email":"sg774j@att.com","date":"2019-05-20 17:37:41.000000000","tz":-300},"committer":{"name":"sg774j","email":"sg774j@att.com","date":"2019-05-20 19:20:53.000000000","tz":-300},"subject":"Horizon: Set SECURE_PROXY_ADDR_HEADER","message":"Horizon: Set SECURE_PROXY_ADDR_HEADER\n\nSetting this to HTTP_X_FORWARDED_FOR will display the IP in\nX-Forwarded-For header instead of REMOTE_ADDR. This is to display\nclient\u0027s IP.\n\nChange-Id: Ifab508f2c3e39de69e3b1423b6aab57e333fc37e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/0d1e01ee3d26f9b1c51643b688f8a619c96a20fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/0d1e01ee3d26f9b1c51643b688f8a619c96a20fb"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f8adab245b3ee9c9e3767f6ff6127879a2bdfd3f","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}