)]}'
{"id":"openstack%2Fopenstack-helm~661722","triplet_id":"openstack%2Fopenstack-helm~master~Ifb8e5050d9fbcd7e5b40b2a5dcb4a2ce384ca195","project":"openstack/openstack-helm","branch":"master","topic":"glance_storage_pool","hashtags":[],"change_id":"Ifb8e5050d9fbcd7e5b40b2a5dcb4a2ce384ca195","subject":"glance: allow configuring the rbd app name","status":"MERGED","created":"2019-05-28 11:09:16.000000000","updated":"2019-05-30 01:56:10.000000000","submitted":"2019-05-29 21:08:38.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"661722-1559164118861-e94487ec","meta_rev_id":"9552f3f145b13c581e8e4bc07f0e64b424bda43d","_number":661722,"virtual_id_number":661722,"owner":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-05-28 15:50:30.000000000","_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"date":"2019-05-29 08:36:49.000000000","_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},{"value":2,"date":"2019-05-29 21:08:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"all":[{"value":0,"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},{"value":2,"date":"2019-05-29 20:26:02.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":2,"date":"2019-05-29 20:17:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"all":[{"value":0,"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},{"value":1,"date":"2019-05-29 20:26:02.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-28 11:37:47.000000000","updated_by":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"reviewer":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"state":"REVIEWER"},{"updated":"2019-05-28 15:50:30.000000000","updated_by":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"reviewer":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"state":"REVIEWER"},{"updated":"2019-05-29 20:17:14.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-05-29 20:26:02.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2019-05-29 21:08:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4ed1ccb83363f5484e4d8c3c7a8fc0e3cc13e279","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-05-28 11:09:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2824c11a0681053e70f80d0037a3396a0ff850f0","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-05-28 11:10:01.000000000","message":"Topic changed from cinder_storage_pool to glance_storage_pool","accounts_in_message":[],"_revision_number":1},{"id":"ca7669c2385ddcea3fe75d956f55e020b75d54f1","author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"date":"2019-05-28 11:37:47.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f5364054a3d0bb587fceb81bf8729b23bf3c7032","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-28 12:09:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/22/661722/1/check/openstack-tox-docs/5215332/html/ : SUCCESS in 8m 57s\n- openstack-helm-lint http://logs.openstack.org/22/661722/1/check/openstack-helm-lint/cef205b/ : SUCCESS in 1m 33s\n- openstack-helm-keystone http://logs.openstack.org/22/661722/1/check/openstack-helm-keystone/4d6ff14/ : SUCCESS in 19m 29s\n- openstack-helm-keystone-rocky-opensuse_15 http://logs.openstack.org/22/661722/1/check/openstack-helm-keystone-rocky-opensuse_15/6ab5d70/ : SUCCESS in 22m 48s (non-voting)\n- openstack-helm-keystone-ldap http://logs.openstack.org/22/661722/1/check/openstack-helm-keystone-ldap/bc5e454/ : SUCCESS in 19m 43s\n- openstack-helm-glance http://logs.openstack.org/22/661722/1/check/openstack-helm-glance/37da7f2/ : SUCCESS in 22m 09s\n- openstack-helm-glance-rocky-opensuse_15 http://logs.openstack.org/22/661722/1/check/openstack-helm-glance-rocky-opensuse_15/2e6e8a6/ : SUCCESS in 27m 51s (non-voting)\n- openstack-helm-heat http://logs.openstack.org/22/661722/1/check/openstack-helm-heat/541635b/ : SUCCESS in 21m 16s\n- openstack-helm-heat-rocky-opensuse_15 http://logs.openstack.org/22/661722/1/check/openstack-helm-heat-rocky-opensuse_15/616ea0a/ : SUCCESS in 20m 37s (non-voting)\n- openstack-helm-cinder http://logs.openstack.org/22/661722/1/check/openstack-helm-cinder/ca9f915/ : SUCCESS in 30m 07s\n- openstack-helm-cinder-rocky-opensuse_15 http://logs.openstack.org/22/661722/1/check/openstack-helm-cinder-rocky-opensuse_15/3ab5ccf/ : SUCCESS in 38m 28s (non-voting)\n- openstack-helm-compute-kit http://logs.openstack.org/22/661722/1/check/openstack-helm-compute-kit/809257a/ : SUCCESS in 30m 39s\n- openstack-helm-compute-kit-rocky-opensuse_15 http://logs.openstack.org/22/661722/1/check/openstack-helm-compute-kit-rocky-opensuse_15/ee03eff/ : SUCCESS in 39m 48s (non-voting)\n- openstack-helm-apparmor http://logs.openstack.org/22/661722/1/check/openstack-helm-apparmor/c2f3a8d/ : SUCCESS in 33m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"339c76bc4c96efcee7b95a13aacefd059b6dee2d","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-05-28 12:32:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3327e0e84785ceae17a9f0aa69d7df193af99372","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-28 13:34:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/22/661722/2/check/openstack-tox-docs/aea3030/html/ : SUCCESS in 4m 53s\n- openstack-helm-lint http://logs.openstack.org/22/661722/2/check/openstack-helm-lint/51f9c36/ : SUCCESS in 1m 34s\n- openstack-helm-keystone http://logs.openstack.org/22/661722/2/check/openstack-helm-keystone/6f2f892/ : SUCCESS in 19m 03s\n- openstack-helm-keystone-rocky-opensuse_15 http://logs.openstack.org/22/661722/2/check/openstack-helm-keystone-rocky-opensuse_15/1312762/ : SUCCESS in 19m 31s (non-voting)\n- openstack-helm-keystone-ldap http://logs.openstack.org/22/661722/2/check/openstack-helm-keystone-ldap/f20a608/ : SUCCESS in 19m 36s\n- openstack-helm-glance http://logs.openstack.org/22/661722/2/check/openstack-helm-glance/8e91f64/ : SUCCESS in 21m 30s\n- openstack-helm-glance-rocky-opensuse_15 http://logs.openstack.org/22/661722/2/check/openstack-helm-glance-rocky-opensuse_15/ca5f0f2/ : SUCCESS in 22m 20s (non-voting)\n- openstack-helm-heat http://logs.openstack.org/22/661722/2/check/openstack-helm-heat/786a8b3/ : SUCCESS in 20m 14s\n- openstack-helm-heat-rocky-opensuse_15 http://logs.openstack.org/22/661722/2/check/openstack-helm-heat-rocky-opensuse_15/2209736/ : SUCCESS in 24m 28s (non-voting)\n- openstack-helm-cinder http://logs.openstack.org/22/661722/2/check/openstack-helm-cinder/f495d86/ : SUCCESS in 38m 05s\n- openstack-helm-cinder-rocky-opensuse_15 http://logs.openstack.org/22/661722/2/check/openstack-helm-cinder-rocky-opensuse_15/8559d24/ : SUCCESS in 35m 38s (non-voting)\n- openstack-helm-compute-kit http://logs.openstack.org/22/661722/2/check/openstack-helm-compute-kit/ed2020a/ : SUCCESS in 36m 09s\n- openstack-helm-compute-kit-rocky-opensuse_15 http://logs.openstack.org/22/661722/2/check/openstack-helm-compute-kit-rocky-opensuse_15/a2c7335/ : SUCCESS in 42m 51s (non-voting)\n- openstack-helm-apparmor http://logs.openstack.org/22/661722/2/check/openstack-helm-apparmor/20abc2a/ : SUCCESS in 35m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e4baa7ee2ec8849fa993cf8eb6e9d24730d74a9f","author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"date":"2019-05-28 15:50:30.000000000","message":"Patch Set 2:\n\nIn most cases, I always prefer to use the default well known names instead of customizing the names. Would you mind telling your real usecase?","accounts_in_message":[],"_revision_number":2},{"id":"0dc6da0869a78db33f7066659ed6124ab8d35433","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-05-29 08:36:49.000000000","message":"Patch Set 2:\n\n\u003e In most cases, I always prefer to use the default well known names instead of customizing the names. Would you mind telling your real usecase?\n\nThe main usecase here is having an existing ceph cluster with pre-made pools+app names. The same way we let users override the pool names to provide their own for a variety of reasons (name change, pre existing pools) we should allow changing the app name. Especailyl becuase after reading about it, the app name seems to be nothing but a label that gets assigned to the pool, something like a tag and has no toher purpose that I can see.","accounts_in_message":[],"_revision_number":2},{"id":"6db32ca210ec4c4aaca7431ceb7dc5071c346d13","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-05-29 20:17:14.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"97c03933fd322148fafe8fff8cf0f6eb2996b493","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2019-05-29 20:26:02.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"1b4fae347d9faf7db0ead5a0cb7142ac559ce43c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-29 20:26:14.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"674455bf3ba2c703580094ea3582745d59eff00c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-29 21:08:38.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/22/661722/2/gate/openstack-tox-docs/d19d7d3/html/ : SUCCESS in 5m 08s\n- openstack-helm-lint http://logs.openstack.org/22/661722/2/gate/openstack-helm-lint/62e328c/ : SUCCESS in 1m 59s\n- openstack-helm-keystone http://logs.openstack.org/22/661722/2/gate/openstack-helm-keystone/4231077/ : SUCCESS in 18m 46s\n- openstack-helm-keystone-ldap http://logs.openstack.org/22/661722/2/gate/openstack-helm-keystone-ldap/e3b18f4/ : SUCCESS in 18m 41s\n- openstack-helm-glance http://logs.openstack.org/22/661722/2/gate/openstack-helm-glance/18e30dc/ : SUCCESS in 20m 52s\n- openstack-helm-heat http://logs.openstack.org/22/661722/2/gate/openstack-helm-heat/a2621d1/ : SUCCESS in 20m 43s\n- openstack-helm-cinder http://logs.openstack.org/22/661722/2/gate/openstack-helm-cinder/8d6a175/ : SUCCESS in 33m 22s\n- openstack-helm-compute-kit http://logs.openstack.org/22/661722/2/gate/openstack-helm-compute-kit/8c5381d/ : SUCCESS in 34m 35s","accounts_in_message":[],"_revision_number":2},{"id":"0d44285b66c127d0731c2b9fc1bb6e82834c99af","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-29 21:08:38.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"9552f3f145b13c581e8e4bc07f0e64b424bda43d","author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"date":"2019-05-30 01:56:10.000000000","message":"Patch Set 2:\n\n\u003e The main usecase here is having an existing ceph cluster with\n \u003e pre-made pools+app names. The same way we let users override the\n \u003e pool names to provide their own for a variety of reasons (name\n \u003e change, pre existing pools) we should allow changing the app name.\n \u003e Especailyl becuase after reading about it, the app name seems to be\n \u003e nothing but a label that gets assigned to the pool, something like\n \u003e a tag and has no toher purpose that I can see.\n\nIt makes sense to me. Sorry for late reply...","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d1e5fb3f921290ed3da2d7e21f71fa15898a7ebf","revisions":{"567d140a1173c6f4cad3fb4d0ad23c16609a30ec":{"kind":"REWORK","_number":1,"created":"2019-05-28 11:09:16.000000000","uploader":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"ref":"refs/changes/22/661722/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/22/661722/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/22/661722/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/22/661722/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/22/661722/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/22/661722/1"}}},"commit":{"parents":[{"commit":"11d76bb08316d966ee1509fd1b6cc6b6091ce3be","subject":"Merge \"Keystone: Enable Proxy Header Parsing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/11d76bb08316d966ee1509fd1b6cc6b6091ce3be"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-05-28 11:08:35.000000000","tz":120},"committer":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-05-28 11:08:35.000000000","tz":120},"subject":"glance: allow configuring the rdb app name","message":"glance: allow configuring the rdb app name\n\nInstead of hardcoding it, let us override it with\nvalues\n\nChange-Id: Ifb8e5050d9fbcd7e5b40b2a5dcb4a2ce384ca195\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/567d140a1173c6f4cad3fb4d0ad23c16609a30ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/567d140a1173c6f4cad3fb4d0ad23c16609a30ec"}]},"branch":"refs/heads/master"},"d1e5fb3f921290ed3da2d7e21f71fa15898a7ebf":{"kind":"REWORK","_number":2,"created":"2019-05-28 12:32:26.000000000","uploader":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"ref":"refs/changes/22/661722/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/22/661722/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/22/661722/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/22/661722/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/22/661722/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/22/661722/2"}}},"commit":{"parents":[{"commit":"11d76bb08316d966ee1509fd1b6cc6b6091ce3be","subject":"Merge \"Keystone: Enable Proxy Header Parsing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/11d76bb08316d966ee1509fd1b6cc6b6091ce3be"}]}],"author":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-05-28 11:08:35.000000000","tz":120},"committer":{"name":"Itxaka","email":"igarcia@suse.com","date":"2019-05-28 12:32:08.000000000","tz":120},"subject":"glance: allow configuring the rbd app name","message":"glance: allow configuring the rbd app name\n\nInstead of hardcoding it, let us override it with\nvalues\n\nChange-Id: Ifb8e5050d9fbcd7e5b40b2a5dcb4a2ce384ca195\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d1e5fb3f921290ed3da2d7e21f71fa15898a7ebf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d1e5fb3f921290ed3da2d7e21f71fa15898a7ebf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}