)]}'
{"nova/templates/bin/_nova-placement-api.sh.tpl":[{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"aba1104b5b97ba06d8bad11a3d926dacd48274db","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  if [ -f /etc/apache2/envvars ]; then"},{"line_number":27,"context_line":"     # Loading Apache2 ENV variables"},{"line_number":28,"context_line":"     source /etc/apache2/envvars"},{"line_number":29,"context_line":"# The directory below have to be created due to the fact that"},{"line_number":30,"context_line":"# libapache2-mod-wsgi-py3 doesn\u0027t create it in contrary by libapache2-mod-wsgi"},{"line_number":31,"context_line":"     if [ ! -d ${APACHE_RUN_DIR} ]; then"},{"line_number":32,"context_line":"        mkdir ${APACHE_RUN_DIR}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"bfb3d3c7_6ed25dd3","line":29,"updated":"2019-05-31 10:19:10.000000000","message":"Could you please fix the indenting?\n\nAlso, \"has to be created\"","commit_id":"38c308c9372ee9803cfab56e7fca5bfedefc8f96"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"91d80a098f2ccda0f0029a242577bed817696192","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  if [ -f /etc/apache2/envvars ]; then"},{"line_number":27,"context_line":"     # Loading Apache2 ENV variables"},{"line_number":28,"context_line":"     source /etc/apache2/envvars"},{"line_number":29,"context_line":"# The directory below have to be created due to the fact that"},{"line_number":30,"context_line":"# libapache2-mod-wsgi-py3 doesn\u0027t create it in contrary by libapache2-mod-wsgi"},{"line_number":31,"context_line":"     if [ ! -d ${APACHE_RUN_DIR} ]; then"},{"line_number":32,"context_line":"        mkdir ${APACHE_RUN_DIR}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"bfb3d3c7_cea90924","line":29,"in_reply_to":"bfb3d3c7_6ed25dd3","updated":"2019-05-31 10:25:23.000000000","message":"Done","commit_id":"38c308c9372ee9803cfab56e7fca5bfedefc8f96"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"aba1104b5b97ba06d8bad11a3d926dacd48274db","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     source /etc/apache2/envvars"},{"line_number":29,"context_line":"# The directory below have to be created due to the fact that"},{"line_number":30,"context_line":"# libapache2-mod-wsgi-py3 doesn\u0027t create it in contrary by libapache2-mod-wsgi"},{"line_number":31,"context_line":"     if [ ! -d ${APACHE_RUN_DIR} ]; then"},{"line_number":32,"context_line":"        mkdir ${APACHE_RUN_DIR}"},{"line_number":33,"context_line":"     fi"},{"line_number":34,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"bfb3d3c7_2ed8e5ec","line":31,"updated":"2019-05-31 10:19:10.000000000","message":"What about \"mkdir -p ${APACHE_RUN_DIR}\" ? Then you can skip the check for existence","commit_id":"38c308c9372ee9803cfab56e7fca5bfedefc8f96"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"0ceac9ac7270057821d0a1be75da399776280905","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     source /etc/apache2/envvars"},{"line_number":29,"context_line":"# The directory below have to be created due to the fact that"},{"line_number":30,"context_line":"# libapache2-mod-wsgi-py3 doesn\u0027t create it in contrary by libapache2-mod-wsgi"},{"line_number":31,"context_line":"     if [ ! -d ${APACHE_RUN_DIR} ]; then"},{"line_number":32,"context_line":"        mkdir ${APACHE_RUN_DIR}"},{"line_number":33,"context_line":"     fi"},{"line_number":34,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"bfb3d3c7_113e60c0","line":31,"in_reply_to":"bfb3d3c7_0e7961c6","updated":"2019-05-31 10:36:46.000000000","message":"Right, good point","commit_id":"38c308c9372ee9803cfab56e7fca5bfedefc8f96"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"91d80a098f2ccda0f0029a242577bed817696192","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     source /etc/apache2/envvars"},{"line_number":29,"context_line":"# The directory below have to be created due to the fact that"},{"line_number":30,"context_line":"# libapache2-mod-wsgi-py3 doesn\u0027t create it in contrary by libapache2-mod-wsgi"},{"line_number":31,"context_line":"     if [ ! -d ${APACHE_RUN_DIR} ]; then"},{"line_number":32,"context_line":"        mkdir ${APACHE_RUN_DIR}"},{"line_number":33,"context_line":"     fi"},{"line_number":34,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"bfb3d3c7_0e7961c6","line":31,"in_reply_to":"bfb3d3c7_2ed8e5ec","updated":"2019-05-31 10:25:23.000000000","message":"The check checks not only existence for a directory and whether variable is defined to avoid breaking the init container.","commit_id":"38c308c9372ee9803cfab56e7fca5bfedefc8f96"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"494d801291b6477d35220b2afb19ad60cc1963d8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"     # The directory below has to be created due to the fact that"},{"line_number":30,"context_line":"     # libapache2-mod-wsgi-py3 doesn\u0027t create it in contrary by libapache2-mod-wsgi"},{"line_number":31,"context_line":"     if [ ! -d ${APACHE_RUN_DIR} ]; then"},{"line_number":32,"context_line":"        mkdir ${APACHE_RUN_DIR}"},{"line_number":33,"context_line":"     fi"},{"line_number":34,"context_line":"  fi"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":4,"id":"9fb8cfa7_a63ea888","line":32,"range":{"start_line":32,"start_character":9,"end_line":32,"end_character":15},"updated":"2019-06-09 04:24:12.000000000","message":"do we want to use mkdir -p just in case?","commit_id":"84892ab20184c36583d0343bbcb9290ada1b6fdd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"22380a172581d57bb2ca29bedd7dc9f8df81682d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"     # The directory below has to be created due to the fact that"},{"line_number":30,"context_line":"     # libapache2-mod-wsgi-py3 doesn\u0027t create it in contrary by libapache2-mod-wsgi"},{"line_number":31,"context_line":"     if [ ! -d ${APACHE_RUN_DIR} ]; then"},{"line_number":32,"context_line":"        mkdir ${APACHE_RUN_DIR}"},{"line_number":33,"context_line":"     fi"},{"line_number":34,"context_line":"  fi"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":4,"id":"9fb8cfa7_9968871d","line":32,"range":{"start_line":32,"start_character":9,"end_line":32,"end_character":15},"in_reply_to":"9fb8cfa7_a63ea888","updated":"2019-06-11 09:17:22.000000000","message":"agreed.","commit_id":"84892ab20184c36583d0343bbcb9290ada1b6fdd"}]}
