)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"03102ca72854d672b2c3d99362b6123c20f62188","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Exposed job-run-tests template\u0027s backoffLimit and restartPolicy in chart"},{"line_number":8,"context_line":"values.yaml, and set default values to 0 and Never, respectively. This"},{"line_number":9,"context_line":"is to prevent the test pod from being deleted before logs can be"},{"line_number":10,"context_line":"retrieved in the event that any tempest tests fail."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0cb0b82fb7f1eff0139a2917b5323eee57eed97a"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_99bb39e4","line":10,"updated":"2019-06-03 07:41:54.000000000","message":"Could you please update the commit message so it follows the usual rules, e.i. a summmary in one sentence, and then the explanation?","commit_id":"5995f0946a19d8cdb0d5261e8fd699597b6dd86b"}],"tempest/templates/job-run-tests.yaml":[{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"03102ca72854d672b2c3d99362b6123c20f62188","unresolved":false,"context_lines":[{"line_number":35,"context_line":"{{ tuple $envAll \"tempest\" \"run-tests\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":36,"context_line":"    spec:"},{"line_number":37,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":38,"context_line":"      restartPolicy: {{ .Values.spec.template.spec.restart_policy }}"},{"line_number":39,"context_line":"      nodeSelector:"},{"line_number":40,"context_line":"        {{ .Values.labels.job.node_selector_key }}: {{ .Values.labels.job.node_selector_value }}"},{"line_number":41,"context_line":"      initContainers:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_19942944","line":38,"updated":"2019-06-03 07:41:54.000000000","message":"This sounds reasonable, but what if the pod fails for some different reason than the tempest run failure?","commit_id":"5995f0946a19d8cdb0d5261e8fd699597b6dd86b"}],"tempest/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"103683ee69f7bf2481cc61b8ffe3c226ba3d3b72","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      - dep_check"},{"line_number":36,"context_line":"      - image_repo_sync"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"spec:"},{"line_number":39,"context_line":"  backoff_limit: 6"},{"line_number":40,"context_line":"  template:"},{"line_number":41,"context_line":"    spec:"},{"line_number":42,"context_line":"      restart_policy: OnFailure"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"pod:"},{"line_number":45,"context_line":"  user:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_18c65a69","line":42,"range":{"start_line":38,"start_character":0,"end_line":42,"end_character":31},"updated":"2019-06-03 16:06:40.000000000","message":"This needs to be put under a jobs: key instead of a spec: key, to bring it in line with the other charts that expose these values.  See: https://github.com/openstack/openstack-helm-infra/blob/master/mariadb/values.yaml#L246-L254","commit_id":"283f430f670d2639e899db6072a245d5437290d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"d1cea4a03f4d564de1aafc5b26a7b1fc10b99e23","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"jobs:"},{"line_number":39,"context_line":"  run_tests:"},{"line_number":40,"context_line":"    backoff_limit: 6"},{"line_number":41,"context_line":"    restart_policy: OnFailure"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"pod:"},{"line_number":44,"context_line":"  user:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_b1308909","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":29},"updated":"2019-06-03 19:14:38.000000000","message":"Sorry I missed this previously -- can we define the keys with the same camelCase as the yaml keys in the pod spec, similar to the mariadb link previously (ie: backoffLimit, restartPolicy)?  This will help us maintain consistency","commit_id":"0af3cd3694819d69f91ac030d3d616195c30bcf9"}]}