)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"7310247617b2718e5d6fa21f046ab5de85a0d30e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     OlegBravo \u003coleg.bravo.ru@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-01 17:26:21 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add TungstenFabric compatibility to charts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The charts changes are required for deployment of various clouds based on Tungsten Fabric SDN. Right now it\u0027s tested for Airship-in-a-bottle."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_979bbdc6","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":42},"updated":"2019-08-28 04:52:31.000000000","message":"perhaps\n\n[neutron] Add TungstenFabric compatibility","commit_id":"6dc9aea0dcef42d120effb92ce9b565cdf37e7ae"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"4f93686d1b1acb7a1e46996238a9a52236029144","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add TungstenFabric compatibility to charts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The charts changes are required for deployment of various clouds based on Tungsten Fabric SDN. Right now it\u0027s tested for Airship-in-a-bottle."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The code cannot be tested currently in OpenStack Helm project because of absence of tests and platform for that."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_d8ddfa13","line":9,"updated":"2019-08-27 11:09:22.000000000","message":"Please, wrap lines in commit message. Thank you.","commit_id":"6dc9aea0dcef42d120effb92ce9b565cdf37e7ae"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"4f93686d1b1acb7a1e46996238a9a52236029144","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The charts changes are required for deployment of various clouds based on Tungsten Fabric SDN. Right now it\u0027s tested for Airship-in-a-bottle."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The code cannot be tested currently in OpenStack Helm project because of absence of tests and platform for that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patchset doesn\u0027t have Heat-related changes, they\u0027ll be added later."},{"line_number":14,"context_line":"Change-Id: I73f2ced2b09dbb93146334b59fe4571fa13dbfb0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_d8065a86","line":11,"updated":"2019-08-27 11:09:22.000000000","message":"Would you create a new change with gate tests needed? Please, create it and add Depends-On to it\u0027s commit message.","commit_id":"6dc9aea0dcef42d120effb92ce9b565cdf37e7ae"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"7310247617b2718e5d6fa21f046ab5de85a0d30e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add TungstenFabric compatibility to charts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The charts changes are required for deployment of various clouds based on Tungsten Fabric SDN. Right now it\u0027s tested for Airship-in-a-bottle."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The code cannot be tested currently in OpenStack Helm project because of absence of tests and platform for that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patchset doesn\u0027t have Heat-related changes, they\u0027ll be added later."},{"line_number":14,"context_line":"Change-Id: I73f2ced2b09dbb93146334b59fe4571fa13dbfb0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_f7ab11d4","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":9},"updated":"2019-08-28 04:52:31.000000000","message":"i think a more terse comment here is fine if you prefer, clearly there will be follow up changes where you can add more commentary","commit_id":"6dc9aea0dcef42d120effb92ce9b565cdf37e7ae"},{"author":{"_account_id":30551,"name":"Oleg Bravo","email":"oleg.bravo.ru@gmail.com","username":"olegbravo"},"change_message_id":"7eaccead83a647daa88c234974ba17f0b1b06006","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The charts changes are required for deployment of various clouds based on Tungsten Fabric SDN. Right now it\u0027s tested for Airship-in-a-bottle."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The code cannot be tested currently in OpenStack Helm project because of absence of tests and platform for that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patchset doesn\u0027t have Heat-related changes, they\u0027ll be added later."},{"line_number":14,"context_line":"Change-Id: I73f2ced2b09dbb93146334b59fe4571fa13dbfb0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_c70951dc","line":11,"in_reply_to":"7faddb67_d8065a86","updated":"2019-08-30 15:40:03.000000000","message":"Tests would be done after commiting","commit_id":"6dc9aea0dcef42d120effb92ce9b565cdf37e7ae"},{"author":{"_account_id":30551,"name":"Oleg Bravo","email":"oleg.bravo.ru@gmail.com","username":"olegbravo"},"change_message_id":"7eaccead83a647daa88c234974ba17f0b1b06006","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add TungstenFabric compatibility to charts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The charts changes are required for deployment of various clouds based on Tungsten Fabric SDN. Right now it\u0027s tested for Airship-in-a-bottle."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The code cannot be tested currently in OpenStack Helm project because of absence of tests and platform for that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patchset doesn\u0027t have Heat-related changes, they\u0027ll be added later."},{"line_number":14,"context_line":"Change-Id: I73f2ced2b09dbb93146334b59fe4571fa13dbfb0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_c7b2b196","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":9},"in_reply_to":"7faddb67_f7ab11d4","updated":"2019-08-30 15:40:03.000000000","message":"Done","commit_id":"6dc9aea0dcef42d120effb92ce9b565cdf37e7ae"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"86e4c815a4d510bddb2e4f3ead5d3002318c337e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-03-16 10:37:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add TungstenFabric compatibility to charts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The charts changes are required for deployment of various clouds based on Tungsten Fabric SDN. Right now it\u0027s tested for Airship-in-a-bottle."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The code cannot be tested currently in OpenStack Helm project because of absence of tests and platform for that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patchset doesn\u0027t have Heat-related changes, they\u0027ll be added later."},{"line_number":14,"context_line":"Change-Id: I73f2ced2b09dbb93146334b59fe4571fa13dbfb0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"1fa4df85_8e161149","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":4},"updated":"2020-03-20 04:06:55.000000000","message":"wrap lines","commit_id":"3ca273b732f54a0acef7e9763f5300e5f05dc9f1"}],"doc/source/install/developer/deploy-with-tungsten-fabric.rst":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"01c22e57fc379545296fc8e300f4889dae8e2e0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Deployment with Tungsten Fabric"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":41,"id":"ff570b3c_3fbdc401","line":1,"updated":"2020-06-05 11:49:33.000000000","message":"docs: Title overline too short.","commit_id":"739e6791fe303c1c56e8ce6ff76e36b3878d29ff"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a2cfde2b47459898ddc969970c2bef7ad785083d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Deployment with Tungsten Fabric"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":45,"id":"ff570b3c_5d684886","line":1,"updated":"2020-06-09 17:33:41.000000000","message":"docs: Title overline too short.","commit_id":"3edf861e4ed0b21725a2fbc1d3947e4b8086dbaa"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e20a921f4f06860b709898a3e3f42452d590573e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Deployment with Tungsten Fabric"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":46,"id":"ff570b3c_d343a712","line":1,"updated":"2020-06-09 19:36:19.000000000","message":"docs: Title overline too short.","commit_id":"56bb0a8e3b5aa6973dc9be96c104285dc986a70c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"053b7a8c3c16f909d1da119982fcf5f6c23868f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Deployment with Tungsten Fabric"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":48,"id":"bf51134e_b820aeb2","line":1,"updated":"2020-06-15 10:33:19.000000000","message":"docs: Title overline too short.","commit_id":"f304f3a19ad4250654d99ca88a611709728d75d0"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"4cab602071c75f6a20ce4c61a8038a30a86cb7fd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"^^^^^"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Tungsten Fabric is the multicloud and multistack network solution which you can"},{"line_number":9,"context_line":"use for your OpenStack as a network plugin. This document decribed how you can deploy"},{"line_number":10,"context_line":"a single node Open Stack based on Tungsten Fabric using openstack helm for development purpuse."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Prepare host"}],"source_content_type":"text/x-rst","patch_set":60,"id":"bf51134e_3ea434b9","line":9,"range":{"start_line":9,"start_character":58,"end_line":9,"end_character":66},"updated":"2020-06-18 18:20:27.000000000","message":"describes","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"6e1d7b51b6f3fb478c29c45bf82e75a8bdcc4c06","unresolved":false,"context_lines":[{"line_number":6,"context_line":"^^^^^"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Tungsten Fabric is the multicloud and multistack network solution which you can"},{"line_number":9,"context_line":"use for your OpenStack as a network plugin. This document decribed how you can deploy"},{"line_number":10,"context_line":"a single node Open Stack based on Tungsten Fabric using openstack helm for development purpuse."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Prepare host"}],"source_content_type":"text/x-rst","patch_set":60,"id":"bf51134e_c8c61049","line":9,"range":{"start_line":9,"start_character":58,"end_line":9,"end_character":66},"in_reply_to":"bf51134e_3ea434b9","updated":"2020-06-19 11:47:54.000000000","message":"Done","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"4cab602071c75f6a20ce4c61a8038a30a86cb7fd","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Tungsten Fabric is the multicloud and multistack network solution which you can"},{"line_number":9,"context_line":"use for your OpenStack as a network plugin. This document decribed how you can deploy"},{"line_number":10,"context_line":"a single node Open Stack based on Tungsten Fabric using openstack helm for development purpuse."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Prepare host"},{"line_number":13,"context_line":"^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":60,"id":"bf51134e_7eaeac98","line":10,"range":{"start_line":10,"start_character":87,"end_line":10,"end_character":94},"updated":"2020-06-18 18:20:27.000000000","message":"purpose","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"6e1d7b51b6f3fb478c29c45bf82e75a8bdcc4c06","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Tungsten Fabric is the multicloud and multistack network solution which you can"},{"line_number":9,"context_line":"use for your OpenStack as a network plugin. This document decribed how you can deploy"},{"line_number":10,"context_line":"a single node Open Stack based on Tungsten Fabric using openstack helm for development purpuse."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Prepare host"},{"line_number":13,"context_line":"^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":60,"id":"bf51134e_e8e034cf","line":10,"range":{"start_line":10,"start_character":87,"end_line":10,"end_character":94},"in_reply_to":"bf51134e_7eaeac98","updated":"2020-06-19 11:47:54.000000000","message":"Done","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"4cab602071c75f6a20ce4c61a8038a30a86cb7fd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  export CONTAINER_DISTRO_NAME\u003dubuntu"},{"line_number":21,"context_line":"  export CONTAINER_DISTRO_VERSION\u003dbionic"},{"line_number":22,"context_line":"  sudo apt update -y"},{"line_number":23,"context_line":"  sudo apt install -y python3-pip resolvconf"},{"line_number":24,"context_line":"  cd ~/openstack-helm"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Install OpenStack packages"}],"source_content_type":"text/x-rst","patch_set":60,"id":"bf51134e_be78442b","line":23,"range":{"start_line":23,"start_character":22,"end_line":23,"end_character":33},"updated":"2020-06-18 18:20:27.000000000","message":"not relevant already. being installed by install-packages.sh","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"6e1d7b51b6f3fb478c29c45bf82e75a8bdcc4c06","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  export CONTAINER_DISTRO_NAME\u003dubuntu"},{"line_number":21,"context_line":"  export CONTAINER_DISTRO_VERSION\u003dbionic"},{"line_number":22,"context_line":"  sudo apt update -y"},{"line_number":23,"context_line":"  sudo apt install -y python3-pip resolvconf"},{"line_number":24,"context_line":"  cd ~/openstack-helm"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Install OpenStack packages"}],"source_content_type":"text/x-rst","patch_set":60,"id":"bf51134e_28eb4cb0","line":23,"range":{"start_line":23,"start_character":22,"end_line":23,"end_character":33},"in_reply_to":"bf51134e_be78442b","updated":"2020-06-19 11:47:54.000000000","message":"Done","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"4cab602071c75f6a20ce4c61a8038a30a86cb7fd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  sudo systemctl restart resolvconf"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Setup env for apply valoues_overrides"},{"line_number":52,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":".. code-block:: shell"}],"source_content_type":"text/x-rst","patch_set":60,"id":"bf51134e_be9de458","line":51,"range":{"start_line":51,"start_character":20,"end_line":51,"end_character":37},"updated":"2020-06-18 18:20:27.000000000","message":"typo","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"6e1d7b51b6f3fb478c29c45bf82e75a8bdcc4c06","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  sudo systemctl restart resolvconf"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Setup env for apply valoues_overrides"},{"line_number":52,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":".. code-block:: shell"}],"source_content_type":"text/x-rst","patch_set":60,"id":"bf51134e_68cc2461","line":51,"range":{"start_line":51,"start_character":20,"end_line":51,"end_character":37},"in_reply_to":"bf51134e_be9de458","updated":"2020-06-19 11:47:54.000000000","message":"Done","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"}],"keystone/values_overrides/tf.yaml":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"4cab602071c75f6a20ce4c61a8038a30a86cb7fd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"conf:"},{"line_number":3,"context_line":"  keystone:"},{"line_number":4,"context_line":"    security_compliance:"},{"line_number":5,"context_line":"      # This is needed to allow TF not to get locked out because of frequent requests during bootstrap"},{"line_number":6,"context_line":"      # TODO: replace with admin user id ignore"},{"line_number":7,"context_line":"      lockout_failure_attempts: 100000"},{"line_number":8,"context_line":"      lockout_duration: 1"},{"line_number":9,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":60,"id":"bf51134e_de8898c7","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":25},"updated":"2020-06-18 18:20:27.000000000","message":"how should be this used in not test deployments with defined security compliance requirements?","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"6e1d7b51b6f3fb478c29c45bf82e75a8bdcc4c06","unresolved":false,"context_lines":[{"line_number":2,"context_line":"conf:"},{"line_number":3,"context_line":"  keystone:"},{"line_number":4,"context_line":"    security_compliance:"},{"line_number":5,"context_line":"      # This is needed to allow TF not to get locked out because of frequent requests during bootstrap"},{"line_number":6,"context_line":"      # TODO: replace with admin user id ignore"},{"line_number":7,"context_line":"      lockout_failure_attempts: 100000"},{"line_number":8,"context_line":"      lockout_duration: 1"},{"line_number":9,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":60,"id":"bf51134e_a8d63cf0","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":25},"in_reply_to":"bf51134e_de8898c7","updated":"2020-06-19 11:47:54.000000000","message":"Removed values_overrides/tf.yaml . Works properly without this overrides","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"}],"neutron/templates/configmap-bin.yaml":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"4cab602071c75f6a20ce4c61a8038a30a86cb7fd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"{{- include \"helm-toolkit.scripts.rabbit_init\" . | indent 4 }}"},{"line_number":92,"context_line":"  neutron-test-force-cleanup.sh: |"},{"line_number":93,"context_line":"{{ tuple \"bin/_neutron-test-force-cleanup.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":94,"context_line":"  tf-plugin.pth: |"},{"line_number":95,"context_line":"    /opt/plugin/site-packages"},{"line_number":96,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":60,"id":"bf51134e_9eb8e076","line":95,"range":{"start_line":94,"start_character":0,"end_line":95,"end_character":29},"updated":"2020-06-18 18:20:27.000000000","message":"lets not include it by default","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"6e1d7b51b6f3fb478c29c45bf82e75a8bdcc4c06","unresolved":false,"context_lines":[{"line_number":91,"context_line":"{{- include \"helm-toolkit.scripts.rabbit_init\" . | indent 4 }}"},{"line_number":92,"context_line":"  neutron-test-force-cleanup.sh: |"},{"line_number":93,"context_line":"{{ tuple \"bin/_neutron-test-force-cleanup.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":94,"context_line":"  tf-plugin.pth: |"},{"line_number":95,"context_line":"    /opt/plugin/site-packages"},{"line_number":96,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":60,"id":"bf51134e_2804ec7a","line":95,"range":{"start_line":94,"start_character":0,"end_line":95,"end_character":29},"in_reply_to":"bf51134e_9eb8e076","updated":"2020-06-19 11:47:54.000000000","message":"Done","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"}],"neutron/templates/configmap-etc.yaml":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"4cab602071c75f6a20ce4c61a8038a30a86cb7fd","unresolved":false,"context_lines":[{"line_number":213,"context_line":"{{- end -}}"},{"line_number":214,"context_line":"{{- end -}}"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"{{- if ( has \"tungstenfabric\" $envAll.Values.network.backend ) -}}"},{"line_number":217,"context_line":"{{- if empty $envAll.Values.conf.plugins.tungstenfabric.KEYSTONE.auth_url -}}"},{"line_number":218,"context_line":"{{- $_ :\u003d tuple \"identity\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_uri_lookup\" | set $envAll.Values.conf.plugins.tungstenfabric.KEYSTONE \"auth_url\" -}}"},{"line_number":219,"context_line":"{{- end -}}"}],"source_content_type":"text/x-yaml","patch_set":60,"id":"bf51134e_1eacd032","line":216,"range":{"start_line":216,"start_character":30,"end_line":216,"end_character":37},"updated":"2020-06-18 18:20:27.000000000","message":"hits an eye. Could you remove it here and below. .Values.network.backend should be fine","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"6e1d7b51b6f3fb478c29c45bf82e75a8bdcc4c06","unresolved":false,"context_lines":[{"line_number":213,"context_line":"{{- end -}}"},{"line_number":214,"context_line":"{{- end -}}"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"{{- if ( has \"tungstenfabric\" $envAll.Values.network.backend ) -}}"},{"line_number":217,"context_line":"{{- if empty $envAll.Values.conf.plugins.tungstenfabric.KEYSTONE.auth_url -}}"},{"line_number":218,"context_line":"{{- $_ :\u003d tuple \"identity\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_uri_lookup\" | set $envAll.Values.conf.plugins.tungstenfabric.KEYSTONE \"auth_url\" -}}"},{"line_number":219,"context_line":"{{- end -}}"}],"source_content_type":"text/x-yaml","patch_set":60,"id":"bf51134e_68f54483","line":216,"range":{"start_line":216,"start_character":30,"end_line":216,"end_character":37},"in_reply_to":"bf51134e_1eacd032","updated":"2020-06-19 11:47:54.000000000","message":"Done","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"}],"neutron/templates/deployment-server.yaml":[{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"84aa360d5dab73f0bf0335487a684a3480813ae1","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            - name: neutron-bin"},{"line_number":139,"context_line":"              mountPath: /usr/local/lib/python2.7/site-packages/tf-plugin.pth"},{"line_number":140,"context_line":"              subPath: tf-plugin.pth"},{"line_number":141,"context_line":"              readOnly: true            "},{"line_number":142,"context_line":"            - name: neutron-bin"},{"line_number":143,"context_line":"              mountPath: /var/lib/openstack/lib/python2.7/site-packages/tf-plugin.pth"},{"line_number":144,"context_line":"              subPath: tf-plugin.pth"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"3f4c43b2_1427c8b5","line":141,"updated":"2020-04-14 10:22:01.000000000","message":"please remove extra spaces","commit_id":"90614083294036c8a8d71b6ef34b8d5e92fcb5b5"}],"neutron/templates/job-db-sync.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"7310247617b2718e5d6fa21f046ab5de85a0d30e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{{- $dbSyncJob :\u003d dict \"envAll\" . \"serviceName\" \"neutron\" \"podVolMounts\" .Values.pod.mounts.neutron_db_sync.neutron_db_sync.volumeMounts \"podVols\" .Values.pod.mounts.neutron_db_sync.neutron_db_sync.volumes -}}"},{"line_number":25,"context_line":"{{ $dbSyncJob | include \"helm-toolkit.manifests.job_db_sync\" }}"},{"line_number":26,"context_line":"{{- end }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_17a7cd0b","line":27,"updated":"2019-08-28 04:52:31.000000000","message":"space not needed","commit_id":"6dc9aea0dcef42d120effb92ce9b565cdf37e7ae"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"86e4c815a4d510bddb2e4f3ead5d3002318c337e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{{- if ( has \"tungstenfabric\" .Values.network.backend ) }}"},{"line_number":20,"context_line":"{{- $podVolMounts :\u003d list (dict \"name\" \"db-sync-conf\" \"mountPath\" \"/etc/neutron/plugins/tungstenfabric/tf_plugin.ini\" \"subPath\" \"tf_plugin.ini\" \"readOnly\" true )}}"},{"line_number":21,"context_line":"{{- $dbSyncJob :\u003d dict \"envAll\" . \"serviceName\" \"neutron\" \"podVolMounts\" $podVolMounts -}}"},{"line_number":22,"context_line":"{{ $dbSyncJob | include \"helm-toolkit.manifests.job_db_sync\" }}"},{"line_number":23,"context_line":"{{- else }}"},{"line_number":24,"context_line":"{{- $dbSyncJob :\u003d dict \"envAll\" . \"serviceName\" \"neutron\" \"podVolMounts\" .Values.pod.mounts.neutron_db_sync.neutron_db_sync.volumeMounts \"podVols\" .Values.pod.mounts.neutron_db_sync.neutron_db_sync.volumes -}}"},{"line_number":25,"context_line":"{{ $dbSyncJob | include \"helm-toolkit.manifests.job_db_sync\" }}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1fa4df85_ee1ea55d","line":22,"range":{"start_line":22,"start_character":1,"end_line":22,"end_character":63},"updated":"2020-03-20 04:06:55.000000000","message":"why is this different?","commit_id":"3ca273b732f54a0acef7e9763f5300e5f05dc9f1"},{"author":{"_account_id":31768,"name":"EvgenyShapovalov","email":"eshapovalov.dev@gmail.com","username":"eshapovalov"},"change_message_id":"4283e446fa57e8473ae01dfd020358a3607bf5fd","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{{- if ( has \"tungstenfabric\" .Values.network.backend ) }}"},{"line_number":20,"context_line":"{{- $podVolMounts :\u003d list (dict \"name\" \"db-sync-conf\" \"mountPath\" \"/etc/neutron/plugins/tungstenfabric/tf_plugin.ini\" \"subPath\" \"tf_plugin.ini\" \"readOnly\" true )}}"},{"line_number":21,"context_line":"{{- $dbSyncJob :\u003d dict \"envAll\" . \"serviceName\" \"neutron\" \"podVolMounts\" $podVolMounts -}}"},{"line_number":22,"context_line":"{{ $dbSyncJob | include \"helm-toolkit.manifests.job_db_sync\" }}"},{"line_number":23,"context_line":"{{- else }}"},{"line_number":24,"context_line":"{{- $dbSyncJob :\u003d dict \"envAll\" . \"serviceName\" \"neutron\" \"podVolMounts\" .Values.pod.mounts.neutron_db_sync.neutron_db_sync.volumeMounts \"podVols\" .Values.pod.mounts.neutron_db_sync.neutron_db_sync.volumes -}}"},{"line_number":25,"context_line":"{{ $dbSyncJob | include \"helm-toolkit.manifests.job_db_sync\" }}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"df33271e_9b5ab54d","line":22,"range":{"start_line":22,"start_character":1,"end_line":22,"end_character":63},"in_reply_to":"1fa4df85_ee1ea55d","updated":"2020-04-02 13:48:07.000000000","message":"Hello, Chris! I have started working on it, I\u0027ll answer asap.","commit_id":"3ca273b732f54a0acef7e9763f5300e5f05dc9f1"}],"neutron/values.yaml":[{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"0fd0f6d7d35b072b1ef41450f6bcad41d6186c00","unresolved":false,"context_lines":[{"line_number":1912,"context_line":"    ml2_conf_sriov: null"},{"line_number":1913,"context_line":"    tungstenfabric:"},{"line_number":1914,"context_line":"      APISERVER:"},{"line_number":1915,"context_line":"        api_server_ip: config-api-server.tf"},{"line_number":1916,"context_line":"        api_server_port: 8082"},{"line_number":1917,"context_line":"        contrail_extensions: \"ipam:neutron_plugin_contrail.plugins.opencontrail.contrail_plugin_ipam.NeutronPluginContrailIpam,policy:neutron_plugin_contrail.plugins.opencontrail.contrail_plugin_policy.NeutronPluginContrailPolicy,route-table:neutron_plugin_contrail.plugins.opencontrail.contrail_plugin_vpc.NeutronPluginContrailVpc,contrail:None,service-interface:None,vf-binding:None\""},{"line_number":1918,"context_line":"        multi_tenancy: True"},{"line_number":1919,"context_line":"      KEYSTONE:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3fa7e38b_3d09fc27","line":1916,"range":{"start_line":1915,"start_character":7,"end_line":1916,"end_character":29},"updated":"2020-02-14 09:27:50.000000000","message":"what about to define the following in endpoints section instead?\n  tungstenfabric:\n    namespace: tungsten-fabric\n    hosts:\n      default: config-api-server\n    host_fqdn_override:\n      default: null\n    port:\n      api:\n        default: 8082\n\nand get values in config-etc:\n$_ :\u003d  tuple \"tungstenfabric\" \"internal\" . | include \"helm-toolkit.endpoints.endpoint_host_lookup\" | set $envAll.Values.conf.plugins.tungstenfabric.apiserver \"api_server_ip\"\n\n$_ :\u003d  tuple \"tungstenfabric\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\"| set $envAll.Values.conf.plugins.tungstenfabric.apiserver \"api_server_port\"","commit_id":"9d67731a10f8e7958b07f338fac18d35a86c13df"}],"nova/templates/configmap-bin.yaml":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"4cab602071c75f6a20ce4c61a8038a30a86cb7fd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"{{- include \"helm-toolkit.scripts.rabbit_init\" . | indent 4 }}"},{"line_number":98,"context_line":"  wait-for-computes-init.sh: |"},{"line_number":99,"context_line":"{{ tuple \"bin/_wait-for-computes-init.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":100,"context_line":"  tf-plugin.pth: |"},{"line_number":101,"context_line":"    /opt/plugin/site-packages"},{"line_number":102,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":60,"id":"bf51134e_3cf71df8","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":29},"updated":"2020-06-18 18:20:27.000000000","message":"ditto","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"6e1d7b51b6f3fb478c29c45bf82e75a8bdcc4c06","unresolved":false,"context_lines":[{"line_number":97,"context_line":"{{- include \"helm-toolkit.scripts.rabbit_init\" . | indent 4 }}"},{"line_number":98,"context_line":"  wait-for-computes-init.sh: |"},{"line_number":99,"context_line":"{{ tuple \"bin/_wait-for-computes-init.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":100,"context_line":"  tf-plugin.pth: |"},{"line_number":101,"context_line":"    /opt/plugin/site-packages"},{"line_number":102,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":60,"id":"bf51134e_082c8800","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":29},"in_reply_to":"bf51134e_3cf71df8","updated":"2020-06-19 11:47:54.000000000","message":"Done","commit_id":"35f8b0a2614913044803d4f876836cc9637c8b70"}],"nova/templates/daemonset-compute.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"7310247617b2718e5d6fa21f046ab5de85a0d30e","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            runAsUser: {{ .Values.pod.user.nova.uid }}"},{"line_number":182,"context_line":"          volumeMounts:"},{"line_number":183,"context_line":"            - name: tf-plugin-shared"},{"line_number":184,"context_line":"              mountPath: /opt/plugin"},{"line_number":185,"context_line":"              # TO-DO: Fix vif-plug-vrouter driver to detect executable dirs path"},{"line_number":186,"context_line":"              # from rootwrap conf"},{"line_number":187,"context_line":"            - name: tf-plugin-bin"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_97841d5f","line":184,"range":{"start_line":184,"start_character":25,"end_line":184,"end_character":36},"updated":"2019-08-28 04:52:31.000000000","message":"not that it matters, but that feels like a pretty generic path","commit_id":"6dc9aea0dcef42d120effb92ce9b565cdf37e7ae"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"b392e1101abdb85623687a977f656deb22fb43f5","unresolved":false,"context_lines":[{"line_number":182,"context_line":"          volumeMounts:"},{"line_number":183,"context_line":"            - name: tf-plugin-shared"},{"line_number":184,"context_line":"              mountPath: /opt/plugin"},{"line_number":185,"context_line":"              # TO-DO: Fix vif-plug-vrouter driver to detect executable dirs path"},{"line_number":186,"context_line":"              # from rootwrap conf"},{"line_number":187,"context_line":"            - name: tf-plugin-bin"},{"line_number":188,"context_line":"              mountPath: /opt/plugin/bin"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_385d2e48","line":185,"range":{"start_line":185,"start_character":16,"end_line":185,"end_character":21},"updated":"2019-08-27 11:24:12.000000000","message":"Format is\n\n  # TODO(yourname)\n\nRef.: https://docs.openstack.org/hacking/latest/user/hacking.html#general","commit_id":"6dc9aea0dcef42d120effb92ce9b565cdf37e7ae"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"b392e1101abdb85623687a977f656deb22fb43f5","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            - name: tf-plugin-shared"},{"line_number":330,"context_line":"              mountPath: /opt/plugin"},{"line_number":331,"context_line":"              readOnly: true"},{"line_number":332,"context_line":"            # TO-DO: Fix vif-plug-vrouter driver to detect executable dirs path"},{"line_number":333,"context_line":"            # from rootwrap conf"},{"line_number":334,"context_line":"            - name: tf-plugin-bin"},{"line_number":335,"context_line":"              mountPath: /usr/sbin"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_b82efea8","line":332,"range":{"start_line":332,"start_character":14,"end_line":332,"end_character":19},"updated":"2019-08-27 11:24:12.000000000","message":"Same as above.","commit_id":"6dc9aea0dcef42d120effb92ce9b565cdf37e7ae"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"b392e1101abdb85623687a977f656deb22fb43f5","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        {{- if ( has \"tungstenfabric\" .Values.network.backend ) }}"},{"line_number":427,"context_line":"        - name: tf-plugin-shared"},{"line_number":428,"context_line":"          emptyDir: {}"},{"line_number":429,"context_line":"          # TO-DO: Fix vif-plug-vrouter driver to detect executable dirs path"},{"line_number":430,"context_line":"          # from rootwrap conf"},{"line_number":431,"context_line":"        - name: tf-plugin-bin"},{"line_number":432,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_783886ed","line":429,"range":{"start_line":429,"start_character":12,"end_line":429,"end_character":17},"updated":"2019-08-27 11:24:12.000000000","message":"Same as above.","commit_id":"6dc9aea0dcef42d120effb92ce9b565cdf37e7ae"},{"author":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"change_message_id":"aad6d61ad9748dd22fd031dd1b310d979635c385","unresolved":false,"context_lines":[{"line_number":339,"context_line":"              mountPropagation: Bidirectional"},{"line_number":340,"context_line":"              {{- end }}"},{"line_number":341,"context_line":"            - name: nova-bin"},{"line_number":342,"context_line":"              mountPath: /usr/local/sbin/iscsiadm"},{"line_number":343,"context_line":"              subPath: iscsiadm"},{"line_number":344,"context_line":"            {{- end }}"},{"line_number":345,"context_line":"{{ if $mounts_nova_compute.volumeMounts }}{{ toYaml $mounts_nova_compute.volumeMounts | indent 12 }}{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"3f4c43b2_951e416e","side":"PARENT","line":342,"updated":"2020-04-13 20:36:07.000000000","message":"Why this section was removed?","commit_id":"cb42a61e11118ea2106c9907f8e74bbe08dd76cd"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"84aa360d5dab73f0bf0335487a684a3480813ae1","unresolved":false,"context_lines":[{"line_number":305,"context_line":"              mountPath: /etc/ceph"},{"line_number":306,"context_line":"              {{- if or ( gt .Capabilities.KubeVersion.Major \"1\" ) ( ge .Capabilities.KubeVersion.Minor \"10\" ) }}"},{"line_number":307,"context_line":"              mountPropagation: Bidirectional"},{"line_number":308,"context_line":"              {{- end }}           "},{"line_number":309,"context_line":"            {{- if and ( empty .Values.conf.ceph.cinder.keyring ) ( empty .Values.conf.ceph.admin_keyring )}}"},{"line_number":310,"context_line":"            - name: ceph-keyring"},{"line_number":311,"context_line":"              mountPath: /tmp/client-keyring"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"3f4c43b2_7440cc36","line":308,"updated":"2020-04-14 10:22:01.000000000","message":"please remove extra spaces","commit_id":"90614083294036c8a8d71b6ef34b8d5e92fcb5b5"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"84aa360d5dab73f0bf0335487a684a3480813ae1","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            - name: nova-bin"},{"line_number":366,"context_line":"              mountPath: /usr/local/lib/python2.7/site-packages/tf-plugin.pth"},{"line_number":367,"context_line":"              subPath: tf-plugin.pth"},{"line_number":368,"context_line":"              readOnly: true            "},{"line_number":369,"context_line":"            - name: nova-bin"},{"line_number":370,"context_line":"              mountPath: /var/lib/openstack/lib/python2.7/site-packages/tf-plugin.pth"},{"line_number":371,"context_line":"              subPath: tf-plugin.pth"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"3f4c43b2_f475fc99","line":368,"updated":"2020-04-14 10:22:01.000000000","message":"please remove extra spaces","commit_id":"90614083294036c8a8d71b6ef34b8d5e92fcb5b5"}],"nova/values.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"d6ce4514c57e8065de7569637b5b6af2dd46a948","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    nova_spiceproxy_assets: docker.io/openstackhelm/nova:stein-ubuntu_bionic"},{"line_number":90,"context_line":"    test: docker.io/xrally/xrally-openstack:1.3.0"},{"line_number":91,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":92,"context_line":"    nova_wait_for_computes_init: gcr.io/google_containers/hyperkube-amd64:v1.11.6"},{"line_number":93,"context_line":"    tf_compute_init: opencontrailnightly/contrail-openstack-compute-init:master-latest"},{"line_number":94,"context_line":"  local_registry:"},{"line_number":95,"context_line":"    active: false"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_98be4962","line":92,"range":{"start_line":92,"start_character":74,"end_line":92,"end_character":81},"updated":"2020-01-22 17:21:43.000000000","message":"i wonder if it wouldn\u0027t make sense to use something more recent?","commit_id":"3fbd11b77b7007f5db6cb3533d2ce50d04a14f3d"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"d3c7f9be08cca13a524dd429285efad4e50d4720","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    nova_spiceproxy_assets: docker.io/openstackhelm/nova:stein-ubuntu_bionic"},{"line_number":90,"context_line":"    test: docker.io/xrally/xrally-openstack:1.3.0"},{"line_number":91,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":92,"context_line":"    nova_wait_for_computes_init: gcr.io/google_containers/hyperkube-amd64:v1.11.6"},{"line_number":93,"context_line":"    tf_compute_init: opencontrailnightly/contrail-openstack-compute-init:master-latest"},{"line_number":94,"context_line":"  local_registry:"},{"line_number":95,"context_line":"    active: false"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_bb13ff59","line":92,"range":{"start_line":92,"start_character":74,"end_line":92,"end_character":81},"in_reply_to":"3fa7e38b_98be4962","updated":"2020-01-22 17:29:19.000000000","message":"I agree :) but it\u0027s out of scope for this change )\nAnyway - all of these can be overridden by user. And maybe he can specify exact version depends on his kubernetes setup.","commit_id":"3fbd11b77b7007f5db6cb3533d2ce50d04a14f3d"},{"author":{"_account_id":30551,"name":"Oleg Bravo","email":"oleg.bravo.ru@gmail.com","username":"olegbravo"},"change_message_id":"4b3f22f2aea8f1c798973c4271f1d859040b05dd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    nova_spiceproxy_assets: docker.io/openstackhelm/nova:stein-ubuntu_bionic"},{"line_number":90,"context_line":"    test: docker.io/xrally/xrally-openstack:1.3.0"},{"line_number":91,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":92,"context_line":"    nova_wait_for_computes_init: gcr.io/google_containers/hyperkube-amd64:v1.11.6"},{"line_number":93,"context_line":"    tf_compute_init: opencontrailnightly/contrail-openstack-compute-init:master-latest"},{"line_number":94,"context_line":"  local_registry:"},{"line_number":95,"context_line":"    active: false"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_4eefa01b","line":92,"range":{"start_line":92,"start_character":74,"end_line":92,"end_character":81},"in_reply_to":"3fa7e38b_98be4962","updated":"2020-01-27 11:04:24.000000000","message":"So let it be for a while ?","commit_id":"3fbd11b77b7007f5db6cb3533d2ce50d04a14f3d"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"d95951ebfc3b6f48d5caeab8846339301e044c0f","unresolved":false,"context_lines":[{"line_number":2263,"context_line":"        nova_placement_api:"},{"line_number":2264,"context_line":"          readOnlyRootFilesystem: false"},{"line_number":2265,"context_line":"          allowPrivilegeEscalation: false"},{"line_number":2266,"context_line":"        nova_placement_api:"},{"line_number":2267,"context_line":"          readOnlyRootFilesystem: false"},{"line_number":2268,"context_line":"          allowPrivilegeEscalation: false"},{"line_number":2269,"context_line":"        nova_scheduler:"},{"line_number":2270,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":2271,"context_line":"          allowPrivilegeEscalation: false"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_7962e443","line":2268,"range":{"start_line":2266,"start_character":8,"end_line":2268,"end_character":41},"updated":"2020-02-03 12:11:23.000000000","message":"What for this double definition? (already there at 2263-2265)","commit_id":"3fbd11b77b7007f5db6cb3533d2ce50d04a14f3d"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"8dfa1126f1516ce12b8decd57e032980c4736cbd","unresolved":false,"context_lines":[{"line_number":2577,"context_line":"      - {}"},{"line_number":2578,"context_line":"    egress:"},{"line_number":2579,"context_line":"      - {}"},{"line_number":2580,"context_line":"      - to:"},{"line_number":2581,"context_line":"        - podSelector:"},{"line_number":2582,"context_line":"            matchLabels:"},{"line_number":2583,"context_line":"              application: ceph"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3fa7e38b_2a9cd70b","line":2580,"updated":"2020-02-06 07:00:30.000000000","message":"why do we need this new block?","commit_id":"194957af230abb12caa3a35b03b4f9c7f9c0a01e"}],"tools/deployment/component/compute-kit/compute-kit.sh":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"55961bd85c041d1508d1085fac89e93e0112430c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    ${OSH_EXTRA_HELM_ARGS_NEUTRON}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"#NOTE: Wait for deploy"},{"line_number":132,"context_line":"# If compute kit installed using Tungsten Fubric, it will be alive when Tunsten Fabric become active."},{"line_number":133,"context_line":"if [[ \"x${TF_DEPLOYMENT}\" !\u003d \u0027xyes\u0027 ]] ; then"},{"line_number":134,"context_line":"  ./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":135,"context_line":"fi"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"#NOTE: Validate Deployment info"},{"line_number":138,"context_line":"export OS_CLOUD\u003dopenstack_helm"},{"line_number":139,"context_line":"openstack service list"},{"line_number":140,"context_line":"sleep 30 #NOTE(portdirect): Wait for ingress controller to update rules and restart Nginx"},{"line_number":141,"context_line":"# If compute kit installed using Tungsten Fubric, it will be alive when Tunsten Fabric become active."},{"line_number":142,"context_line":"if [[ \"x${TF_DEPLOYMENT}\" !\u003d \u0027xyes\u0027 ]] ; then"},{"line_number":143,"context_line":"  openstack compute service list"},{"line_number":144,"context_line":"  openstack network agent list"},{"line_number":145,"context_line":"  openstack hypervisor list"},{"line_number":146,"context_line":"fi"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ \"x${RUN_HELM_TESTS}\" \u003d\u003d \"xno\" || \"x${TF_DEPLOYMENT}\" \u003d\u003d \u0027xyes\u0027 ]; then"},{"line_number":149,"context_line":"    exit 0"},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"# Delete the test pods if they still exist"},{"line_number":153,"context_line":"kubectl delete pods -l application\u003dnova,release_group\u003dnova,component\u003dtest --namespace\u003dopenstack --ignore-not-found"},{"line_number":154,"context_line":"kubectl delete pods -l application\u003dneutron,release_group\u003dneutron,component\u003dtest --namespace\u003dopenstack --ignore-not-found"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"timeout\u003d${OSH_TEST_TIMEOUT:-900}"},{"line_number":157,"context_line":"helm test nova --timeout $timeout"},{"line_number":158,"context_line":"helm test neutron --timeout $timeout"}],"source_content_type":"text/x-sh","patch_set":69,"id":"bf51134e_5db0dd8a","line":158,"range":{"start_line":132,"start_character":0,"end_line":158,"end_character":36},"updated":"2020-06-22 15:32:34.000000000","message":"if [[ \"x${TF_DEPLOYMENT}\" \u003d\u003d \u0027xyes\u0027 ]] ; then\n  exit 0\nfi\n\nshould be enough before selected","commit_id":"ab7885d10dcd08f2e35474583b7fd9480946f896"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"9c81e09deca056d0d12edc7e9286592945de8796","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    ${OSH_EXTRA_HELM_ARGS_NEUTRON}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"#NOTE: Wait for deploy"},{"line_number":132,"context_line":"# If compute kit installed using Tungsten Fubric, it will be alive when Tunsten Fabric become active."},{"line_number":133,"context_line":"if [[ \"x${TF_DEPLOYMENT}\" !\u003d \u0027xyes\u0027 ]] ; then"},{"line_number":134,"context_line":"  ./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":135,"context_line":"fi"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"#NOTE: Validate Deployment info"},{"line_number":138,"context_line":"export OS_CLOUD\u003dopenstack_helm"},{"line_number":139,"context_line":"openstack service list"},{"line_number":140,"context_line":"sleep 30 #NOTE(portdirect): Wait for ingress controller to update rules and restart Nginx"},{"line_number":141,"context_line":"# If compute kit installed using Tungsten Fubric, it will be alive when Tunsten Fabric become active."},{"line_number":142,"context_line":"if [[ \"x${TF_DEPLOYMENT}\" !\u003d \u0027xyes\u0027 ]] ; then"},{"line_number":143,"context_line":"  openstack compute service list"},{"line_number":144,"context_line":"  openstack network agent list"},{"line_number":145,"context_line":"  openstack hypervisor list"},{"line_number":146,"context_line":"fi"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ \"x${RUN_HELM_TESTS}\" \u003d\u003d \"xno\" || \"x${TF_DEPLOYMENT}\" \u003d\u003d \u0027xyes\u0027 ]; then"},{"line_number":149,"context_line":"    exit 0"},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"# Delete the test pods if they still exist"},{"line_number":153,"context_line":"kubectl delete pods -l application\u003dnova,release_group\u003dnova,component\u003dtest --namespace\u003dopenstack --ignore-not-found"},{"line_number":154,"context_line":"kubectl delete pods -l application\u003dneutron,release_group\u003dneutron,component\u003dtest --namespace\u003dopenstack --ignore-not-found"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"timeout\u003d${OSH_TEST_TIMEOUT:-900}"},{"line_number":157,"context_line":"helm test nova --timeout $timeout"},{"line_number":158,"context_line":"helm test neutron --timeout $timeout"}],"source_content_type":"text/x-sh","patch_set":69,"id":"bf51134e_e052e83a","line":158,"range":{"start_line":132,"start_character":0,"end_line":158,"end_character":36},"in_reply_to":"bf51134e_5db0dd8a","updated":"2020-06-23 10:01:17.000000000","message":"Done, and also add review with TF_DEPLOYMENT env var to openstack_helm_infra to pass the param: https://review.opendev.org/#/c/737480/","commit_id":"ab7885d10dcd08f2e35474583b7fd9480946f896"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"e10ccfda251fd3f033b03db1d20c07fd99ddd1a8","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    ${OSH_EXTRA_HELM_ARGS_NEUTRON}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"#NOTE: Wait for deploy"},{"line_number":132,"context_line":"# If compute kit installed using Tungsten Fubric, it will be alive when Tunsten Fabric become active."},{"line_number":133,"context_line":"echo TF_DEPLOYMENT\u003d$TF_DEPLOYMENT"},{"line_number":134,"context_line":"if [[ \"x${TF_DEPLOYMENT}\" \u003d\u003d \u0027xyes\u0027 ]] ; then"},{"line_number":135,"context_line":"  exit 0"},{"line_number":136,"context_line":"fi"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-sh","patch_set":73,"id":"bf51134e_b93dadde","line":134,"range":{"start_line":132,"start_character":0,"end_line":134,"end_character":45},"updated":"2020-06-24 00:44:39.000000000","message":"please parse properly FEATURE_GATES here instead","commit_id":"fa200b968e4c3cdb37ca246d04e6a99b852b5edf"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"3f663cf9b65a85203515b035ac95fbb01bc6965b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    ${OSH_EXTRA_HELM_ARGS_NEUTRON}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"#NOTE: Wait for deploy"},{"line_number":132,"context_line":"# If compute kit installed using Tungsten Fubric, it will be alive when Tunsten Fabric become active."},{"line_number":133,"context_line":"echo TF_DEPLOYMENT\u003d$TF_DEPLOYMENT"},{"line_number":134,"context_line":"if [[ \"x${TF_DEPLOYMENT}\" \u003d\u003d \u0027xyes\u0027 ]] ; then"},{"line_number":135,"context_line":"  exit 0"},{"line_number":136,"context_line":"fi"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-sh","patch_set":73,"id":"bf51134e_76d4b720","line":134,"range":{"start_line":132,"start_character":0,"end_line":134,"end_character":45},"in_reply_to":"bf51134e_b93dadde","updated":"2020-06-24 13:50:43.000000000","message":"Done","commit_id":"fa200b968e4c3cdb37ca246d04e6a99b852b5edf"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"9704cd42caced9bb65abf9fcf7fba4c675f198ed","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    ${OSH_EXTRA_HELM_ARGS_NEUTRON}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"#NOTE: Wait for deploy"},{"line_number":132,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"#NOTE: Validate Deployment info"},{"line_number":135,"context_line":"export OS_CLOUD\u003dopenstack_helm"}],"source_content_type":"text/x-sh","patch_set":76,"id":"bf51134e_53a705be","side":"PARENT","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":52},"updated":"2020-06-24 13:01:13.000000000","message":"you\u0027ve lost this guy after feature gates check","commit_id":"3135f1f00c02bb6f2d605ffbfe095997b6b2bb80"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"3f663cf9b65a85203515b035ac95fbb01bc6965b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    ${OSH_EXTRA_HELM_ARGS_NEUTRON}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"#NOTE: Wait for deploy"},{"line_number":132,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"#NOTE: Validate Deployment info"},{"line_number":135,"context_line":"export OS_CLOUD\u003dopenstack_helm"}],"source_content_type":"text/x-sh","patch_set":76,"id":"bf51134e_16c0db29","side":"PARENT","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":52},"in_reply_to":"bf51134e_53a705be","updated":"2020-06-24 13:50:43.000000000","message":"Done","commit_id":"3135f1f00c02bb6f2d605ffbfe095997b6b2bb80"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"9704cd42caced9bb65abf9fcf7fba4c675f198ed","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"#NOTE: Wait for deploy"},{"line_number":132,"context_line":"# If compute kit installed using Tungsten Fubric, it will be alive when Tunsten Fabric become active."},{"line_number":133,"context_line":"if [[ \"x${FEATURE_GATES}\" \u003d\u003d \u0027xtf\u0027 ]] ; then"},{"line_number":134,"context_line":"  exit 0"},{"line_number":135,"context_line":"fi"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-sh","patch_set":76,"id":"bf51134e_d3c31588","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":44},"updated":"2020-06-24 13:01:13.000000000","message":"This works in your current case but is not right from formal perspective: FEATURE_GATES is a string consisting of strings separated by comma.\n\nSomething like here will be more appropriate:\nhttps://opendev.org/openstack/openstack-helm/src/branch/master/tools/deployment/component/keystone/keystone.sh#L39\n\nOr you may come with something better.","commit_id":"fa29883f4ea8ec0b2f06ab3a7a7d76ee577e7957"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"3f663cf9b65a85203515b035ac95fbb01bc6965b","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"#NOTE: Wait for deploy"},{"line_number":132,"context_line":"# If compute kit installed using Tungsten Fubric, it will be alive when Tunsten Fabric become active."},{"line_number":133,"context_line":"if [[ \"x${FEATURE_GATES}\" \u003d\u003d \u0027xtf\u0027 ]] ; then"},{"line_number":134,"context_line":"  exit 0"},{"line_number":135,"context_line":"fi"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-sh","patch_set":76,"id":"bf51134e_f6956741","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":44},"in_reply_to":"bf51134e_d3c31588","updated":"2020-06-24 13:50:43.000000000","message":"Done","commit_id":"fa29883f4ea8ec0b2f06ab3a7a7d76ee577e7957"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"3142ed3c18fcc1161e67560d5564b1ed8651e19c","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# If compute kit installed using Tungsten Fubric, it will be alive when Tunsten Fabric become active."},{"line_number":133,"context_line":"if [[ \"$FEATURE_GATES\" \u003d~ ,tf,|^tf,|^tf$|,tf$ ]]; then"},{"line_number":134,"context_line":"  exit 0"},{"line_number":135,"context_line":"fi"},{"line_number":136,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":80,"id":"bf51134e_31b6c93f","line":133,"range":{"start_line":133,"start_character":26,"end_line":133,"end_character":45},"updated":"2020-06-24 14:13:11.000000000","message":"(,|^)tf(,|$)","commit_id":"c7cc6571068d5b6d432c13c5a63ad17b4332f93a"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"fe405d293a0009ab78916c370f97b81225ed5efe","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# If compute kit installed using Tungsten Fubric, it will be alive when Tunsten Fabric become active."},{"line_number":133,"context_line":"if [[ \"$FEATURE_GATES\" \u003d~ ,tf,|^tf,|^tf$|,tf$ ]]; then"},{"line_number":134,"context_line":"  exit 0"},{"line_number":135,"context_line":"fi"},{"line_number":136,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":80,"id":"bf51134e_6738839f","line":133,"range":{"start_line":133,"start_character":26,"end_line":133,"end_character":45},"in_reply_to":"bf51134e_31b6c93f","updated":"2020-06-24 15:38:33.000000000","message":"Done","commit_id":"c7cc6571068d5b6d432c13c5a63ad17b4332f93a"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"0f944228ab2c2a5143b6af5f0979063a73b3e1a5","unresolved":false,"context_lines":[{"line_number":144,"context_line":"openstack network agent list"},{"line_number":145,"context_line":"openstack hypervisor list"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"if [ \"x${RUN_HELM_TESTS}\" \u003d\u003d \"xno\" ] ; then"},{"line_number":148,"context_line":"    exit 0"},{"line_number":149,"context_line":"fi"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-sh","patch_set":80,"id":"bf51134e_0c43aeb0","line":147,"range":{"start_line":147,"start_character":36,"end_line":147,"end_character":37},"updated":"2020-06-24 15:07:21.000000000","message":"extra space","commit_id":"c7cc6571068d5b6d432c13c5a63ad17b4332f93a"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"fe405d293a0009ab78916c370f97b81225ed5efe","unresolved":false,"context_lines":[{"line_number":144,"context_line":"openstack network agent list"},{"line_number":145,"context_line":"openstack hypervisor list"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"if [ \"x${RUN_HELM_TESTS}\" \u003d\u003d \"xno\" ] ; then"},{"line_number":148,"context_line":"    exit 0"},{"line_number":149,"context_line":"fi"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-sh","patch_set":80,"id":"bf51134e_27520bdf","line":147,"range":{"start_line":147,"start_character":36,"end_line":147,"end_character":37},"in_reply_to":"bf51134e_0c43aeb0","updated":"2020-06-24 15:38:33.000000000","message":"Done","commit_id":"c7cc6571068d5b6d432c13c5a63ad17b4332f93a"}],"tools/deployment/component/compute-kit/tungsten-fabric.sh":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"afdd515f2824791b277036c37fc787a556104adc","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function get_node_ip() {"},{"line_number":20,"context_line":"  local phys_int\u003d`ip route get 1 | grep -o \u0027dev.*\u0027 | awk \u0027{print($2)}\u0027`"},{"line_number":21,"context_line":"  local node_ip\u003d`ip addr show dev $phys_int | grep \u0027inet \u0027 | awk \u0027{print $2}\u0027 | head -n 1 | cut -d \u0027/\u0027 -f 1`"},{"line_number":22,"context_line":"  echo $node_ip"},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-sh","patch_set":62,"id":"bf51134e_c2f38872","line":21,"range":{"start_line":21,"start_character":16,"end_line":21,"end_character":108},"updated":"2020-06-19 15:26:54.000000000","message":"$(ip addr show dev $phys_int | grep -Pom1 \"(?\u003c\u003dinet )([0-9]+\\.{0,1}){4}\")","commit_id":"6833fbe86aadbbe3fc68a30d9443922f08971b8b"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"ec5230f7d882b411b36889aa412fea74fe58ac11","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function get_node_ip() {"},{"line_number":20,"context_line":"  local phys_int\u003d`ip route get 1 | grep -o \u0027dev.*\u0027 | awk \u0027{print($2)}\u0027`"},{"line_number":21,"context_line":"  local node_ip\u003d`ip addr show dev $phys_int | grep \u0027inet \u0027 | awk \u0027{print $2}\u0027 | head -n 1 | cut -d \u0027/\u0027 -f 1`"},{"line_number":22,"context_line":"  echo $node_ip"},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-sh","patch_set":62,"id":"bf51134e_9ee4323e","line":21,"range":{"start_line":21,"start_character":16,"end_line":21,"end_character":108},"in_reply_to":"bf51134e_c2f38872","updated":"2020-06-22 12:17:17.000000000","message":"Done","commit_id":"6833fbe86aadbbe3fc68a30d9443922f08971b8b"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"afdd515f2824791b277036c37fc787a556104adc","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"function nic_has_ip() {"},{"line_number":26,"context_line":"  local nic\u003d$1"},{"line_number":27,"context_line":"  if nic_ip\u003d$(ip addr show $nic | grep -o \"inet [0-9]*\\.[0-9]*\\.[0-9]*\\.[0-9]*\" | grep -o \"[0-9]*\\.[0-9]*\\.[0-9]*\\.[0-9]*\"); then"},{"line_number":28,"context_line":"    printf \"\\n$nic has IP $nic_ip\""},{"line_number":29,"context_line":"    return 0"},{"line_number":30,"context_line":"  else"}],"source_content_type":"text/x-sh","patch_set":62,"id":"bf51134e_42aad8d1","line":27,"range":{"start_line":27,"start_character":34,"end_line":27,"end_character":123},"updated":"2020-06-19 15:26:54.000000000","message":"Pls make it neat:\ngrep -Pom1 \"(?\u003c\u003dinet )([0-9]+\\.{0,1}){4}\"","commit_id":"6833fbe86aadbbe3fc68a30d9443922f08971b8b"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"ec5230f7d882b411b36889aa412fea74fe58ac11","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"function nic_has_ip() {"},{"line_number":26,"context_line":"  local nic\u003d$1"},{"line_number":27,"context_line":"  if nic_ip\u003d$(ip addr show $nic | grep -o \"inet [0-9]*\\.[0-9]*\\.[0-9]*\\.[0-9]*\" | grep -o \"[0-9]*\\.[0-9]*\\.[0-9]*\\.[0-9]*\"); then"},{"line_number":28,"context_line":"    printf \"\\n$nic has IP $nic_ip\""},{"line_number":29,"context_line":"    return 0"},{"line_number":30,"context_line":"  else"}],"source_content_type":"text/x-sh","patch_set":62,"id":"bf51134e_7ee15e2a","line":27,"range":{"start_line":27,"start_character":34,"end_line":27,"end_character":123},"in_reply_to":"bf51134e_42aad8d1","updated":"2020-06-22 12:17:17.000000000","message":"Done","commit_id":"6833fbe86aadbbe3fc68a30d9443922f08971b8b"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"afdd515f2824791b277036c37fc787a556104adc","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"EOF"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  # comment lines in compute_kit.sh which wait nova and neutron is working and run tests"},{"line_number":160,"context_line":"  sed -i \u0027s/^\\.\\/tools\\/deployment\\/common\\/wait-for-pods.sh openstack/#\\.\\/tools\\/deployment\\/common\\/wait-for-pods.sh openstack/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":161,"context_line":"  sed -i \u0027s/^openstack compute service list/#openstack compute service list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":162,"context_line":"  sed -i \u0027s/^openstack hypervisor list/#openstack hypervisor list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":163,"context_line":"  sed -i \u0027s/^openstack network agent list/#openstack network_agent list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":164,"context_line":"  sed -i \u0027s/^helm test nova --timeout $timeout/#helm test nova --timeout $timeout/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":165,"context_line":"  sed -i \u0027s/^helm test neutron --timeout $timeout/#helm test neutron --timeout $timeout/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"  # check and add a line to /etc/hosts file"},{"line_number":168,"context_line":"  local node_ip\u003d$(get_node_ip)"}],"source_content_type":"text/x-sh","patch_set":62,"id":"bf51134e_e2a16cab","line":165,"range":{"start_line":159,"start_character":0,"end_line":165,"end_character":145},"updated":"2020-06-19 15:26:54.000000000","message":"please avoid this.\ncompute-kit.sh already allows to pass variable to disable tests.\nYou may introduce another there, e.g. TF_DEPLOYMENT\nto skip logic you need to move here.\nOr with the same variable - make a conditional invocation of this script from zuul definition to compute-kit.sh where you need it.\nI\u0027d like to see opinions of other reviewers on the second option though.","commit_id":"6833fbe86aadbbe3fc68a30d9443922f08971b8b"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"ec5230f7d882b411b36889aa412fea74fe58ac11","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"EOF"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  # comment lines in compute_kit.sh which wait nova and neutron is working and run tests"},{"line_number":160,"context_line":"  sed -i \u0027s/^\\.\\/tools\\/deployment\\/common\\/wait-for-pods.sh openstack/#\\.\\/tools\\/deployment\\/common\\/wait-for-pods.sh openstack/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":161,"context_line":"  sed -i \u0027s/^openstack compute service list/#openstack compute service list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":162,"context_line":"  sed -i \u0027s/^openstack hypervisor list/#openstack hypervisor list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":163,"context_line":"  sed -i \u0027s/^openstack network agent list/#openstack network_agent list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":164,"context_line":"  sed -i \u0027s/^helm test nova --timeout $timeout/#helm test nova --timeout $timeout/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":165,"context_line":"  sed -i \u0027s/^helm test neutron --timeout $timeout/#helm test neutron --timeout $timeout/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"  # check and add a line to /etc/hosts file"},{"line_number":168,"context_line":"  local node_ip\u003d$(get_node_ip)"}],"source_content_type":"text/x-sh","patch_set":62,"id":"bf51134e_bed8167b","line":165,"range":{"start_line":159,"start_character":0,"end_line":165,"end_character":145},"in_reply_to":"bf51134e_e2a16cab","updated":"2020-06-22 12:17:17.000000000","message":"Done","commit_id":"6833fbe86aadbbe3fc68a30d9443922f08971b8b"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"6f72f514ff8366ec58078840e488b5b5f5bd68e6","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"EOF"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  # comment lines in compute_kit.sh which wait nova and neutron is working and run tests"},{"line_number":160,"context_line":"  sed -i \u0027s/^\\.\\/tools\\/deployment\\/common\\/wait-for-pods.sh openstack/#\\.\\/tools\\/deployment\\/common\\/wait-for-pods.sh openstack/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":161,"context_line":"  sed -i \u0027s/^openstack compute service list/#openstack compute service list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":162,"context_line":"  sed -i \u0027s/^openstack hypervisor list/#openstack hypervisor list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":163,"context_line":"  sed -i \u0027s/^openstack network agent list/#openstack network_agent list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":164,"context_line":"  sed -i \u0027s/^helm test nova --timeout $timeout/#helm test nova --timeout $timeout/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":165,"context_line":"  sed -i \u0027s/^helm test neutron --timeout $timeout/#helm test neutron --timeout $timeout/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"  # check and add a line to /etc/hosts file"},{"line_number":168,"context_line":"  local node_ip\u003d$(get_node_ip)"}],"source_content_type":"text/x-sh","patch_set":63,"id":"bf51134e_63db9eec","line":165,"range":{"start_line":159,"start_character":1,"end_line":165,"end_character":145},"updated":"2020-06-19 17:31:01.000000000","message":"Agreed with andrii, the compute-kit script already allows you to pass in values there, utilize that.","commit_id":"ab60992de300261f07879b0b90507a889ddf9dda"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"9ffb4047396f1d8759dc199d651d25a2a559019f","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"EOF"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  # comment lines in compute_kit.sh which wait nova and neutron is working and run tests"},{"line_number":160,"context_line":"  sed -i \u0027s/^\\.\\/tools\\/deployment\\/common\\/wait-for-pods.sh openstack/#\\.\\/tools\\/deployment\\/common\\/wait-for-pods.sh openstack/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":161,"context_line":"  sed -i \u0027s/^openstack compute service list/#openstack compute service list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":162,"context_line":"  sed -i \u0027s/^openstack hypervisor list/#openstack hypervisor list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":163,"context_line":"  sed -i \u0027s/^openstack network agent list/#openstack network_agent list/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":164,"context_line":"  sed -i \u0027s/^helm test nova --timeout $timeout/#helm test nova --timeout $timeout/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":165,"context_line":"  sed -i \u0027s/^helm test neutron --timeout $timeout/#helm test neutron --timeout $timeout/\u0027 ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"  # check and add a line to /etc/hosts file"},{"line_number":168,"context_line":"  local node_ip\u003d$(get_node_ip)"}],"source_content_type":"text/x-sh","patch_set":63,"id":"bf51134e_be3db690","line":165,"range":{"start_line":159,"start_character":1,"end_line":165,"end_character":145},"in_reply_to":"bf51134e_63db9eec","updated":"2020-06-22 12:18:46.000000000","message":"Done","commit_id":"ab60992de300261f07879b0b90507a889ddf9dda"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"e10ccfda251fd3f033b03db1d20c07fd99ddd1a8","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function get_node_ip() {"},{"line_number":20,"context_line":"  local phys_int\u003d`ip route get 1 | grep -o \u0027dev.*\u0027 | awk \u0027{print($2)}\u0027`"},{"line_number":21,"context_line":"  local node_ip\u003d$(ip addr show dev vhost0 | grep -Pom1 \"(?\u003c\u003dinet )([0-9]+\\.{0,1}){4}\")"},{"line_number":22,"context_line":"  echo $node_ip"},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-sh","patch_set":73,"id":"bf51134e_197819c2","line":21,"range":{"start_line":21,"start_character":35,"end_line":21,"end_character":41},"updated":"2020-06-24 00:44:39.000000000","message":"hard-coded","commit_id":"fa200b968e4c3cdb37ca246d04e6a99b852b5edf"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"3f663cf9b65a85203515b035ac95fbb01bc6965b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function get_node_ip() {"},{"line_number":20,"context_line":"  local phys_int\u003d`ip route get 1 | grep -o \u0027dev.*\u0027 | awk \u0027{print($2)}\u0027`"},{"line_number":21,"context_line":"  local node_ip\u003d$(ip addr show dev vhost0 | grep -Pom1 \"(?\u003c\u003dinet )([0-9]+\\.{0,1}){4}\")"},{"line_number":22,"context_line":"  echo $node_ip"},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-sh","patch_set":73,"id":"bf51134e_b6b3ef09","line":21,"range":{"start_line":21,"start_character":35,"end_line":21,"end_character":41},"in_reply_to":"bf51134e_197819c2","updated":"2020-06-24 13:50:43.000000000","message":"It is hard coded Tungsten Fabric network interface, if this has another name something get wrong.","commit_id":"fa200b968e4c3cdb37ca246d04e6a99b852b5edf"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"cf681062a32a13c618910fd752133eeff528978d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function get_node_ip() {"},{"line_number":20,"context_line":"  local phys_int\u003d`ip route get 1 | grep -o \u0027dev.*\u0027 | awk \u0027{print($2)}\u0027`"},{"line_number":21,"context_line":"  local node_ip\u003d$(ip addr show dev vhost0 | grep -Pom1 \"(?\u003c\u003dinet )([0-9]+\\.{0,1}){4}\")"},{"line_number":22,"context_line":"  echo $node_ip"},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-sh","patch_set":73,"id":"bf51134e_cd06c620","line":21,"range":{"start_line":21,"start_character":35,"end_line":21,"end_character":41},"in_reply_to":"bf51134e_b6b3ef09","updated":"2020-06-25 09:51:10.000000000","message":"You were right, it was an error, and I was not careful enough","commit_id":"fa200b968e4c3cdb37ca246d04e6a99b852b5edf"}],"zuul.d/jobs-openstack-helm.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8f27d88f1c0db4be42f9921e86e45123cda2d0e8","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        - ./tools/deployment/common/openstack-exporter.sh"},{"line_number":352,"context_line":"        - ./tools/deployment/developer/common/900-use-it.sh"},{"line_number":353,"context_line":"        - ./tools/deployment/common/test-networkpolicy.sh"},{"line_number":354,"context_line":"- job:"},{"line_number":355,"context_line":"    name: openstack-helm-tf"},{"line_number":356,"context_line":"    parent: openstack-helm-chart-deploy"},{"line_number":357,"context_line":"    timeout: 9600"},{"line_number":358,"context_line":"    run: tools/gate/playbooks/osh-gate-runner.yaml"},{"line_number":359,"context_line":"    nodeset: openstack-helm-single-32GB-node"},{"line_number":360,"context_line":"    vars:"},{"line_number":361,"context_line":"      osh_params:"},{"line_number":362,"context_line":"        openstack_release: train"},{"line_number":363,"context_line":"        container_distro_name: ubuntu"},{"line_number":364,"context_line":"        container_distro_version: bionic"},{"line_number":365,"context_line":"        feature_gates: tf"},{"line_number":366,"context_line":"      gate_scripts:"},{"line_number":367,"context_line":"        - ./tools/deployment/common/install-packages.sh"},{"line_number":368,"context_line":"        - ./tools/deployment/common/deploy-k8s.sh"},{"line_number":369,"context_line":"        - ./tools/deployment/common/setup-client.sh"},{"line_number":370,"context_line":"        - ./tools/deployment/component/common/ingress.sh"},{"line_number":371,"context_line":"        - ./tools/deployment/component/common/mariadb.sh"},{"line_number":372,"context_line":"        - ./tools/deployment/component/common/memcached.sh"},{"line_number":373,"context_line":"        - ./tools/deployment/component/common/rabbitmq.sh"},{"line_number":374,"context_line":"        - ./tools/deployment/component/nfs-provisioner/nfs-provisioner.sh"},{"line_number":375,"context_line":"        - ./tools/deployment/component/keystone/keystone.sh"},{"line_number":376,"context_line":"        - ./tools/deployment/component/heat/heat.sh"},{"line_number":377,"context_line":"        - ./tools/deployment/component/glance/glance.sh"},{"line_number":378,"context_line":"        - ./tools/deployment/component/compute-kit/tungsten-fabric.sh prepare"},{"line_number":379,"context_line":"        - ./tools/deployment/component/compute-kit/libvirt.sh"},{"line_number":380,"context_line":"        - ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":381,"context_line":"        - ./tools/deployment/component/compute-kit/tungsten-fabric.sh deploy"},{"line_number":382,"context_line":"- job:"},{"line_number":383,"context_line":"    name: openstack-helm-netpol-compute-kit"},{"line_number":384,"context_line":"    parent: openstack-helm-chart-deploy"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"ff570b3c_25829c01","line":381,"range":{"start_line":354,"start_character":2,"end_line":381,"end_character":0},"updated":"2020-06-09 15:25:31.000000000","message":"The nodeset \"openstack-helm-single-32GB-node\" was not found.","commit_id":"02e1bdb9393e115903884126af0b813f8439b516"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0b3aaa92c6b7b656bf0184abc1a145d563fe2b16","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        - ./tools/deployment/common/openstack-exporter.sh"},{"line_number":352,"context_line":"        - ./tools/deployment/developer/common/900-use-it.sh"},{"line_number":353,"context_line":"        - ./tools/deployment/common/test-networkpolicy.sh"},{"line_number":354,"context_line":"- job:"},{"line_number":355,"context_line":"    name: openstack-helm-tf"},{"line_number":356,"context_line":"    parent: openstack-helm-functional-temp"},{"line_number":357,"context_line":"    timeout: 9600"},{"line_number":358,"context_line":"    run: tools/gate/playbooks/osh-gate-runner.yaml"},{"line_number":359,"context_line":"    nodeset: openstack-helm-single-32GB-node"},{"line_number":360,"context_line":"    vars:"},{"line_number":361,"context_line":"      osh_params:"},{"line_number":362,"context_line":"        openstack_release: train"},{"line_number":363,"context_line":"        container_distro_name: ubuntu"},{"line_number":364,"context_line":"        container_distro_version: bionic"},{"line_number":365,"context_line":"        feature_gates: tf"},{"line_number":366,"context_line":"      gate_scripts:"},{"line_number":367,"context_line":"        - ./tools/deployment/common/install-packages.sh"},{"line_number":368,"context_line":"        - ./tools/deployment/common/deploy-k8s.sh"},{"line_number":369,"context_line":"        - ./tools/deployment/common/setup-client.sh"},{"line_number":370,"context_line":"        - ./tools/deployment/component/common/ingress.sh"},{"line_number":371,"context_line":"        - ./tools/deployment/component/common/mariadb.sh"},{"line_number":372,"context_line":"        - ./tools/deployment/component/common/memcached.sh"},{"line_number":373,"context_line":"        - ./tools/deployment/component/common/rabbitmq.sh"},{"line_number":374,"context_line":"        - ./tools/deployment/component/nfs-provisioner/nfs-provisioner.sh"},{"line_number":375,"context_line":"        - ./tools/deployment/component/keystone/keystone.sh"},{"line_number":376,"context_line":"        - ./tools/deployment/component/heat/heat.sh"},{"line_number":377,"context_line":"        - ./tools/deployment/component/glance/glance.sh"},{"line_number":378,"context_line":"        - ./tools/deployment/component/compute-kit/tungsten-fabric.sh prepare"},{"line_number":379,"context_line":"        - ./tools/deployment/component/compute-kit/libvirt.sh"},{"line_number":380,"context_line":"        - ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":381,"context_line":"        - ./tools/deployment/component/compute-kit/tungsten-fabric.sh deploy"},{"line_number":382,"context_line":"- job:"},{"line_number":383,"context_line":"    name: openstack-helm-netpol-compute-kit"},{"line_number":384,"context_line":"    parent: openstack-helm-chart-deploy"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"ff570b3c_25e57cdd","line":381,"range":{"start_line":354,"start_character":2,"end_line":381,"end_character":0},"updated":"2020-06-09 15:29:44.000000000","message":"The nodeset \"openstack-helm-single-32GB-node\" was not found.","commit_id":"d9381c3ef495471493ec7a8256a02e976dff29f4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"76f6a6e353f8fd508cb90d0e31398a718e5b9de4","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        - ./tools/deployment/common/openstack-exporter.sh"},{"line_number":352,"context_line":"        - ./tools/deployment/developer/common/900-use-it.sh"},{"line_number":353,"context_line":"        - ./tools/deployment/common/test-networkpolicy.sh"},{"line_number":354,"context_line":"- job:"},{"line_number":355,"context_line":"    name: openstack-helm-tf"},{"line_number":356,"context_line":"    parent: openstack-helm-functional-temp"},{"line_number":357,"context_line":"    timeout: 9600"},{"line_number":358,"context_line":"    run: tools/gate/playbooks/osh-gate-runner.yaml"},{"line_number":359,"context_line":"    nodeset: openstack-helm-single-32GB-node"},{"line_number":360,"context_line":"    vars:"},{"line_number":361,"context_line":"      osh_params:"},{"line_number":362,"context_line":"        openstack_release: train"},{"line_number":363,"context_line":"        container_distro_name: ubuntu"},{"line_number":364,"context_line":"        container_distro_version: bionic"},{"line_number":365,"context_line":"        feature_gates: tf"},{"line_number":366,"context_line":"      gate_scripts:"},{"line_number":367,"context_line":"        - ./tools/deployment/common/install-packages.sh"},{"line_number":368,"context_line":"        - ./tools/deployment/common/deploy-k8s.sh"},{"line_number":369,"context_line":"        - ./tools/deployment/common/setup-client.sh"},{"line_number":370,"context_line":"        - ./tools/deployment/component/common/ingress.sh"},{"line_number":371,"context_line":"        - ./tools/deployment/component/common/mariadb.sh"},{"line_number":372,"context_line":"        - ./tools/deployment/component/common/memcached.sh"},{"line_number":373,"context_line":"        - ./tools/deployment/component/common/rabbitmq.sh"},{"line_number":374,"context_line":"        - ./tools/deployment/component/nfs-provisioner/nfs-provisioner.sh"},{"line_number":375,"context_line":"        - ./tools/deployment/component/keystone/keystone.sh"},{"line_number":376,"context_line":"        - ./tools/deployment/component/heat/heat.sh"},{"line_number":377,"context_line":"        - ./tools/deployment/component/glance/glance.sh"},{"line_number":378,"context_line":"        - ./tools/deployment/component/compute-kit/tungsten-fabric.sh prepare"},{"line_number":379,"context_line":"        - ./tools/deployment/component/compute-kit/libvirt.sh"},{"line_number":380,"context_line":"        - ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":381,"context_line":"        - ./tools/deployment/component/compute-kit/tungsten-fabric.sh deploy"},{"line_number":382,"context_line":"- job:"},{"line_number":383,"context_line":"    name: openstack-helm-netpol-compute-kit"},{"line_number":384,"context_line":"    parent: openstack-helm-chart-deploy"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"ff570b3c_85ee08b2","line":381,"range":{"start_line":354,"start_character":2,"end_line":381,"end_character":0},"updated":"2020-06-09 15:30:27.000000000","message":"The nodeset \"openstack-helm-single-32GB-node\" was not found.","commit_id":"f0c7f008fab6300aaeacf22b6ba30a546671a936"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"e10ccfda251fd3f033b03db1d20c07fd99ddd1a8","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        - ./tools/deployment/common/test-networkpolicy.sh"},{"line_number":354,"context_line":"- job:"},{"line_number":355,"context_line":"    name: openstack-helm-tf"},{"line_number":356,"context_line":"    parent: openstack-helm-functional-temp"},{"line_number":357,"context_line":"    timeout: 9600"},{"line_number":358,"context_line":"    run: tools/gate/playbooks/osh-gate-runner.yaml"},{"line_number":359,"context_line":"    nodeset: openstack-helm-single-32GB-node"}],"source_content_type":"text/x-yaml","patch_set":73,"id":"bf51134e_b9480d87","line":356,"range":{"start_line":356,"start_character":12,"end_line":356,"end_character":42},"updated":"2020-06-24 00:44:39.000000000","message":"pls switch to openstack-compute-kit and remove duplicated params","commit_id":"fa200b968e4c3cdb37ca246d04e6a99b852b5edf"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"3f663cf9b65a85203515b035ac95fbb01bc6965b","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        - ./tools/deployment/common/test-networkpolicy.sh"},{"line_number":354,"context_line":"- job:"},{"line_number":355,"context_line":"    name: openstack-helm-tf"},{"line_number":356,"context_line":"    parent: openstack-helm-functional-temp"},{"line_number":357,"context_line":"    timeout: 9600"},{"line_number":358,"context_line":"    run: tools/gate/playbooks/osh-gate-runner.yaml"},{"line_number":359,"context_line":"    nodeset: openstack-helm-single-32GB-node"}],"source_content_type":"text/x-yaml","patch_set":73,"id":"bf51134e_36c7df66","line":356,"range":{"start_line":356,"start_character":12,"end_line":356,"end_character":42},"in_reply_to":"bf51134e_b9480d87","updated":"2020-06-24 13:50:43.000000000","message":"Done","commit_id":"fa200b968e4c3cdb37ca246d04e6a99b852b5edf"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"e10ccfda251fd3f033b03db1d20c07fd99ddd1a8","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    vars:"},{"line_number":365,"context_line":"      zuul_osh_infra_relative_path: ../openstack-helm-infra/"},{"line_number":366,"context_line":"      osh_params:"},{"line_number":367,"context_line":"        tf_deployment: yes"},{"line_number":368,"context_line":"        openstack_release: train"},{"line_number":369,"context_line":"        container_distro_name: ubuntu"},{"line_number":370,"context_line":"        container_distro_version: bionic"}],"source_content_type":"text/x-yaml","patch_set":73,"id":"bf51134e_3954fd20","line":367,"range":{"start_line":367,"start_character":8,"end_line":367,"end_character":26},"updated":"2020-06-24 00:44:39.000000000","message":"pls remove. did not notice you pass feature gate already. no need for duplication","commit_id":"fa200b968e4c3cdb37ca246d04e6a99b852b5edf"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"3f663cf9b65a85203515b035ac95fbb01bc6965b","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    vars:"},{"line_number":365,"context_line":"      zuul_osh_infra_relative_path: ../openstack-helm-infra/"},{"line_number":366,"context_line":"      osh_params:"},{"line_number":367,"context_line":"        tf_deployment: yes"},{"line_number":368,"context_line":"        openstack_release: train"},{"line_number":369,"context_line":"        container_distro_name: ubuntu"},{"line_number":370,"context_line":"        container_distro_version: bionic"}],"source_content_type":"text/x-yaml","patch_set":73,"id":"bf51134e_16c45b5e","line":367,"range":{"start_line":367,"start_character":8,"end_line":367,"end_character":26},"in_reply_to":"bf51134e_3954fd20","updated":"2020-06-24 13:50:43.000000000","message":"Done","commit_id":"fa200b968e4c3cdb37ca246d04e6a99b852b5edf"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"9704cd42caced9bb65abf9fcf7fba4c675f198ed","unresolved":false,"context_lines":[{"line_number":362,"context_line":"      - openstack/openstack-helm-infra"},{"line_number":363,"context_line":"    vars:"},{"line_number":364,"context_line":"      zuul_osh_infra_relative_path: ../openstack-helm-infra/"},{"line_number":365,"context_line":"      osh_params:"},{"line_number":366,"context_line":"        feature_gates: tf"},{"line_number":367,"context_line":"      gate_scripts:"},{"line_number":368,"context_line":"        - ./tools/deployment/common/install-packages.sh"}],"source_content_type":"text/x-yaml","patch_set":76,"id":"bf51134e_f3f9f9c7","line":365,"updated":"2020-06-24 13:01:13.000000000","message":"default compute-kit release is currently \u0027stein\u0027. Previously you had \u0027train\u0027 here.","commit_id":"fa29883f4ea8ec0b2f06ab3a7a7d76ee577e7957"},{"author":{"_account_id":32056,"name":"Ivan Timofeev","email":"ivanv.timofeev@gmail.com","username":"ivanvtimofeev"},"change_message_id":"3f663cf9b65a85203515b035ac95fbb01bc6965b","unresolved":false,"context_lines":[{"line_number":362,"context_line":"      - openstack/openstack-helm-infra"},{"line_number":363,"context_line":"    vars:"},{"line_number":364,"context_line":"      zuul_osh_infra_relative_path: ../openstack-helm-infra/"},{"line_number":365,"context_line":"      osh_params:"},{"line_number":366,"context_line":"        feature_gates: tf"},{"line_number":367,"context_line":"      gate_scripts:"},{"line_number":368,"context_line":"        - ./tools/deployment/common/install-packages.sh"}],"source_content_type":"text/x-yaml","patch_set":76,"id":"bf51134e_768b171e","line":365,"in_reply_to":"bf51134e_f3f9f9c7","updated":"2020-06-24 13:50:43.000000000","message":"Done","commit_id":"fa29883f4ea8ec0b2f06ab3a7a7d76ee577e7957"}]}