)]}'
{"cinder/templates/job-storage-init.yaml":[{"author":{"_account_id":21830,"name":"Jaesang Lee","email":"jaesang_lee@sk.com","username":"jaesanglee"},"change_message_id":"8853ad38b9883db575f4b9b7b32f578a965b6a62","unresolved":false,"context_lines":[{"line_number":131,"context_line":"              mountPath: /etc/ceph"},{"line_number":132,"context_line":"            - name: ceph-etc"},{"line_number":133,"context_line":"              mountPath: /etc/ceph/ceph.conf"},{"line_number":134,"context_line":"              subPath: ceph.conf"},{"line_number":135,"context_line":"              readOnly: true"},{"line_number":136,"context_line":"            {{- if empty $envAll.Values.conf.ceph.admin_keyring }}"},{"line_number":137,"context_line":"            - name: ceph-keyring"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_832a9fe4","line":134,"updated":"2019-06-21 01:37:47.000000000","message":"We were also discussing implementation of multi backends internally. If there are multiple ceph clusters, there should be a separate ceph.conf. This patch seems to use one ceph.conf. Does this patch support multiple ceph clusters? If so, how can  support it?","commit_id":"2d88c6910b12155098dc788aa0ba69d4df3e1ddc"},{"author":{"_account_id":28758,"name":"Daniel Badea","email":"dnlbadea@gmail.com","username":"dbadea"},"change_message_id":"a1bb65ef3ac98bacc15feb99aa82a4ecfb3925ce","unresolved":false,"context_lines":[{"line_number":131,"context_line":"              mountPath: /etc/ceph"},{"line_number":132,"context_line":"            - name: ceph-etc"},{"line_number":133,"context_line":"              mountPath: /etc/ceph/ceph.conf"},{"line_number":134,"context_line":"              subPath: ceph.conf"},{"line_number":135,"context_line":"              readOnly: true"},{"line_number":136,"context_line":"            {{- if empty $envAll.Values.conf.ceph.admin_keyring }}"},{"line_number":137,"context_line":"            - name: ceph-keyring"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_f420ef4b","line":134,"in_reply_to":"9fb8cfa7_832a9fe4","updated":"2019-06-21 06:54:07.000000000","message":"This patch does not support multiple ceph clusters. It just extends existing chart to support multiple ceph backends on the same cluster. It allows you to partition existing Ceph storage space into let\u0027s say faster pools backed by SSDs and slower pools backed by HDDs then define separate backends in Cinder for each of them.","commit_id":"2d88c6910b12155098dc788aa0ba69d4df3e1ddc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ccedffda8a0884449bd033ecc69ee719c8caf6dd","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            - name: RBD_POOL_NAME"},{"line_number":106,"context_line":"              value: {{ $backend.rbd_pool | quote }}"},{"line_number":107,"context_line":"            - name: RBD_POOL_APP_NAME"},{"line_number":108,"context_line":"              value: {{ (index $envAll.Values.conf.ceph.pools $backend.rbd_pool).app_name | quote }}"},{"line_number":109,"context_line":"            - name: RBD_POOL_USER"},{"line_number":110,"context_line":"              value: {{ $backend.rbd_user | quote }}"},{"line_number":111,"context_line":"            - name: RBD_POOL_CRUSH_RULE"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_604973b5","line":108,"range":{"start_line":108,"start_character":24,"end_line":108,"end_character":90},"updated":"2019-06-25 01:49:22.000000000","message":"Zuul is failing because of these references. \n\n  value: {{ (index $envAll.Values.conf.ceph.pools $backend.rbd_pool).app_name | quote }}\n  value: {{ (index $envAll.Values.conf.ceph.pools $backend.rbd_pool).crush_rule |   quote }}\n  value: {{ (index $envAll.Values.conf.ceph.pools $backend.rbd_pool).replication | quote }}\n  value: {{ (index $envAll.Values.conf.ceph.pools $backend.rbd_pool).chunk_size | quote }}\n\nYou need to change values.yaml to:\n\n  ceph:\n    pools:\n      backup:\n        replication: 3\n        crush_rule: replicated_rule\n        chunk_size: 8\n        app_name: cinder-backup\n      rbd1:\n        replication: 1\n        crush_rule: replicated_rule\n        chunk_size: 8\n        app_name: cinder-volume\n\nIf you are going to use the pool name to allow individual pool creation with unique values then for consistency you should also change \u0027backup\u0027 to \u0027cinder.backups\u0027 and update job-backup-storage-init.yaml.","commit_id":"2205c3048d447641bbea71d6f2cf340945eeb205"},{"author":{"_account_id":28758,"name":"Daniel Badea","email":"dnlbadea@gmail.com","username":"dbadea"},"change_message_id":"e1093c369292b237ff1c2ba326237c256e4caea0","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            - name: RBD_POOL_NAME"},{"line_number":106,"context_line":"              value: {{ $backend.rbd_pool | quote }}"},{"line_number":107,"context_line":"            - name: RBD_POOL_APP_NAME"},{"line_number":108,"context_line":"              value: {{ (index $envAll.Values.conf.ceph.pools $backend.rbd_pool).app_name | quote }}"},{"line_number":109,"context_line":"            - name: RBD_POOL_USER"},{"line_number":110,"context_line":"              value: {{ $backend.rbd_user | quote }}"},{"line_number":111,"context_line":"            - name: RBD_POOL_CRUSH_RULE"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_74d0bfca","line":108,"range":{"start_line":108,"start_character":24,"end_line":108,"end_character":90},"in_reply_to":"9fb8cfa7_604973b5","updated":"2019-07-05 06:57:17.000000000","message":"Zuul is failing because volumes pool should be named \u0027cinder.volumes\u0027.","commit_id":"2205c3048d447641bbea71d6f2cf340945eeb205"}],"cinder/values.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ccedffda8a0884449bd033ecc69ee719c8caf6dd","unresolved":false,"context_lines":[{"line_number":766,"context_line":"    monitors: []"},{"line_number":767,"context_line":"    admin_keyring: null"},{"line_number":768,"context_line":"    pools:"},{"line_number":769,"context_line":"      backup:"},{"line_number":770,"context_line":"        replication: 3"},{"line_number":771,"context_line":"        crush_rule: replicated_rule"},{"line_number":772,"context_line":"        chunk_size: 8"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_833cb1c8","line":769,"range":{"start_line":769,"start_character":6,"end_line":769,"end_character":12},"updated":"2019-06-25 01:49:22.000000000","message":"Consider making similar updates to \u0027job-backup-storage-init.yaml\u0027 so that all pools are referenced by name (this becomes cinder.backups) as opposed to function","commit_id":"2205c3048d447641bbea71d6f2cf340945eeb205"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ccedffda8a0884449bd033ecc69ee719c8caf6dd","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        crush_rule: replicated_rule"},{"line_number":772,"context_line":"        chunk_size: 8"},{"line_number":773,"context_line":"        app_name: cinder-backup"},{"line_number":774,"context_line":"      volume:"},{"line_number":775,"context_line":"        replication: 3"},{"line_number":776,"context_line":"        crush_rule: replicated_rule"},{"line_number":777,"context_line":"        chunk_size: 8"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_232e2592","line":774,"range":{"start_line":774,"start_character":6,"end_line":774,"end_character":12},"updated":"2019-06-25 01:49:22.000000000","message":"I think this needs to be \u0027rbd1\u0027","commit_id":"2205c3048d447641bbea71d6f2cf340945eeb205"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"7c173011e020202566f1cca5304e394ff382fdb0","unresolved":false,"context_lines":[{"line_number":770,"context_line":"        replication: 3"},{"line_number":771,"context_line":"        crush_rule: replicated_rule"},{"line_number":772,"context_line":"        chunk_size: 8"},{"line_number":773,"context_line":"        app_name: cinder-backup"},{"line_number":774,"context_line":"      cinder.volumes:"},{"line_number":775,"context_line":"        replication: 3"},{"line_number":776,"context_line":"        crush_rule: replicated_rule"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_520c733a","line":773,"updated":"2019-07-10 08:53:49.000000000","message":"this could be a breaking change to existing deployments that are overriding this values.\n\nCan we have a release note for this?","commit_id":"d0b88a0b8f625dd26258807eed6c8e35e08b90da"}],"tools/deployment/component/cinder/cinder.sh":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ccedffda8a0884449bd033ecc69ee719c8caf6dd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        crush_rule: same_host"},{"line_number":30,"context_line":"        chunk_size: 8"},{"line_number":31,"context_line":"        app_name: cinder-backup"},{"line_number":32,"context_line":"      volume:"},{"line_number":33,"context_line":"        replication: 1"},{"line_number":34,"context_line":"        crush_rule: same_host"},{"line_number":35,"context_line":"        chunk_size: 8"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9fb8cfa7_e015634a","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":12},"updated":"2019-06-25 01:49:22.000000000","message":"I believe that this now needs to be \u0027rbd1\u0027","commit_id":"2205c3048d447641bbea71d6f2cf340945eeb205"},{"author":{"_account_id":28758,"name":"Daniel Badea","email":"dnlbadea@gmail.com","username":"dbadea"},"change_message_id":"e1093c369292b237ff1c2ba326237c256e4caea0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        crush_rule: same_host"},{"line_number":30,"context_line":"        chunk_size: 8"},{"line_number":31,"context_line":"        app_name: cinder-backup"},{"line_number":32,"context_line":"      volume:"},{"line_number":33,"context_line":"        replication: 1"},{"line_number":34,"context_line":"        crush_rule: same_host"},{"line_number":35,"context_line":"        chunk_size: 8"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_b461573c","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":12},"in_reply_to":"9fb8cfa7_e015634a","updated":"2019-07-05 06:57:17.000000000","message":"Needs to be cinder.volumes","commit_id":"2205c3048d447641bbea71d6f2cf340945eeb205"}],"tools/deployment/developer/ceph/130-cinder.sh":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ccedffda8a0884449bd033ecc69ee719c8caf6dd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        crush_rule: same_host"},{"line_number":30,"context_line":"        chunk_size: 8"},{"line_number":31,"context_line":"        app_name: cinder-backup"},{"line_number":32,"context_line":"      volume:"},{"line_number":33,"context_line":"        replication: 1"},{"line_number":34,"context_line":"        crush_rule: same_host"},{"line_number":35,"context_line":"        chunk_size: 8"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9fb8cfa7_4319d977","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":12},"updated":"2019-06-25 01:49:22.000000000","message":"I think this needs to be \u0027rbd1\u0027","commit_id":"2205c3048d447641bbea71d6f2cf340945eeb205"},{"author":{"_account_id":28758,"name":"Daniel Badea","email":"dnlbadea@gmail.com","username":"dbadea"},"change_message_id":"e1093c369292b237ff1c2ba326237c256e4caea0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        crush_rule: same_host"},{"line_number":30,"context_line":"        chunk_size: 8"},{"line_number":31,"context_line":"        app_name: cinder-backup"},{"line_number":32,"context_line":"      volume:"},{"line_number":33,"context_line":"        replication: 1"},{"line_number":34,"context_line":"        crush_rule: same_host"},{"line_number":35,"context_line":"        chunk_size: 8"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_f4758ffb","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":12},"in_reply_to":"9fb8cfa7_4319d977","updated":"2019-07-05 06:57:17.000000000","message":"Needs to be cinder.volumes","commit_id":"2205c3048d447641bbea71d6f2cf340945eeb205"}]}