)]}'
{"id":"openstack%2Fopenstack-helm~668039","triplet_id":"openstack%2Fopenstack-helm~master~I45f3e73f8a957576ef82a733c1a7b7feaba7b679","project":"openstack/openstack-helm","branch":"master","topic":"keystone-cred","hashtags":[],"change_id":"I45f3e73f8a957576ef82a733c1a7b7feaba7b679","subject":"Fix credential cleanup hook","status":"MERGED","created":"2019-06-27 20:11:15.000000000","updated":"2019-07-09 07:51:10.000000000","submitted":"2019-07-09 07:51:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"668039-1562658670799-29425bd4","meta_rev_id":"ad402cad7aa279638f63d0af53ab181a230dfb15","_number":668039,"virtual_id_number":668039,"owner":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":2,"date":"2019-07-09 07:51:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":2,"date":"2019-07-09 06:12:11.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2019-07-09 06:12:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":1,"date":"2019-07-09 06:12:13.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-04 14:10:08.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-07-09 06:12:13.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2019-07-09 07:51:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c7d26dd36eb5af8e92df2cdd8db0af83966b2412","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2019-06-27 20:11:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9fa36e3254bc904805e003185f6dc5116c208374","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-27 21:11:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/39/668039/1/check/openstack-tox-docs/46956fd/html/ : SUCCESS in 3m 07s\n- openstack-helm-lint http://logs.openstack.org/39/668039/1/check/openstack-helm-lint/15a04d4/ : SUCCESS in 1m 43s\n- openstack-helm-cinder http://logs.openstack.org/39/668039/1/check/openstack-helm-cinder/f25db57/ : SUCCESS in 36m 09s\n- openstack-helm-cinder-pike-ubuntu_xenial http://logs.openstack.org/39/668039/1/check/openstack-helm-cinder-pike-ubuntu_xenial/0e5d9c0/ : SUCCESS in 33m 50s (non-voting)\n- openstack-helm-cinder-queens-ubuntu_xenial http://logs.openstack.org/39/668039/1/check/openstack-helm-cinder-queens-ubuntu_xenial/9feaa95/ : FAILURE in 9m 45s (non-voting)\n- openstack-helm-cinder-rocky-ubuntu_xenial http://logs.openstack.org/39/668039/1/check/openstack-helm-cinder-rocky-ubuntu_xenial/f733942/ : SUCCESS in 36m 20s (non-voting)\n- openstack-helm-cinder-rocky-ubuntu_bionic http://logs.openstack.org/39/668039/1/check/openstack-helm-cinder-rocky-ubuntu_bionic/865c0c5/ : SUCCESS in 37m 05s (non-voting)\n- openstack-helm-cinder-rocky-opensuse_15 http://logs.openstack.org/39/668039/1/check/openstack-helm-cinder-rocky-opensuse_15/e1e8ecb/ : SUCCESS in 36m 42s (non-voting)\n- openstack-helm-compute-kit http://logs.openstack.org/39/668039/1/check/openstack-helm-compute-kit/7f80235/ : SUCCESS in 37m 19s\n- openstack-helm-compute-kit-pike-ubuntu_xenial http://logs.openstack.org/39/668039/1/check/openstack-helm-compute-kit-pike-ubuntu_xenial/5b52faf/ : SUCCESS in 46m 27s (non-voting)\n- openstack-helm-compute-kit-queens-ubuntu_xenial http://logs.openstack.org/39/668039/1/check/openstack-helm-compute-kit-queens-ubuntu_xenial/f863a87/ : SUCCESS in 43m 06s (non-voting)\n- openstack-helm-compute-kit-rocky-ubuntu_xenial http://logs.openstack.org/39/668039/1/check/openstack-helm-compute-kit-rocky-ubuntu_xenial/76d4373/ : SUCCESS in 41m 27s (non-voting)\n- openstack-helm-compute-kit-rocky-ubuntu_bionic http://logs.openstack.org/39/668039/1/check/openstack-helm-compute-kit-rocky-ubuntu_bionic/87ed588/ : SUCCESS in 42m 20s (non-voting)\n- openstack-helm-compute-kit-rocky-opensuse_15 http://logs.openstack.org/39/668039/1/check/openstack-helm-compute-kit-rocky-opensuse_15/51a99d4/ : FAILURE in 48m 55s (non-voting)\n- openstack-helm-horizon http://logs.openstack.org/39/668039/1/check/openstack-helm-horizon/4c7a326/ : SUCCESS in 21m 30s\n- openstack-helm-apparmor http://logs.openstack.org/39/668039/1/check/openstack-helm-apparmor/b51d252/ : SUCCESS in 37m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0423233b76750944da3ddb87a065c29e7b26b216","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-07-04 14:10:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"89ab99b220ca207d7b88135d38d86eca5713903f","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2019-07-08 20:51:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"be95799f6b11353b0ab7a2f4259375a7481607d4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-08 20:51:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a1fb925cafcb3679a44eec33412145061554f09a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-08 21:01:00.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/39/668039/1/gate/openstack-tox-docs/b467b7b/html/ : SUCCESS in 3m 29s\n- openstack-helm-lint http://logs.openstack.org/39/668039/1/gate/openstack-helm-lint/1d9101c/ : SUCCESS in 1m 31s\n- openstack-helm-cinder http://logs.openstack.org/39/668039/1/gate/openstack-helm-cinder/854f42a/ : FAILURE in 2m 36s\n- openstack-helm-compute-kit http://logs.openstack.org/39/668039/1/gate/openstack-helm-compute-kit/ec7b422/ : FAILURE in 3m 09s","accounts_in_message":[],"_revision_number":1},{"id":"d22f128417eb33b59e874909b9ae489feaba33b2","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2019-07-09 06:12:11.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"86ecb7ac99abd4e2c04a137e35cf488bf6bbca21","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2019-07-09 06:12:13.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"7927d4786a29528151a5e4237146ab4aae42c948","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-09 07:07:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/39/668039/2/check/openstack-tox-docs/920521c/html/ : SUCCESS in 4m 22s\n- openstack-helm-lint http://logs.openstack.org/39/668039/2/check/openstack-helm-lint/602b008/ : SUCCESS in 1m 49s\n- openstack-helm-cinder http://logs.openstack.org/39/668039/2/check/openstack-helm-cinder/3b0b313/ : SUCCESS in 37m 23s\n- openstack-helm-cinder-pike-ubuntu_xenial http://logs.openstack.org/39/668039/2/check/openstack-helm-cinder-pike-ubuntu_xenial/6cbb81d/ : SUCCESS in 38m 45s (non-voting)\n- openstack-helm-cinder-queens-ubuntu_xenial http://logs.openstack.org/39/668039/2/check/openstack-helm-cinder-queens-ubuntu_xenial/189ff3f/ : SUCCESS in 36m 32s (non-voting)\n- openstack-helm-cinder-rocky-ubuntu_xenial http://logs.openstack.org/39/668039/2/check/openstack-helm-cinder-rocky-ubuntu_xenial/01c5561/ : SUCCESS in 35m 05s (non-voting)\n- openstack-helm-cinder-rocky-ubuntu_bionic http://logs.openstack.org/39/668039/2/check/openstack-helm-cinder-rocky-ubuntu_bionic/3f678aa/ : SUCCESS in 37m 42s (non-voting)\n- openstack-helm-cinder-rocky-opensuse_15 http://logs.openstack.org/39/668039/2/check/openstack-helm-cinder-rocky-opensuse_15/7394c6c/ : SUCCESS in 42m 20s (non-voting)\n- openstack-helm-cinder-stein-ubuntu_bionic http://logs.openstack.org/39/668039/2/check/openstack-helm-cinder-stein-ubuntu_bionic/8ed4229/ : SUCCESS in 37m 52s (non-voting)\n- openstack-helm-compute-kit http://logs.openstack.org/39/668039/2/check/openstack-helm-compute-kit/cfdb8ea/ : SUCCESS in 36m 50s\n- openstack-helm-compute-kit-pike-ubuntu_xenial http://logs.openstack.org/39/668039/2/check/openstack-helm-compute-kit-pike-ubuntu_xenial/be5032b/ : SUCCESS in 42m 18s (non-voting)\n- openstack-helm-compute-kit-queens-ubuntu_xenial http://logs.openstack.org/39/668039/2/check/openstack-helm-compute-kit-queens-ubuntu_xenial/1f01614/ : SUCCESS in 41m 46s (non-voting)\n- openstack-helm-compute-kit-rocky-ubuntu_xenial http://logs.openstack.org/39/668039/2/check/openstack-helm-compute-kit-rocky-ubuntu_xenial/e957427/ : SUCCESS in 41m 55s (non-voting)\n- openstack-helm-compute-kit-rocky-ubuntu_bionic http://logs.openstack.org/39/668039/2/check/openstack-helm-compute-kit-rocky-ubuntu_bionic/efc3489/ : SUCCESS in 45m 40s (non-voting)\n- openstack-helm-compute-kit-rocky-opensuse_15 http://logs.openstack.org/39/668039/2/check/openstack-helm-compute-kit-rocky-opensuse_15/401fdfd/ : FAILURE in 42m 33s (non-voting)\n- openstack-helm-compute-kit-stein-ubuntu_bionic http://logs.openstack.org/39/668039/2/check/openstack-helm-compute-kit-stein-ubuntu_bionic/cbef822/ : SUCCESS in 44m 38s (non-voting)\n- openstack-helm-horizon http://logs.openstack.org/39/668039/2/check/openstack-helm-horizon/13ffa06/ : SUCCESS in 23m 22s\n- openstack-helm-apparmor http://logs.openstack.org/39/668039/2/check/openstack-helm-apparmor/bcfa837/ : SUCCESS in 37m 39s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"20e1b4bc43431b22eab68ca2c4531a02cee8b1e4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-09 07:07:17.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ed24e63a368792cc76bf74deb41852a7daa6bbfd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-09 07:51:10.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/39/668039/2/gate/openstack-tox-docs/8504c81/html/ : SUCCESS in 3m 44s\n- openstack-helm-lint http://logs.openstack.org/39/668039/2/gate/openstack-helm-lint/6c3c64c/ : SUCCESS in 1m 26s\n- openstack-helm-cinder http://logs.openstack.org/39/668039/2/gate/openstack-helm-cinder/a2ce465/ : SUCCESS in 34m 08s\n- openstack-helm-compute-kit http://logs.openstack.org/39/668039/2/gate/openstack-helm-compute-kit/041fe9e/ : SUCCESS in 40m 52s","accounts_in_message":[],"_revision_number":2},{"id":"9a9c500754210313326e9b88da7c2911b239d247","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-09 07:51:10.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a57cd78439bbaca20173e17b4ce601d616ee1189","revisions":{"46f5c2399e89888bca131163629d9234f5e74fc9":{"kind":"REWORK","_number":1,"created":"2019-06-27 20:11:15.000000000","uploader":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"ref":"refs/changes/39/668039/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/39/668039/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/39/668039/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/39/668039/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/39/668039/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/39/668039/1"}}},"commit":{"parents":[{"commit":"5d993140d7aadf5584681e63f8792cb0b9b5b656","subject":"Merge \"[neutron] Mend rootwrap privsep indentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/5d993140d7aadf5584681e63f8792cb0b9b5b656"}]}],"author":{"name":"Gage Hugo","email":"gagehugo@gmail.com","date":"2019-06-27 20:09:57.000000000","tz":-300},"committer":{"name":"Gage Hugo","email":"gagehugo@gmail.com","date":"2019-06-27 20:09:57.000000000","tz":-300},"subject":"Fix credential cleanup hook","message":"Fix credential cleanup hook\n\nThe keystone-credential-cleanup hook was previously changed to\npost-delete, this can cause issues where the serviceName is deleted\nprior to running and will cause this to fail. This change reverts\nthe hook back to pre-delete to avoid this issue.\n\nChange-Id: I45f3e73f8a957576ef82a733c1a7b7feaba7b679\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/46f5c2399e89888bca131163629d9234f5e74fc9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/46f5c2399e89888bca131163629d9234f5e74fc9"}]},"branch":"refs/heads/master"},"a57cd78439bbaca20173e17b4ce601d616ee1189":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-07-09 06:12:11.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/39/668039/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/39/668039/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/39/668039/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/39/668039/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/39/668039/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/39/668039/2"}}},"commit":{"parents":[{"commit":"69d5c4c1e1794abb1ba10cee9ec3e90948d72341","subject":"Merge \"Nova: add service token\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/69d5c4c1e1794abb1ba10cee9ec3e90948d72341"}]}],"author":{"name":"Gage Hugo","email":"gagehugo@gmail.com","date":"2019-06-27 20:09:57.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2019-07-09 06:12:11.000000000","tz":0},"subject":"Fix credential cleanup hook","message":"Fix credential cleanup hook\n\nThe keystone-credential-cleanup hook was previously changed to\npost-delete, this can cause issues where the serviceName is deleted\nprior to running and will cause this to fail. This change reverts\nthe hook back to pre-delete to avoid this issue.\n\nChange-Id: I45f3e73f8a957576ef82a733c1a7b7feaba7b679\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/a57cd78439bbaca20173e17b4ce601d616ee1189"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/a57cd78439bbaca20173e17b4ce601d616ee1189"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}