)]}'
{"id":"openstack%2Fopenstack-helm~673906","triplet_id":"openstack%2Fopenstack-helm~master~Id3cda737895451c2261bf9adfe54995db28c2f63","project":"openstack/openstack-helm","branch":"master","hashtags":[],"change_id":"Id3cda737895451c2261bf9adfe54995db28c2f63","subject":"Cinder: Make image conversion dir an emptydir","status":"MERGED","created":"2019-07-31 20:06:21.000000000","updated":"2019-07-31 21:43:35.000000000","submitted":"2019-07-31 21:43:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673906-1564609415702-154fa80f","meta_rev_id":"0aa5496d7465acee9564ae1ba7400d148a3941cc","_number":673906,"virtual_id_number":673906,"owner":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":2,"date":"2019-07-31 21:43:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},{"value":0,"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"recommended":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"all":[{"value":1,"date":"2019-07-31 20:07:48.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"value":1,"date":"2019-07-31 20:10:57.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-31 20:11:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},{"value":2,"date":"2019-07-31 20:15:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":1,"date":"2019-07-31 20:34:54.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},{"value":2,"date":"2019-07-31 20:13:12.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":2,"date":"2019-07-31 20:10:24.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"all":[{"value":0,"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},{"value":1,"date":"2019-07-31 20:15:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},{"value":1,"date":"2019-07-31 20:13:12.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-31 20:07:48.000000000","updated_by":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"reviewer":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"state":"REVIEWER"},{"updated":"2019-07-31 20:10:24.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2019-07-31 20:10:57.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2019-07-31 20:11:55.000000000","updated_by":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"reviewer":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"state":"REVIEWER"},{"updated":"2019-07-31 20:13:12.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2019-07-31 20:15:53.000000000","updated_by":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"reviewer":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"state":"REVIEWER"},{"updated":"2019-07-31 20:34:54.000000000","updated_by":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"reviewer":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"state":"REVIEWER"},{"updated":"2019-07-31 21:43:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ed5293514bf1e0984f902b1783a1c3667fd6cb3f","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-07-31 20:06:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0d7d797a58fd763769eb6fb870f1adf4197e7b63","author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"date":"2019-07-31 20:07:48.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a6140719f7c4a9c167be2b42cd312bc5c9c03e77","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2019-07-31 20:10:24.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0a9fa9d3710334f1605de456d20b89a951f7805e","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2019-07-31 20:10:57.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8bc4d9c8d4c8c6e94db05540cd71ca240779edb9","author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"date":"2019-07-31 20:11:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d1bd948e62041f71d74a5dfccb0edc75965ec69b","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2019-07-31 20:13:12.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b5224f7e41d95e8c98d3b2ab4d275df5e43792e2","author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"date":"2019-07-31 20:15:53.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nI\u0027d ideally like to see the conversion directory something that would not potentially fill up the docker partition (given emptydirs are overlayed onto that) - giving tenants effectively a DoS angle on the platform with a large enough image.  I will +2 for now given a PVC dedicated to this is a bit overkill but this is worth revisiting.","accounts_in_message":[],"_revision_number":1},{"id":"3ba0283d1358c425990ce925aab1a95e1e6d641a","author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"date":"2019-07-31 20:34:54.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"75edbf628a8f28e09558838814433e3d03353750","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 21:05:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/06/673906/1/check/openstack-tox-docs/84a86a5/html/ : SUCCESS in 3m 40s\n- openstack-helm-lint http://logs.openstack.org/06/673906/1/check/openstack-helm-lint/7aa327b/ : SUCCESS in 2m 09s\n- openstack-helm-cinder http://logs.openstack.org/06/673906/1/check/openstack-helm-cinder/0644bf5/ : SUCCESS in 37m 17s\n- openstack-helm-cinder-pike-ubuntu_xenial http://logs.openstack.org/06/673906/1/check/openstack-helm-cinder-pike-ubuntu_xenial/b14bfe0/ : SUCCESS in 36m 10s (non-voting)\n- openstack-helm-cinder-queens-ubuntu_xenial http://logs.openstack.org/06/673906/1/check/openstack-helm-cinder-queens-ubuntu_xenial/2e7cc33/ : SUCCESS in 37m 38s (non-voting)\n- openstack-helm-cinder-rocky-ubuntu_xenial http://logs.openstack.org/06/673906/1/check/openstack-helm-cinder-rocky-ubuntu_xenial/3f95409/ : SUCCESS in 38m 38s (non-voting)\n- openstack-helm-cinder-rocky-ubuntu_bionic http://logs.openstack.org/06/673906/1/check/openstack-helm-cinder-rocky-ubuntu_bionic/c64b7a3/ : SUCCESS in 38m 55s (non-voting)\n- openstack-helm-cinder-rocky-opensuse_15 http://logs.openstack.org/06/673906/1/check/openstack-helm-cinder-rocky-opensuse_15/3b97919/ : SUCCESS in 40m 41s (non-voting)\n- openstack-helm-cinder-stein-ubuntu_bionic http://logs.openstack.org/06/673906/1/check/openstack-helm-cinder-stein-ubuntu_bionic/66f5b5f/ : SUCCESS in 40m 56s (non-voting)\n- openstack-helm-compute-kit http://logs.openstack.org/06/673906/1/check/openstack-helm-compute-kit/98c26ae/ : SUCCESS in 44m 41s\n- openstack-helm-compute-kit-pike-ubuntu_xenial http://logs.openstack.org/06/673906/1/check/openstack-helm-compute-kit-pike-ubuntu_xenial/d550a8e/ : SUCCESS in 46m 45s (non-voting)\n- openstack-helm-compute-kit-queens-ubuntu_xenial http://logs.openstack.org/06/673906/1/check/openstack-helm-compute-kit-queens-ubuntu_xenial/c105b8f/ : SUCCESS in 45m 21s (non-voting)\n- openstack-helm-compute-kit-rocky-ubuntu_xenial http://logs.openstack.org/06/673906/1/check/openstack-helm-compute-kit-rocky-ubuntu_xenial/ae356a8/ : SUCCESS in 44m 42s (non-voting)\n- openstack-helm-compute-kit-rocky-ubuntu_bionic http://logs.openstack.org/06/673906/1/check/openstack-helm-compute-kit-rocky-ubuntu_bionic/6d8bb63/ : SUCCESS in 47m 05s (non-voting)\n- openstack-helm-compute-kit-rocky-opensuse_15 http://logs.openstack.org/06/673906/1/check/openstack-helm-compute-kit-rocky-opensuse_15/ebaadd3/ : SUCCESS in 46m 27s (non-voting)\n- openstack-helm-compute-kit-stein-ubuntu_bionic http://logs.openstack.org/06/673906/1/check/openstack-helm-compute-kit-stein-ubuntu_bionic/b5d5e7e/ : SUCCESS in 48m 14s (non-voting)\n- openstack-helm-horizon http://logs.openstack.org/06/673906/1/check/openstack-helm-horizon/32c7891/ : SUCCESS in 23m 32s\n- openstack-helm-apparmor http://logs.openstack.org/06/673906/1/check/openstack-helm-apparmor/4388494/ : SUCCESS in 36m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d77d62e6a7e63db94ca16acf01ed037e24966bd4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 21:05:40.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b308a374b59bcefaf84c0314049e7fc177508836","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 21:43:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/06/673906/1/gate/openstack-tox-docs/64d9c46/html/ : SUCCESS in 4m 31s\n- openstack-helm-lint http://logs.openstack.org/06/673906/1/gate/openstack-helm-lint/e318713/ : SUCCESS in 2m 25s\n- openstack-helm-cinder http://logs.openstack.org/06/673906/1/gate/openstack-helm-cinder/0e71cc1/ : SUCCESS in 32m 41s\n- openstack-helm-compute-kit http://logs.openstack.org/06/673906/1/gate/openstack-helm-compute-kit/77ed45c/ : SUCCESS in 36m 05s","accounts_in_message":[],"_revision_number":1},{"id":"0aa5496d7465acee9564ae1ba7400d148a3941cc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 21:43:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d4cf8f8c71ac21ccb12fdf6776398d0d7da0c4c8","revisions":{"d4cf8f8c71ac21ccb12fdf6776398d0d7da0c4c8":{"kind":"REWORK","_number":1,"created":"2019-07-31 20:06:21.000000000","uploader":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"ref":"refs/changes/06/673906/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/06/673906/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/06/673906/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/06/673906/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/06/673906/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/06/673906/1"}}},"commit":{"parents":[{"commit":"c3e727410d90f1b08f420c62e6f750e14733b774","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/c3e727410d90f1b08f420c62e6f750e14733b774"}]}],"author":{"name":"Pete Birley","email":"pete@port.direct","date":"2019-07-31 20:05:29.000000000","tz":-300},"committer":{"name":"Pete Birley","email":"pete@port.direct","date":"2019-07-31 20:05:29.000000000","tz":-300},"subject":"Cinder: Make image conversion dir an emptydir","message":"Cinder: Make image conversion dir an emptydir\n\nThis PS makes the image conversion directory an emptydir, so that\nwe can use read only containers and sill convert images from glance\ninto volumes.\n\nChange-Id: Id3cda737895451c2261bf9adfe54995db28c2f63\nSigned-off-by: Pete Birley \u003cpete@port.direct\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d4cf8f8c71ac21ccb12fdf6776398d0d7da0c4c8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d4cf8f8c71ac21ccb12fdf6776398d0d7da0c4c8"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c3e727410d90f1b08f420c62e6f750e14733b774","is_merged_in_target_branch":true,"change_id":"Ief7244bf134ccd64bf47a9978abff8c68177e5e3","change_number":673130,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}