)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2894b0f7a1a25cb4a462776020b9d8ba1c9d2f31","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     chengli3 \u003ccheng1.li@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-21 12:13:16 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support bond port with auto_bridge_add"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In neutron chart, ovs bridges are created and ports are added to some"},{"line_number":10,"context_line":"of the ovs bridges according to auto_bridge_add."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"3fa7e38b_b35e0643","line":7,"updated":"2019-10-24 06:54:25.000000000","message":"shouldn\u0027t this be handled by underlay OS management level, not sure if openstack helm chart is appropriate place for such deep networking configuration","commit_id":"2743f487f76a0d9c4549c780cf3d14100a714d7b"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"ec0d7e9efe11a1c93ee90878bc1aa0b394711bf6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     chengli3 \u003ccheng1.li@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-21 12:13:16 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support bond port with auto_bridge_add"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In neutron chart, ovs bridges are created and ports are added to some"},{"line_number":10,"context_line":"of the ovs bridges according to auto_bridge_add."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"3fa7e38b_1624a8ae","line":7,"in_reply_to":"3fa7e38b_b35e0643","updated":"2019-10-24 07:03:30.000000000","message":"When you say handle this by underlay OS, do you mean that we do this by hand instead of leveraging openstack-helm?","commit_id":"2743f487f76a0d9c4549c780cf3d14100a714d7b"}],"neutron/templates/bin/_neutron-openvswitch-agent-init.sh.tpl":[{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"4d319f5d1b5477e3747e8e521d87d89a13db602b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"do"},{"line_number":43,"context_line":"  br\u003d$(echo $bridge | sed \u0027s/\\\"//g\u0027)"},{"line_number":44,"context_line":"  ovs-vsctl --no-wait --may-exist add-br $br"},{"line_number":45,"context_line":"  if [ $(cat /tmp/auto_bridge_add | jq .$bridge | jq -r \u0027type\u0027) \u003d object  ]"},{"line_number":46,"context_line":"  then"},{"line_number":47,"context_line":"    brtype\u003d$(cat /tmp/auto_bridge_add | jq -r  .$bridge.type)"},{"line_number":48,"context_line":"    if [ $brtype \u003d bond ]"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_5c42c13f","line":45,"range":{"start_line":45,"start_character":2,"end_line":45,"end_character":75},"updated":"2019-08-06 02:11:50.000000000","message":"I guess that you are test if the port is bond or ethernet here right? So please add a comment here to explain the meaning.","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"1b3d2c6c602f1010102feb0f5d816d963d840683","unresolved":false,"context_lines":[{"line_number":42,"context_line":"do"},{"line_number":43,"context_line":"  br\u003d$(echo $bridge | sed \u0027s/\\\"//g\u0027)"},{"line_number":44,"context_line":"  ovs-vsctl --no-wait --may-exist add-br $br"},{"line_number":45,"context_line":"  if [ $(cat /tmp/auto_bridge_add | jq .$bridge | jq -r \u0027type\u0027) \u003d object  ]"},{"line_number":46,"context_line":"  then"},{"line_number":47,"context_line":"    brtype\u003d$(cat /tmp/auto_bridge_add | jq -r  .$bridge.type)"},{"line_number":48,"context_line":"    if [ $brtype \u003d bond ]"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_b7abce85","line":45,"range":{"start_line":45,"start_character":2,"end_line":45,"end_character":75},"in_reply_to":"7faddb67_5714da43","updated":"2019-08-06 05:29:05.000000000","message":"I mean you should add comment in the file, to explain this line code","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":30752,"name":"Qianshui Jiang","email":"qianshui.jiang@intel.com","username":"qianshui"},"change_message_id":"eb4f941b6086882650983555df5362540dbfea74","unresolved":false,"context_lines":[{"line_number":42,"context_line":"do"},{"line_number":43,"context_line":"  br\u003d$(echo $bridge | sed \u0027s/\\\"//g\u0027)"},{"line_number":44,"context_line":"  ovs-vsctl --no-wait --may-exist add-br $br"},{"line_number":45,"context_line":"  if [ $(cat /tmp/auto_bridge_add | jq .$bridge | jq -r \u0027type\u0027) \u003d object  ]"},{"line_number":46,"context_line":"  then"},{"line_number":47,"context_line":"    brtype\u003d$(cat /tmp/auto_bridge_add | jq -r  .$bridge.type)"},{"line_number":48,"context_line":"    if [ $brtype \u003d bond ]"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_5714da43","line":45,"range":{"start_line":45,"start_character":2,"end_line":45,"end_character":75},"in_reply_to":"7faddb67_5c42c13f","updated":"2019-08-06 05:15:29.000000000","message":"it\u0027s to determine whether the file is in new format or in old format.the interface in old format is going to be detected as \"string\"","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"4d319f5d1b5477e3747e8e521d87d89a13db602b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  if [ $(cat /tmp/auto_bridge_add | jq .$bridge | jq -r \u0027type\u0027) \u003d object  ]"},{"line_number":46,"context_line":"  then"},{"line_number":47,"context_line":"    brtype\u003d$(cat /tmp/auto_bridge_add | jq -r  .$bridge.type)"},{"line_number":48,"context_line":"    if [ $brtype \u003d bond ]"},{"line_number":49,"context_line":"    then"},{"line_number":50,"context_line":"      britf\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.slaves[])"},{"line_number":51,"context_line":"      bd_md\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.bond_mode )"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_7c38ddd1","line":48,"range":{"start_line":48,"start_character":10,"end_line":48,"end_character":16},"updated":"2019-08-06 02:11:50.000000000","message":"What if brtype  is empty?","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":30752,"name":"Qianshui Jiang","email":"qianshui.jiang@intel.com","username":"qianshui"},"change_message_id":"eb4f941b6086882650983555df5362540dbfea74","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  if [ $(cat /tmp/auto_bridge_add | jq .$bridge | jq -r \u0027type\u0027) \u003d object  ]"},{"line_number":46,"context_line":"  then"},{"line_number":47,"context_line":"    brtype\u003d$(cat /tmp/auto_bridge_add | jq -r  .$bridge.type)"},{"line_number":48,"context_line":"    if [ $brtype \u003d bond ]"},{"line_number":49,"context_line":"    then"},{"line_number":50,"context_line":"      britf\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.slaves[])"},{"line_number":51,"context_line":"      bd_md\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.bond_mode )"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_f751460f","line":48,"range":{"start_line":48,"start_character":10,"end_line":48,"end_character":16},"in_reply_to":"7faddb67_7c38ddd1","updated":"2019-08-06 05:15:29.000000000","message":"if it\u0027s empty,the script would exit with an error message bellow.","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"1b3d2c6c602f1010102feb0f5d816d963d840683","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  if [ $(cat /tmp/auto_bridge_add | jq .$bridge | jq -r \u0027type\u0027) \u003d object  ]"},{"line_number":46,"context_line":"  then"},{"line_number":47,"context_line":"    brtype\u003d$(cat /tmp/auto_bridge_add | jq -r  .$bridge.type)"},{"line_number":48,"context_line":"    if [ $brtype \u003d bond ]"},{"line_number":49,"context_line":"    then"},{"line_number":50,"context_line":"      britf\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.slaves[])"},{"line_number":51,"context_line":"      bd_md\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.bond_mode )"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_777a3624","line":48,"range":{"start_line":48,"start_character":10,"end_line":48,"end_character":16},"in_reply_to":"7faddb67_f751460f","updated":"2019-08-06 05:29:05.000000000","message":"No, if brtype is empty.\n```if  [ $brtype \u003d bond ]``` turns to ```if [ \u003d bond ]```\n\nThis is not expected. Please wrap $brtype with \"\"","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"4d319f5d1b5477e3747e8e521d87d89a13db602b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    brtype\u003d$(cat /tmp/auto_bridge_add | jq -r  .$bridge.type)"},{"line_number":48,"context_line":"    if [ $brtype \u003d bond ]"},{"line_number":49,"context_line":"    then"},{"line_number":50,"context_line":"      britf\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.slaves[])"},{"line_number":51,"context_line":"      bd_md\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.bond_mode )"},{"line_number":52,"context_line":"      port\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.port_name )"},{"line_number":53,"context_line":"      if [ ! -n \"$port\" ] || [ \"$port\" \u003d \"null\" ]"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_5c6ba1b5","line":50,"range":{"start_line":50,"start_character":6,"end_line":50,"end_character":11},"updated":"2019-08-06 02:11:50.000000000","message":"Can I know what the \u0027britf\u0027 stand for?","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":30752,"name":"Qianshui Jiang","email":"qianshui.jiang@intel.com","username":"qianshui"},"change_message_id":"eb4f941b6086882650983555df5362540dbfea74","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    brtype\u003d$(cat /tmp/auto_bridge_add | jq -r  .$bridge.type)"},{"line_number":48,"context_line":"    if [ $brtype \u003d bond ]"},{"line_number":49,"context_line":"    then"},{"line_number":50,"context_line":"      britf\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.slaves[])"},{"line_number":51,"context_line":"      bd_md\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.bond_mode )"},{"line_number":52,"context_line":"      port\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.port_name )"},{"line_number":53,"context_line":"      if [ ! -n \"$port\" ] || [ \"$port\" \u003d \"null\" ]"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_372efe8b","line":50,"range":{"start_line":50,"start_character":6,"end_line":50,"end_character":11},"in_reply_to":"7faddb67_5c6ba1b5","updated":"2019-08-06 05:15:29.000000000","message":"britf refers to bridge interface, it represents the interfaces claimed in slaves[].","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"4d319f5d1b5477e3747e8e521d87d89a13db602b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      britf\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.slaves[])"},{"line_number":51,"context_line":"      bd_md\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.bond_mode )"},{"line_number":52,"context_line":"      port\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.port_name )"},{"line_number":53,"context_line":"      if [ ! -n \"$port\" ] || [ \"$port\" \u003d \"null\" ]"},{"line_number":54,"context_line":"      then"},{"line_number":55,"context_line":"        port\u003dbond_$(echo $britf | sed \u0027s/[ ][ ]*/_/g\u0027)"},{"line_number":56,"context_line":"      fi"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_5c140144","line":53,"range":{"start_line":53,"start_character":11,"end_line":53,"end_character":15},"updated":"2019-08-06 02:11:50.000000000","message":"-z is better here","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"4d319f5d1b5477e3747e8e521d87d89a13db602b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        ovs-vsctl --may-exist add-bond $br $port $britf bond_mode\u003d$bd_md"},{"line_number":62,"context_line":"      fi"},{"line_number":63,"context_line":"    else"},{"line_number":64,"context_line":"      echo \"Type\u003e\u003e\u003e\u003e\u003e\u003e$brtype  is not supported, please check the type you set!\""},{"line_number":65,"context_line":"      exit 1"},{"line_number":66,"context_line":"    fi"},{"line_number":67,"context_line":"  else"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_1c48c959","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":79},"updated":"2019-08-06 02:11:50.000000000","message":"Please have the \"error\u0027 keyword in the message.","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"4d319f5d1b5477e3747e8e521d87d89a13db602b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  fi"},{"line_number":75,"context_line":"done"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"tunnel_interface\u003d\"{{- .Values.network.interface.tunnel -}}\""},{"line_number":79,"context_line":"if [ -z \"${tunnel_interface}\" ] ; then"},{"line_number":80,"context_line":"    # search for interface with tunnel network routing"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_9c6d99cd","line":77,"updated":"2019-08-06 02:11:50.000000000","message":"Don\u0027t see the need of this empty line","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"f72676a6644c0b72cd5d0c63fb7f2d244f516720","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      port\u003d$(cat /tmp/auto_bridge_add | jq -r .$bridge.port_name )"},{"line_number":54,"context_line":"      if [ -z \"$port\" ] || [ \"$port\" \u003d \"null\" ]"},{"line_number":55,"context_line":"      then"},{"line_number":56,"context_line":"        port\u003dbond_$(echo $britf | sed \u0027s/[ ][ ]*/_/g\u0027)"},{"line_number":57,"context_line":"      fi"},{"line_number":58,"context_line":"      if [ -z \"$bd_md\" ] || [ \"$bd_md\" \u003d \"null\" ]"},{"line_number":59,"context_line":"      then"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"7faddb67_0c5c1417","line":56,"range":{"start_line":56,"start_character":34,"end_line":56,"end_character":53},"updated":"2019-08-06 07:45:54.000000000","message":"I guess you are placing the spaces with _ right?\nHow about the following command?\n\n```\nsed \u0027s/ /_/g\u0027\n```","commit_id":"697e720f6ee672314eb88017adac3603cf880aeb"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4c56b7604658d7f65bb5a50d88cbd4b7ffa18ad2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        ovs-vsctl --may-exist add-bond $br $port $britf bond_mode\u003d$bd_md"},{"line_number":63,"context_line":"      fi"},{"line_number":64,"context_line":"    else"},{"line_number":65,"context_line":"      echo \"Error:The type\u003e\u003e\u003e\u003e\u003e\u003e$brtype is not supported, please check the type you set!\""},{"line_number":66,"context_line":"      exit 1"},{"line_number":67,"context_line":"    fi"},{"line_number":68,"context_line":"  else"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"5faad753_fb5a294e","line":65,"range":{"start_line":65,"start_character":26,"end_line":65,"end_character":32},"updated":"2019-09-10 15:28:09.000000000","message":"?","commit_id":"48cf0719fb2647449fab514774f4d513104fca42"}],"neutron/values.yaml":[{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"22a31751fbea341c4a9611b12d92044f343d0cd0","unresolved":false,"context_lines":[{"line_number":1924,"context_line":"          message-ttl: 70000"},{"line_number":1925,"context_line":"        priority: 0"},{"line_number":1926,"context_line":"        apply-to: all"},{"line_number":1927,"context_line":"        pattern: \u0027^(?!amq\\.).*\u0027"},{"line_number":1928,"context_line":"  ## NOTE: \"besteffort\" is meant for dev env with mixed compute type only."},{"line_number":1929,"context_line":"  ##       This helps prevent sriov init script from failing due to mis-matched NIC"},{"line_number":1930,"context_line":"  ##       For prod env, target NIC should match and init script should fail otherwise."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_f7abc3d2","line":1927,"range":{"start_line":1927,"start_character":8,"end_line":1927,"end_character":31},"updated":"2019-08-01 08:43:19.000000000","message":"What\u0027s this change for?","commit_id":"600c91129d5428391e1480097e9fb4232fa29204"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"22a31751fbea341c4a9611b12d92044f343d0cd0","unresolved":false,"context_lines":[{"line_number":1939,"context_line":"  #"},{"line_number":1940,"context_line":"  # auto_bridge_add:"},{"line_number":1941,"context_line":"  #   br-ex:"},{"line_number":1942,"context_line":"  #     br_name: br-ex "},{"line_number":1943,"context_line":"  #     type: bond/ethernet"},{"line_number":1944,"context_line":"  #     port_name: (be different to bridge name)"},{"line_number":1945,"context_line":"  #     bond_mode: (active-backup/balance-slb/balance-tcp)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_d797a78f","line":1942,"range":{"start_line":1942,"start_character":22,"end_line":1942,"end_character":23},"updated":"2019-08-01 08:43:19.000000000","message":"Please remove this line ending space","commit_id":"600c91129d5428391e1480097e9fb4232fa29204"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"22a31751fbea341c4a9611b12d92044f343d0cd0","unresolved":false,"context_lines":[{"line_number":1946,"context_line":"  #     slaves:"},{"line_number":1947,"context_line":"  #       - eth1"},{"line_number":1948,"context_line":"  #       - eth2"},{"line_number":1949,"context_line":"  #   br-ex1: null (or the interference to be bind to the bridge)"},{"line_number":1950,"context_line":"  # br-ex will be added by default"},{"line_number":1951,"context_line":"  auto_bridge_add:"},{"line_number":1952,"context_line":"    br-ex: null"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_f794238d","line":1949,"range":{"start_line":1949,"start_character":6,"end_line":1949,"end_character":12},"updated":"2019-08-01 08:43:19.000000000","message":"Please not change the origin sample bridge name. Let\u0027s get it back to \u0027br-ex\u0027, you can name your new bridge \u0027br-ex1\u0027","commit_id":"600c91129d5428391e1480097e9fb4232fa29204"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"4d319f5d1b5477e3747e8e521d87d89a13db602b","unresolved":false,"context_lines":[{"line_number":1935,"context_line":""},{"line_number":1936,"context_line":"  # auto_bridge_add is a set of To automatically add a physical interfaces to a specific bridges"},{"line_number":1937,"context_line":"  # for example eth3 to bridge br-physnet1, if0 to br0 and iface_two"},{"line_number":1938,"context_line":"  # and binding eth1 and eth2 to bridge br-ex to construct a bond which work in different bond mode"},{"line_number":1939,"context_line":"  # like this:"},{"line_number":1940,"context_line":"  # auto_bridge_add:"},{"line_number":1941,"context_line":"  #   br-ex:"},{"line_number":1942,"context_line":"  #     br_name: br-ex"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_5cc72197","line":1939,"range":{"start_line":1938,"start_character":65,"end_line":1939,"end_character":14},"updated":"2019-08-06 02:11:50.000000000","message":"I think we can remove these words","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"4d319f5d1b5477e3747e8e521d87d89a13db602b","unresolved":false,"context_lines":[{"line_number":1948,"context_line":"  #     slaves:"},{"line_number":1949,"context_line":"  #       - eth1"},{"line_number":1950,"context_line":"  #       - eth2"},{"line_number":1951,"context_line":"  #   br-physnet1: eth3"},{"line_number":1952,"context_line":"  #   br0: if0"},{"line_number":1953,"context_line":"  #   br1: iface_two"},{"line_number":1954,"context_line":"  #"},{"line_number":1955,"context_line":"  # br-ex will be added by default"},{"line_number":1956,"context_line":"  auto_bridge_add:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_bcf3b508","line":1953,"range":{"start_line":1951,"start_character":0,"end_line":1953,"end_character":20},"updated":"2019-08-06 02:11:50.000000000","message":"Please move these 3 lines up to your additional be-ex configuration.","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"1b3d2c6c602f1010102feb0f5d816d963d840683","unresolved":false,"context_lines":[{"line_number":1948,"context_line":"  #     slaves:"},{"line_number":1949,"context_line":"  #       - eth1"},{"line_number":1950,"context_line":"  #       - eth2"},{"line_number":1951,"context_line":"  #   br-physnet1: eth3"},{"line_number":1952,"context_line":"  #   br0: if0"},{"line_number":1953,"context_line":"  #   br1: iface_two"},{"line_number":1954,"context_line":"  #"},{"line_number":1955,"context_line":"  # br-ex will be added by default"},{"line_number":1956,"context_line":"  auto_bridge_add:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_97afb27b","line":1953,"range":{"start_line":1951,"start_character":0,"end_line":1953,"end_character":20},"in_reply_to":"7faddb67_bc3bb5e7","updated":"2019-08-06 05:29:05.000000000","message":"I  don\u0027t mean to remove these lines. I mean we should move these lines up. You additional configuration sample is supposed to be appended after original configuration, instead of inserting.","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":30752,"name":"Qianshui Jiang","email":"qianshui.jiang@intel.com","username":"qianshui"},"change_message_id":"eb4f941b6086882650983555df5362540dbfea74","unresolved":false,"context_lines":[{"line_number":1948,"context_line":"  #     slaves:"},{"line_number":1949,"context_line":"  #       - eth1"},{"line_number":1950,"context_line":"  #       - eth2"},{"line_number":1951,"context_line":"  #   br-physnet1: eth3"},{"line_number":1952,"context_line":"  #   br0: if0"},{"line_number":1953,"context_line":"  #   br1: iface_two"},{"line_number":1954,"context_line":"  #"},{"line_number":1955,"context_line":"  # br-ex will be added by default"},{"line_number":1956,"context_line":"  auto_bridge_add:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_bc3bb5e7","line":1953,"range":{"start_line":1951,"start_character":0,"end_line":1953,"end_character":20},"in_reply_to":"7faddb67_bcf3b508","updated":"2019-08-06 05:15:29.000000000","message":"it\u0027s for supporting the old format to bind single interface, Doesn\u0027t it necessary to give an example here?","commit_id":"a3a3bcefebcc192356e8f4af8cb1209b55ef0348"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"0d08c5e7838f80ec4b54835ef5d754b44430d200","unresolved":false,"context_lines":[{"line_number":1988,"context_line":"  #   br0: if0"},{"line_number":1989,"context_line":"  #   br1: iface_two"},{"line_number":1990,"context_line":"  #   br-physnet2:"},{"line_number":1991,"context_line":"  #     type: bond"},{"line_number":1992,"context_line":"  #     port_name: bond_eth1_eth2 is used if empty"},{"line_number":1993,"context_line":"  #     bond_mode: active-backup/balance-slb/balance-tcp, ovs default bond mode is used if empty"},{"line_number":1994,"context_line":"  #     slaves:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3fa7e38b_1af53057","line":1991,"range":{"start_line":1991,"start_character":7,"end_line":1991,"end_character":18},"updated":"2019-10-15 18:08:54.000000000","message":"nitpick... but we are talking about the port type here right, not bridge type?  and should we also state that currently only bonding is supported and not any other ovs port type?","commit_id":"b8ba91dfcfa24b63558d0a1e94f7de21e1259935"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"dafbf9828f88e6cdd5fbf50b2f7feb37a96a11f6","unresolved":false,"context_lines":[{"line_number":1988,"context_line":"  #   br0: if0"},{"line_number":1989,"context_line":"  #   br1: iface_two"},{"line_number":1990,"context_line":"  #   br-physnet2:"},{"line_number":1991,"context_line":"  #     type: bond"},{"line_number":1992,"context_line":"  #     port_name: bond_eth1_eth2 is used if empty"},{"line_number":1993,"context_line":"  #     bond_mode: active-backup/balance-slb/balance-tcp, ovs default bond mode is used if empty"},{"line_number":1994,"context_line":"  #     slaves:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3fa7e38b_cf2fd53c","line":1991,"range":{"start_line":1991,"start_character":7,"end_line":1991,"end_character":18},"in_reply_to":"3fa7e38b_1af53057","updated":"2019-10-16 01:03:18.000000000","message":"Yes, this is port type instead of bridge type.\nActually every item under auto_bridge_add is a key-value pair.\nThe key is bridge name, the value is the port properties.\n\nFor now, we only have requirement of bond type. Other port types supporting, we can make it future features.","commit_id":"b8ba91dfcfa24b63558d0a1e94f7de21e1259935"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"0d08c5e7838f80ec4b54835ef5d754b44430d200","unresolved":false,"context_lines":[{"line_number":1990,"context_line":"  #   br-physnet2:"},{"line_number":1991,"context_line":"  #     type: bond"},{"line_number":1992,"context_line":"  #     port_name: bond_eth1_eth2 is used if empty"},{"line_number":1993,"context_line":"  #     bond_mode: active-backup/balance-slb/balance-tcp, ovs default bond mode is used if empty"},{"line_number":1994,"context_line":"  #     slaves:"},{"line_number":1995,"context_line":"  #       - eth1"},{"line_number":1996,"context_line":"  #       - eth2"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3fa7e38b_e02c269a","line":1993,"range":{"start_line":1993,"start_character":11,"end_line":1993,"end_character":31},"updated":"2019-10-15 18:08:54.000000000","message":"should we also allow other ovs supported bond setting?","commit_id":"b8ba91dfcfa24b63558d0a1e94f7de21e1259935"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"dafbf9828f88e6cdd5fbf50b2f7feb37a96a11f6","unresolved":false,"context_lines":[{"line_number":1990,"context_line":"  #   br-physnet2:"},{"line_number":1991,"context_line":"  #     type: bond"},{"line_number":1992,"context_line":"  #     port_name: bond_eth1_eth2 is used if empty"},{"line_number":1993,"context_line":"  #     bond_mode: active-backup/balance-slb/balance-tcp, ovs default bond mode is used if empty"},{"line_number":1994,"context_line":"  #     slaves:"},{"line_number":1995,"context_line":"  #       - eth1"},{"line_number":1996,"context_line":"  #       - eth2"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3fa7e38b_efc09152","line":1993,"range":{"start_line":1993,"start_character":11,"end_line":1993,"end_character":31},"in_reply_to":"3fa7e38b_e02c269a","updated":"2019-10-16 01:03:18.000000000","message":"This value is going to be passed to ovs-vsctl. So any bond mode ovs support, we support it as well. I can update this sample to make is clear.","commit_id":"b8ba91dfcfa24b63558d0a1e94f7de21e1259935"}]}