)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"62581434031103f8b4ec514c7bf30bf15088c279","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Oleg Bondarev \u003cobondarev@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-03 10:53:02 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[neutron] Add DVR support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With DVR feature enabled in neutron l3 and metadata agents"},{"line_number":10,"context_line":"will be deployed on compute nodes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_6a3a6498","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":17},"updated":"2019-09-04 16:56:45.000000000","message":"if you revisit that it might be good to expand that in the commitmsg somewhere","commit_id":"a307bacdc317db9d3c7a39874107947ef5144520"}],"neutron/templates/daemonset-metadata-agent.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"43a85439ecb5f992b466dd436e4420a9677527e5","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    spec:"},{"line_number":72,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"neutron_metadata_agent\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":73,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":74,"context_line":"      {{- if .Values.network.dvr }}"},{"line_number":75,"context_line":"      affinity:"},{"line_number":76,"context_line":"        nodeAffinity:"},{"line_number":77,"context_line":"          requiredDuringSchedulingIgnoredDuringExecution:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_0f57b429","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":33},"updated":"2019-12-03 16:16:51.000000000","message":"A default value of false should be added to the values.yaml. Also, should this be .dvr.enabled?","commit_id":"7f8dca5ad726fca5f6d3aaffdcca090dfeb798be"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0c32a98ad1d5601d8a9e8619c0511353df4e160a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    spec:"},{"line_number":72,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"neutron_metadata_agent\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":73,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":74,"context_line":"      {{- if .Values.network.dvr }}"},{"line_number":75,"context_line":"      affinity:"},{"line_number":76,"context_line":"        nodeAffinity:"},{"line_number":77,"context_line":"          requiredDuringSchedulingIgnoredDuringExecution:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_55eae4d8","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":33},"in_reply_to":"3fa7e38b_0f57b429","updated":"2019-12-06 12:27:12.000000000","message":"\u003e A default value of false should be added to the values.yaml.\n\nDone\n\n \u003e Also, should this be .dvr.enabled?\n\nWhy?","commit_id":"7f8dca5ad726fca5f6d3aaffdcca090dfeb798be"}],"neutron/values.yaml":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8cf4ea4e7e389e13c6a00d373c584001203e45c5","unresolved":false,"context_lines":[{"line_number":1960,"context_line":"        conf:"},{"line_number":1961,"context_line":"          l3_agent:"},{"line_number":1962,"context_line":"            DEFAULT:"},{"line_number":1963,"context_line":"              agent_mode: dvr"},{"line_number":1964,"context_line":"      - label:"},{"line_number":1965,"context_line":"          key: snat"},{"line_number":1966,"context_line":"          values:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_e09670f0","line":1963,"range":{"start_line":1963,"start_character":14,"end_line":1963,"end_character":29},"updated":"2019-08-05 07:05:51.000000000","message":"In my test setup I have 3 nodes labeled with \u0027dvr\u0027 and 1 node labeled with both \u0027dvr\u0027 and \u0027snat\u0027 - but for some reason on each of those 4 nodes l3 agent has dvr_snat mode. Not sure if it\u0027s a bug or some wrong config. l3 agent daemonset naming in pod list seems correct:\n\nneutron-l3-agent-dvr-012d1698-59rs9\nneutron-l3-agent-dvr-012d1698-nth42\nneutron-l3-agent-dvr-012d1698-xrr9j\nneutron-l3-agent-snat-a263e36a-n7q7v","commit_id":"4fe7aac0b39a174f810405cd120c2087699ea1ad"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9b4eed643984e780b3aaa4f151d41a12e45c08ac","unresolved":false,"context_lines":[{"line_number":1960,"context_line":"        conf:"},{"line_number":1961,"context_line":"          l3_agent:"},{"line_number":1962,"context_line":"            DEFAULT:"},{"line_number":1963,"context_line":"              agent_mode: dvr"},{"line_number":1964,"context_line":"      - label:"},{"line_number":1965,"context_line":"          key: snat"},{"line_number":1966,"context_line":"          values:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_1bc3013a","line":1963,"range":{"start_line":1963,"start_character":14,"end_line":1963,"end_character":29},"in_reply_to":"7faddb67_e09670f0","updated":"2019-08-05 07:49:33.000000000","message":"Seems it\u0027s https://storyboard.openstack.org/#!/story/2005936 and I have to update helm infra.","commit_id":"4fe7aac0b39a174f810405cd120c2087699ea1ad"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e68300027664c84bb698d31e8b447592f680f68c","unresolved":false,"context_lines":[{"line_number":1749,"context_line":"      #(NOTE)portdirect: if unset this is populated dynamically from the value in"},{"line_number":1750,"context_line":"      # \u0027network.backend\u0027 to sane defaults."},{"line_number":1751,"context_line":"      interface_driver: null"},{"line_number":1752,"context_line":"      router_distributed: False"},{"line_number":1753,"context_line":"    oslo_concurrency:"},{"line_number":1754,"context_line":"      lock_path: /var/lib/neutron/tmp"},{"line_number":1755,"context_line":"    database:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_ddafd3dd","line":1752,"updated":"2019-09-02 08:26:07.000000000","message":"I suggest to move all dvr related options to values-overrides/dvr.yaml like it is done for ldap in keystone https://github.com/openstack/openstack-helm/blob/master/keystone/values_overrides/ldap.yaml\n\nand left here only general values:networking:dvr:false","commit_id":"1cebdac617414921c35a123a2c3b460aeb81dd0b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"fee1098225c89791c0c626835bc52d24cab8cf4e","unresolved":false,"context_lines":[{"line_number":1749,"context_line":"      #(NOTE)portdirect: if unset this is populated dynamically from the value in"},{"line_number":1750,"context_line":"      # \u0027network.backend\u0027 to sane defaults."},{"line_number":1751,"context_line":"      interface_driver: null"},{"line_number":1752,"context_line":"      router_distributed: False"},{"line_number":1753,"context_line":"    oslo_concurrency:"},{"line_number":1754,"context_line":"      lock_path: /var/lib/neutron/tmp"},{"line_number":1755,"context_line":"    database:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_835ed8e6","line":1752,"in_reply_to":"7faddb67_20659ae1","updated":"2019-09-02 11:19:05.000000000","message":"dvr enablement requires some changes in different places, so it is good practice to place them in one file, so when deployment engineer needs to enable some feature, all changes might be easily identified. I think you can consider values-overrides as some sort of documentation for features.","commit_id":"1cebdac617414921c35a123a2c3b460aeb81dd0b"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"870e9de8a4afbad265897a41e65a2d0f5981b561","unresolved":false,"context_lines":[{"line_number":1749,"context_line":"      #(NOTE)portdirect: if unset this is populated dynamically from the value in"},{"line_number":1750,"context_line":"      # \u0027network.backend\u0027 to sane defaults."},{"line_number":1751,"context_line":"      interface_driver: null"},{"line_number":1752,"context_line":"      router_distributed: False"},{"line_number":1753,"context_line":"    oslo_concurrency:"},{"line_number":1754,"context_line":"      lock_path: /var/lib/neutron/tmp"},{"line_number":1755,"context_line":"    database:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_20659ae1","line":1752,"in_reply_to":"7faddb67_ddafd3dd","updated":"2019-09-02 09:48:24.000000000","message":"It will require additional changes (need to include dvr.yaml somewhere), which problem will it solve? What\u0027s wrong with having DVR here?","commit_id":"1cebdac617414921c35a123a2c3b460aeb81dd0b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e68300027664c84bb698d31e8b447592f680f68c","unresolved":false,"context_lines":[{"line_number":1866,"context_line":"        tunnel_types: vxlan"},{"line_number":1867,"context_line":"        l2_population: True"},{"line_number":1868,"context_line":"        arp_responder: True"},{"line_number":1869,"context_line":"        enable_distributed_routing: False"},{"line_number":1870,"context_line":"      ovs:"},{"line_number":1871,"context_line":"        bridge_mappings: \"external:br-ex\""},{"line_number":1872,"context_line":"      securitygroup:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_7d825f54","line":1869,"updated":"2019-09-02 08:26:07.000000000","message":"ditto","commit_id":"1cebdac617414921c35a123a2c3b460aeb81dd0b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e68300027664c84bb698d31e8b447592f680f68c","unresolved":false,"context_lines":[{"line_number":1951,"context_line":"  # br-ex will be added by default"},{"line_number":1952,"context_line":"  auto_bridge_add:"},{"line_number":1953,"context_line":"    br-ex: null"},{"line_number":1954,"context_line":"  overrides:"},{"line_number":1955,"context_line":"    neutron_l3-agent:"},{"line_number":1956,"context_line":"      labels:"},{"line_number":1957,"context_line":"      - label:"},{"line_number":1958,"context_line":"          key: openstack-compute-node"},{"line_number":1959,"context_line":"          values:"},{"line_number":1960,"context_line":"          - \"enabled\""},{"line_number":1961,"context_line":"        conf:"},{"line_number":1962,"context_line":"          l3_agent:"},{"line_number":1963,"context_line":"            DEFAULT:"},{"line_number":1964,"context_line":"              agent_mode: dvr"},{"line_number":1965,"context_line":"      - label:"},{"line_number":1966,"context_line":"          key: openstack-control-plane"},{"line_number":1967,"context_line":"          values:"},{"line_number":1968,"context_line":"          - \"enabled\""},{"line_number":1969,"context_line":"        conf:"},{"line_number":1970,"context_line":"          l3_agent:"},{"line_number":1971,"context_line":"            DEFAULT:"},{"line_number":1972,"context_line":"              agent_mode: dvr_snat"},{"line_number":1973,"context_line":""},{"line_number":1974,"context_line":"# Names of secrets used by bootstrap and environmental checks"},{"line_number":1975,"context_line":"secrets:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_9d871b62","line":1972,"range":{"start_line":1954,"start_character":2,"end_line":1972,"end_character":34},"updated":"2019-09-02 08:26:07.000000000","message":"ditto","commit_id":"1cebdac617414921c35a123a2c3b460aeb81dd0b"}],"neutron/values_overrides/dvr.yaml":[{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"a5347ff3709b259012b0f3111ede148ab5053e05","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    openvswitch_agent:"},{"line_number":12,"context_line":"      agent:"},{"line_number":13,"context_line":"        enable_distributed_routing: True"},{"line_number":14,"context_line":"  overrides:"},{"line_number":15,"context_line":"    neutron_l3-agent:"},{"line_number":16,"context_line":"      labels:"},{"line_number":17,"context_line":"      - label:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_df443c4a","line":14,"updated":"2019-10-18 01:27:18.000000000","message":"sorry to be ignorant here. But could you please provide some reference links explaining why this override work? Thank you.","commit_id":"26f77a0435795255b81164b1fcbf38867b5716d4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0d1dbb8b47bed3d2d441bdd35095c4a71ad40d75","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    openvswitch_agent:"},{"line_number":12,"context_line":"      agent:"},{"line_number":13,"context_line":"        enable_distributed_routing: True"},{"line_number":14,"context_line":"  overrides:"},{"line_number":15,"context_line":"    neutron_l3-agent:"},{"line_number":16,"context_line":"      labels:"},{"line_number":17,"context_line":"      - label:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_9cc6b949","line":14,"in_reply_to":"3fa7e38b_25e1bafd","updated":"2019-10-21 07:10:12.000000000","message":"Well, it\u0027s probably some issue with how you pass values/deploy neutron chart. Please verify that your values have this overrides section. Details on node label specific configuration can be found here: https://github.com/openstack/openstack-helm/blob/master/doc/source/devref/node-and-label-specific-configurations.rst","commit_id":"26f77a0435795255b81164b1fcbf38867b5716d4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7aca918bda80648fe8d6aca119384bc407fd3cba","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    openvswitch_agent:"},{"line_number":12,"context_line":"      agent:"},{"line_number":13,"context_line":"        enable_distributed_routing: True"},{"line_number":14,"context_line":"  overrides:"},{"line_number":15,"context_line":"    neutron_l3-agent:"},{"line_number":16,"context_line":"      labels:"},{"line_number":17,"context_line":"      - label:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_d618a21f","line":14,"in_reply_to":"3fa7e38b_902d51ff","updated":"2019-10-18 09:26:16.000000000","message":"sorry, didn\u0027t get you: this overrides make \u0027agent_mode\u0027 in l3_agent.ini on nodes with openstack-compute-node label have \u0027dvr\u0027 value; on nodes with openstack-control-plane label have \u0027dvr_snat\u0027 value. configmap-etc doesn\u0027t do anything in regarding agent_mode.","commit_id":"26f77a0435795255b81164b1fcbf38867b5716d4"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"220585b42c458feabbaecece5ac68b5d3ca0337e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    openvswitch_agent:"},{"line_number":12,"context_line":"      agent:"},{"line_number":13,"context_line":"        enable_distributed_routing: True"},{"line_number":14,"context_line":"  overrides:"},{"line_number":15,"context_line":"    neutron_l3-agent:"},{"line_number":16,"context_line":"      labels:"},{"line_number":17,"context_line":"      - label:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_902d51ff","line":14,"in_reply_to":"3fa7e38b_959d43bd","updated":"2019-10-18 08:33:01.000000000","message":"no. in my opinion for dvr mode, l3-agent on different nodes should have different agent mode configured. I would like to know how this patch enables that? because seems that contents of l3_agent.ini in configmap-etc is fixed for every pod using it.","commit_id":"26f77a0435795255b81164b1fcbf38867b5716d4"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"ba8db8595c0a8cd42c614034714c45763a15515a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    openvswitch_agent:"},{"line_number":12,"context_line":"      agent:"},{"line_number":13,"context_line":"        enable_distributed_routing: True"},{"line_number":14,"context_line":"  overrides:"},{"line_number":15,"context_line":"    neutron_l3-agent:"},{"line_number":16,"context_line":"      labels:"},{"line_number":17,"context_line":"      - label:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_4246977d","line":14,"in_reply_to":"3fa7e38b_9cc6b949","updated":"2019-10-29 14:32:39.000000000","message":"Hi, seems like `daemonset_overrides` will add a default deamonset https://github.com/openstack/openstack-helm-infra/blob/74f3eb5824f7c52173088d63297f36769ed77a4e/helm-toolkit/templates/utils/_daemonset_overrides.tpl#L184. How can i disable it? I need to run l3 agent on control or compute node only.","commit_id":"26f77a0435795255b81164b1fcbf38867b5716d4"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"b9fb8a205ac97deaa1e168cf4e2bc738d5070b51","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    openvswitch_agent:"},{"line_number":12,"context_line":"      agent:"},{"line_number":13,"context_line":"        enable_distributed_routing: True"},{"line_number":14,"context_line":"  overrides:"},{"line_number":15,"context_line":"    neutron_l3-agent:"},{"line_number":16,"context_line":"      labels:"},{"line_number":17,"context_line":"      - label:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_25e1bafd","line":14,"in_reply_to":"3fa7e38b_d618a21f","updated":"2019-10-18 14:02:07.000000000","message":"ok, this is what i am asking： why this overrides will work that way? I still see agent_mode set to legacy in configmap-etc even though I set --values\u003ddvr.yaml.","commit_id":"26f77a0435795255b81164b1fcbf38867b5716d4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ddce10e5b66f4bee10e3a3add883cae900cc68de","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    openvswitch_agent:"},{"line_number":12,"context_line":"      agent:"},{"line_number":13,"context_line":"        enable_distributed_routing: True"},{"line_number":14,"context_line":"  overrides:"},{"line_number":15,"context_line":"    neutron_l3-agent:"},{"line_number":16,"context_line":"      labels:"},{"line_number":17,"context_line":"      - label:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_959d43bd","line":14,"in_reply_to":"3fa7e38b_df443c4a","updated":"2019-10-18 07:02:34.000000000","message":"Sure, DVR configuration is described here https://docs.openstack.org/neutron/pike/admin/deploy-ovs-ha-dvr.html. Did I get you right?","commit_id":"26f77a0435795255b81164b1fcbf38867b5716d4"}]}