)]}'
{"cinder/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5374c979df703abfb4650a7eb4322f5637859af5","unresolved":false,"context_lines":[{"line_number":1300,"context_line":"      api:"},{"line_number":1301,"context_line":"        default: 8776"},{"line_number":1302,"context_line":"        public: 80"},{"line_number":1303,"context_line":"    ip:"},{"line_number":1304,"context_line":"      ingress: None"},{"line_number":1305,"context_line":"  volumev2:"},{"line_number":1306,"context_line":"    name: cinderv2"},{"line_number":1307,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1fa4df85_34927058","line":1304,"range":{"start_line":1303,"start_character":0,"end_line":1304,"end_character":19},"updated":"2020-03-10 13:43:40.000000000","message":"without the osh-infra dependencies, these keys are not being used.","commit_id":"54b784f3c986c0ecd03a2ccc7eb605441b595a45"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"43ba7411aea47071c075277f63d40502b22db7f4","unresolved":false,"context_lines":[{"line_number":1300,"context_line":"      api:"},{"line_number":1301,"context_line":"        default: 8776"},{"line_number":1302,"context_line":"        public: 80"},{"line_number":1303,"context_line":"    ip:"},{"line_number":1304,"context_line":"      ingress: None"},{"line_number":1305,"context_line":"  volumev2:"},{"line_number":1306,"context_line":"    name: cinderv2"},{"line_number":1307,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1fa4df85_b4bd00b8","line":1304,"range":{"start_line":1303,"start_character":0,"end_line":1304,"end_character":19},"in_reply_to":"1fa4df85_34927058","updated":"2020-03-10 13:46:06.000000000","message":"https://review.opendev.org/#/c/675777 is the one and has same topic and this PS.","commit_id":"54b784f3c986c0ecd03a2ccc7eb605441b595a45"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"5f32a822a03d08be87f09aefb97c6c51c2134599","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"      api:"},{"line_number":1303,"context_line":"        default: 8776"},{"line_number":1304,"context_line":"        public: 80"},{"line_number":1305,"context_line":"    ip:"},{"line_number":1306,"context_line":"      # To set headless service, set ingress to None"},{"line_number":1307,"context_line":"      # To set service ClusetrIP to a specific IP, set ingress to the IP"},{"line_number":1308,"context_line":"      # To allocate service ClusetrIP automatically, remove ingress field."},{"line_number":1309,"context_line":"      ingress: None"},{"line_number":1310,"context_line":"  volumev2:"},{"line_number":1311,"context_line":"    name: cinderv2"},{"line_number":1312,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1fa4df85_95eea289","line":1309,"range":{"start_line":1305,"start_character":0,"end_line":1309,"end_character":19},"updated":"2020-03-11 19:58:28.000000000","message":"This is a global comments... so now that we have add \"ingress: None\" to the values.yaml, how is anyone suppose to \"remove\" this field via override?  Also we are changing the default behavior to headless, is the community ok with this change?","commit_id":"d46d6552ea6b8226aceac20089123d619c0fc1cd"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"73404f44024ff4602838b04cc5f31f879f533b00","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"      api:"},{"line_number":1303,"context_line":"        default: 8776"},{"line_number":1304,"context_line":"        public: 80"},{"line_number":1305,"context_line":"    ip:"},{"line_number":1306,"context_line":"      # To set headless service, set ingress to None"},{"line_number":1307,"context_line":"      # To set service ClusetrIP to a specific IP, set ingress to the IP"},{"line_number":1308,"context_line":"      # To allocate service ClusetrIP automatically, remove ingress field."},{"line_number":1309,"context_line":"      ingress: None"},{"line_number":1310,"context_line":"  volumev2:"},{"line_number":1311,"context_line":"    name: cinderv2"},{"line_number":1312,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1fa4df85_952f82a6","line":1309,"range":{"start_line":1305,"start_character":0,"end_line":1309,"end_character":19},"in_reply_to":"1fa4df85_1575d2cc","updated":"2020-03-11 20:06:29.000000000","message":"This is what I and Roy were just discussing. I agree this could be brought up in IRC call and a decision can be made.","commit_id":"d46d6552ea6b8226aceac20089123d619c0fc1cd"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"cf00df74c5f358c5c854e120a994804b4d37acfc","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"      api:"},{"line_number":1303,"context_line":"        default: 8776"},{"line_number":1304,"context_line":"        public: 80"},{"line_number":1305,"context_line":"    ip:"},{"line_number":1306,"context_line":"      # To set headless service, set ingress to None"},{"line_number":1307,"context_line":"      # To set service ClusetrIP to a specific IP, set ingress to the IP"},{"line_number":1308,"context_line":"      # To allocate service ClusetrIP automatically, remove ingress field."},{"line_number":1309,"context_line":"      ingress: None"},{"line_number":1310,"context_line":"  volumev2:"},{"line_number":1311,"context_line":"    name: cinderv2"},{"line_number":1312,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1fa4df85_1575d2cc","line":1309,"range":{"start_line":1305,"start_character":0,"end_line":1309,"end_character":19},"in_reply_to":"1fa4df85_95eea289","updated":"2020-03-11 20:04:27.000000000","message":"Perhaps a topic to raise during next week\u0027s IRC meeting (or mid cycle). One proposal we can do may be to comment out this entire block and have the deployer override it (if they choose) downstream - allowing for the scenario where they will get an unspecified IP.","commit_id":"d46d6552ea6b8226aceac20089123d619c0fc1cd"}]}
