)]}'
{"id":"openstack%2Fopenstack-helm~682669","triplet_id":"openstack%2Fopenstack-helm~master~I50cbd0b11b55711dc484c0a4c382301a4680edb3","project":"openstack/openstack-helm","branch":"master","hashtags":[],"change_id":"I50cbd0b11b55711dc484c0a4c382301a4680edb3","subject":"Simplify code for value overrides for ceph","status":"MERGED","created":"2019-09-17 14:57:07.000000000","updated":"2019-09-26 04:12:31.000000000","submitted":"2019-09-25 08:22:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"682669-1569399768766-efb49f7a","meta_rev_id":"6967f39b8e66aa90c898ec2e51cc4fb18146c644","_number":682669,"virtual_id_number":682669,"owner":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-25 08:22:48.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-09-20 17:27:57.000000000","_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},{"value":2,"date":"2019-09-24 21:06:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":2,"date":"2019-09-25 07:39:25.000000000","_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":1,"date":"2019-09-25 07:39:25.000000000","_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"date":"2019-09-20 17:27:48.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"date":"2019-09-24 14:50:00.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-20 17:27:48.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2019-09-24 14:50:00.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2019-09-24 21:06:01.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-09-25 07:39:25.000000000","updated_by":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"reviewer":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"state":"REVIEWER"},{"updated":"2019-09-25 08:22:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"db335d0b2f7dffb5ef8a17ef6e5e2acb9187b279","author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"date":"2019-09-17 14:57:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f10d6238754498442307bec3cd8e0deff00b108b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 16:14:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/96f1d4a9fb284e61ba7a61f21897a033 : SUCCESS in 4m 54s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/5c610197bddb4bd4ba1f4ebfd4ea3e48 : SUCCESS in 1m 32s\n- openstack-helm-cinder https://zuul.opendev.org/t/openstack/build/8a21554aa0c34ac89596649f68c43cb2 : FAILURE in 11m 37s\n- openstack-helm-cinder-pike-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/bdace6362c54409e95aea2d090ae2b57 : FAILURE in 11m 41s (non-voting)\n- openstack-helm-cinder-queens-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/e58a5789668848cb88eae32b3bfb9ddd : FAILURE in 13m 57s (non-voting)\n- openstack-helm-cinder-rocky-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/cb0d83c634fa44908eb252efd354e7f3 : FAILURE in 13m 34s (non-voting)\n- openstack-helm-cinder-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/9824f55eb1ee405482f5c24ac6140e96 : FAILURE in 12m 30s (non-voting)\n- openstack-helm-cinder-rocky-opensuse_15 https://zuul.opendev.org/t/openstack/build/0f5175a97a624cb680cb295813abf2f3 : FAILURE in 11m 37s (non-voting)\n- openstack-helm-cinder-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/226082ea442b4aa2b7c4b895bbe91805 : FAILURE in 12m 57s (non-voting)\n- openstack-helm-compute-kit https://zuul.opendev.org/t/openstack/build/238e6f933a7541239d9718175624637e : SUCCESS in 41m 51s\n- openstack-helm-compute-kit-pike-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/b047b9e0137a4e33810327423c3518fb : SUCCESS in 52m 03s (non-voting)\n- openstack-helm-compute-kit-queens-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/157c9ea012a841c09c0ed5a94002a2e1 : SUCCESS in 49m 47s (non-voting)\n- openstack-helm-compute-kit-rocky-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/70b671004d4e4795864066c22ab7ee15 : SUCCESS in 50m 07s (non-voting)\n- openstack-helm-compute-kit-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/13c5b3a995f14f5b8523a5b58d8675e6 : SUCCESS in 47m 16s (non-voting)\n- openstack-helm-compute-kit-rocky-opensuse_15 https://zuul.opendev.org/t/openstack/build/a31f010d4cef4dd9bcfc15b6f3157131 : SUCCESS in 45m 21s (non-voting)\n- openstack-helm-compute-kit-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/3287189b90a54f8db2864f94edd51308 : SUCCESS in 44m 18s (non-voting)\n- openstack-helm-horizon https://zuul.opendev.org/t/openstack/build/aa2d061e21ec4fd5bd1e9ef16aab4682 : SUCCESS in 23m 53s\n- openstack-helm-apparmor https://zuul.opendev.org/t/openstack/build/4748cd611eed4304a15724d39c63260e : SUCCESS in 48m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4f3f7bdc1342b065552687c0e58e5177c0e26917","author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"date":"2019-09-17 17:14:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6f5b10de812a19f049ed9c6ad0dbaf495fffbbe3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 18:12:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/34e8d5eae7444dc5ace9df93c1fc0e5b : SUCCESS in 6m 27s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/e605b44dfe314cafb948843d6dac4af6 : SUCCESS in 1m 27s\n- openstack-helm-cinder https://zuul.opendev.org/t/openstack/build/ce6f5354db0f4ba2b492647182cb092e : SUCCESS in 39m 02s\n- openstack-helm-cinder-pike-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/04ce8e235cc741deb9e59f0eaeecc448 : SUCCESS in 35m 01s (non-voting)\n- openstack-helm-cinder-queens-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/8b032b543344487b8d03523ab712e98f : SUCCESS in 38m 44s (non-voting)\n- openstack-helm-cinder-rocky-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/70f929a755be4858984eee7bc50a8e8f : SUCCESS in 39m 24s (non-voting)\n- openstack-helm-cinder-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/10e555055aba43b8b716dbfb8388a47c : SUCCESS in 40m 56s (non-voting)\n- openstack-helm-cinder-rocky-opensuse_15 https://zuul.opendev.org/t/openstack/build/0a828a3822504864a8bdcfc4548ec8b8 : SUCCESS in 40m 51s (non-voting)\n- openstack-helm-cinder-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/9acf1147b90942159adf3fed64615deb : SUCCESS in 40m 03s (non-voting)\n- openstack-helm-compute-kit https://zuul.opendev.org/t/openstack/build/22b754fbb47e4ab7b9a512ae04420b4c : SUCCESS in 47m 44s\n- openstack-helm-compute-kit-pike-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/23974f30f4fe41ce9f66128249295b90 : SUCCESS in 50m 03s (non-voting)\n- openstack-helm-compute-kit-queens-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/d999904f945f4d3c817473b6f2d1970a : SUCCESS in 48m 21s (non-voting)\n- openstack-helm-compute-kit-rocky-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/316dfd3ad44f43f6ae1ca2011a86f36d : SUCCESS in 51m 11s (non-voting)\n- openstack-helm-compute-kit-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/dfd4d05046404b25b5e6cb53c31626e0 : SUCCESS in 47m 36s (non-voting)\n- openstack-helm-compute-kit-rocky-opensuse_15 https://zuul.opendev.org/t/openstack/build/831406d1b44447929ffa832ebd9b56e8 : SUCCESS in 49m 05s (non-voting)\n- openstack-helm-compute-kit-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/58e1c529667948b7b46e00ada93b2001 : SUCCESS in 46m 54s (non-voting)\n- openstack-helm-horizon https://zuul.opendev.org/t/openstack/build/12937d96cb7b4cfea6c01b9e5967111a : SUCCESS in 25m 12s\n- openstack-helm-apparmor https://zuul.opendev.org/t/openstack/build/c5764e4b84bb4f64828b0c4f5c8e9462 : SUCCESS in 45m 06s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"30f1cf44a74d48321627c67b2275fbf5a91a272c","author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"date":"2019-09-20 17:27:57.000000000","message":"Patch Set 2:\n\nPlease review. Thank you!","accounts_in_message":[],"_revision_number":2},{"id":"c07b91c3e0b3c123a39d333ab6cc6500cd274209","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-09-24 21:06:01.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a3511a8bd66473ac6881f084a1638e59668f1225","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-09-25 07:39:25.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nCool, I guess we can extend this to all charts that has overrides?","accounts_in_message":[],"_revision_number":2},{"id":"7b0516fdae088dde5817d068a4f023ad8a66cb6f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 07:39:38.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"bc768782cd0c14e41e5584bb51b4286c98d649e8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 08:22:48.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/521afed2226449aba76a5a2bffa3b178 : SUCCESS in 6m 13s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/74eab0d019f84925be85c83e0a1d72f6 : SUCCESS in 1m 40s\n- openstack-helm-cinder https://zuul.opendev.org/t/openstack/build/55334af20c6b471295d169e220ebe7e0 : SUCCESS in 35m 15s\n- openstack-helm-compute-kit https://zuul.opendev.org/t/openstack/build/9f74684024a1408b977748952a73cc40 : SUCCESS in 37m 35s","accounts_in_message":[],"_revision_number":2},{"id":"79fc5cb551c33602b6f88ecc3020938301a0882b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 08:22:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"910d5fe930eafdbc64ac56c9b585cf4d60f82a07","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 08:24:15.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7ae052cc670d4c618e5d5f2b7f58c9d5 : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":2},{"id":"6967f39b8e66aa90c898ec2e51cc4fb18146c644","author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"date":"2019-09-26 04:12:31.000000000","message":"Patch Set 2:\n\nThank you for review. The most value here is for ceph because we install multiple charts in a loop","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"11f02edc43984667684930901fc2e3571046223f","revisions":{"fdc7895af194ae231538d3c98d887d9636cd97f0":{"kind":"REWORK","_number":1,"created":"2019-09-17 14:57:07.000000000","uploader":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"ref":"refs/changes/69/682669/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/69/682669/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/69/682669/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/69/682669/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/69/682669/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/69/682669/1"}}},"commit":{"parents":[{"commit":"c54f51c603141c08ce5291711ba8fccf6c8c7c67","subject":"Mount all ironic conductor volumes.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/c54f51c603141c08ce5291711ba8fccf6c8c7c67"}]}],"author":{"name":"Andrii Ostapenko","email":"aostapenko@mirantis.com","date":"2019-09-17 14:56:07.000000000","tz":-300},"committer":{"name":"Andrii Ostapenko","email":"aostapenko@mirantis.com","date":"2019-09-17 14:56:07.000000000","tz":-300},"subject":"Simplify code for value overrides for ceph","message":"Simplify code for value overrides for ceph\n\nChange-Id: I50cbd0b11b55711dc484c0a4c382301a4680edb3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/fdc7895af194ae231538d3c98d887d9636cd97f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/fdc7895af194ae231538d3c98d887d9636cd97f0"}]},"branch":"refs/heads/master"},"11f02edc43984667684930901fc2e3571046223f":{"kind":"REWORK","_number":2,"created":"2019-09-17 17:14:59.000000000","uploader":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"ref":"refs/changes/69/682669/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/69/682669/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/69/682669/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/69/682669/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/69/682669/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/69/682669/2"}}},"commit":{"parents":[{"commit":"c54f51c603141c08ce5291711ba8fccf6c8c7c67","subject":"Mount all ironic conductor volumes.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/c54f51c603141c08ce5291711ba8fccf6c8c7c67"}]}],"author":{"name":"Andrii Ostapenko","email":"aostapenko@mirantis.com","date":"2019-09-17 14:56:07.000000000","tz":-300},"committer":{"name":"Andrii Ostapenko","email":"aostapenko@mirantis.com","date":"2019-09-17 17:14:55.000000000","tz":-300},"subject":"Simplify code for value overrides for ceph","message":"Simplify code for value overrides for ceph\n\nChange-Id: I50cbd0b11b55711dc484c0a4c382301a4680edb3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/11f02edc43984667684930901fc2e3571046223f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/11f02edc43984667684930901fc2e3571046223f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}