)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"0d8d8b76422a740998d624dfe045e3d5ddff747e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"timeoutSeconds, successThreshold and failureThreshold of the keystone-api"},{"line_number":14,"context_line":"probes."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"A new section in the values.yaml is introduced to eb able to override it."},{"line_number":17,"context_line":"Existing configuration have not changed as the values are set to the"},{"line_number":18,"context_line":"previous values or to the default ones if they werent configured before."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_76b2d5e8","line":16,"updated":"2019-09-19 19:46:04.000000000","message":"Typo: \"enable\"\n\nSorry, I know I\u0027m a pain...","commit_id":"9fe214b9d61e017d329b248717bf26eb0ae1e279"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"73136347b28db4147e89cbf0dae7a35a405081ce","unresolved":false,"context_lines":[{"line_number":13,"context_line":"timeoutSeconds, successThreshold and failureThreshold of the keystone-api"},{"line_number":14,"context_line":"probes."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"A new section in the values.yaml is introduced to eb able to override it."},{"line_number":17,"context_line":"Existing configuration have not changed as the values are set to the"},{"line_number":18,"context_line":"previous values or to the default ones if they werent configured before."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_e9b82a2b","line":16,"in_reply_to":"3fa7e38b_76b2d5e8","updated":"2019-09-19 20:27:59.000000000","message":"¯\\_(ツ)_/¯","commit_id":"9fe214b9d61e017d329b248717bf26eb0ae1e279"}],"keystone/templates/deployment-api.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"71fee9024240ddb9ae0cdbdea860dab6be983810","unresolved":false,"context_lines":[{"line_number":78,"context_line":"              scheme: HTTP"},{"line_number":79,"context_line":"              path: /v3/"},{"line_number":80,"context_line":"              port: {{ $portInt }}"},{"line_number":81,"context_line":"{{ toYaml .Values.probes.keystone_api.readinessProbe | trim | indent 12 }}"},{"line_number":82,"context_line":"          livenessProbe:"},{"line_number":83,"context_line":"            httpGet:"},{"line_number":84,"context_line":"              scheme: HTTP"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_a546ae20","line":81,"updated":"2019-09-23 07:46:58.000000000","message":"nit: alternatively you can make it nindent and not start from column 0 :)","commit_id":"b59316c73ad4d4ca9bb7a2fd9968fbc279facb93"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"34067e3fa8ebbe26de43b8ba2d4ca4abb2516c48","unresolved":false,"context_lines":[{"line_number":78,"context_line":"              scheme: HTTP"},{"line_number":79,"context_line":"              path: /v3/"},{"line_number":80,"context_line":"              port: {{ $portInt }}"},{"line_number":81,"context_line":"{{ toYaml .Values.probes.keystone_api.readinessProbe | trim | indent 12 }}"},{"line_number":82,"context_line":"          livenessProbe:"},{"line_number":83,"context_line":"            httpGet:"},{"line_number":84,"context_line":"              scheme: HTTP"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_058b021f","line":81,"in_reply_to":"3fa7e38b_a546ae20","updated":"2019-09-23 07:53:34.000000000","message":"yeah, I hate it like this but it seems to be the de facto way across all the other files, so to maintain consistency I kept it like that.","commit_id":"b59316c73ad4d4ca9bb7a2fd9968fbc279facb93"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"4bf8b5e3eede2c66d8640071e37748eb735298aa","unresolved":false,"context_lines":[{"line_number":18,"context_line":"httpGet:"},{"line_number":19,"context_line":"  scheme: HTTP"},{"line_number":20,"context_line":"  path: /v3/"},{"line_number":21,"context_line":"  port: {{ tuple \"identity\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":22,"context_line":"{{- end }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{- if .Values.manifests.deployment_api }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_386ab5ec","line":21,"updated":"2019-09-25 09:26:59.000000000","message":"Would it make sense to save the port value into variable like it was in original version and use it in both places?","commit_id":"bb99b8140862d3413d59557a225f384b1a63a73e"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"3bfea24b96773f72537c7c6d957e2318947f9130","unresolved":false,"context_lines":[{"line_number":18,"context_line":"httpGet:"},{"line_number":19,"context_line":"  scheme: HTTP"},{"line_number":20,"context_line":"  path: /v3/"},{"line_number":21,"context_line":"  port: {{ tuple \"identity\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":22,"context_line":"{{- end }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{- if .Values.manifests.deployment_api }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_bbbc5f06","line":21,"in_reply_to":"3fa7e38b_386ab5ec","updated":"2019-09-25 09:38:45.000000000","message":"you cant. Dont ask me why because I dont know why, but I tried and because the template is defined outside of the if (you have to do it like that otherwise it fails to render) you need to use the full call to get the port.\n\nCheck the neutron probes to see this as well. Probably someone with more gotpl knowledge (poor them) can explain why this is like this.","commit_id":"bb99b8140862d3413d59557a225f384b1a63a73e"}]}