)]}'
{"tools/deployment/multinode/900-tempest.sh":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"25c6aa166816c912d2101221437a7ddc4136e378","unresolved":false,"context_lines":[{"line_number":23,"context_line":"export OSH_EXT_SUBNET_NAME\u003d\"public-subnet\""},{"line_number":24,"context_line":"export OSH_EXT_SUBNET\u003d\"172.24.4.0/24\""},{"line_number":25,"context_line":"export OSH_BR_EX_ADDR\u003d\"172.24.4.1/24\""},{"line_number":26,"context_line":"openstack stack delete --wait --yes heat-public-net-deployment"},{"line_number":27,"context_line":"openstack stack create --wait \\"},{"line_number":28,"context_line":"  --parameter network_name\u003d${OSH_EXT_NET_NAME} \\"},{"line_number":29,"context_line":"  --parameter physical_network_name\u003dpublic \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_13a4c407","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":62},"updated":"2019-10-07 14:01:42.000000000","message":"This will cause the script to fail if the stack does not exist. I would recommend changing to set +e before the openstack create command instead.","commit_id":"0d89eabf4435617310ead4da78a01264d122c50d"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"6a63a1fe8d2b245c9113b7738ead09989ff671f8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"export OSH_EXT_SUBNET_NAME\u003d\"public-subnet\""},{"line_number":24,"context_line":"export OSH_EXT_SUBNET\u003d\"172.24.4.0/24\""},{"line_number":25,"context_line":"export OSH_BR_EX_ADDR\u003d\"172.24.4.1/24\""},{"line_number":26,"context_line":"openstack stack delete --wait --yes heat-public-net-deployment"},{"line_number":27,"context_line":"openstack stack create --wait \\"},{"line_number":28,"context_line":"  --parameter network_name\u003d${OSH_EXT_NET_NAME} \\"},{"line_number":29,"context_line":"  --parameter physical_network_name\u003dpublic \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_5378fcf6","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":62},"in_reply_to":"3fa7e38b_13a4c407","updated":"2019-10-07 14:22:48.000000000","message":"Oh, you are right of course.\n\nHowever, why do you think setting +e is any better? IMHO it could lead to masking real errors, e.g. when the stack exist but is in some bad shape. It still seems to be better to delete it and recreate to make sure all is correct (with the right check for existence though)","commit_id":"0d89eabf4435617310ead4da78a01264d122c50d"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"86de103813c532d761512a301e1b49f3dee47d69","unresolved":false,"context_lines":[{"line_number":23,"context_line":"export OSH_EXT_SUBNET_NAME\u003d\"public-subnet\""},{"line_number":24,"context_line":"export OSH_EXT_SUBNET\u003d\"172.24.4.0/24\""},{"line_number":25,"context_line":"export OSH_BR_EX_ADDR\u003d\"172.24.4.1/24\""},{"line_number":26,"context_line":"openstack stack delete --wait --yes heat-public-net-deployment"},{"line_number":27,"context_line":"openstack stack create --wait \\"},{"line_number":28,"context_line":"  --parameter network_name\u003d${OSH_EXT_NET_NAME} \\"},{"line_number":29,"context_line":"  --parameter physical_network_name\u003dpublic \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_486cca07","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":62},"in_reply_to":"3fa7e38b_5378fcf6","updated":"2019-10-07 15:38:08.000000000","message":"\u003e However, why do you think setting +e is any better? IMHO it could\n \u003e lead to masking real errors, e.g. when the stack exist but is in\n \u003e some bad shape. It still seems to be better to delete it and\n \u003e recreate to make sure all is correct (with the right check for\n \u003e existence though)\n\nThat\u0027s a good point. What if we still deleted the stack, but used set +e before that? We don\u0027t care if the stack fails to delete. If there\u0027s any real problem, things will error out below. And, sometimes the stack won\u0027t exist, which we also don\u0027t care about.","commit_id":"0d89eabf4435617310ead4da78a01264d122c50d"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"25c6aa166816c912d2101221437a7ddc4136e378","unresolved":false,"context_lines":[{"line_number":36,"context_line":"export OSH_PRIVATE_SUBNET_POOL\u003d\"10.0.0.0/8\""},{"line_number":37,"context_line":"export OSH_PRIVATE_SUBNET_POOL_NAME\u003d\"shared-default-subnetpool\""},{"line_number":38,"context_line":"export OSH_PRIVATE_SUBNET_POOL_DEF_PREFIX\u003d\"24\""},{"line_number":39,"context_line":"openstack stack delete --wait --yes heat-subnet-pool-deployment"},{"line_number":40,"context_line":"openstack stack create --wait \\"},{"line_number":41,"context_line":"  --parameter subnet_pool_name\u003d${OSH_PRIVATE_SUBNET_POOL_NAME} \\"},{"line_number":42,"context_line":"  --parameter subnet_pool_prefixes\u003d${OSH_PRIVATE_SUBNET_POOL} \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_33a7800e","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":63},"updated":"2019-10-07 14:01:42.000000000","message":"Same here.","commit_id":"0d89eabf4435617310ead4da78a01264d122c50d"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"dea833cd0c1d3d9bc1cbef9a447b93b70549e3f0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"export OSH_EXT_SUBNET_NAME\u003d\"public-subnet\""},{"line_number":24,"context_line":"export OSH_EXT_SUBNET\u003d\"172.24.4.0/24\""},{"line_number":25,"context_line":"export OSH_BR_EX_ADDR\u003d\"172.24.4.1/24\""},{"line_number":26,"context_line":"if openstack stack show heat-public-net-deployment \u003e/dev/null 2\u003e\u00261; then"},{"line_number":27,"context_line":"  openstack stack delete --wait --yes heat-public-net-deployment"},{"line_number":28,"context_line":"fi"},{"line_number":29,"context_line":"openstack stack create --wait \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_e98ebc25","line":26,"range":{"start_line":26,"start_character":3,"end_line":26,"end_character":50},"updated":"2019-10-08 21:54:15.000000000","message":"Technically, this will have output whether or not a stack is found, right? So this if statement will have the same result every time.\n\nI think you need to grep here.","commit_id":"1509f33a3be65e545a2cfbe34e02e5a0be7e2e7b"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"bc76f92048c941fef42c820bd6e9c080e21ffc05","unresolved":false,"context_lines":[{"line_number":23,"context_line":"export OSH_EXT_SUBNET_NAME\u003d\"public-subnet\""},{"line_number":24,"context_line":"export OSH_EXT_SUBNET\u003d\"172.24.4.0/24\""},{"line_number":25,"context_line":"export OSH_BR_EX_ADDR\u003d\"172.24.4.1/24\""},{"line_number":26,"context_line":"if openstack stack show heat-public-net-deployment \u003e/dev/null 2\u003e\u00261; then"},{"line_number":27,"context_line":"  openstack stack delete --wait --yes heat-public-net-deployment"},{"line_number":28,"context_line":"fi"},{"line_number":29,"context_line":"openstack stack create --wait \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf51134e_9d1b4a71","line":26,"range":{"start_line":26,"start_character":3,"end_line":26,"end_character":50},"in_reply_to":"3fa7e38b_e98ebc25","updated":"2020-06-26 05:23:02.000000000","message":"Done","commit_id":"1509f33a3be65e545a2cfbe34e02e5a0be7e2e7b"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"80082d5eed28df1f8dbda64d797ce9f586b0696e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"export OSH_EXT_SUBNET_NAME\u003d\"public-subnet\""},{"line_number":24,"context_line":"export OSH_EXT_SUBNET\u003d\"172.24.4.0/24\""},{"line_number":25,"context_line":"export OSH_BR_EX_ADDR\u003d\"172.24.4.1/24\""},{"line_number":26,"context_line":"if openstack stack show heat-public-net-deployment \u003e/dev/null 2\u003e\u00261; then"},{"line_number":27,"context_line":"  openstack stack delete --wait --yes heat-public-net-deployment"},{"line_number":28,"context_line":"fi"},{"line_number":29,"context_line":"openstack stack create --wait \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_7dca826e","line":26,"range":{"start_line":26,"start_character":3,"end_line":26,"end_character":50},"in_reply_to":"3fa7e38b_e98ebc25","updated":"2019-10-09 07:28:07.000000000","message":"The return value is different, and that\u0027s what the if command checks.","commit_id":"1509f33a3be65e545a2cfbe34e02e5a0be7e2e7b"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"3880802b1f5b023331e062afa8a6ee47b3bbacdc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"export OSH_EXT_SUBNET_NAME\u003d\"public-subnet\""},{"line_number":22,"context_line":"export OSH_EXT_SUBNET\u003d\"172.24.4.0/24\""},{"line_number":23,"context_line":"export OSH_BR_EX_ADDR\u003d\"172.24.4.1/24\""},{"line_number":24,"context_line":"if openstack stack show heat-public-net-deployment \u003e/dev/null 2\u003e\u00261 ; then"},{"line_number":25,"context_line":"  openstack stack delete --wait --yes heat-public-net-deployment"},{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":"openstack stack create --wait \\"},{"line_number":28,"context_line":"  --parameter network_name\u003d${OSH_EXT_NET_NAME} \\"},{"line_number":29,"context_line":"  --parameter physical_network_name\u003dpublic \\"}],"source_content_type":"text/x-sh","patch_set":7,"id":"bf51134e_c9669aed","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":2},"updated":"2020-06-26 22:01:20.000000000","message":"that\u0027s overcomplication - lets just do non-voting attempt to delete and avoid extra request.\nopenstack stack delete --wait --yes heat-public-net-deployment ||:","commit_id":"cb3166e9bb4449f975123e5bd30399ca05cb3966"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"3880802b1f5b023331e062afa8a6ee47b3bbacdc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"export OSH_PRIVATE_SUBNET_POOL\u003d\"10.0.0.0/8\""},{"line_number":37,"context_line":"export OSH_PRIVATE_SUBNET_POOL_NAME\u003d\"shared-default-subnetpool\""},{"line_number":38,"context_line":"export OSH_PRIVATE_SUBNET_POOL_DEF_PREFIX\u003d\"24\""},{"line_number":39,"context_line":"if openstack stack show heat-subnet-pool-deployment \u003e/dev/null 2\u003e\u00261 ; then"},{"line_number":40,"context_line":"  openstack stack delete --wait --yes heat-subnet-pool-deployment"},{"line_number":41,"context_line":"fi"},{"line_number":42,"context_line":"openstack stack create --wait \\"},{"line_number":43,"context_line":"  --parameter subnet_pool_name\u003d${OSH_PRIVATE_SUBNET_POOL_NAME} \\"},{"line_number":44,"context_line":"  --parameter subnet_pool_prefixes\u003d${OSH_PRIVATE_SUBNET_POOL} \\"}],"source_content_type":"text/x-sh","patch_set":7,"id":"bf51134e_2962b6d8","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":2},"updated":"2020-06-26 22:01:20.000000000","message":"ditto","commit_id":"cb3166e9bb4449f975123e5bd30399ca05cb3966"}]}