)]}'
{"neutron/templates/bin/_health-probe.py.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"db1f47d07940254c00971ed331e1aee4253af472","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                            continue"},{"line_number":167,"context_line":"                        if port in rabbitmq_ports and\\"},{"line_number":168,"context_line":"                                status \u003d\u003d tcp_established:"},{"line_number":169,"context_line":"                            rabbit_sock_count \u003d rabbit_sock_count + 1"},{"line_number":170,"context_line":"        except psutil.Error:"},{"line_number":171,"context_line":"            continue"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_10a237fd","line":169,"range":{"start_line":169,"start_character":27,"end_line":169,"end_character":69},"updated":"2019-10-10 14:13:46.000000000","message":"as this loop can\u0027t error out (all the except: clauses just continue anyway), can this just be a \"return\". If rabbit_sock_count gets incremented, the code block in L173 - 177 wouldn\u0027t be executed anyway. In any case, this can be done in a followup patch set.","commit_id":"3ba23f7ab01d306ff9ed9bef790c64c6ead15a21"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"144cd8b47d836f0d8a74f9354f441e700b94d473","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                            continue"},{"line_number":167,"context_line":"                        if port in rabbitmq_ports and\\"},{"line_number":168,"context_line":"                                status \u003d\u003d tcp_established:"},{"line_number":169,"context_line":"                            rabbit_sock_count \u003d rabbit_sock_count + 1"},{"line_number":170,"context_line":"        except psutil.Error:"},{"line_number":171,"context_line":"            continue"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_103eb78a","line":169,"range":{"start_line":169,"start_character":27,"end_line":169,"end_character":69},"in_reply_to":"3fa7e38b_10a237fd","updated":"2019-10-10 14:16:29.000000000","message":"Yeah, good suggestion. Thank you. Will take care of it in the next patch set.","commit_id":"3ba23f7ab01d306ff9ed9bef790c64c6ead15a21"}]}