)]}'
{"nova/templates/bin/_nova-compute-init.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"be238bda0d9853f57a02aa37b5973f6770da4e6b","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{{- if .Values.endpoints.compute.host_fqdn_override.default }}"},{"line_number":61,"context_line":"tee \u003e\u003e /etc/nova/nova.conf \u003c\u003c EOF"},{"line_number":62,"context_line":"host \u003d \"$(hostname).{{ .Values.endpoints.compute.host_fqdn_override }}\""},{"line_number":63,"context_line":"EOF"},{"line_number":64,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3fa7e38b_7b3fe024","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":71},"updated":"2019-10-09 17:42:44.000000000","message":"appending this at the end of a ini file may cause this to be in a non [DEFAULT] section.","commit_id":"ffe798bfb84798c4e81d41455e88fdc0166cdfd0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e31f0cdaa98f8a5e02ee865d85d42b014adb8f6b","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{{- if .Values.endpoints.compute.host_fqdn_override.default }}"},{"line_number":61,"context_line":"tee \u003e\u003e /etc/nova/nova.conf \u003c\u003c EOF"},{"line_number":62,"context_line":"host \u003d \"$(hostname).{{ .Values.endpoints.compute.host_fqdn_override }}\""},{"line_number":63,"context_line":"EOF"},{"line_number":64,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3fa7e38b_94f4a2d0","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":71},"in_reply_to":"3fa7e38b_7b3fe024","updated":"2019-10-31 18:39:48.000000000","message":"also, you cant append to a read only file.","commit_id":"ffe798bfb84798c4e81d41455e88fdc0166cdfd0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a6e1e71108423927b91e9430929ca45ee8e551e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fa7e38b_f405d6c2","updated":"2019-10-31 18:39:12.000000000","message":"you also need to add this to the following: https://github.com/openstack/openstack-helm/blob/master/nova/templates/bin/_nova-compute.sh.tpl#L25, wrapped in the same conditional as line 60.","commit_id":"2eb392e520e574a1aa03650798aa2e1cb9a64c20"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"0dfad3f01d4e7bb3c123e5a3bbabd6e3e72d789f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fa7e38b_fa2e1441","in_reply_to":"3fa7e38b_f405d6c2","updated":"2019-11-01 17:00:15.000000000","message":"\u003e you also need to add this to the following: https://github.com/openstack/openstack-helm/blob/master/nova/templates/bin/_nova-compute.sh.tpl#L25,\n \u003e wrapped in the same conditional as line 60.\n\nDone.","commit_id":"2eb392e520e574a1aa03650798aa2e1cb9a64c20"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a6e1e71108423927b91e9430929ca45ee8e551e2","unresolved":false,"context_lines":[{"line_number":57,"context_line":"my_ip  \u003d $hypervisor_address"},{"line_number":58,"context_line":"EOF"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{{- if and .Values.endpoints.compute.host_fqdn_override.default (empty .Values.conf.nova.DEFAULT.host) }}"},{"line_number":61,"context_line":"tee \u003e /etc/nova/nova.conf.d/010-nova-compute-fdn.conf \u003c\u003c EOF"},{"line_number":62,"context_line":"[DEFAULT]"},{"line_number":63,"context_line":"host \u003d \"$(hostname).{{ .Values.endpoints.compute.host_fqdn_override }}\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_f46076a7","line":60,"range":{"start_line":60,"start_character":11,"end_line":60,"end_character":63},"updated":"2019-10-31 18:39:12.000000000","message":"this would give you the fqdn for the api, dont overcook this.","commit_id":"2eb392e520e574a1aa03650798aa2e1cb9a64c20"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"0dfad3f01d4e7bb3c123e5a3bbabd6e3e72d789f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"my_ip  \u003d $hypervisor_address"},{"line_number":58,"context_line":"EOF"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{{- if and .Values.endpoints.compute.host_fqdn_override.default (empty .Values.conf.nova.DEFAULT.host) }}"},{"line_number":61,"context_line":"tee \u003e /etc/nova/nova.conf.d/010-nova-compute-fdn.conf \u003c\u003c EOF"},{"line_number":62,"context_line":"[DEFAULT]"},{"line_number":63,"context_line":"host \u003d \"$(hostname).{{ .Values.endpoints.compute.host_fqdn_override }}\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_7af9c4c5","line":60,"range":{"start_line":60,"start_character":11,"end_line":60,"end_character":63},"in_reply_to":"3fa7e38b_f46076a7","updated":"2019-11-01 17:00:15.000000000","message":"\u003e this would give you the fqdn for the api, dont overcook this.\n\nAh, I see. So the only place this can be set is in .Values.conf.nova.DEFAULT.host?\n\nI edited the check to only consider that.","commit_id":"2eb392e520e574a1aa03650798aa2e1cb9a64c20"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a6e1e71108423927b91e9430929ca45ee8e551e2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"EOF"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{{- if and .Values.endpoints.compute.host_fqdn_override.default (empty .Values.conf.nova.DEFAULT.host) }}"},{"line_number":61,"context_line":"tee \u003e /etc/nova/nova.conf.d/010-nova-compute-fdn.conf \u003c\u003c EOF"},{"line_number":62,"context_line":"[DEFAULT]"},{"line_number":63,"context_line":"host \u003d \"$(hostname).{{ .Values.endpoints.compute.host_fqdn_override }}\""},{"line_number":64,"context_line":"EOF"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_9446e220","line":61,"range":{"start_line":61,"start_character":45,"end_line":61,"end_character":48},"updated":"2019-10-31 18:39:12.000000000","message":"typo","commit_id":"2eb392e520e574a1aa03650798aa2e1cb9a64c20"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a6e1e71108423927b91e9430929ca45ee8e551e2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{{- if and .Values.endpoints.compute.host_fqdn_override.default (empty .Values.conf.nova.DEFAULT.host) }}"},{"line_number":61,"context_line":"tee \u003e /etc/nova/nova.conf.d/010-nova-compute-fdn.conf \u003c\u003c EOF"},{"line_number":62,"context_line":"[DEFAULT]"},{"line_number":63,"context_line":"host \u003d \"$(hostname).{{ .Values.endpoints.compute.host_fqdn_override }}\""},{"line_number":64,"context_line":"EOF"},{"line_number":65,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_b4567ecd","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":70},"updated":"2019-10-31 18:39:12.000000000","message":"$(hostname -f)","commit_id":"2eb392e520e574a1aa03650798aa2e1cb9a64c20"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"0dfad3f01d4e7bb3c123e5a3bbabd6e3e72d789f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{{- if and .Values.endpoints.compute.host_fqdn_override.default (empty .Values.conf.nova.DEFAULT.host) }}"},{"line_number":61,"context_line":"tee \u003e /etc/nova/nova.conf.d/010-nova-compute-fdn.conf \u003c\u003c EOF"},{"line_number":62,"context_line":"[DEFAULT]"},{"line_number":63,"context_line":"host \u003d \"$(hostname).{{ .Values.endpoints.compute.host_fqdn_override }}\""},{"line_number":64,"context_line":"EOF"},{"line_number":65,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_3affccab","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":70},"in_reply_to":"3fa7e38b_b4567ecd","updated":"2019-11-01 17:00:15.000000000","message":"\u003e $(hostname -f)\n\nDone.","commit_id":"2eb392e520e574a1aa03650798aa2e1cb9a64c20"}],"nova/templates/bin/_nova-compute.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"52141bb47ad2300c7757ec22f63d1b1d354a7f22","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      --config-file /tmp/pod-shared/nova-libvirt.conf \\"},{"line_number":25,"context_line":"{{- if empty .Values.conf.nova.DEFAULT.host }}"},{"line_number":26,"context_line":"      --config-file /tmp/pod-shared/nova-compute-fqdn.conf \\"},{"line_number":27,"context_line":"{{ end }}"},{"line_number":28,"context_line":"      --config-file /tmp/pod-shared/nova-hypervisor.conf"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_602036b1","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":9},"updated":"2019-11-01 18:35:59.000000000","message":"there may be a missing \"-\" here to chomp newline, this may end up creating a blank line and break the \"\\\" in the script","commit_id":"e34dcf21f15ae283329b668f1e1dc97b55217634"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"ed9d48385756d8dfd1cab643b13db337f2d87b9f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      --config-file /tmp/pod-shared/nova-libvirt.conf \\"},{"line_number":25,"context_line":"{{- if empty .Values.conf.nova.DEFAULT.host }}"},{"line_number":26,"context_line":"      --config-file /tmp/pod-shared/nova-compute-fqdn.conf \\"},{"line_number":27,"context_line":"{{ end }}"},{"line_number":28,"context_line":"      --config-file /tmp/pod-shared/nova-hypervisor.conf"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_49220554","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":9},"in_reply_to":"3fa7e38b_602036b1","updated":"2019-11-01 21:43:02.000000000","message":"\u003e there may be a missing \"-\" here to chomp newline, this may end up\n \u003e creating a blank line and break the \"\\\" in the script\n\nGood catch. Done.","commit_id":"e34dcf21f15ae283329b668f1e1dc97b55217634"}]}