)]}'
{"neutron/templates/bin/_neutron-openvswitch-agent-readiness.sh.tpl":[{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"d03915abc86ff582e44b8f649013c0030e59ac18","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{ if .Values.conf.ovs_dpdk.enabled }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  # Check if dpdk is initialized"},{"line_number":31,"context_line":"  [ \"$(ovs-vsctl get Open_vSwitch . dpdk_initialized)\" \u003d\u003d true ]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  {{- if hasKey .Values.conf.ovs_dpdk \"nics\"}}"},{"line_number":34,"context_line":"    # Check if port(s) and bridge(s) are configured."}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_e7f07f94","side":"PARENT","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":64},"updated":"2019-10-19 00:31:11.000000000","message":"Maybe we should just remove the check entirely.","commit_id":"be3a4f65de6faba22a25d9bb5d9ed1e4247b97ed"},{"author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"change_message_id":"1347893fd1404050deada26dba8fff2b9d43d0ac","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{ if .Values.conf.ovs_dpdk.enabled }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  # Check if dpdk is initialized"},{"line_number":31,"context_line":"  [ \"$(ovs-vsctl get Open_vSwitch . dpdk_initialized)\" \u003d\u003d true ]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  {{- if hasKey .Values.conf.ovs_dpdk \"nics\"}}"},{"line_number":34,"context_line":"    # Check if port(s) and bridge(s) are configured."}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_8f32fa5d","side":"PARENT","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":64},"in_reply_to":"3fa7e38b_e7f07f94","updated":"2019-10-21 12:14:57.000000000","message":"Sounds ok to me.","commit_id":"be3a4f65de6faba22a25d9bb5d9ed1e4247b97ed"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"d03915abc86ff582e44b8f649013c0030e59ac18","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  #       this command assumes that DPDK has been initialized and so gives no"},{"line_number":33,"context_line":"  #       guarantees. However, if DPDK was not successfully initialized, the subsequent"},{"line_number":34,"context_line":"  #       checks for bridges and ports fail."},{"line_number":35,"context_line":"  if ! /usr/bin/ovs-vsctl list Open_vSwitch | grep -q \u0027dpdk_initialized.*false\u0027; then"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  {{- if hasKey .Values.conf.ovs_dpdk \"nics\"}}"},{"line_number":38,"context_line":"    # Check if port(s) and bridge(s) are configured."}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_8710abaa","line":35,"range":{"start_line":35,"start_character":5,"end_line":35,"end_character":79},"updated":"2019-10-19 00:31:11.000000000","message":"This will jump to a non-existent `else` if the check is actually supported and `dpdk_initialized: false`, giving a false pass.","commit_id":"433e0d0ac2b936d2d16c5a9651d69309c187d427"}]}