)]}'
{"id":"openstack%2Fopenstack-helm~697525","triplet_id":"openstack%2Fopenstack-helm~master~I49bbec247248fef76cd4c46fad35e3022fe58983","project":"openstack/openstack-helm","branch":"master","hashtags":[],"change_id":"I49bbec247248fef76cd4c46fad35e3022fe58983","subject":"Support ingress creation for keystone admin endpoint","status":"ABANDONED","created":"2019-12-05 16:58:12.000000000","updated":"2021-04-15 18:37:33.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ecc82f89cceb9fefa663015025554bca5f61d989","_number":697525,"virtual_id_number":697525,"owner":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"tag":"autogenerated:zuul:check","value":1,"date":"2019-12-31 20:21:22.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},{"date":"2020-01-22 19:26:33.000000000","_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"all":[{"value":-1,"date":"2020-01-08 16:49:01.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-05 17:00:31.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-12-05 17:00:56.000000000","updated_by":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"reviewer":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"state":"REVIEWER"},{"updated":"2019-12-31 20:21:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-01-08 16:49:01.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"}],"messages":[{"id":"a271f0f55729527b5009f78abfc96880c66fcbc9","author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"date":"2019-12-05 16:58:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"94b7265a154e73efe16d69f45bd862ccbbbb8cbe","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-05 17:57:10.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3c67e6af09b542fa8907ef9aadf71fc9 : SUCCESS in 6m 17s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/9fdbb90eab594a1d827c9798b199fbf3 : SUCCESS in 1m 47s\n- openstack-helm-cinder https://zuul.opendev.org/t/openstack/build/910e82b485f34f7480f733f6536a7e37 : SUCCESS in 37m 19s\n- openstack-helm-cinder-pike-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/f70b297c228043fe9b3371174ddfe810 : SUCCESS in 43m 56s\n- openstack-helm-cinder-queens-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/76ac007886bd431da188e2d0ef61ed72 : SUCCESS in 39m 20s\n- openstack-helm-cinder-rocky-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/f5de777c421241679add5ea16859a5d6 : SUCCESS in 40m 31s\n- openstack-helm-cinder-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/e3414e56c7a54ea6bda8217caff0a4af : SUCCESS in 37m 02s\n- openstack-helm-cinder-rocky-opensuse_15 https://zuul.opendev.org/t/openstack/build/beb3384d872e4ac0b524c4ec4df1257b : SUCCESS in 44m 57s\n- openstack-helm-cinder-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/44c87392686f4a39a6ab22dd5d589d7a : SUCCESS in 42m 09s\n- openstack-helm-compute-kit https://zuul.opendev.org/t/openstack/build/54b4f5b0135444769bf81acea3cda3c6 : SUCCESS in 41m 22s\n- openstack-helm-compute-kit-pike-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/0ca3ab4642b14a1b8b378baf1c24365e : SUCCESS in 51m 01s\n- openstack-helm-compute-kit-queens-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/ed184d2bf86b495bac56ebb6cef2d02e : SUCCESS in 48m 52s\n- openstack-helm-compute-kit-rocky-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/2e2d5620e269462fafbf5a475199f739 : SUCCESS in 48m 07s\n- openstack-helm-compute-kit-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/8cce57c2fc12435a9460edf89d1052a2 : SUCCESS in 51m 13s\n- openstack-helm-compute-kit-rocky-opensuse_15 https://zuul.opendev.org/t/openstack/build/4b63a7d2933b40b4b862c9ad74b87f68 : FAILURE in 46m 21s\n- openstack-helm-compute-kit-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/ca3fc9cdc7c24a97a79c451a00329df7 : SUCCESS in 49m 16s\n- openstack-helm-horizon https://zuul.opendev.org/t/openstack/build/e3e350f1968641278ea98e0c42265c29 : SUCCESS in 30m 31s\n- openstack-helm-apparmor https://zuul.opendev.org/t/openstack/build/cbcca3deb8994d35b209d67acf0baf4f : FAILURE in 34m 31s (non-voting)\n- openstack-helm-netpol-compute-kit https://zuul.opendev.org/t/openstack/build/38b756c38d3a47b496bb3cac0dff1766 : SUCCESS in 53m 23s (non-voting)\n- openstack-helm-netpol-cinder https://zuul.opendev.org/t/openstack/build/56eba0c2927b4f94a2650f2ce972dcab : SUCCESS in 49m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d15901de3014c882ac34fb4c3f3ed82172737db8","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-12-31 18:59:25.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"d1afd63bb54208c3ad5e95a9f7bbfcbabd7ebb9b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-31 20:21:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fa97e7e35eae4b3fba11aaf49c706270 : SUCCESS in 4m 42s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/bb826df12f7349488508d7f7ea539611 : SUCCESS in 1m 47s\n- openstack-helm-cinder https://zuul.opendev.org/t/openstack/build/9a33e3757d6f4298b23b9e284b2d8e6e : SUCCESS in 53m 03s\n- openstack-helm-cinder-pike-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/c8732c912ff54b369f9e494e284ecbb7 : SUCCESS in 54m 45s\n- openstack-helm-cinder-queens-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/8d7507bb42104d9bb8af9555a109eae5 : SUCCESS in 37m 24s\n- openstack-helm-cinder-rocky-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/91e71afba00645c88317af1a4a81373e : SUCCESS in 1h 00m 24s\n- openstack-helm-cinder-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/0fd8a6d382614bbfa03ea15629840f88 : SUCCESS in 38m 16s\n- openstack-helm-cinder-rocky-opensuse_15 https://zuul.opendev.org/t/openstack/build/03e2966cdddb4789a9a5cbaefef9875d : SUCCESS in 37m 27s\n- openstack-helm-cinder-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/fd0c4e47445f465288f75d4245889c58 : SUCCESS in 39m 12s\n- openstack-helm-compute-kit https://zuul.opendev.org/t/openstack/build/6c7c2b840c0b4b9d978ae1b749ef69e2 : SUCCESS in 40m 56s\n- openstack-helm-compute-kit-pike-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/2ed0c1b526f8493088df4ad6ed131d04 : SUCCESS in 43m 43s\n- openstack-helm-compute-kit-queens-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/9b467951fad5496caf9a39f49512490c : SUCCESS in 43m 46s\n- openstack-helm-compute-kit-rocky-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/9079ba04d7c34f809687b6db2d00cd7b : SUCCESS in 42m 46s\n- openstack-helm-compute-kit-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/155ef0b4acf54dc79603055336b2412c : SUCCESS in 44m 02s\n- openstack-helm-compute-kit-rocky-opensuse_15 https://zuul.opendev.org/t/openstack/build/d610cbae17304438b495be1df2ef2719 : SUCCESS in 1h 05m 07s\n- openstack-helm-compute-kit-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/254fb3c5272d4eb08fdae0519e2e831d : SUCCESS in 45m 09s\n- openstack-helm-horizon https://zuul.opendev.org/t/openstack/build/4c2fff0bacfa4703adb44f4ca051bd61 : SUCCESS in 26m 13s\n- openstack-helm-apparmor https://zuul.opendev.org/t/openstack/build/afef3fef392141618e3b9fe644b935e5 : FAILURE in 32m 09s (non-voting)\n- openstack-helm-netpol-compute-kit https://zuul.opendev.org/t/openstack/build/c9fb24b9fde1423299c769987632bee3 : SUCCESS in 1h 07m 58s (non-voting)\n- openstack-helm-netpol-cinder https://zuul.opendev.org/t/openstack/build/116d8c3072c043d0a13a3789ca3c31aa : SUCCESS in 44m 12s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"cc96b4a25f2c324b191ad668ca9d6bdb8a507dce","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2020-01-08 16:49:01.000000000","message":"Patch Set 2: Code-Review-1\n\nIs this something for keystone v2? There\u0027s not really separate \"admin\" and \"public\" endpoints anymore with the v3 API, it\u0027s all on the same endpoint.","accounts_in_message":[],"_revision_number":2},{"id":"9a54611d8c985167e5d6ec026ac18a64b806f4db","author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"date":"2020-01-22 19:26:33.000000000","message":"Patch Set 2:\n\n\u003e Is this something for keystone v2? There\u0027s not really separate\n \u003e \"admin\" and \"public\" endpoints anymore with the v3 API, it\u0027s all on\n \u003e the same endpoint.\n\n \u003e Is this something for keystone v2? There\u0027s not really separate\n \u003e \"admin\" and \"public\" endpoints anymore with the v3 API, it\u0027s all on\n \u003e the same endpoint.\n\nThis is for V3. Yes there is no distinguish among internal, admin and public endpoint anymore. But a deployment can create multiple endpoints based on their use cases. For us in StarlingX project, we create all three endpoints, with public endpoint for end users (whose fqdn can be overridden by a system tool provided by StarlingX sysinv), internal endpoint for containerized openstack services within the Kubernetes cluster (it\u0027s not accessible from outside of the cluster at all), and admin endpoint for administration purpose on a separate management network. So they serve different users on different networks.   \n\nFor the admin endpoint, it\u0027s on an administration network exposed to outside of the cluster, not accessible by end users, and it has to be overridable independently. This is why we need the ingress creation for admin endpoint.","accounts_in_message":[],"_revision_number":2},{"id":"ecc82f89cceb9fefa663015025554bca5f61d989","tag":"autogenerated:gerrit:abandon","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-04-15 18:37:33.000000000","message":"Abandoned\n\nAbandoning since there hasn\u0027t been any recent activity, if anyone wants to continue this work, please feel free to restore this or create a new change.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"702846380bb2494d7cf1492a277f723e6a3553bd","revisions":{"adb92780b4d75eefbe6c625ec3366126ef453a7d":{"kind":"REWORK","_number":1,"created":"2019-12-05 16:58:12.000000000","uploader":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"ref":"refs/changes/25/697525/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/25/697525/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/25/697525/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/25/697525/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/25/697525/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/25/697525/1"}}},"commit":{"parents":[{"commit":"52c132b9356695bf455ae25ec78cef9f532f9fe8","subject":"Merge \"Octavia: fix developer cert generation script\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/52c132b9356695bf455ae25ec78cef9f532f9fe8"}]}],"author":{"name":"Andy Ning","email":"andy.ning@windriver.com","date":"2019-12-04 18:35:44.000000000","tz":-300},"committer":{"name":"Andy Ning","email":"andy.ning@windriver.com","date":"2019-12-05 16:55:33.000000000","tz":-300},"subject":"Support ingress creation for keystone admin endpoint","message":"Support ingress creation for keystone admin endpoint\n\nThis update added support to create ingress for custom keystone admin\nendpoint. It can be used by deployment to expose keystone admin endpoint\nto outside of the cluster by ingress.\n\nChange-Id: I49bbec247248fef76cd4c46fad35e3022fe58983\nStory: 2006588\nTask: 37747\nSigned-off-by: Andy Ning \u003candy.ning@windriver.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/adb92780b4d75eefbe6c625ec3366126ef453a7d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/adb92780b4d75eefbe6c625ec3366126ef453a7d"}]},"branch":"refs/heads/master"},"702846380bb2494d7cf1492a277f723e6a3553bd":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-12-31 18:59:25.000000000","uploader":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"ref":"refs/changes/25/697525/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/25/697525/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/25/697525/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/25/697525/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/25/697525/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/25/697525/2"}}},"commit":{"parents":[{"commit":"942fa475cfc1981a9c3017823ab8f3f550afd3e8","subject":"Merge \"Support the Nautilus release for Ceph\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/942fa475cfc1981a9c3017823ab8f3f550afd3e8"}]}],"author":{"name":"Andy Ning","email":"andy.ning@windriver.com","date":"2019-12-04 18:35:44.000000000","tz":-300},"committer":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2019-12-31 18:59:25.000000000","tz":0},"subject":"Support ingress creation for keystone admin endpoint","message":"Support ingress creation for keystone admin endpoint\n\nThis update added support to create ingress for custom keystone admin\nendpoint. It can be used by deployment to expose keystone admin endpoint\nto outside of the cluster by ingress.\n\nChange-Id: I49bbec247248fef76cd4c46fad35e3022fe58983\nStory: 2006588\nTask: 37747\nSigned-off-by: Andy Ning \u003candy.ning@windriver.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/702846380bb2494d7cf1492a277f723e6a3553bd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/702846380bb2494d7cf1492a277f723e6a3553bd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}