)]}'
{"neutron/templates/bin/_neutron-openvswitch-agent-init-cleanup.sh.tpl":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"edaf10f1940180337762447b5b4983fd6d48bcb0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if [[ ! -f /run/ovs-cleanup.tmp ]]"},{"line_number":22,"context_line":"then"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_d20a5f1c","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"updated":"2020-02-10 16:18:55.000000000","message":"just wondering... is this something worth \"failing\" the installation if the cleanup script doesn\u0027t clean up by any chance?","commit_id":"39a42003951736f5657bc2a935dafc699677de96"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"511b9a75cc63d19a7dc79cae24af16f98c28bc3e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if [[ ! -f /run/ovs-cleanup.tmp ]]"},{"line_number":22,"context_line":"then"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_9b00666b","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"in_reply_to":"3fa7e38b_d20a5f1c","updated":"2020-02-12 05:11:32.000000000","message":"Done","commit_id":"39a42003951736f5657bc2a935dafc699677de96"}],"neutron/templates/daemonset-ovs-agent.yaml":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"edaf10f1940180337762447b5b4983fd6d48bcb0","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            - name: pci-devices"},{"line_number":102,"context_line":"              mountPath: /sys/bus/pci/devices"},{"line_number":103,"context_line":"{{- end }}"},{"line_number":104,"context_line":"        - name: neutron-ovs-agent-init-cleanup"},{"line_number":105,"context_line":"{{ tuple $envAll \"neutron_openvswitch_agent\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":106,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.agent.ovs | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":107,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"neutron_ovs_agent\" \"container\" \"neutron_ovs_agent_init_cleanup\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_f218bb72","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":46},"updated":"2020-02-10 16:18:55.000000000","message":"should this not be run as a job perhaps?","commit_id":"39a42003951736f5657bc2a935dafc699677de96"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"511b9a75cc63d19a7dc79cae24af16f98c28bc3e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            - name: pci-devices"},{"line_number":102,"context_line":"              mountPath: /sys/bus/pci/devices"},{"line_number":103,"context_line":"{{- end }}"},{"line_number":104,"context_line":"        - name: neutron-ovs-agent-init-cleanup"},{"line_number":105,"context_line":"{{ tuple $envAll \"neutron_openvswitch_agent\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":106,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.agent.ovs | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":107,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"neutron_ovs_agent\" \"container\" \"neutron_ovs_agent_init_cleanup\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_fbe63adb","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":46},"in_reply_to":"3fa7e38b_f218bb72","updated":"2020-02-12 05:11:32.000000000","message":"There is nothing extra we gain by running this as a job. This is much more leaner achieving same results as a job wud do. Also it logically fits into an init container task before neutron-ovs-agent is run (to clean br-int etc.).\n\nMoreover every time chart is uninstalled and reinstalled, the job will run once, while we want to run this cleanup command only once after compute restart. So job too fails to achieve our objective without putting additional hacks, i.e. touch a file in /run on the hostpath when we run the script for the first time and then check for this file before running the script.","commit_id":"39a42003951736f5657bc2a935dafc699677de96"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5c225f44377a7881e171bb196022ea5544f766ec","unresolved":false,"context_lines":[{"line_number":153,"context_line":"              readOnly: true"},{"line_number":154,"context_line":"            {{- if .Values.conf.ovs_dpdk.enabled }}"},{"line_number":155,"context_line":"            - name: neutron-etc"},{"line_number":156,"context_line":"              mountPath: /tmp/dpdk.conf"},{"line_number":157,"context_line":"              subPath: dpdk.conf"},{"line_number":158,"context_line":"              readOnly: true"},{"line_number":159,"context_line":"            {{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_f752ed69","line":156,"range":{"start_line":156,"start_character":25,"end_line":156,"end_character":30},"updated":"2020-02-10 16:04:13.000000000","message":"should this be mount to an /etc/* folder and not /tmp?","commit_id":"39a42003951736f5657bc2a935dafc699677de96"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"511b9a75cc63d19a7dc79cae24af16f98c28bc3e","unresolved":false,"context_lines":[{"line_number":153,"context_line":"              readOnly: true"},{"line_number":154,"context_line":"            {{- if .Values.conf.ovs_dpdk.enabled }}"},{"line_number":155,"context_line":"            - name: neutron-etc"},{"line_number":156,"context_line":"              mountPath: /tmp/dpdk.conf"},{"line_number":157,"context_line":"              subPath: dpdk.conf"},{"line_number":158,"context_line":"              readOnly: true"},{"line_number":159,"context_line":"            {{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_bb2a02e3","line":156,"range":{"start_line":156,"start_character":25,"end_line":156,"end_character":30},"in_reply_to":"3fa7e38b_f752ed69","updated":"2020-02-12 05:11:32.000000000","message":"Done","commit_id":"39a42003951736f5657bc2a935dafc699677de96"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5c225f44377a7881e171bb196022ea5544f766ec","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            {{- end }}"},{"line_number":160,"context_line":"            {{- range $key, $value :\u003d $envAll.Values.conf.rootwrap_filters }}"},{"line_number":161,"context_line":"            {{- if ( has \"ovs_agent\" $value.pods ) }}"},{"line_number":162,"context_line":"            {{- $filePrefix :\u003d replace \"_\" \"-\"  $key }}"},{"line_number":163,"context_line":"            {{- $rootwrapFile :\u003d printf \"/etc/neutron/rootwrap.d/%s.filters\" $filePrefix }}"},{"line_number":164,"context_line":"            - name: neutron-etc"},{"line_number":165,"context_line":"              mountPath: {{ $rootwrapFile }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_170a2977","line":162,"range":{"start_line":162,"start_character":52,"end_line":162,"end_character":55},"updated":"2020-02-10 16:04:13.000000000","message":"nit: -}}","commit_id":"39a42003951736f5657bc2a935dafc699677de96"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"511b9a75cc63d19a7dc79cae24af16f98c28bc3e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            {{- end }}"},{"line_number":160,"context_line":"            {{- range $key, $value :\u003d $envAll.Values.conf.rootwrap_filters }}"},{"line_number":161,"context_line":"            {{- if ( has \"ovs_agent\" $value.pods ) }}"},{"line_number":162,"context_line":"            {{- $filePrefix :\u003d replace \"_\" \"-\"  $key }}"},{"line_number":163,"context_line":"            {{- $rootwrapFile :\u003d printf \"/etc/neutron/rootwrap.d/%s.filters\" $filePrefix }}"},{"line_number":164,"context_line":"            - name: neutron-etc"},{"line_number":165,"context_line":"              mountPath: {{ $rootwrapFile }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_5b2bcee7","line":162,"range":{"start_line":162,"start_character":52,"end_line":162,"end_character":55},"in_reply_to":"3fa7e38b_170a2977","updated":"2020-02-12 05:11:32.000000000","message":"Done","commit_id":"39a42003951736f5657bc2a935dafc699677de96"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5c225f44377a7881e171bb196022ea5544f766ec","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            {{- range $key, $value :\u003d $envAll.Values.conf.rootwrap_filters }}"},{"line_number":161,"context_line":"            {{- if ( has \"ovs_agent\" $value.pods ) }}"},{"line_number":162,"context_line":"            {{- $filePrefix :\u003d replace \"_\" \"-\"  $key }}"},{"line_number":163,"context_line":"            {{- $rootwrapFile :\u003d printf \"/etc/neutron/rootwrap.d/%s.filters\" $filePrefix }}"},{"line_number":164,"context_line":"            - name: neutron-etc"},{"line_number":165,"context_line":"              mountPath: {{ $rootwrapFile }}"},{"line_number":166,"context_line":"              subPath: {{ base $rootwrapFile }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_d71fb1b5","line":163,"range":{"start_line":163,"start_character":88,"end_line":163,"end_character":91},"updated":"2020-02-10 16:04:13.000000000","message":"nit: -}}","commit_id":"39a42003951736f5657bc2a935dafc699677de96"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"511b9a75cc63d19a7dc79cae24af16f98c28bc3e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            {{- range $key, $value :\u003d $envAll.Values.conf.rootwrap_filters }}"},{"line_number":161,"context_line":"            {{- if ( has \"ovs_agent\" $value.pods ) }}"},{"line_number":162,"context_line":"            {{- $filePrefix :\u003d replace \"_\" \"-\"  $key }}"},{"line_number":163,"context_line":"            {{- $rootwrapFile :\u003d printf \"/etc/neutron/rootwrap.d/%s.filters\" $filePrefix }}"},{"line_number":164,"context_line":"            - name: neutron-etc"},{"line_number":165,"context_line":"              mountPath: {{ $rootwrapFile }}"},{"line_number":166,"context_line":"              subPath: {{ base $rootwrapFile }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_7b300a55","line":163,"range":{"start_line":163,"start_character":88,"end_line":163,"end_character":91},"in_reply_to":"3fa7e38b_d71fb1b5","updated":"2020-02-12 05:11:32.000000000","message":"Done","commit_id":"39a42003951736f5657bc2a935dafc699677de96"}]}