)]}'
{"neutron/templates/bin/_neutron-netns-cleanup-cron.py.tpl":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"6c69f3d83b46813064b2c6dc5da1cd9bd036a234","unresolved":false,"context_lines":[{"line_number":10,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":11,"context_line":"    while True:"},{"line_number":12,"context_line":"        try:"},{"line_number":13,"context_line":"            main()"},{"line_number":14,"context_line":"            # Sleep for 12 hours"},{"line_number":15,"context_line":"            time.sleep(43200)"},{"line_number":16,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3fa7e38b_39f385ea","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":18},"updated":"2020-02-11 16:56:15.000000000","message":"where do we find what this is doing?  also values.yaml seems to have rootwrap filter defined for this, does that need to be tuned?","commit_id":"62db99d1d19833aa14b6e92a7503df0f6a9a5fb4"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"7646f7ea4c16206c332fe1e481350307207d2129","unresolved":false,"context_lines":[{"line_number":10,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":11,"context_line":"    while True:"},{"line_number":12,"context_line":"        try:"},{"line_number":13,"context_line":"            main()"},{"line_number":14,"context_line":"            # Sleep for 12 hours"},{"line_number":15,"context_line":"            time.sleep(43200)"},{"line_number":16,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3fa7e38b_f16d0168","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":18},"in_reply_to":"3fa7e38b_39f385ea","updated":"2020-02-11 20:28:15.000000000","message":"https://github.com/openstack/neutron/blob/master/neutron/cmd/netns_cleanup.py imports oslo_log. It should be based on whatever is configured in neutron.conf.","commit_id":"62db99d1d19833aa14b6e92a7503df0f6a9a5fb4"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"6c69f3d83b46813064b2c6dc5da1cd9bd036a234","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        try:"},{"line_number":13,"context_line":"            main()"},{"line_number":14,"context_line":"            # Sleep for 12 hours"},{"line_number":15,"context_line":"            time.sleep(43200)"},{"line_number":16,"context_line":"        except Exception as ex:"},{"line_number":17,"context_line":"            sys.stderr.write("},{"line_number":18,"context_line":"                \"Cleaning network namespaces caught an exception %s\""}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3fa7e38b_19f6c9d6","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":29},"updated":"2020-02-11 16:56:15.000000000","message":"you sure we don\u0027t want to entertain the idea of running this as a readiness probe on this daemonset?  haha","commit_id":"62db99d1d19833aa14b6e92a7503df0f6a9a5fb4"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"7646f7ea4c16206c332fe1e481350307207d2129","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        try:"},{"line_number":13,"context_line":"            main()"},{"line_number":14,"context_line":"            # Sleep for 12 hours"},{"line_number":15,"context_line":"            time.sleep(43200)"},{"line_number":16,"context_line":"        except Exception as ex:"},{"line_number":17,"context_line":"            sys.stderr.write("},{"line_number":18,"context_line":"                \"Cleaning network namespaces caught an exception %s\""}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3fa7e38b_5175f531","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":29},"in_reply_to":"3fa7e38b_19f6c9d6","updated":"2020-02-11 20:28:15.000000000","message":"The probes run too frequently and it does not suit for this purpose.","commit_id":"62db99d1d19833aa14b6e92a7503df0f6a9a5fb4"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"6ae3f3a084121b574bfd840b0058689a9f035d9f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            sys.stderr.write("},{"line_number":18,"context_line":"                \"Cleaning network namespaces caught an exception %s\""},{"line_number":19,"context_line":"                % str(ex))"},{"line_number":20,"context_line":"        except:"},{"line_number":21,"context_line":"            sys.stderr.write("},{"line_number":22,"context_line":"                \"Cleaning network namespaces caught an exception\")"},{"line_number":23,"context_line":"        finally:"},{"line_number":24,"context_line":"            cfg.CONF.clear()"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3fa7e38b_2490e741","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":66},"updated":"2020-02-17 20:07:37.000000000","message":"This is unreachable code since any exception that is thrown would have been handled by the block starting on L16.","commit_id":"62db99d1d19833aa14b6e92a7503df0f6a9a5fb4"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"65bdd2dcc016ff90a2e23e065b7377e3d1ef7c56","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            sys.stderr.write("},{"line_number":18,"context_line":"                \"Cleaning network namespaces caught an exception %s\""},{"line_number":19,"context_line":"                % str(ex))"},{"line_number":20,"context_line":"        except:"},{"line_number":21,"context_line":"            sys.stderr.write("},{"line_number":22,"context_line":"                \"Cleaning network namespaces caught an exception\")"},{"line_number":23,"context_line":"        finally:"},{"line_number":24,"context_line":"            cfg.CONF.clear()"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3fa7e38b_5f804cf7","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":66},"in_reply_to":"3fa7e38b_2490e741","updated":"2020-02-17 20:59:29.000000000","message":"Python\u0027s \u0027Exception\u0027 class does not catch system-exiting exceptions. L20 catches everything.\n\nhttps://docs.python.org/3/library/exceptions.html#base-classes","commit_id":"62db99d1d19833aa14b6e92a7503df0f6a9a5fb4"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"de8a928c974eceff9af407be83602141b904b228","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            sys.stderr.write("},{"line_number":18,"context_line":"                \"Cleaning network namespaces caught an exception %s\""},{"line_number":19,"context_line":"                % str(ex))"},{"line_number":20,"context_line":"        except:"},{"line_number":21,"context_line":"            sys.stderr.write("},{"line_number":22,"context_line":"                \"Cleaning network namespaces caught an exception\")"},{"line_number":23,"context_line":"        finally:"},{"line_number":24,"context_line":"            cfg.CONF.clear()"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3fa7e38b_dab9aac5","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":66},"in_reply_to":"3fa7e38b_5f804cf7","updated":"2020-02-17 22:19:07.000000000","message":"What system-exiting exceptions do you expect here that should not result in the daemonset restarted?","commit_id":"62db99d1d19833aa14b6e92a7503df0f6a9a5fb4"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"033e92ac6f64674bf5e8c1604850774cb4125462","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            sys.stderr.write("},{"line_number":18,"context_line":"                \"Cleaning network namespaces caught an exception %s\""},{"line_number":19,"context_line":"                % str(ex))"},{"line_number":20,"context_line":"        except:"},{"line_number":21,"context_line":"            sys.stderr.write("},{"line_number":22,"context_line":"                \"Cleaning network namespaces caught an exception\")"},{"line_number":23,"context_line":"        finally:"},{"line_number":24,"context_line":"            cfg.CONF.clear()"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3fa7e38b_35c32f8f","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":66},"in_reply_to":"3fa7e38b_dab9aac5","updated":"2020-02-17 23:04:41.000000000","message":"My intention was that there were other exception types which could not be caught by \"Exception\" class. I wanted \u0027except\u0027 to catch everything and restart claiming stale namespaces.","commit_id":"62db99d1d19833aa14b6e92a7503df0f6a9a5fb4"}],"neutron/templates/daemonset-netns-cleanup-cron.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"508efc51342ee0760c270b86c35e46341e15c52c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"---"},{"line_number":28,"context_line":"apiVersion: apps/v1"},{"line_number":29,"context_line":"kind: DaemonSet"},{"line_number":30,"context_line":"metadata:"},{"line_number":31,"context_line":"  name: neutron-netns-cleanup-cron"},{"line_number":32,"context_line":"  annotations:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_95e60714","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":15},"updated":"2020-02-11 05:25:36.000000000","message":"should this be a CronJob?","commit_id":"62db99d1d19833aa14b6e92a7503df0f6a9a5fb4"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"7646f7ea4c16206c332fe1e481350307207d2129","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"---"},{"line_number":28,"context_line":"apiVersion: apps/v1"},{"line_number":29,"context_line":"kind: DaemonSet"},{"line_number":30,"context_line":"metadata:"},{"line_number":31,"context_line":"  name: neutron-netns-cleanup-cron"},{"line_number":32,"context_line":"  annotations:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_71a111a7","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":15},"in_reply_to":"3fa7e38b_95e60714","updated":"2020-02-11 20:28:15.000000000","message":"Cronjob does not run on all the nodes based on label. It only selects one of the matching nodes. Unfortunately, k8s does not support it natively.","commit_id":"62db99d1d19833aa14b6e92a7503df0f6a9a5fb4"}]}