)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2aaef3956a3285a9d6c581641f488dc5767224d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In this Patchset, Cinder configuration is added to values_overrides"},{"line_number":10,"context_line":"for supporting PURE as one possible Cinder block storage backend."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Please note: updated images are needed for Cinder and Nova to"},{"line_number":13,"context_line":"include packages specific for the support of pure backend."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ic0f1116045d74ec624449fbaf92858ccf8d4d936"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1fa4df85_00a449b8","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":58},"updated":"2020-03-18 23:35:25.000000000","message":"are these images available? and should they be mentioned in the override","commit_id":"91effc43fb2dcf6b3983293d1ce17cbb5838a724"}],"cinder/values.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bcc5a41e36141319ca4bea6bbe60b79c45fff5f3","unresolved":false,"context_lines":[{"line_number":957,"context_line":"      rados_connect_timeout: -1"},{"line_number":958,"context_line":"      rbd_user: cinder"},{"line_number":959,"context_line":"      rbd_secret_uuid: 457eb676-33da-42ec-9a8c-9293d545c337"},{"line_number":960,"context_line":"  optional_backends:"},{"line_number":961,"context_line":"    PURE:"},{"line_number":962,"context_line":"      pure_eradicate_on_delete: True"},{"line_number":963,"context_line":"      volume_backend_name: PURE_BE"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_e27edf69","line":960,"range":{"start_line":960,"start_character":2,"end_line":960,"end_character":20},"updated":"2020-03-02 08:16:55.000000000","message":"Why can\u0027t we add needed values to backends section directly when needed? I suggest to add this to values_overrides as an example.","commit_id":"24e87e625da8ba35e679b8c42fb1d00eaf271126"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"feb6dc51b20fbc28fc8cfe4b1ce688eea4c04180","unresolved":false,"context_lines":[{"line_number":957,"context_line":"      rados_connect_timeout: -1"},{"line_number":958,"context_line":"      rbd_user: cinder"},{"line_number":959,"context_line":"      rbd_secret_uuid: 457eb676-33da-42ec-9a8c-9293d545c337"},{"line_number":960,"context_line":"  optional_backends:"},{"line_number":961,"context_line":"    PURE:"},{"line_number":962,"context_line":"      pure_eradicate_on_delete: True"},{"line_number":963,"context_line":"      volume_backend_name: PURE_BE"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_fe1d0a73","line":960,"range":{"start_line":960,"start_character":2,"end_line":960,"end_character":20},"in_reply_to":"1fa4df85_e27edf69","updated":"2020-03-02 20:05:55.000000000","message":"All the backends under backends section will be deployed to backends.conf by cinder/templates/configmap-etc.yaml. An alternative solution would be: still keep optional_backends and enable_pure_backend here and move the PURE section to values_overrides. The purpose is to avoid the deployment engineer to add the PURE section manually.","commit_id":"24e87e625da8ba35e679b8c42fb1d00eaf271126"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"e0f5497aaf0040aee87eff727255d04178d678f1","unresolved":false,"context_lines":[{"line_number":957,"context_line":"      rados_connect_timeout: -1"},{"line_number":958,"context_line":"      rbd_user: cinder"},{"line_number":959,"context_line":"      rbd_secret_uuid: 457eb676-33da-42ec-9a8c-9293d545c337"},{"line_number":960,"context_line":"  optional_backends:"},{"line_number":961,"context_line":"    PURE:"},{"line_number":962,"context_line":"      pure_eradicate_on_delete: True"},{"line_number":963,"context_line":"      volume_backend_name: PURE_BE"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_1e08262a","line":960,"range":{"start_line":960,"start_character":2,"end_line":960,"end_character":20},"in_reply_to":"1fa4df85_e27edf69","updated":"2020-03-02 20:06:37.000000000","message":"what do you think","commit_id":"24e87e625da8ba35e679b8c42fb1d00eaf271126"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"facd136a8e28149e4c1553dbd4e7c19929db4a9b","unresolved":false,"context_lines":[{"line_number":957,"context_line":"      rados_connect_timeout: -1"},{"line_number":958,"context_line":"      rbd_user: cinder"},{"line_number":959,"context_line":"      rbd_secret_uuid: 457eb676-33da-42ec-9a8c-9293d545c337"},{"line_number":960,"context_line":"  optional_backends:"},{"line_number":961,"context_line":"    PURE:"},{"line_number":962,"context_line":"      pure_eradicate_on_delete: True"},{"line_number":963,"context_line":"      volume_backend_name: PURE_BE"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_d86842ba","line":960,"range":{"start_line":960,"start_character":2,"end_line":960,"end_character":20},"in_reply_to":"1fa4df85_fe1d0a73","updated":"2020-03-04 12:42:45.000000000","message":"but some information still have to be added manually like san_ip?","commit_id":"24e87e625da8ba35e679b8c42fb1d00eaf271126"}],"cinder/values_overrides/backend_pure.yaml":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"a3b29e30071dfa0e5bae9df7e08a80718495be20","unresolved":false,"context_lines":[{"line_number":18,"context_line":"       pure_api_token: pure-api-token-value"},{"line_number":19,"context_line":"       volume_driver: cinder.volume.drivers.pure.PureISCSIDriver"},{"line_number":20,"context_line":"       use_multipath_for_image_xfer: True"},{"line_number":21,"context_line":"       san_ip: 1.1.1.1"},{"line_number":22,"context_line":"  enable_iscsi: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fa4df85_3e3e7029","line":21,"range":{"start_line":21,"start_character":1,"end_line":21,"end_character":22},"updated":"2020-03-16 18:50:40.000000000","message":"want to leave some comments in here to explain that san_ip value here is mock only and should be replaced with a real ip?","commit_id":"146c9f32d5761122eb5d9379affa61164be03679"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"24c608136c81ef9f89870d0454dafbe83ed124fc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"       pure_api_token: pure-api-token-value"},{"line_number":19,"context_line":"       volume_driver: cinder.volume.drivers.pure.PureISCSIDriver"},{"line_number":20,"context_line":"       use_multipath_for_image_xfer: True"},{"line_number":21,"context_line":"       san_ip: 1.1.1.1"},{"line_number":22,"context_line":"  enable_iscsi: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fa4df85_9d3449e0","line":21,"range":{"start_line":21,"start_character":1,"end_line":21,"end_character":22},"in_reply_to":"1fa4df85_3e3e7029","updated":"2020-03-16 20:45:56.000000000","message":"Updated","commit_id":"146c9f32d5761122eb5d9379affa61164be03679"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2aaef3956a3285a9d6c581641f488dc5767224d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      enabled_backends: \"rbd1,PURE\""},{"line_number":14,"context_line":"  backends:"},{"line_number":15,"context_line":"    PURE:"},{"line_number":16,"context_line":"       pure_eradicate_on_delete: True"},{"line_number":17,"context_line":"       volume_backend_name: PURE_BE"},{"line_number":18,"context_line":"       # NOTE: Replace below pure-api-token-value with the real token value"},{"line_number":19,"context_line":"       pure_api_token: pure-api-token-value"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_c0b871e6","line":16,"range":{"start_line":16,"start_character":33,"end_line":16,"end_character":37},"updated":"2020-03-18 23:35:25.000000000","message":"true","commit_id":"91effc43fb2dcf6b3983293d1ce17cbb5838a724"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2aaef3956a3285a9d6c581641f488dc5767224d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"       # NOTE: Replace below pure-api-token-value with the real token value"},{"line_number":19,"context_line":"       pure_api_token: pure-api-token-value"},{"line_number":20,"context_line":"       volume_driver: cinder.volume.drivers.pure.PureISCSIDriver"},{"line_number":21,"context_line":"       use_multipath_for_image_xfer: True"},{"line_number":22,"context_line":"       # NOTE: Replace below 1.1.1.1 with the real ip value"},{"line_number":23,"context_line":"       san_ip: 1.1.1.1"},{"line_number":24,"context_line":"  enable_iscsi: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_80ca796b","line":21,"range":{"start_line":21,"start_character":37,"end_line":21,"end_character":41},"updated":"2020-03-18 23:35:25.000000000","message":"true","commit_id":"91effc43fb2dcf6b3983293d1ce17cbb5838a724"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"5b03d347218b724ea8b7ba23517f63320a172dd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# NOTE: In order for below code to work, \"purestorage\" and related packages"},{"line_number":2,"context_line":"# need to be built into Cnder and Nova images."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"pod:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f493fa4_9c9dcf5b","line":1,"range":{"start_line":1,"start_character":59,"end_line":1,"end_character":75},"updated":"2020-04-21 14:29:35.000000000","message":"is it possible to nail down the list of \"related packages\"?  This seems a little abstract, some additional reference would be good if possible.","commit_id":"c8aac6a9b349490adadcf1296fadd68570e683c4"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"5b03d347218b724ea8b7ba23517f63320a172dd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# NOTE: In order for below code to work, \"purestorage\" and related packages"},{"line_number":2,"context_line":"# need to be built into Cnder and Nova images."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"pod:"},{"line_number":5,"context_line":"  useHostNetwork:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f493fa4_bcb1abe4","line":2,"range":{"start_line":2,"start_character":29,"end_line":2,"end_character":46},"updated":"2020-04-21 14:29:35.000000000","message":"Can we also specified the list of images that must contain the packages listed above?  I assume there are no such images upstream, so we can add the values override example here, but maybe at least of which images to override?","commit_id":"c8aac6a9b349490adadcf1296fadd68570e683c4"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"5b03d347218b724ea8b7ba23517f63320a172dd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# NOTE: In order for below code to work, \"purestorage\" and related packages"},{"line_number":2,"context_line":"# need to be built into Cnder and Nova images."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"pod:"},{"line_number":5,"context_line":"  useHostNetwork:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f493fa4_1c741f35","line":2,"range":{"start_line":2,"start_character":24,"end_line":2,"end_character":29},"updated":"2020-04-21 14:29:35.000000000","message":"typo","commit_id":"c8aac6a9b349490adadcf1296fadd68570e683c4"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"18799285531dbb896dd4a4538298d529e2ff5f22","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      enabled_backends: \"rbd1,PURE\""},{"line_number":17,"context_line":"  backends:"},{"line_number":18,"context_line":"    PURE:"},{"line_number":19,"context_line":"       pure_eradicate_on_delete: true"},{"line_number":20,"context_line":"       volume_backend_name: PURE_BE"},{"line_number":21,"context_line":"       # NOTE: Replace below pure-api-token-value with the real token value"},{"line_number":22,"context_line":"       pure_api_token: pure-api-token-value"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f493fa4_1b69bcbd","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":7},"updated":"2020-04-21 21:20:30.000000000","message":"this is indented 3 spaces","commit_id":"7b42ecf9c9c70806c34d2e684293eaffb4b5a313"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"6d43f9ce726bdb00df41877b50f6d323a3579d3a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      enabled_backends: \"rbd1,PURE\""},{"line_number":17,"context_line":"  backends:"},{"line_number":18,"context_line":"    PURE:"},{"line_number":19,"context_line":"       pure_eradicate_on_delete: true"},{"line_number":20,"context_line":"       volume_backend_name: PURE_BE"},{"line_number":21,"context_line":"       # NOTE: Replace below pure-api-token-value with the real token value"},{"line_number":22,"context_line":"       pure_api_token: pure-api-token-value"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f493fa4_5bbfc4fa","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":7},"in_reply_to":"1f493fa4_1b69bcbd","updated":"2020-04-21 21:25:43.000000000","message":"updated","commit_id":"7b42ecf9c9c70806c34d2e684293eaffb4b5a313"}]}