)]}'
{"tools/deployment/developer/ceph/160-compute-kit.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e441fad2ffa025a51d4683c1ec20cfb866720e72","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  \"rocky\")"},{"line_number":33,"context_line":"    DEPLOY_SEPARATE_PLACEMENT\u003d\"no\""},{"line_number":34,"context_line":"    ;;"},{"line_number":35,"context_line":"  *)"},{"line_number":36,"context_line":"    DEPLOY_SEPARATE_PLACEMENT\u003d\"yes\""},{"line_number":37,"context_line":"    ;;"},{"line_number":38,"context_line":"esac"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_54767fda","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":10},"updated":"2020-03-19 09:11:05.000000000","message":"for stein, I believe we still deploy the placement as part of nova.","commit_id":"1f557d07215fb8bb4f9b5922dc14d4be6d76cf18"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"2ba82e08352b672bb53c789c348410e0c034b797","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"df33271e_cd232c05","updated":"2020-03-21 03:34:08.000000000","message":"this script unfortunately isn\u0027t being run by the gate.","commit_id":"db4db61596be6e63ba27767eda33e389e42c6c0b"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"2ba82e08352b672bb53c789c348410e0c034b797","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"set -xe"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"export RUN_HELM_TESTS\u003d\"no\""},{"line_number":19,"context_line":"export CEPH_ENABLED\u003dtrue"},{"line_number":20,"context_line":"export OSH_EXTRA_HELM_ARGS_NOVA\u003d\"${OSH_EXTRA_HELM_ARGS} --set manifests.network_policy\u003dtrue\""},{"line_number":21,"context_line":"# Deploy nova and neutron charts"}],"source_content_type":"text/x-sh","patch_set":6,"id":"df33271e_ed26f016","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":26},"updated":"2020-03-21 03:34:08.000000000","message":"why are we disabling helm test for this?","commit_id":"db4db61596be6e63ba27767eda33e389e42c6c0b"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"0309c6ac2522a7752c8659c94003944771b3854d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"set -xe"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"export RUN_HELM_TESTS\u003d\"no\""},{"line_number":19,"context_line":"export CEPH_ENABLED\u003dtrue"},{"line_number":20,"context_line":"export OSH_EXTRA_HELM_ARGS_NOVA\u003d\"${OSH_EXTRA_HELM_ARGS} --set manifests.network_policy\u003dtrue\""},{"line_number":21,"context_line":"# Deploy nova and neutron charts"}],"source_content_type":"text/x-sh","patch_set":6,"id":"df33271e_cdadec32","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":26},"in_reply_to":"df33271e_cdd68cc4","updated":"2020-03-21 04:45:26.000000000","message":"i you wish i can externalize this parameter in scope of this ps. but logically this should be a separate effort","commit_id":"db4db61596be6e63ba27767eda33e389e42c6c0b"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"c2c003af30959a270099ed9bcc679a0d067f7c2c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"set -xe"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"export RUN_HELM_TESTS\u003d\"no\""},{"line_number":19,"context_line":"export CEPH_ENABLED\u003dtrue"},{"line_number":20,"context_line":"export OSH_EXTRA_HELM_ARGS_NOVA\u003d\"${OSH_EXTRA_HELM_ARGS} --set manifests.network_policy\u003dtrue\""},{"line_number":21,"context_line":"# Deploy nova and neutron charts"}],"source_content_type":"text/x-sh","patch_set":6,"id":"df33271e_cdd68cc4","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":26},"in_reply_to":"df33271e_ed26f016","updated":"2020-03-21 03:54:06.000000000","message":"This is a refactoring w/o changing logic.","commit_id":"db4db61596be6e63ba27767eda33e389e42c6c0b"}],"tools/deployment/developer/nfs/160-compute-kit.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"2ba82e08352b672bb53c789c348410e0c034b797","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"df33271e_2d21f8fc","updated":"2020-03-21 03:34:08.000000000","message":"same here - this script isn\u0027t currently being run","commit_id":"db4db61596be6e63ba27767eda33e389e42c6c0b"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"c2c003af30959a270099ed9bcc679a0d067f7c2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"df33271e_edd9d0f4","in_reply_to":"df33271e_2d21f8fc","updated":"2020-03-21 03:54:06.000000000","message":"i\u0027m aware of that. this is a simple refactoring without changing any logic","commit_id":"db4db61596be6e63ba27767eda33e389e42c6c0b"}]}