)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"690567f91485dc64f010d880f12459cafb88e285","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  security:"},{"line_number":16,"context_line":"  software:"},{"line_number":17,"context_line":"    apache2:"},{"line_number":18,"context_line":"      conf_dir:"},{"line_number":19,"context_line":"      site_dir:"},{"line_number":20,"context_line":"      mods_dir:"},{"line_number":21,"context_line":"      binary:"},{"line_number":22,"context_line":"      start_flags:"},{"line_number":23,"context_line":"      a2enmod:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_f68e5d25","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":15},"updated":"2020-05-07 23:44:08.000000000","message":"I see you discussed this with Tin. If you\u0027ve decided against implementing these, I would remove this example from the commit message (and below too). On the other hand, it looks like you could make these configurable by updating the templates/deployment.yaml if you wanted to.","commit_id":"99af93f09cead6fd80ac6a8ea48897f42701c66e"}],"placement/templates/bin/_placement-api.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"47c3bbc17d269a272ed6bf54e2ad43b0d5440e24","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    source /etc/apache2/envvars"},{"line_number":29,"context_line":"    # The directory below has to be created due to the fact that"},{"line_number":30,"context_line":"    # libapache2-mod-wsgi-py3 doesn\u0027t create it in contrary by libapache2-mod-wsgi"},{"line_number":31,"context_line":"    if [ ! -d ${APACHE_RUN_DIR} ]; then"},{"line_number":32,"context_line":"      mkdir -p ${APACHE_RUN_DIR}"},{"line_number":33,"context_line":"    fi"},{"line_number":34,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"ff570b3c_b1ee0486","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":39},"updated":"2020-05-11 10:59:59.000000000","message":"is this needed if we are using -p below? per mkdir\u0027s manpage:\n\n       -p, --parents\n              no error if existing, make parent directories as needed","commit_id":"ef65f105dbded993f0216cfff90c82590e2090af"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"603d5f28ad29377449269d36e5f3cbce14b7e8a2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    source /etc/apache2/envvars"},{"line_number":29,"context_line":"    # The directory below has to be created due to the fact that"},{"line_number":30,"context_line":"    # libapache2-mod-wsgi-py3 doesn\u0027t create it in contrary by libapache2-mod-wsgi"},{"line_number":31,"context_line":"    if [ ! -d ${APACHE_RUN_DIR} ]; then"},{"line_number":32,"context_line":"      mkdir -p ${APACHE_RUN_DIR}"},{"line_number":33,"context_line":"    fi"},{"line_number":34,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"ff570b3c_03d79bc1","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":39},"in_reply_to":"ff570b3c_b1ee0486","updated":"2020-05-11 16:39:30.000000000","message":"I just refer to our existed code below.\nhttps://review.opendev.org/#/c/667570/2/aodh/templates/bin/_aodh-api.sh.tpl\nIf you are mind, I can change it, thanks!","commit_id":"ef65f105dbded993f0216cfff90c82590e2090af"}],"placement/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"cd50f2a6b3b0a25de9af585a003969a277383c43","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    apache2:"},{"line_number":70,"context_line":"      binary: apache2"},{"line_number":71,"context_line":"      start_parameters: -DFOREGROUND"},{"line_number":72,"context_line":"      site_dir: /etc/apache2/sites-enable"},{"line_number":73,"context_line":"      conf_dir: /etc/apache2/conf-enabled"},{"line_number":74,"context_line":"      mods_dir: /etc/apache2/mods-available"},{"line_number":75,"context_line":"      a2enmod: null"},{"line_number":76,"context_line":"      a2dismod: null"},{"line_number":77,"context_line":"  placement:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_08f84fe3","line":74,"range":{"start_line":72,"start_character":0,"end_line":74,"end_character":43},"updated":"2020-04-22 03:07:23.000000000","message":"where are these being used?","commit_id":"e19758b08aaae3724d26438ec7789a25f5238616"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"859bad4d5dd1ac69905cd98a8f93cd7bb60a06fd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    apache2:"},{"line_number":70,"context_line":"      binary: apache2"},{"line_number":71,"context_line":"      start_parameters: -DFOREGROUND"},{"line_number":72,"context_line":"      site_dir: /etc/apache2/sites-enable"},{"line_number":73,"context_line":"      conf_dir: /etc/apache2/conf-enabled"},{"line_number":74,"context_line":"      mods_dir: /etc/apache2/mods-available"},{"line_number":75,"context_line":"      a2enmod: null"},{"line_number":76,"context_line":"      a2dismod: null"},{"line_number":77,"context_line":"  placement:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_88ff3fa9","line":74,"range":{"start_line":72,"start_character":0,"end_line":74,"end_character":43},"in_reply_to":"1f493fa4_08f84fe3","updated":"2020-04-22 05:03:57.000000000","message":"seems not used, I can remove it, thanks!","commit_id":"e19758b08aaae3724d26438ec7789a25f5238616"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"47c3bbc17d269a272ed6bf54e2ad43b0d5440e24","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    default: \u0027rule:admin_or_owner\u0027"},{"line_number":68,"context_line":"  software:"},{"line_number":69,"context_line":"    apache2:"},{"line_number":70,"context_line":"      binary: apache2"},{"line_number":71,"context_line":"      start_parameters: -DFOREGROUND"},{"line_number":72,"context_line":"      a2enmod: null"},{"line_number":73,"context_line":"      a2dismod: null"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_f1ffdc31","line":70,"range":{"start_line":70,"start_character":14,"end_line":70,"end_character":21},"updated":"2020-05-11 10:59:59.000000000","message":"this was previously apachectl","commit_id":"ef65f105dbded993f0216cfff90c82590e2090af"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"603d5f28ad29377449269d36e5f3cbce14b7e8a2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    default: \u0027rule:admin_or_owner\u0027"},{"line_number":68,"context_line":"  software:"},{"line_number":69,"context_line":"    apache2:"},{"line_number":70,"context_line":"      binary: apache2"},{"line_number":71,"context_line":"      start_parameters: -DFOREGROUND"},{"line_number":72,"context_line":"      a2enmod: null"},{"line_number":73,"context_line":"      a2dismod: null"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_83bc4bbc","line":70,"range":{"start_line":70,"start_character":14,"end_line":70,"end_character":21},"in_reply_to":"ff570b3c_f1ffdc31","updated":"2020-05-11 16:39:30.000000000","message":"Hi Tin,\nChange in this file refers to nova/value.yaml completely","commit_id":"ef65f105dbded993f0216cfff90c82590e2090af"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"47c3bbc17d269a272ed6bf54e2ad43b0d5440e24","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    apache2:"},{"line_number":70,"context_line":"      binary: apache2"},{"line_number":71,"context_line":"      start_parameters: -DFOREGROUND"},{"line_number":72,"context_line":"      a2enmod: null"},{"line_number":73,"context_line":"      a2dismod: null"},{"line_number":74,"context_line":"  placement:"},{"line_number":75,"context_line":"    DEFAULT:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_318f94cd","line":72,"range":{"start_line":72,"start_character":15,"end_line":72,"end_character":19},"updated":"2020-05-11 10:59:59.000000000","message":"minimally, can we put a note on what this a2enmod: supposed to be? a comma-separated list, an array - so folks don\u0027t need to read the code to figure it out the required structure.","commit_id":"ef65f105dbded993f0216cfff90c82590e2090af"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"47c3bbc17d269a272ed6bf54e2ad43b0d5440e24","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      binary: apache2"},{"line_number":71,"context_line":"      start_parameters: -DFOREGROUND"},{"line_number":72,"context_line":"      a2enmod: null"},{"line_number":73,"context_line":"      a2dismod: null"},{"line_number":74,"context_line":"  placement:"},{"line_number":75,"context_line":"    DEFAULT:"},{"line_number":76,"context_line":"      debug: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_d1b73886","line":73,"range":{"start_line":73,"start_character":16,"end_line":73,"end_character":20},"updated":"2020-05-11 10:59:59.000000000","message":"ditto","commit_id":"ef65f105dbded993f0216cfff90c82590e2090af"}]}