)]}'
{"id":"openstack%2Fopenstack-helm~730762","triplet_id":"openstack%2Fopenstack-helm~master~I9aae94bc0a68318b2c16fedbc973f7a0a2a3729e","project":"openstack/openstack-helm","branch":"master","topic":"fix/indentation","hashtags":[],"change_id":"I9aae94bc0a68318b2c16fedbc973f7a0a2a3729e","subject":"fix(yaml): correct bad annotations","status":"MERGED","created":"2020-05-26 11:17:42.000000000","updated":"2020-06-02 18:07:36.000000000","submitted":"2020-06-02 18:05:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"730762-1591121134002-4985846c","meta_rev_id":"d50625c970785f4ee328023f12203bf98196d4e2","_number":730762,"virtual_id_number":730762,"owner":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-02 18:05:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"date":"2020-05-26 19:04:55.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"all":[{"value":2,"date":"2020-05-27 20:05:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-06-02 16:52:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"all":[{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-06-02 16:52:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"date":"2020-05-26 11:20:42.000000000","_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},{"value":0,"date":"2020-05-26 11:19:26.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-26 11:19:26.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2020-05-26 11:20:42.000000000","updated_by":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"reviewer":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"state":"REVIEWER"},{"updated":"2020-05-27 20:05:41.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2020-06-02 16:52:24.000000000","updated_by":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"reviewer":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"state":"REVIEWER"},{"updated":"2020-06-02 18:05:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7f981bc4d0f6678faf5165de67e6412dc6ed5abb","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2020-05-26 11:17:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"80c22a45f0be5d1156f291b16f9b49e270763296","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2020-05-26 11:19:03.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"486489284343a82f171de1cbf984a67d2b44a79c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-26 12:29:51.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/09d89892aa1840bca76edb478e6d95b2 : SUCCESS in 6m 28s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/405bde44a8ed45aca4c6e4d4f88bcc98 : SUCCESS in 2m 22s\n- openstack-helm-cinder https://zuul.opendev.org/t/openstack/build/ba10ffc05efb4d6c81aa4d06623c6e02 : FAILURE in 1h 00m 58s\n- openstack-helm-cinder-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/120b5199a5e84e36a98b7ead2068716d : FAILURE in 59m 44s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/bb578f4ab2f94df69aa1287fd8128cde : FAILURE in 1h 09m 19s\n- openstack-helm-compute-kit https://zuul.opendev.org/t/openstack/build/c705a6decf1944c098cd63eb776caf82 : SUCCESS in 1h 03m 35s\n- openstack-helm-compute-kit-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/e8a5922bb16440599988806237bbdc2a : SUCCESS in 1h 03m 25s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/f726cd3568514ed2a15953c0a1ec1227 : SUCCESS in 1h 04m 59s","accounts_in_message":[],"_revision_number":2},{"id":"9e8761293fbe8baf430ca1fc84f9b11c18b463c3","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2020-05-26 19:04:55.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"2916f8e37c6ea340fc78061eb24f99fe968decd1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-26 20:19:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/73ddbea0b2a3443295464b2d84d5a9e4 : SUCCESS in 6m 42s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/4a58e0b6207f44db8d77423519659331 : SUCCESS in 2m 54s\n- openstack-helm-cinder https://zuul.opendev.org/t/openstack/build/5e2314522d5646cd981d0c8f77109ee9 : SUCCESS in 58m 04s\n- openstack-helm-cinder-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/a9cfa755547347239ae55dfeb882dc3c : SUCCESS in 1h 00m 27s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/eb0085911cab460cbccb72358d6d3539 : SUCCESS in 48m 26s\n- openstack-helm-compute-kit https://zuul.opendev.org/t/openstack/build/0a93466f337e42078da5018af2f41655 : SUCCESS in 59m 32s\n- openstack-helm-compute-kit-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/76d6189a47944feca0e4f9e4a9d57b19 : SUCCESS in 1h 05m 55s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/471ac6e5d7dc43bcbce94d845a582700 : SUCCESS in 1h 09m 32s","accounts_in_message":[],"_revision_number":2},{"id":"18c5a324d63db108401d64d8030a9c2efb716372","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2020-05-27 20:05:41.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1013205a59adebc207953dac9d08eda8d77ddda4","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-06-02 16:52:24.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"f94ecc48d60146ba2b746b834b7d555e31016e43","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-02 16:52:35.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"75955176473e60becc2eed7fa003ba84ed41ab8c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-02 18:05:33.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e2c24f06f98d416e9c90653c51966c6c : SUCCESS in 5m 40s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/5f35f4cbf4ed43fdaad17f4f49eb0283 : SUCCESS in 2m 15s\n- openstack-helm-cinder https://zuul.opendev.org/t/openstack/build/4e1eb9a014ac4d9390be671b296139d7 : SUCCESS in 40m 22s\n- openstack-helm-compute-kit https://zuul.opendev.org/t/openstack/build/ce471ef9dc6e4b69bf92d2596690d163 : SUCCESS in 1h 11m 59s","accounts_in_message":[],"_revision_number":2},{"id":"87d1cd35921f5511c98ef78d64cf58d03f69dcc4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-02 18:05:34.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"5f6156ed6ad9938c7eda1f2c1f444049f63203b1","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-02 18:07:36.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5daaf6c30e304185a62ef3d95ea05007 : SUCCESS in 1m 45s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d239c701527931553c69b60755b073b4571f3ca1","revisions":{"6f5f3560316757afb5227cdf70b2838ce14ba90b":{"kind":"REWORK","_number":1,"created":"2020-05-26 11:17:42.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/62/730762/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/62/730762/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/62/730762/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/62/730762/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/62/730762/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/62/730762/1"}}},"commit":{"parents":[{"commit":"3af196f5788464f8369b2dbf31a68d0d7ecc6a52","subject":"Merge \"feat(tls): adding cert manager to gate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3af196f5788464f8369b2dbf31a68d0d7ecc6a52"}]}],"author":{"name":"Tin Lam","email":"tin@irrational.io","date":"2020-05-26 11:14:23.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2020-05-26 11:14:23.000000000","tz":-300},"subject":"fix(yaml): correct bad annotations","message":"fix(yaml): correct bad annotations\n\nIn a recent apparmor security patch [0], additional annotations were\nadded to the cronjob that are incorrectly indented. While helm v2 seems\nfairly generously with these errors, trying to run this in helm v3 seems\nto cause rendering problems as we are placing incorrect key/value into\nthe spec: field. This patch set corrects this.\n\n[0] https://review.opendev.org/#/c/725727/8\n\nChange-Id: I9aae94bc0a68318b2c16fedbc973f7a0a2a3729e\nSigned-off-by: Tin Lam \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/6f5f3560316757afb5227cdf70b2838ce14ba90b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/6f5f3560316757afb5227cdf70b2838ce14ba90b"}]},"branch":"refs/heads/master"},"d239c701527931553c69b60755b073b4571f3ca1":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-05-26 11:19:03.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/62/730762/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/62/730762/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/62/730762/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/62/730762/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/62/730762/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/62/730762/2"}}},"commit":{"parents":[{"commit":"3af196f5788464f8369b2dbf31a68d0d7ecc6a52","subject":"Merge \"feat(tls): adding cert manager to gate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3af196f5788464f8369b2dbf31a68d0d7ecc6a52"}]}],"author":{"name":"Tin Lam","email":"tin@irrational.io","date":"2020-05-26 11:14:23.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2020-05-26 11:18:59.000000000","tz":0},"subject":"fix(yaml): correct bad annotations","message":"fix(yaml): correct bad annotations\n\nIn a recent apparmor security patch [0], additional annotations were\nadded to the cronjobs that were incorrectly indented. While helm v2\nseems fairly tolerant and ignores these errors, running this usig helm\nv3 seems to cause rendering problems as we are placing incorrect key\nand value pair into the spec: field. This patch set corrects this.\n\n[0] https://review.opendev.org/#/c/725727/8\n\nChange-Id: I9aae94bc0a68318b2c16fedbc973f7a0a2a3729e\nSigned-off-by: Tin Lam \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d239c701527931553c69b60755b073b4571f3ca1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/d239c701527931553c69b60755b073b4571f3ca1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}