)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"efb97625ba9f490032896aa5bf4f29626293be4d","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This also addresses comments mentioned in previous patches."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Co-authored-by: Gage Hugo \u003cgagehugo@gmail.com\u003e"},{"line_number":23,"context_line":"Co-authored-by: sgupta \u003csg774j@att.com\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-on: https://review.opendev.org/#/c/737194/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"bf51134e_a4762bd7","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":46},"updated":"2020-07-10 21:16:37.000000000","message":"Not really co-authored by me","commit_id":"918a307427ee9bfaf4ecdb758905de59831f15b5"}],"glance/templates/deployment-api.yaml":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"174c2ffc1eea339d58a9817548e46c2fdfcd6c30","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        {{ end }}"},{"line_number":94,"context_line":"      containers:"},{"line_number":95,"context_line":"        {{- if $envAll.Values.manifests.certificates }}"},{"line_number":96,"context_line":"        - name: nginx"},{"line_number":97,"context_line":"          image: {{ $envAll.Values.images.tags.nginx }}"},{"line_number":98,"context_line":"          imagePullPolicy: IfNotPresent"},{"line_number":99,"context_line":"          ports:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bf51134e_0f80f6be","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":21},"updated":"2020-07-09 02:11:39.000000000","message":"no resource allocation for this guy","commit_id":"4af01e5cc0f89d5798b3dc606b18348f0a70e8c0"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"345a1106bc2b51297b4de8d1a23eb89eb012e7d6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        {{ end }}"},{"line_number":94,"context_line":"      containers:"},{"line_number":95,"context_line":"        {{- if $envAll.Values.manifests.certificates }}"},{"line_number":96,"context_line":"        - name: nginx"},{"line_number":97,"context_line":"          image: {{ $envAll.Values.images.tags.nginx }}"},{"line_number":98,"context_line":"          imagePullPolicy: IfNotPresent"},{"line_number":99,"context_line":"          ports:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bf51134e_32a0bd90","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":21},"in_reply_to":"bf51134e_0f80f6be","updated":"2020-07-09 04:05:44.000000000","message":"Done","commit_id":"4af01e5cc0f89d5798b3dc606b18348f0a70e8c0"}],"glance/templates/deployment-registry.yaml":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"174c2ffc1eea339d58a9817548e46c2fdfcd6c30","unresolved":false,"context_lines":[{"line_number":56,"context_line":"{{ tuple $envAll \"registry\" $mounts_glance_registry_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":57,"context_line":"      containers:"},{"line_number":58,"context_line":"        {{- if $envAll.Values.manifests.certificates }}"},{"line_number":59,"context_line":"        - name: nginx"},{"line_number":60,"context_line":"          image: {{ $envAll.Values.images.tags.nginx }}"},{"line_number":61,"context_line":"          imagePullPolicy: IfNotPresent"},{"line_number":62,"context_line":"          ports:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bf51134e_4f6dce30","line":59,"range":{"start_line":59,"start_character":16,"end_line":59,"end_character":21},"updated":"2020-07-09 02:11:39.000000000","message":"ditto","commit_id":"4af01e5cc0f89d5798b3dc606b18348f0a70e8c0"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"345a1106bc2b51297b4de8d1a23eb89eb012e7d6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"{{ tuple $envAll \"registry\" $mounts_glance_registry_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":57,"context_line":"      containers:"},{"line_number":58,"context_line":"        {{- if $envAll.Values.manifests.certificates }}"},{"line_number":59,"context_line":"        - name: nginx"},{"line_number":60,"context_line":"          image: {{ $envAll.Values.images.tags.nginx }}"},{"line_number":61,"context_line":"          imagePullPolicy: IfNotPresent"},{"line_number":62,"context_line":"          ports:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bf51134e_72a6b5ad","line":59,"range":{"start_line":59,"start_character":16,"end_line":59,"end_character":21},"in_reply_to":"bf51134e_4f6dce30","updated":"2020-07-09 04:05:44.000000000","message":"Done","commit_id":"4af01e5cc0f89d5798b3dc606b18348f0a70e8c0"}],"glance/values_overrides/tls.yaml":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"2bb0013ee33beb5424fe55ba0bdd58ff2472bb22","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        ssl_certificate      /etc/nginx/certs/tls.crt;"},{"line_number":52,"context_line":"        ssl_certificate_key  /etc/nginx/certs/tls.key;"},{"line_number":53,"context_line":"        ssl_ciphers ECDHE-RSA-AES256-GCM-SHA512:DHE-RSA-AES256-GCM-SHA512:ECDHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-SHA384;"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        location / {"},{"line_number":56,"context_line":"          proxy_pass_request_headers on;"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_61768840","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":19},"updated":"2020-06-26 18:51:22.000000000","message":"Is there a reason for the different list of ciphers for different services?\n\nIs there an opportunity for some more centralization for repeated values throughout all these charts?","commit_id":"7292ddc72a7f1905061c1447d1b3ff00f35658a4"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fb65c4c7bb8ebc04b9917b46a24561b898c2d9e0","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        ssl_certificate      /etc/nginx/certs/tls.crt;"},{"line_number":52,"context_line":"        ssl_certificate_key  /etc/nginx/certs/tls.key;"},{"line_number":53,"context_line":"        ssl_ciphers ECDHE-RSA-AES256-GCM-SHA512:DHE-RSA-AES256-GCM-SHA512:ECDHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-SHA384;"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        location / {"},{"line_number":56,"context_line":"          proxy_pass_request_headers on;"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_4128a495","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":19},"in_reply_to":"bf51134e_61768840","updated":"2020-06-26 19:21:56.000000000","message":"This is only called out due to the requirement that ECDHE-RSA-AES256-SHA384; has to be included. However, I expect folks can remove this option altogether and still get a reasonable set of ciphers ensuring security. However, if folks want to further customize this (e.g. restrict things to TLS 1.3), they will end up overwriting this entire conf anyway.\n\nHaving helm toolkit spit back a set of fixed cipher makes it difficult to customize - and it will end up just reading off a key. Perhaps we can read this off {{ .Values.x.y.tls.cipher }} in a follow on patch set.","commit_id":"7292ddc72a7f1905061c1447d1b3ff00f35658a4"}],"zuul.d/jobs-openstack-helm.yaml":[{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"10b1f088b99a079e12e0b09170024af459cb0ce7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    parent: openstack-helm-cinder"},{"line_number":151,"context_line":"    vars:"},{"line_number":152,"context_line":"      osh_params:"},{"line_number":153,"context_line":"        openstack_release: train"},{"line_number":154,"context_line":"        container_distro_name: ubuntu"},{"line_number":155,"context_line":"        container_distro_version: bionic"},{"line_number":156,"context_line":"        feature_gates: tls"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_96231da7","line":153,"range":{"start_line":153,"start_character":27,"end_line":153,"end_character":32},"updated":"2020-06-26 20:52:03.000000000","message":"should be stein","commit_id":"7292ddc72a7f1905061c1447d1b3ff00f35658a4"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"10b1f088b99a079e12e0b09170024af459cb0ce7","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    parent: openstack-helm-compute-kit"},{"line_number":248,"context_line":"    vars:"},{"line_number":249,"context_line":"      osh_params:"},{"line_number":250,"context_line":"        openstack_release: train"},{"line_number":251,"context_line":"        container_distro_name: ubuntu"},{"line_number":252,"context_line":"        container_distro_version: bionic"},{"line_number":253,"context_line":"        feature_gates: tls"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_b65581fc","line":250,"range":{"start_line":250,"start_character":27,"end_line":250,"end_character":32},"updated":"2020-06-26 20:52:03.000000000","message":"should be stein","commit_id":"7292ddc72a7f1905061c1447d1b3ff00f35658a4"}],"zuul.d/project.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0706db7a08189544b67fe704d729e557261d7b1a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# and jobs are defined."},{"line_number":19,"context_line":"# NOTE(evrardjp): Some jobs and playbooks haven\u0027t been"},{"line_number":20,"context_line":"# migrated to openstack-helm-infra yet."},{"line_number":21,"context_line":"- project:"},{"line_number":22,"context_line":"    templates:"},{"line_number":23,"context_line":"      - publish-openstack-docs-pti"},{"line_number":24,"context_line":"    check:"},{"line_number":25,"context_line":"      jobs:"},{"line_number":26,"context_line":"        - openstack-helm-lint"},{"line_number":27,"context_line":"        - openstack-helm-bandit"},{"line_number":28,"context_line":"        - openstack-helm-cinder-stein-ubuntu_bionic"},{"line_number":29,"context_line":"        - openstack-helm-cinder-rocky-ubuntu_bionic"},{"line_number":30,"context_line":"        - openstack-helm-cinder-train-ubuntu_bionic"},{"line_number":31,"context_line":"        - openstack-helm-compute-kit-stein-ubuntu_bionic"},{"line_number":32,"context_line":"        - openstack-helm-compute-kit-rocky-ubuntu_bionic"},{"line_number":33,"context_line":"        - openstack-helm-compute-kit-train-ubuntu_bionic"},{"line_number":34,"context_line":"        - openstack-helm-horizon-stein-ubuntu_bionic"},{"line_number":35,"context_line":"        - openstack-helm-tf"},{"line_number":36,"context_line":"    gate:"},{"line_number":37,"context_line":"      jobs:"},{"line_number":38,"context_line":"        - openstack-helm-lint"},{"line_number":39,"context_line":"        - openstack-helm-cinder-stein-ubuntu_bionic"},{"line_number":40,"context_line":"        - openstack-helm-compute-kit-stein-ubuntu_bionic"},{"line_number":41,"context_line":"        - openstack-helm-horizon-stein-ubuntu_bionic"},{"line_number":42,"context_line":"    periodic:"},{"line_number":43,"context_line":"      jobs:"},{"line_number":44,"context_line":"        - openstack-helm-keystone-ldap"},{"line_number":45,"context_line":"        - openstack-helm-cinder-ocata-ubuntu_xenial"},{"line_number":46,"context_line":"        - openstack-helm-cinder-pike-ubuntu_xenial"},{"line_number":47,"context_line":"        - openstack-helm-cinder-queens-ubuntu_xenial"},{"line_number":48,"context_line":"        - openstack-helm-cinder-rocky-ubuntu_bionic"},{"line_number":49,"context_line":"        - openstack-helm-compute-kit-ocata-ubuntu_xenial"},{"line_number":50,"context_line":"        - openstack-helm-compute-kit-pike-ubuntu_xenial"},{"line_number":51,"context_line":"        - openstack-helm-compute-kit-queens-ubuntu_xenial"},{"line_number":52,"context_line":"        - openstack-helm-compute-kit-rocky-ubuntu_bionic"},{"line_number":53,"context_line":"        - openstack-helm-tungsten-fabric"},{"line_number":54,"context_line":"    experimental:"},{"line_number":55,"context_line":"      jobs:"},{"line_number":56,"context_line":"        - openstack-helm-apparmor"},{"line_number":57,"context_line":"        - openstack-helm-tls"},{"line_number":58,"context_line":"        - openstack-helm-apparmor-cinder"},{"line_number":59,"context_line":"        - openstack-helm-netpol-compute-kit"},{"line_number":60,"context_line":"        - openstack-helm-netpol-compute-kit-train"},{"line_number":61,"context_line":"        - openstack-helm-netpol-cinder"},{"line_number":62,"context_line":"        # NOTE(srwilkers): Disabling the following jobs until"},{"line_number":63,"context_line":"        # issues with the kubeadm-aio based deployments are addressed"},{"line_number":64,"context_line":"        # - openstack-helm-multinode-temp-ubuntu"},{"line_number":65,"context_line":"        # - openstack-helm-multinode-temp-centos"},{"line_number":66,"context_line":"        # - openstack-helm-multinode-temp-fedora"},{"line_number":67,"context_line":"        # - openstack-helm-multinode-temp-tempest"},{"line_number":68,"context_line":"        # - openstack-helm-armada-deploy"},{"line_number":69,"context_line":"        # - openstack-helm-armada-update-uuid"},{"line_number":70,"context_line":"        # - openstack-helm-armada-update-passwords"},{"line_number":71,"context_line":"        # - openstack-helm-ironic-ubuntu"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bf51134e_55af097c","line":71,"range":{"start_line":21,"start_character":2,"end_line":71,"end_character":0},"updated":"2020-07-10 02:09:21.000000000","message":"Job openstack-helm-tf not defined","commit_id":"a1377a8e4cfc6a01ccc59b843ef5e112f6563814"}]}