)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"008b862616c6bdf577d9d7703f4e9ff354a6681a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     chinasubbareddy mallavarapu \u003ccr3938@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-07-23 16:38:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[CEPH] Seperate creating loopback devices for ceph."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to seperate loopback devices creation from main script for"},{"line_number":10,"context_line":"better control of deployment"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I937ae79512ffc998d8dbd0b277a611347550044b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_c86c509e","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":28},"updated":"2020-07-23 16:41:16.000000000","message":"[CEPH] Seperate creating loopback devices for ceph\n\nThis is to seperate loopback devices creation from main script for\nbetter control of deployment.","commit_id":"7ab1540ad8fa6bf1ccb67585e5ea4b0b88b1a6cf"}],"doc/source/install/developer/cleaning-deployment.rst":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  : \"${CEPH_OSD_DB_WAL_DEVICE:\u003d/dev/loop1}\""},{"line_number":66,"context_line":"  if [ ! -z \"$CEPH_OSD_DATA_DEVICE\" ]; then"},{"line_number":67,"context_line":"    ceph_osd_disk_name\u003d`basename \"$CEPH_OSD_DATA_DEVICE\"`"},{"line_number":68,"context_line":"    if lsblk|grep $ceph_osd_disk_name;then"},{"line_number":69,"context_line":"       losetup -d \"$CEPH_OSD_DATA_DEVICE\""},{"line_number":70,"context_line":"    fi"},{"line_number":71,"context_line":"  fi"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_e1889120","line":68,"range":{"start_line":68,"start_character":7,"end_line":68,"end_character":12},"updated":"2020-07-28 14:42:13.000000000","message":"This isn\u0027t wrong, but why not use \u0027losetup -a\u0027 here instead? That is more efficient as it will only query loopback devices and not others. Mainly to avoid querying mapped RBDs.","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  fi"},{"line_number":72,"context_line":"  if [ ! -z \"$CEPH_OSD_DB_WAL_DEVICE\" ]; then"},{"line_number":73,"context_line":"    ceph_db_wal_disk_name\u003d`basename \"$CEPH_OSD_DB_WAL_DEVICE\"`"},{"line_number":74,"context_line":"    if lsblk|grep $ceph_db_wal_disk_name;then"},{"line_number":75,"context_line":"       losetup -d \"$CEPH_OSD_DB_WAL_DEVICE\""},{"line_number":76,"context_line":"    fi"},{"line_number":77,"context_line":"  fi"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_217a8923","line":74,"range":{"start_line":74,"start_character":7,"end_line":74,"end_character":12},"updated":"2020-07-28 14:42:13.000000000","message":"Same as above.","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"56f110170439a8e583fc44deee643c61dd9012fb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    echo $VG"},{"line_number":60,"context_line":"    vgremove -y $VG"},{"line_number":61,"context_line":"  done"},{"line_number":62,"context_line":"  # lets delete loopback devices setup for ceph, if the device names are different in your case,please"},{"line_number":63,"context_line":"  # update them here as environmental variables as shown below."},{"line_number":64,"context_line":"  : \"${CEPH_OSD_DATA_DEVICE:\u003d/dev/loop0}\""},{"line_number":65,"context_line":"  : \"${CEPH_OSD_DB_WAL_DEVICE:\u003d/dev/loop1}\""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_1ab883c6","line":62,"range":{"start_line":62,"start_character":96,"end_line":62,"end_character":102},"updated":"2020-07-28 21:51:45.000000000","message":"space, or better next line","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"3cd5acdc736d012e1c7830971b845cf837a57bf2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    echo $VG"},{"line_number":60,"context_line":"    vgremove -y $VG"},{"line_number":61,"context_line":"  done"},{"line_number":62,"context_line":"  # lets delete loopback devices setup for ceph, if the device names are different in your case,please"},{"line_number":63,"context_line":"  # update them here as environmental variables as shown below."},{"line_number":64,"context_line":"  : \"${CEPH_OSD_DATA_DEVICE:\u003d/dev/loop0}\""},{"line_number":65,"context_line":"  : \"${CEPH_OSD_DB_WAL_DEVICE:\u003d/dev/loop1}\""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_ae32fcef","line":62,"range":{"start_line":62,"start_character":96,"end_line":62,"end_character":102},"in_reply_to":"9f560f44_1ab883c6","updated":"2020-07-28 22:13:55.000000000","message":"Done","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"56f110170439a8e583fc44deee643c61dd9012fb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  : \"${CEPH_OSD_DB_WAL_DEVICE:\u003d/dev/loop1}\""},{"line_number":66,"context_line":"  if [ ! -z \"$CEPH_OSD_DATA_DEVICE\" ]; then"},{"line_number":67,"context_line":"    ceph_osd_disk_name\u003d`basename \"$CEPH_OSD_DATA_DEVICE\"`"},{"line_number":68,"context_line":"    if losetup -a|grep $ceph_osd_disk_name;then"},{"line_number":69,"context_line":"       losetup -d \"$CEPH_OSD_DATA_DEVICE\""},{"line_number":70,"context_line":"    fi"},{"line_number":71,"context_line":"  fi"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_dac56b3e","line":68,"range":{"start_line":68,"start_character":43,"end_line":68,"end_character":47},"updated":"2020-07-28 21:51:45.000000000","message":"lets keep some style here, could you add space please after semicolon","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"3cd5acdc736d012e1c7830971b845cf837a57bf2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  : \"${CEPH_OSD_DB_WAL_DEVICE:\u003d/dev/loop1}\""},{"line_number":66,"context_line":"  if [ ! -z \"$CEPH_OSD_DATA_DEVICE\" ]; then"},{"line_number":67,"context_line":"    ceph_osd_disk_name\u003d`basename \"$CEPH_OSD_DATA_DEVICE\"`"},{"line_number":68,"context_line":"    if losetup -a|grep $ceph_osd_disk_name;then"},{"line_number":69,"context_line":"       losetup -d \"$CEPH_OSD_DATA_DEVICE\""},{"line_number":70,"context_line":"    fi"},{"line_number":71,"context_line":"  fi"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_0e4de871","line":68,"range":{"start_line":68,"start_character":43,"end_line":68,"end_character":47},"in_reply_to":"9f560f44_dac56b3e","updated":"2020-07-28 22:13:55.000000000","message":"Done","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"56f110170439a8e583fc44deee643c61dd9012fb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  fi"},{"line_number":72,"context_line":"  if [ ! -z \"$CEPH_OSD_DB_WAL_DEVICE\" ]; then"},{"line_number":73,"context_line":"    ceph_db_wal_disk_name\u003d`basename \"$CEPH_OSD_DB_WAL_DEVICE\"`"},{"line_number":74,"context_line":"    if losetup -a|grep $ceph_db_wal_disk_name;then"},{"line_number":75,"context_line":"       losetup -d \"$CEPH_OSD_DB_WAL_DEVICE\""},{"line_number":76,"context_line":"    fi"},{"line_number":77,"context_line":"  fi"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_1add2314","line":74,"range":{"start_line":74,"start_character":45,"end_line":74,"end_character":50},"updated":"2020-07-28 21:51:45.000000000","message":"ditto","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"3cd5acdc736d012e1c7830971b845cf837a57bf2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  fi"},{"line_number":72,"context_line":"  if [ ! -z \"$CEPH_OSD_DB_WAL_DEVICE\" ]; then"},{"line_number":73,"context_line":"    ceph_db_wal_disk_name\u003d`basename \"$CEPH_OSD_DB_WAL_DEVICE\"`"},{"line_number":74,"context_line":"    if losetup -a|grep $ceph_db_wal_disk_name;then"},{"line_number":75,"context_line":"       losetup -d \"$CEPH_OSD_DB_WAL_DEVICE\""},{"line_number":76,"context_line":"    fi"},{"line_number":77,"context_line":"  fi"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_ee519410","line":74,"range":{"start_line":74,"start_character":45,"end_line":74,"end_character":50},"in_reply_to":"9f560f44_1add2314","updated":"2020-07-28 22:13:55.000000000","message":"Done","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"}],"doc/source/install/developer/deploy-with-ceph.rst":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"22bde1b6216b8873c9c8a3c1e1f05ec2b0d5d602","unresolved":false,"context_lines":[{"line_number":6,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Create two loopback devices for ceph as one disk for OSD data and other disk for"},{"line_number":9,"context_line":"block DB and block WAL.If default devices(loop0 and loop1)are busy in"},{"line_number":10,"context_line":"your case ,Feel free to change them in parameters by using --ceph-osd-data"},{"line_number":11,"context_line":"and --ceph-osd-dbwal options."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_28022c70","line":9,"range":{"start_line":9,"start_character":57,"end_line":9,"end_character":59},"updated":"2020-07-23 17:09:53.000000000","message":"space","commit_id":"f776ac613a5d6c6fc4a4ccecc3406c1e7078f8f5"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"22bde1b6216b8873c9c8a3c1e1f05ec2b0d5d602","unresolved":false,"context_lines":[{"line_number":6,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Create two loopback devices for ceph as one disk for OSD data and other disk for"},{"line_number":9,"context_line":"block DB and block WAL.If default devices(loop0 and loop1)are busy in"},{"line_number":10,"context_line":"your case ,Feel free to change them in parameters by using --ceph-osd-data"},{"line_number":11,"context_line":"and --ceph-osd-dbwal options."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_a8d47cea","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":24},"updated":"2020-07-23 17:09:53.000000000","message":"space","commit_id":"f776ac613a5d6c6fc4a4ccecc3406c1e7078f8f5"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"22bde1b6216b8873c9c8a3c1e1f05ec2b0d5d602","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Create two loopback devices for ceph as one disk for OSD data and other disk for"},{"line_number":9,"context_line":"block DB and block WAL.If default devices(loop0 and loop1)are busy in"},{"line_number":10,"context_line":"your case ,Feel free to change them in parameters by using --ceph-osd-data"},{"line_number":11,"context_line":"and --ceph-osd-dbwal options."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. literalinclude:: ../../../../tools/deployment/common/setup-ceph-loopback-device.sh"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_88cff855","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":15},"updated":"2020-07-23 17:09:53.000000000","message":"case, feel","commit_id":"f776ac613a5d6c6fc4a4ccecc3406c1e7078f8f5"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"22bde1b6216b8873c9c8a3c1e1f05ec2b0d5d602","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Deploy Ceph"},{"line_number":22,"context_line":"^^^^^^^^^^^"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If you created diffrent devices than default loopback devices(loop0 and loop1) in"},{"line_number":25,"context_line":"previous step then export them by as environmental variables(CEPH_OSD_DATA_DEVICE and"},{"line_number":26,"context_line":"CEPH_OSD_DB_WAL_DEVICE)."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_a8ed9cb8","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":23},"updated":"2020-07-23 17:09:53.000000000","message":"typo","commit_id":"f776ac613a5d6c6fc4a4ccecc3406c1e7078f8f5"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"22bde1b6216b8873c9c8a3c1e1f05ec2b0d5d602","unresolved":false,"context_lines":[{"line_number":22,"context_line":"^^^^^^^^^^^"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If you created diffrent devices than default loopback devices(loop0 and loop1) in"},{"line_number":25,"context_line":"previous step then export them by as environmental variables(CEPH_OSD_DATA_DEVICE and"},{"line_number":26,"context_line":"CEPH_OSD_DB_WAL_DEVICE)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. literalinclude:: ../../../../tools/deployment/developer/ceph/040-ceph.sh"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_2837cc4f","line":25,"range":{"start_line":25,"start_character":31,"end_line":25,"end_character":34},"updated":"2020-07-23 17:09:53.000000000","message":"delete","commit_id":"f776ac613a5d6c6fc4a4ccecc3406c1e7078f8f5"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Deploy Ceph"},{"line_number":10,"context_line":"^^^^^^^^^^^"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We are going to install ceph osds backed by loopback devices as  this will"},{"line_number":13,"context_line":"help us not to attach extra disks, in case if you have enough disks"},{"line_number":14,"context_line":"on the node then feel free to adjust below script part of ceph overrides."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_61c2c135","line":12,"range":{"start_line":12,"start_character":24,"end_line":12,"end_character":33},"updated":"2020-07-28 14:42:13.000000000","message":"nit: Ceph OSDs (consistent capitalization for documentation)","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Deploy Ceph"},{"line_number":10,"context_line":"^^^^^^^^^^^"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We are going to install ceph osds backed by loopback devices as  this will"},{"line_number":13,"context_line":"help us not to attach extra disks, in case if you have enough disks"},{"line_number":14,"context_line":"on the node then feel free to adjust below script part of ceph overrides."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_61a9217a","line":12,"range":{"start_line":12,"start_character":63,"end_line":12,"end_character":65},"updated":"2020-07-28 14:42:13.000000000","message":"nit: extra space","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We are going to install ceph osds backed by loopback devices as  this will"},{"line_number":13,"context_line":"help us not to attach extra disks, in case if you have enough disks"},{"line_number":14,"context_line":"on the node then feel free to adjust below script part of ceph overrides."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are also going to seperate metadata of ceph and data onto a diffrent devices"},{"line_number":17,"context_line":"to replicate the ideal scenario of fast disks for metadata and slow disks to store data."}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_01e785e6","line":14,"range":{"start_line":14,"start_character":58,"end_line":14,"end_character":62},"updated":"2020-07-28 14:42:13.000000000","message":"nit: Ceph (capitalization)","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":13,"context_line":"help us not to attach extra disks, in case if you have enough disks"},{"line_number":14,"context_line":"on the node then feel free to adjust below script part of ceph overrides."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are also going to seperate metadata of ceph and data onto a diffrent devices"},{"line_number":17,"context_line":"to replicate the ideal scenario of fast disks for metadata and slow disks to store data."},{"line_number":18,"context_line":"You can change this as per your design by refering the docmentation explained in"},{"line_number":19,"context_line":"../openstack-helm-infra/ceph-osd/values.yaml"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_41d05df8","line":16,"range":{"start_line":16,"start_character":30,"end_line":16,"end_character":55},"updated":"2020-07-28 14:42:13.000000000","message":"nit: Ceph metadata and data","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":18,"context_line":"You can change this as per your design by refering the docmentation explained in"},{"line_number":19,"context_line":"../openstack-helm-infra/ceph-osd/values.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This script will create two loopback devices for ceph as one disk for OSD data"},{"line_number":22,"context_line":"and other disk for block DB and block WAL. If default devices(loop0 and loop1) are busy in"},{"line_number":23,"context_line":"your case,feel free to change them by passing through parameters --ceph-osd-data and --ceph-osd-dbwal"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_c1058d7c","line":21,"range":{"start_line":21,"start_character":49,"end_line":21,"end_character":53},"updated":"2020-07-28 14:42:13.000000000","message":"nit: Ceph (capitalization)","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":19,"context_line":"../openstack-helm-infra/ceph-osd/values.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This script will create two loopback devices for ceph as one disk for OSD data"},{"line_number":22,"context_line":"and other disk for block DB and block WAL. If default devices(loop0 and loop1) are busy in"},{"line_number":23,"context_line":"your case,feel free to change them by passing through parameters --ceph-osd-data and --ceph-osd-dbwal"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. literalinclude:: ../../../../tools/deployment/developer/ceph/040-ceph.sh"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_e104117e","line":22,"range":{"start_line":22,"start_character":60,"end_line":22,"end_character":62},"updated":"2020-07-28 14:42:13.000000000","message":"nit: no space","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This script will create two loopback devices for ceph as one disk for OSD data"},{"line_number":22,"context_line":"and other disk for block DB and block WAL. If default devices(loop0 and loop1) are busy in"},{"line_number":23,"context_line":"your case,feel free to change them by passing through parameters --ceph-osd-data and --ceph-osd-dbwal"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. literalinclude:: ../../../../tools/deployment/developer/ceph/040-ceph.sh"},{"line_number":26,"context_line":"    :language: shell"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_e1b6d1d9","line":23,"range":{"start_line":23,"start_character":9,"end_line":23,"end_character":11},"updated":"2020-07-28 14:42:13.000000000","message":"nit: no space","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"a84740f37685abccbe9bcd8311860d3335e0bc03","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are also going to seperate Ceph metadata and data onto a diffrent devices"},{"line_number":17,"context_line":"to replicate the ideal scenario of fast disks for metadata and slow disks to store data."},{"line_number":18,"context_line":"You can change this as per your design by refering the docmentation explained in"},{"line_number":19,"context_line":"../openstack-helm-infra/ceph-osd/values.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This script will create two loopback devices for Ceph as one disk for OSD data"}],"source_content_type":"text/x-rst","patch_set":16,"id":"9f560f44_25a1f4aa","line":18,"range":{"start_line":18,"start_character":42,"end_line":18,"end_character":50},"updated":"2020-07-28 15:08:55.000000000","message":"referring to","commit_id":"13da823954a1bf0eb4246af94e9e903651df2f97"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"cdd184cadd97bb4441381b92a3feb4fd7ff5121b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are also going to seperate Ceph metadata and data onto a diffrent devices"},{"line_number":17,"context_line":"to replicate the ideal scenario of fast disks for metadata and slow disks to store data."},{"line_number":18,"context_line":"You can change this as per your design by refering the docmentation explained in"},{"line_number":19,"context_line":"../openstack-helm-infra/ceph-osd/values.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This script will create two loopback devices for Ceph as one disk for OSD data"}],"source_content_type":"text/x-rst","patch_set":16,"id":"9f560f44_289b89c9","line":18,"range":{"start_line":18,"start_character":42,"end_line":18,"end_character":50},"in_reply_to":"9f560f44_25a1f4aa","updated":"2020-07-28 15:42:58.000000000","message":"Done","commit_id":"13da823954a1bf0eb4246af94e9e903651df2f97"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"56f110170439a8e583fc44deee643c61dd9012fb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"help us not to attach extra disks, in case if you have enough disks"},{"line_number":14,"context_line":"on the node then feel free to adjust below script part of Ceph overrides."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are also going to seperate Ceph metadata and data onto a diffrent devices"},{"line_number":17,"context_line":"to replicate the ideal scenario of fast disks for metadata and slow disks to store data."},{"line_number":18,"context_line":"You can change this as per your design by referring to the docmentation explained in"},{"line_number":19,"context_line":"../openstack-helm-infra/ceph-osd/values.yaml"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_3a9e2756","line":16,"range":{"start_line":16,"start_character":60,"end_line":16,"end_character":68},"updated":"2020-07-28 21:51:45.000000000","message":"typo","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"3cd5acdc736d012e1c7830971b845cf837a57bf2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"help us not to attach extra disks, in case if you have enough disks"},{"line_number":14,"context_line":"on the node then feel free to adjust below script part of Ceph overrides."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are also going to seperate Ceph metadata and data onto a diffrent devices"},{"line_number":17,"context_line":"to replicate the ideal scenario of fast disks for metadata and slow disks to store data."},{"line_number":18,"context_line":"You can change this as per your design by referring to the docmentation explained in"},{"line_number":19,"context_line":"../openstack-helm-infra/ceph-osd/values.yaml"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_8e3bb8cf","line":16,"range":{"start_line":16,"start_character":60,"end_line":16,"end_character":68},"in_reply_to":"9f560f44_3a9e2756","updated":"2020-07-28 22:13:55.000000000","message":"Done","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"56f110170439a8e583fc44deee643c61dd9012fb","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are also going to seperate Ceph metadata and data onto a diffrent devices"},{"line_number":17,"context_line":"to replicate the ideal scenario of fast disks for metadata and slow disks to store data."},{"line_number":18,"context_line":"You can change this as per your design by referring to the docmentation explained in"},{"line_number":19,"context_line":"../openstack-helm-infra/ceph-osd/values.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This script will create two loopback devices for Ceph as one disk for OSD data"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_9aa2d399","line":18,"range":{"start_line":18,"start_character":59,"end_line":18,"end_character":71},"updated":"2020-07-28 21:51:45.000000000","message":"typo","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"3cd5acdc736d012e1c7830971b845cf837a57bf2","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are also going to seperate Ceph metadata and data onto a diffrent devices"},{"line_number":17,"context_line":"to replicate the ideal scenario of fast disks for metadata and slow disks to store data."},{"line_number":18,"context_line":"You can change this as per your design by referring to the docmentation explained in"},{"line_number":19,"context_line":"../openstack-helm-infra/ceph-osd/values.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This script will create two loopback devices for Ceph as one disk for OSD data"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_6e38e4d2","line":18,"range":{"start_line":18,"start_character":59,"end_line":18,"end_character":71},"in_reply_to":"9f560f44_9aa2d399","updated":"2020-07-28 22:13:55.000000000","message":"Done","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"56f110170439a8e583fc44deee643c61dd9012fb","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This script will create two loopback devices for Ceph as one disk for OSD data"},{"line_number":22,"context_line":"and other disk for block DB and block WAL. If default devices (loop0 and loop1) are busy in"},{"line_number":23,"context_line":"your case, feel free to change them by exporting environmental variables(CEPH_OSD_DATA_DEVICE"},{"line_number":24,"context_line":"and CEPH_OSD_DB_WAL_DEVICE)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. literalinclude:: ../../../../tools/deployment/developer/ceph/040-ceph.sh"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_7acd3f5c","line":23,"range":{"start_line":23,"start_character":49,"end_line":23,"end_character":62},"updated":"2020-07-28 21:51:45.000000000","message":"environment","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"3cd5acdc736d012e1c7830971b845cf837a57bf2","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This script will create two loopback devices for Ceph as one disk for OSD data"},{"line_number":22,"context_line":"and other disk for block DB and block WAL. If default devices (loop0 and loop1) are busy in"},{"line_number":23,"context_line":"your case, feel free to change them by exporting environmental variables(CEPH_OSD_DATA_DEVICE"},{"line_number":24,"context_line":"and CEPH_OSD_DB_WAL_DEVICE)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. literalinclude:: ../../../../tools/deployment/developer/ceph/040-ceph.sh"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_ce35b0dc","line":23,"range":{"start_line":23,"start_character":49,"end_line":23,"end_character":62},"in_reply_to":"9f560f44_7acd3f5c","updated":"2020-07-28 22:13:55.000000000","message":"Done","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"}],"tools/deployment/common/setup-ceph-loopback-device.sh":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"56f110170439a8e583fc44deee643c61dd9012fb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  echo \"Ceph osd data device is not set so using ${OSD_DATA_DEVICE}\""},{"line_number":26,"context_line":"else"},{"line_number":27,"context_line":"  ceph_osd_disk_name\u003d`basename \"$OSD_DATA_DEVICE\"`"},{"line_number":28,"context_line":"  if losetup -a|grep $ceph_osd_disk_name;then"},{"line_number":29,"context_line":"     echo \"Ceph osd data device is already in use, please double check and correct the device name\""},{"line_number":30,"context_line":"     exit 1"},{"line_number":31,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9f560f44_3a058778","line":28,"range":{"start_line":28,"start_character":41,"end_line":28,"end_character":45},"updated":"2020-07-28 21:51:45.000000000","message":"space for consistency","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"3cd5acdc736d012e1c7830971b845cf837a57bf2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  echo \"Ceph osd data device is not set so using ${OSD_DATA_DEVICE}\""},{"line_number":26,"context_line":"else"},{"line_number":27,"context_line":"  ceph_osd_disk_name\u003d`basename \"$OSD_DATA_DEVICE\"`"},{"line_number":28,"context_line":"  if losetup -a|grep $ceph_osd_disk_name;then"},{"line_number":29,"context_line":"     echo \"Ceph osd data device is already in use, please double check and correct the device name\""},{"line_number":30,"context_line":"     exit 1"},{"line_number":31,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9f560f44_4e2240a6","line":28,"range":{"start_line":28,"start_character":41,"end_line":28,"end_character":45},"in_reply_to":"9f560f44_3a058778","updated":"2020-07-28 22:13:55.000000000","message":"Done","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"56f110170439a8e583fc44deee643c61dd9012fb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  echo \"Ceph osd db/wal device is not set so using ${OSD_DB_WAL_DEVICE}\""},{"line_number":37,"context_line":"else"},{"line_number":38,"context_line":"  ceph_dbwal_disk_name\u003d`basename \"$OSD_DATA_DEVICE\"`"},{"line_number":39,"context_line":"  if losetup -a|grep $ceph_dbwal_disk_name;then"},{"line_number":40,"context_line":"     echo \"Ceph osd dbwal device is already in use, please double check and correct the device name\""},{"line_number":41,"context_line":"     exit 1"},{"line_number":42,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9f560f44_daf3ab9d","line":39,"range":{"start_line":39,"start_character":43,"end_line":39,"end_character":47},"updated":"2020-07-28 21:51:45.000000000","message":"ditto","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"3cd5acdc736d012e1c7830971b845cf837a57bf2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  echo \"Ceph osd db/wal device is not set so using ${OSD_DB_WAL_DEVICE}\""},{"line_number":37,"context_line":"else"},{"line_number":38,"context_line":"  ceph_dbwal_disk_name\u003d`basename \"$OSD_DATA_DEVICE\"`"},{"line_number":39,"context_line":"  if losetup -a|grep $ceph_dbwal_disk_name;then"},{"line_number":40,"context_line":"     echo \"Ceph osd dbwal device is already in use, please double check and correct the device name\""},{"line_number":41,"context_line":"     exit 1"},{"line_number":42,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9f560f44_2e270cb6","line":39,"range":{"start_line":39,"start_character":43,"end_line":39,"end_character":47},"in_reply_to":"9f560f44_daf3ab9d","updated":"2020-07-28 22:13:55.000000000","message":"Done","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"61beb2b18dac28bb8ca3c73a07f1cc47b05b3d7a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  OSD_DB_WAL_DEVICE\u003d/dev/loop1"},{"line_number":36,"context_line":"  echo \"Ceph osd db/wal device is not set so using ${OSD_DB_WAL_DEVICE}\""},{"line_number":37,"context_line":"else"},{"line_number":38,"context_line":"  ceph_dbwal_disk_name\u003d`basename \"$OSD_DATA_DEVICE\"`"},{"line_number":39,"context_line":"  if losetup -a|grep $ceph_dbwal_disk_name; then"},{"line_number":40,"context_line":"     echo \"Ceph osd dbwal device is already in use, please double check and correct the device name\""},{"line_number":41,"context_line":"     exit 1"}],"source_content_type":"text/x-sh","patch_set":23,"id":"9f560f44_b9123708","line":38,"range":{"start_line":38,"start_character":35,"end_line":38,"end_character":50},"updated":"2020-07-29 14:38:01.000000000","message":"OSD_DB_WAL_DEVICE","commit_id":"05df4f1da0a1fccdfd1fcba84cccdf24bf02f3a9"}],"tools/deployment/component/ceph/ceph.sh":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  osd_data_device\u003d\"$1\""},{"line_number":21,"context_line":"  osd_wal_db_device\u003d\"$2\""},{"line_number":22,"context_line":"  sudo df -lh"},{"line_number":23,"context_line":"  sudo lsblk"},{"line_number":24,"context_line":"  sudo mkdir -p /var/lib/openstack-helm/ceph"},{"line_number":25,"context_line":"  sudo truncate -s 10G /var/lib/openstack-helm/ceph/ceph-osd-data-loopbackfile.img"},{"line_number":26,"context_line":"  sudo truncate -s 8G /var/lib/openstack-helm/ceph/ceph-osd-db-wal-loopbackfile.img"}],"source_content_type":"text/x-sh","patch_set":15,"id":"9f560f44_c113cdb7","line":23,"range":{"start_line":23,"start_character":7,"end_line":23,"end_character":12},"updated":"2020-07-28 14:42:13.000000000","message":"This appears to be here for the purpose of logging block device info. Is it sufficient to log loopback device info via \u0027losetup -a\u0027 or do we really need all block device info?\n\nThis is mostly a concern when there are RBDs mapped on the same host. We should avoid querying those if possible.","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  sudo losetup $osd_wal_db_device /var/lib/openstack-helm/ceph/ceph-osd-db-wal-loopbackfile.img"},{"line_number":29,"context_line":"  #lets verify the devices"},{"line_number":30,"context_line":"  sudo df -lh"},{"line_number":31,"context_line":"  sudo lsblk"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"while [[ \"$#\" \u003e 0 ]]; do case $1 in"}],"source_content_type":"text/x-sh","patch_set":15,"id":"9f560f44_e11251b1","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":12},"updated":"2020-07-28 14:42:13.000000000","message":"Same as above","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  -d|--ceph-osd-data) OSD_DATA_DEVICE\u003d\"$2\"; shift;shift;;"},{"line_number":36,"context_line":"  -w|--ceph-osd-dbwal) OSD_DB_WAL_DEVICE\u003d\"$2\";shift;shift;;"},{"line_number":37,"context_line":"  -v|--verbose) VERBOSE\u003d1;shift;;"},{"line_number":38,"context_line":"  *) echo \"Unknown parameter passed: $1\"; shift; shift;;"},{"line_number":39,"context_line":"esac; done"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# verify params"}],"source_content_type":"text/x-sh","patch_set":15,"id":"9f560f44_2169e924","line":38,"range":{"start_line":38,"start_character":42,"end_line":38,"end_character":54},"updated":"2020-07-28 14:42:13.000000000","message":"Why 2 shifts? What if the unknown parameter is only 1 parameter?","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  echo \"Ceph osd data device is not set so using ${OSD_DATA_DEVICE}\""},{"line_number":45,"context_line":"else"},{"line_number":46,"context_line":"  ceph_osd_disk_name\u003d`basename \"$OSD_DATA_DEVICE\"`"},{"line_number":47,"context_line":"  if lsblk|grep $ceph_osd_disk_name;then"},{"line_number":48,"context_line":"     echo \"Ceph osd data device is already in use, please double check and correct the device name\""},{"line_number":49,"context_line":"     exit 1"},{"line_number":50,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":15,"id":"9f560f44_614c81c7","line":47,"range":{"start_line":47,"start_character":5,"end_line":47,"end_character":10},"updated":"2020-07-28 14:42:13.000000000","message":"Same as others. Please replace with \u0027losetup -a\u0027 if possible.","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f53a39cfbae828a42639fa135b09012433b4c124","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  echo \"Ceph osd db/wal device is not set so using ${OSD_DB_WAL_DEVICE}\""},{"line_number":56,"context_line":"else"},{"line_number":57,"context_line":"  ceph_dbwal_disk_name\u003d`basename \"$OSD_DATA_DEVICE\"`"},{"line_number":58,"context_line":"  if lsblk|grep $ceph_dbwal_disk_name;then"},{"line_number":59,"context_line":"     echo \"Ceph osd dbwal device is already in use, please double check and correct the device name\""},{"line_number":60,"context_line":"     exit 1"},{"line_number":61,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":15,"id":"9f560f44_e1d531bb","line":58,"range":{"start_line":58,"start_character":5,"end_line":58,"end_character":10},"updated":"2020-07-28 14:42:13.000000000","message":"Same. \u0027losetup -a\u0027 if possible.","commit_id":"6a69939dbf19432559c00449b672e4123dd7cf5c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"a84740f37685abccbe9bcd8311860d3335e0bc03","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  -d|--ceph-osd-data) OSD_DATA_DEVICE\u003d\"$2\"; shift;shift;;"},{"line_number":33,"context_line":"  -w|--ceph-osd-dbwal) OSD_DB_WAL_DEVICE\u003d\"$2\";shift;shift;;"},{"line_number":34,"context_line":"  -v|--verbose) VERBOSE\u003d1;shift;;"},{"line_number":35,"context_line":"  *) echo \"Unknown parameter passed: $1\"; shift; shift;;"},{"line_number":36,"context_line":"esac; done"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# verify params"}],"source_content_type":"text/x-sh","patch_set":16,"id":"9f560f44_8591e055","line":35,"range":{"start_line":35,"start_character":42,"end_line":35,"end_character":54},"updated":"2020-07-28 15:08:55.000000000","message":"Why shift twice for 1 unknown parameter?","commit_id":"13da823954a1bf0eb4246af94e9e903651df2f97"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"cdd184cadd97bb4441381b92a3feb4fd7ff5121b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  -d|--ceph-osd-data) OSD_DATA_DEVICE\u003d\"$2\"; shift;shift;;"},{"line_number":33,"context_line":"  -w|--ceph-osd-dbwal) OSD_DB_WAL_DEVICE\u003d\"$2\";shift;shift;;"},{"line_number":34,"context_line":"  -v|--verbose) VERBOSE\u003d1;shift;;"},{"line_number":35,"context_line":"  *) echo \"Unknown parameter passed: $1\"; shift; shift;;"},{"line_number":36,"context_line":"esac; done"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# verify params"}],"source_content_type":"text/x-sh","patch_set":16,"id":"9f560f44_48aa3dd4","line":35,"range":{"start_line":35,"start_character":42,"end_line":35,"end_character":54},"in_reply_to":"9f560f44_8591e055","updated":"2020-07-28 15:42:58.000000000","message":"yes , no need of extra shift, removed, thank you","commit_id":"13da823954a1bf0eb4246af94e9e903651df2f97"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"56f110170439a8e583fc44deee643c61dd9012fb","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"export CEPH_ENABLED\u003dtrue"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":": \"${CEPH_OSD_DATA_DEVICE:\u003d/dev/loop0}\""},{"line_number":20,"context_line":": \"${CEPH_OSD_DB_WAL_DEVICE:\u003d/dev/loop1}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"if [ ! -z ${CEPH_OSD_DATA_DEVICE} ]; then"},{"line_number":23,"context_line":"  CEPH_LOOPBACK_DEVICE_PARAMS\u003d\" --ceph-osd-data ${CEPH_OSD_DATA_DEVICE}\""},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":"if [ ! -z ${CEPH_OSD_DB_WALL_DEVICE} ]; then"},{"line_number":26,"context_line":"  CEPH_LOOPBACK_DEVICE_PARAMS\u003d\"${CEPH_LOOPBACK_DEVICE_PARAMS} --ceph-osd-dbwal ${CEPH_OSD_DB_WALL_DEVICE}\""},{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"./tools/deployment/common/setup-ceph-loopback-device.sh ${CEPH_LOOPBACK_DEVICE_PARAMS}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#NOTE: Lint and package chart"},{"line_number":32,"context_line":"export HELM_CHART_ROOT_PATH\u003d\"${HELM_CHART_ROOT_PATH:\u003d\"${OSH_INFRA_PATH:\u003d\"../openstack-helm-infra\"}\"}\""}],"source_content_type":"text/x-sh","patch_set":19,"id":"9f560f44_facb0f1b","line":29,"range":{"start_line":19,"start_character":0,"end_line":29,"end_character":86},"updated":"2020-07-28 21:51:45.000000000","message":"does not make sense. You assign variables if not defined above and then check if they are not empty below. Since we want to use these parameters in the same script we indeed must define duplicate defaults here, but then there\u0027s no need for checking if they are empty. So in oneline this all should be like that, but it\u0027s up to your taste:\n\n./tools/deployment/common/setup-ceph-loopback-device.sh --ceph-osd-data ${CEPH_OSD_DATA_DEVICE:\u003d/dev/loop0} --ceph-osd-dbwal ${CEPH_OSD_DB_WALL_DEVICE:\u003d/dev/loop1}","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"3cd5acdc736d012e1c7830971b845cf837a57bf2","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"export CEPH_ENABLED\u003dtrue"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":": \"${CEPH_OSD_DATA_DEVICE:\u003d/dev/loop0}\""},{"line_number":20,"context_line":": \"${CEPH_OSD_DB_WAL_DEVICE:\u003d/dev/loop1}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"if [ ! -z ${CEPH_OSD_DATA_DEVICE} ]; then"},{"line_number":23,"context_line":"  CEPH_LOOPBACK_DEVICE_PARAMS\u003d\" --ceph-osd-data ${CEPH_OSD_DATA_DEVICE}\""},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":"if [ ! -z ${CEPH_OSD_DB_WALL_DEVICE} ]; then"},{"line_number":26,"context_line":"  CEPH_LOOPBACK_DEVICE_PARAMS\u003d\"${CEPH_LOOPBACK_DEVICE_PARAMS} --ceph-osd-dbwal ${CEPH_OSD_DB_WALL_DEVICE}\""},{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"./tools/deployment/common/setup-ceph-loopback-device.sh ${CEPH_LOOPBACK_DEVICE_PARAMS}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#NOTE: Lint and package chart"},{"line_number":32,"context_line":"export HELM_CHART_ROOT_PATH\u003d\"${HELM_CHART_ROOT_PATH:\u003d\"${OSH_INFRA_PATH:\u003d\"../openstack-helm-infra\"}\"}\""}],"source_content_type":"text/x-sh","patch_set":19,"id":"9f560f44_0e284884","line":29,"range":{"start_line":19,"start_character":0,"end_line":29,"end_character":86},"in_reply_to":"9f560f44_facb0f1b","updated":"2020-07-28 22:13:55.000000000","message":"yes ,  agree, updated","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"56f110170439a8e583fc44deee643c61dd9012fb","unresolved":false,"context_lines":[{"line_number":42,"context_line":". /etc/os-release"},{"line_number":43,"context_line":"if [ \"x${ID}\" \u003d\u003d \"xcentos\" ] || \\"},{"line_number":44,"context_line":"   ([ \"x${ID}\" \u003d\u003d \"xubuntu\" ] \u0026\u0026 \\"},{"line_number":45,"context_line":"   [ \"$(uname -r | awk -F \".\" \u0027{ print $2 }\u0027)\" -lt \"5\" ]); then"},{"line_number":46,"context_line":"  CRUSH_TUNABLES\u003dhammer"},{"line_number":47,"context_line":"else"},{"line_number":48,"context_line":"  CRUSH_TUNABLES\u003dnull"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9f560f44_1a1403a0","line":45,"range":{"start_line":45,"start_character":5,"end_line":45,"end_character":54},"updated":"2020-07-28 21:51:45.000000000","message":"at least lets check that major one is at least 5 as well.","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"3cd5acdc736d012e1c7830971b845cf837a57bf2","unresolved":false,"context_lines":[{"line_number":42,"context_line":". /etc/os-release"},{"line_number":43,"context_line":"if [ \"x${ID}\" \u003d\u003d \"xcentos\" ] || \\"},{"line_number":44,"context_line":"   ([ \"x${ID}\" \u003d\u003d \"xubuntu\" ] \u0026\u0026 \\"},{"line_number":45,"context_line":"   [ \"$(uname -r | awk -F \".\" \u0027{ print $2 }\u0027)\" -lt \"5\" ]); then"},{"line_number":46,"context_line":"  CRUSH_TUNABLES\u003dhammer"},{"line_number":47,"context_line":"else"},{"line_number":48,"context_line":"  CRUSH_TUNABLES\u003dnull"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9f560f44_ae195c7a","line":45,"range":{"start_line":45,"start_character":5,"end_line":45,"end_character":54},"in_reply_to":"9f560f44_1a1403a0","updated":"2020-07-28 22:13:55.000000000","message":"as mentioned in above note, this change is not required for 4.5 kernel version","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"095111dfba4f0138e4179aa1c2e434c69fcfa924","unresolved":false,"context_lines":[{"line_number":42,"context_line":". /etc/os-release"},{"line_number":43,"context_line":"if [ \"x${ID}\" \u003d\u003d \"xcentos\" ] || \\"},{"line_number":44,"context_line":"   ([ \"x${ID}\" \u003d\u003d \"xubuntu\" ] \u0026\u0026 \\"},{"line_number":45,"context_line":"   [ \"$(uname -r | awk -F \".\" \u0027{ print $2 }\u0027)\" -lt \"5\" ]); then"},{"line_number":46,"context_line":"  CRUSH_TUNABLES\u003dhammer"},{"line_number":47,"context_line":"else"},{"line_number":48,"context_line":"  CRUSH_TUNABLES\u003dnull"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9f560f44_2ed6ecc6","line":45,"range":{"start_line":45,"start_character":5,"end_line":45,"end_character":54},"in_reply_to":"9f560f44_ae195c7a","updated":"2020-07-28 23:02:54.000000000","message":"i got you  now , updated the logic, thank you","commit_id":"643eed469777c686b640c442b0b1ee30cea3f3e5"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"19bb385f5963fe05f310ead7fae6f6da39e0fe57","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# should be set to \u0027hammer\u0027"},{"line_number":33,"context_line":". /etc/os-release"},{"line_number":34,"context_line":"if [ \"x${ID}\" \u003d\u003d \"xcentos\" ] || \\"},{"line_number":35,"context_line":"   ([ \"x${ID}\" \u003d\u003d \"xubuntu\" ] \u0026\u0026 \\"},{"line_number":36,"context_line":"   [ \"$(uname -r | awk -F \".\" \u0027{ print $1 }\u0027)\" -lt \"5\" ] \u0026\u0026 \\"},{"line_number":37,"context_line":"   [ \"$(uname -r | awk -F \".\" \u0027{ print $2 }\u0027)\" -lt \"5\" ]); then"},{"line_number":38,"context_line":"  CRUSH_TUNABLES\u003dhammer"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"  CRUSH_TUNABLES\u003dnull"}],"source_content_type":"text/x-sh","patch_set":22,"id":"9f560f44_b16a5d7d","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":63},"updated":"2020-07-29 00:00:09.000000000","message":"what about (\u003c4).(\u003e\u003d5)? :D\nAs I understand condition should be true for 4.4 and below. Lets be formally correct - now it\u0027s false for \u003e\u003d3.5,\u003c4.0 or \u003e\u003d2.5,\u003c3.0 as well. Well maybe these kernel versions are out of scope, though I\u0027d prefer not to think about the scope.\nI would suggest something better instead:\n([ \"x${ID}\" \u003d\u003d \"xubuntu\" ] \u0026\u0026 dpkg --compare-versions \"$(uname -r)\" \"lt\" \"4.5\"); then","commit_id":"d003974c355e6992ef447751248b8e7e21bec1f1"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"45498566dd653a186c205508d43e49377d6cb65f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# should be set to \u0027hammer\u0027"},{"line_number":33,"context_line":". /etc/os-release"},{"line_number":34,"context_line":"if [ \"x${ID}\" \u003d\u003d \"xcentos\" ] || \\"},{"line_number":35,"context_line":"   ([ \"x${ID}\" \u003d\u003d \"xubuntu\" ] \u0026\u0026 \\"},{"line_number":36,"context_line":"   [ \"$(uname -r | awk -F \".\" \u0027{ print $1 }\u0027)\" -lt \"5\" ] \u0026\u0026 \\"},{"line_number":37,"context_line":"   [ \"$(uname -r | awk -F \".\" \u0027{ print $2 }\u0027)\" -lt \"5\" ]); then"},{"line_number":38,"context_line":"  CRUSH_TUNABLES\u003dhammer"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"  CRUSH_TUNABLES\u003dnull"}],"source_content_type":"text/x-sh","patch_set":22,"id":"9f560f44_b3ea58a9","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":63},"in_reply_to":"9f560f44_b16a5d7d","updated":"2020-07-29 13:26:20.000000000","message":"thank  you for simple solution, updated.","commit_id":"d003974c355e6992ef447751248b8e7e21bec1f1"}]}