)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"f9d4d117d6bc18144149a19ee2f20663e8ef77d7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Using local variables is not allowed in bash."},{"line_number":10,"context_line":"During adding route it tries to delete cached route and"},{"line_number":11,"context_line":"fails with \"Not found\" because it can delete only"},{"line_number":12,"context_line":"user created routes, so we need to omit Chached routes"},{"line_number":13,"context_line":"in ovs/route/show listing."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ifc8da7fc36206f7ebd2e6198dbf192a5a40261af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f6b1bfe_7fe603eb","line":12,"range":{"start_line":12,"start_character":40,"end_line":12,"end_character":47},"updated":"2020-10-13 15:01:31.000000000","message":"nit: typo","commit_id":"0d025bd8b959a3f2b1fdbe0f24024b937554acfe"}],"neutron/Chart.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6eec8bd5c9aa01cb3b4857da00d37bdadf4b3dd1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"appVersion: v1.0.0"},{"line_number":15,"context_line":"description: OpenStack-Helm Neutron"},{"line_number":16,"context_line":"name: neutron"},{"line_number":17,"context_line":"version: 0.1.4"},{"line_number":18,"context_line":"home: https://docs.openstack.org/neutron/latest/"},{"line_number":19,"context_line":"icon: https://www.openstack.org/themes/openstack/images/project-mascots/Neutron/OpenStack_Project_Neutron_vertical.png"},{"line_number":20,"context_line":"sources:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f621f24_e87d04e8","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":14},"updated":"2020-11-02 07:48:16.000000000","message":"question to community: are we going to have release-notes, or something to indicate what was fixed in particular version?","commit_id":"2c66c2d69047cbf1d0bf9a7b32631eae35c953be"}],"neutron/templates/bin/_neutron-openvswitch-agent-init.sh.tpl":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ab0445d4484c6ab4e258c8f927ca1cd5e2135423","unresolved":false,"context_lines":[{"line_number":450,"context_line":"      if [[ \"${bridge_name}\" \u003d\u003d \"${tunnel_interface}\" ]]; then"},{"line_number":451,"context_line":"        # Route the tunnel traffic via the physical bridge"},{"line_number":452,"context_line":"        if [[ -n \"${LOCAL_IP}\" \u0026\u0026 -n \"${PREFIX}\" ]]; then"},{"line_number":453,"context_line":"          if [[ -n $(ovs-appctl -t ${OVS_CTL} ovs/route/show | grep \"${LOCAL_IP}\") | grep -v Cached ]]; then"},{"line_number":454,"context_line":"            ovs-appctl -t ${OVS_CTL} ovs/route/del \"${LOCAL_IP}\"/\"${PREFIX}\""},{"line_number":455,"context_line":"          fi"},{"line_number":456,"context_line":"          ovs-appctl -t ${OVS_CTL} ovs/route/add \"${LOCAL_IP}\"/\"${PREFIX}\" \"${tunnel_interface}\""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"9f560f44_438277a6","line":453,"updated":"2020-10-13 10:54:51.000000000","message":"nit: grep -v \u0027^Cached:\u0027 to allow use Cached in device names.","commit_id":"7c98f51a253197e1547410924978d04825e23c47"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"f9d4d117d6bc18144149a19ee2f20663e8ef77d7","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    # loop over all nics"},{"line_number":445,"context_line":"    echo $DPDK_CONFIG | jq -r -c \u0027.bridges[]\u0027 | \\"},{"line_number":446,"context_line":"    while IFS\u003d read -r br; do"},{"line_number":447,"context_line":"      bridge_name\u003d$(get_dpdk_config_value ${br} \u0027.name\u0027)"},{"line_number":448,"context_line":"      tunnel_underlay_vlan\u003d$(get_dpdk_config_value ${br} \u0027.tunnel_underlay_vlan\u0027)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"      if [[ \"${bridge_name}\" \u003d\u003d \"${tunnel_interface}\" ]]; then"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f6b1bfe_7f8283ca","line":447,"range":{"start_line":447,"start_character":6,"end_line":447,"end_character":17},"updated":"2020-10-13 15:01:31.000000000","message":"If \u0027local\u0027 is removed, does not it affect other parts of code where it is referred?\n\nAlso, gnu documentation says it can support local variables: https://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html","commit_id":"0d025bd8b959a3f2b1fdbe0f24024b937554acfe"},{"author":{"_account_id":28735,"name":"Denys Myrhorodskyi","email":"dmyrhorodskyi@mirantis.com","username":"dmyrhorodskyi"},"change_message_id":"bebc2a90e5d0bbae363a9a8d9da90fa63e26f8f8","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    # loop over all nics"},{"line_number":445,"context_line":"    echo $DPDK_CONFIG | jq -r -c \u0027.bridges[]\u0027 | \\"},{"line_number":446,"context_line":"    while IFS\u003d read -r br; do"},{"line_number":447,"context_line":"      bridge_name\u003d$(get_dpdk_config_value ${br} \u0027.name\u0027)"},{"line_number":448,"context_line":"      tunnel_underlay_vlan\u003d$(get_dpdk_config_value ${br} \u0027.tunnel_underlay_vlan\u0027)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"      if [[ \"${bridge_name}\" \u003d\u003d \"${tunnel_interface}\" ]]; then"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f65232a_23b1ff90","line":447,"range":{"start_line":447,"start_character":6,"end_line":447,"end_character":17},"in_reply_to":"7f6b1bfe_7f8283ca","updated":"2020-10-22 14:06:25.000000000","message":"@Hemachandra Reddy No, \"bridge_name\" was used only in migrate_ip function called from process_dpdk_nics function before this loop for tunnels where \u0027local was removed\u0027. Function process_dpdk_nics have own bridge variable passed to migrate_ip. \"tunnel_underlay_vlan\" variable is not used anywhere. To be sure that change will not break anything, I can add local to bridge_name in migrate_ip function.\n\nAlso GNU documentation does say it can not support local variables outside of function. Please refer to \"4.2 Bash Builtin Commands\" find \u0027local\u0027 and it says \"local can only be used within a function\"","commit_id":"0d025bd8b959a3f2b1fdbe0f24024b937554acfe"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8466e68fff73ca356391ec29a21a0968e48581c8","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    # loop over all nics"},{"line_number":445,"context_line":"    echo $DPDK_CONFIG | jq -r -c \u0027.bridges[]\u0027 | \\"},{"line_number":446,"context_line":"    while IFS\u003d read -r br; do"},{"line_number":447,"context_line":"      bridge_name\u003d$(get_dpdk_config_value ${br} \u0027.name\u0027)"},{"line_number":448,"context_line":"      tunnel_underlay_vlan\u003d$(get_dpdk_config_value ${br} \u0027.tunnel_underlay_vlan\u0027)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"      if [[ \"${bridge_name}\" \u003d\u003d \"${tunnel_interface}\" ]]; then"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f6b1bfe_05805c8b","line":447,"range":{"start_line":447,"start_character":6,"end_line":447,"end_character":17},"in_reply_to":"7f6b1bfe_7f8283ca","updated":"2020-10-21 07:37:26.000000000","message":"I doubt it is possible to use local outside of bash functions.\n\nvsaienko@vsaienko-pc:$ local fooo\u003dbar\nbash: local: can only be used in a function","commit_id":"0d025bd8b959a3f2b1fdbe0f24024b937554acfe"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"6b4fc2d4602831ff8d9fc76b925dad1c45eb2f6f","unresolved":true,"context_lines":[{"line_number":450,"context_line":"      if [[ \"${bridge_name}\" \u003d\u003d \"${tunnel_interface}\" ]]; then"},{"line_number":451,"context_line":"        # Route the tunnel traffic via the physical bridge"},{"line_number":452,"context_line":"        if [[ -n \"${LOCAL_IP}\" \u0026\u0026 -n \"${PREFIX}\" ]]; then"},{"line_number":453,"context_line":"          if [[ -n $(ovs-appctl -t ${OVS_CTL} ovs/route/show | grep \"${LOCAL_IP}\" | grep -v \u0027^Cached:\u0027) ]]; then"},{"line_number":454,"context_line":"            ovs-appctl -t ${OVS_CTL} ovs/route/del \"${LOCAL_IP}\"/\"${PREFIX}\""},{"line_number":455,"context_line":"          fi"},{"line_number":456,"context_line":"          ovs-appctl -t ${OVS_CTL} ovs/route/add \"${LOCAL_IP}\"/\"${PREFIX}\" \"${tunnel_interface}\""}],"source_content_type":"text/x-smarty","patch_set":15,"id":"e8ec0aae_5a254965","line":453,"range":{"start_line":453,"start_character":84,"end_line":453,"end_character":100},"updated":"2021-07-13 15:31:17.000000000","message":"wondering what happens when the pod comes back up second time? Would it cleanup the route that it added the first time? May be we do not need to filter out cached here and just ignore the error if not present.","commit_id":"27e12b88ad41ed0f092cbedd58664232eb34fe7c"}]}