)]}'
{"id":"openstack%2Fopenstack-helm~759136","triplet_id":"openstack%2Fopenstack-helm~master~I7c1c97f38877e0e54bea7fc09b37dd6f77c9dc8a","project":"openstack/openstack-helm","branch":"master","topic":"fix-credential-reset","hashtags":[],"change_id":"I7c1c97f38877e0e54bea7fc09b37dd6f77c9dc8a","subject":"[keystone] Fix fernet secret reset","status":"MERGED","created":"2020-10-21 20:14:17.000000000","updated":"2021-01-20 21:21:26.000000000","submitted":"2020-10-22 06:15:26.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"759136-1603347327241-424d6157","meta_rev_id":"21fb93e78027698c5704e11dcb187fb7190965b8","_number":759136,"virtual_id_number":759136,"owner":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-10-22 06:15:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"all":[{"value":2,"date":"2020-10-22 02:42:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-10-22 02:52:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":2,"date":"2020-10-22 04:48:45.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":1,"date":"2020-10-22 04:48:45.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},{"_account_id":30858,"name":"zhen","email":"zhen00fa@gmail.com","username":"zhen"}],"REVIEWER":[{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-22 02:42:25.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2020-10-22 02:52:44.000000000","updated_by":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"reviewer":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"state":"REVIEWER"},{"updated":"2020-10-22 04:48:45.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2020-10-22 06:15:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-30 13:45:03.000000000","updated_by":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"reviewer":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"state":"CC"},{"updated":"2021-01-13 08:11:21.000000000","updated_by":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"reviewer":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"state":"CC"},{"updated":"2021-01-13 08:36:50.000000000","updated_by":{"_account_id":30858,"name":"zhen","email":"zhen00fa@gmail.com","username":"zhen"},"reviewer":{"_account_id":30858,"name":"zhen","email":"zhen00fa@gmail.com","username":"zhen"},"state":"CC"}],"messages":[{"id":"f59e7955affff9c221b00006f2a4c5a556b55031","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2020-10-21 20:14:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0fdd46849fff4b3a76d303bccfd9be6c80b9d1d3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-21 21:29:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e5f05f1f936645ae85879c06e9c051df : SUCCESS in 7m 02s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/a15ca915926b496aba600cd6cfccd467 : SUCCESS in 6m 01s\n- openstack-helm-cinder-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/525b6f18739642919255313bd1edd7ab : SUCCESS in 43m 35s\n- openstack-helm-cinder-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/57ed07e7659f42f48efed52f96cd7a81 : SUCCESS in 46m 47s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/7793c1c639b943b98a357a0a3f895689 : SUCCESS in 47m 24s\n- openstack-helm-cinder-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/ed89a838a3ac400986dbce0156c3493a : SUCCESS in 42m 24s\n- openstack-helm-compute-kit-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/a20c9396f32d492191940cb4ee3d78ea : SUCCESS in 56m 24s\n- openstack-helm-compute-kit-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/1624ef14cc9e4df39bdc94b4860fd2e9 : SUCCESS in 50m 17s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/4114cdf8cf4e4649ba9c55b83d049a03 : SUCCESS in 51m 00s\n- openstack-helm-compute-kit-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/d2884d9ef22646b5ada5737dff61bbfb : SUCCESS in 43m 39s","accounts_in_message":[],"_revision_number":1},{"id":"ba8661a632f923fc326f6bee729ccd04e23b95db","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2020-10-22 02:42:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"bfb60049e9bcfabf2e39543d8f75d94d94cdedf1","author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"date":"2020-10-22 02:52:44.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"310b3b955fa88ebe9f29140ce3204175c9953701","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2020-10-22 04:48:45.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9e4debe43db0aab2328d8663c5e63bda31b5d83e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-22 04:48:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"33155c7121708569ed0924224fc283f97182632d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-22 06:15:26.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e5d2375fc5804ec4ad54d4767ba708c4 : SUCCESS in 10m 03s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/11474a37a0df4e8ba4db3d8a871c6d5e : SUCCESS in 9m 10s\n- openstack-helm-tls https://zuul.opendev.org/t/openstack/build/577d6397e5d144d0969570ace35a4711 : SUCCESS in 1h 25m 42s\n- openstack-helm-cinder-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/c0c1e4c5cda047a2b9ef0de28412ef7f : SUCCESS in 46m 41s\n- openstack-helm-compute-kit-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/036a544c090f4ec3939b727b51480d2d : SUCCESS in 49m 14s","accounts_in_message":[],"_revision_number":1},{"id":"f4906a9254f80c1ac27986ee161ef19d5ca5a155","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-22 06:15:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"ea16d99059813c125b2b0831423024cf8a0960c3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-22 06:17:28.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3ac94137b8b54e4e9d252d1c7a21dcd0 : SUCCESS in 1m 39s","accounts_in_message":[],"_revision_number":1},{"id":"5106014f43cc80b0e0fac69a7b3016b3e085d87e","author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"date":"2020-12-30 13:45:03.000000000","message":"Patch Set 1:\n\nWith this changed, brown field upgrades are failing. Since the secret chart is changed, at the time of upgrade, the secret get deleted but never created due to the pre-install hook. I am not very sure for exactly what scenario this code was put in place but this fix needs to be re-thought.","accounts_in_message":[],"_revision_number":1},{"id":"ceb1083f552386e97be3870365f8147a42fb3114","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-01-13 08:11:21.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e With this changed, brown field upgrades are failing. Since the secret chart is changed, at the time of upgrade, the secret get deleted but never created due to the pre-install hook. I am not very sure for exactly what scenario this code was put in place but this fix needs to be re-thought.\n\nagree ...","accounts_in_message":[],"_revision_number":1},{"id":"0a262594b9969494744639ed09a6d651a9a83786","author":{"_account_id":30858,"name":"zhen","email":"zhen00fa@gmail.com","username":"zhen"},"date":"2021-01-13 08:36:50.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e With this changed, brown field upgrades are failing. Since the secret chart is changed, at the time of upgrade, the secret get deleted but never created due to the pre-install hook. I am not very sure for exactly what scenario this code was put in place but this fix needs to be re-thought.\n\u003e \n\u003e agree ...\n\nagree ...","accounts_in_message":[],"_revision_number":1},{"id":"21fb93e78027698c5704e11dcb187fb7190965b8","tag":"autogenerated:gerrit:revert","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-01-20 21:21:26.000000000","message":"Created a revert of this change as Iea57c999abf42e364f78d1bd352fa4414e7f1f83","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f5a757b1065d26593bdf6fca55ed70772d5ff722","revisions":{"f5a757b1065d26593bdf6fca55ed70772d5ff722":{"kind":"REWORK","_number":1,"created":"2020-10-21 20:14:17.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/36/759136/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/36/759136/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/36/759136/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/36/759136/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/36/759136/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/36/759136/1"}}},"commit":{"parents":[{"commit":"fe53b5e5590b23a1e410e3373262621f2fdd745c","subject":"Add blank access_rules file","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/fe53b5e5590b23a1e410e3373262621f2fdd745c"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2020-10-21 20:12:56.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2020-10-21 20:12:56.000000000","tz":-240},"subject":"[keystone] Fix fernet secret reset","message":"[keystone] Fix fernet secret reset\n\nThis patch makes the fernet and credential secret something that gets\ncreated only once when the deployment is first done, as when using Helm,\nit\u0027s possible that it overrides it\u0027s values with an empty secret in the\nruns afterwards.\n\nBy making it a hook, it will instead create it and leave an owner\nreference in Helm 3 to delete it later if the release is deleted.  It\nwill not manage it afterwards as well.\n\nChange-Id: I7c1c97f38877e0e54bea7fc09b37dd6f77c9dc8a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f5a757b1065d26593bdf6fca55ed70772d5ff722"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f5a757b1065d26593bdf6fca55ed70772d5ff722"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}